dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
Subsystems (2)
Rob Herring
maintainerPATCH 1/1 dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios'
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
Add the missing definition for 'rb-gpios'.
--- Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +5 -0
@@ -53,6 +53,11 @@ properties: enum: [8, 16] default: 8 + rb-gpios: + description: + GPIO connection to R/B signal from NAND chip + maxItems: 1 + patternProperties: "@[0-9a-f]+$": $ref: "/schemas/mtd/partitions/partition.yaml"
Signature · 1 line
2.32.0
Quoted 14 lines · Rob Herring
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)Add the missing definition for 'rb-gpios'.
Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>Cc Tony Lindgren <[email protected]>Cc Roger Quadros <[email protected]>Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines
--- Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Quoted 7 lines · Rob Herring
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)Add the missing definition for 'rb-gpios'.
Quoted 7 lines
Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>Cc Tony Lindgren <[email protected]>Cc Roger Quadros <[email protected]>Signed-off-by Rob Herring <[email protected]>
Quoted 4 lines
--- Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Miquel Raynal
maintainerHi Rob,
[email protected] wrote on Mon, 6 Dec 2021 11:42:09 -0600:
Quoted 6 lines
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in nand-controller.yaml. I seems like the real problem is that this file does not refer to it. Can you update the fix?
While at it you might also want to drop the rb-gpios property from ingenic,nand.yaml, which also defines it a second time.
Quoted 17 lines
Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>Cc Tony Lindgren <[email protected]>Cc Roger Quadros <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +0
-0@@ -53,6 +53,11 @@ properties: enum: [8, 16]
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml properties: · line 63
Quoted 10 lines
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +5
-0default: 8 + rb-gpios: + description: + GPIO connection to R/B signal from NAND chip + maxItems: 1 + patternProperties: "@[0-9a-f]+$": $ref: "/schemas/mtd/partitions/partition.yaml"
Thanks,
Miquèl
Hi Miquel,
Quoted 7 lines · Miquel Raynal
Hi Rob,
[email protected] wrote on Mon, 6 Dec 2021 11:42:09 -0600:
Quoted 3 lines
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Quoted 7 lines
Quoted 3 lines
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in
nand-controller.yaml. I seems like the real problem is that this file does not refer to it. Can you update the fix?
I don't think we can refer to nand-controller.yaml right now as we are not fully compatible with it yet. Please see examples below.
ti,gpmc-nand example:
nand@0,0 {
compatible = "ti,omap2-nand";
reg = <0 0 4>; /* device IO registers */
interrupt-parent = <&gpmc>;
interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
<1 IRQ_TYPE_NONE>; /* termcount */
ti,nand-xfer-type = "prefetch-dma";
ti,nand-ecc-opt = "bch16";
ti,elm-id = <&elm>;
#address-cells = <1>;
#size-cells = <1>;
/* NAND generic properties */
nand-bus-width = <8>;
rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */
/* GPMC properties*/
gpmc,device-width = <1>;
partition@0 {
label = "NAND.SPL";
reg = <0x00000000 0x00040000>;
};
partition@1 {
label = "NAND.SPL.backup1";
reg = <0x00040000 0x00040000>;
};
};nand-controller example:
nand-controller {
#address-cells = <1>;
#size-cells = <0>;
cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */
/* controller specific properties */
nand@0 {
reg = <0>; /* Native CS */
nand-use-soft-ecc-engine;
nand-ecc-algo = "bch";
/* controller specific properties */
};
nand@1 {
reg = <1>; /* GPIO CS */
};
};Quoted 23 lines
While at it you might also want to drop the rb-gpios property from ingenic,nand.yaml, which also defines it a second time.
Quoted 19 lines
Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>Cc Tony Lindgren <[email protected]>Cc Roger Quadros <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +0
-0@@ -53,6 +53,11 @@ properties: enum: [8, 16] default: 8
Quoted 12 lines
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml properties: · line 63
Quoted 8 lines
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +5
-0+ rb-gpios: + description: + GPIO connection to R/B signal from NAND chip + maxItems: 1 + patternProperties: "@[0-9a-f]+$": $ref: "/schemas/mtd/partitions/partition.yaml"Thanks,
Miquèl
cheers,
-roger
Miquel Raynal
maintainerHi Roger,
[email protected] wrote on Thu, 9 Dec 2021 12:08:07 +0200:
Quoted 12 lines
Hi Miquel,
Quoted 9 lines · Miquel Raynal
Hi Rob,
[email protected] wrote on Mon, 6 Dec 2021 11:42:09 -0600:
Quoted 5 lines
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in
nand-controller.yaml. I seems like the real problem is that this file does not refer to it. Can you update the fix?I don't think we can refer to
nand-controller.yamlright now as we are not fully compatible with it yet. Please see examples below.
This is a *very* wrong way of defining a NAND setup. I will take the patch to silence the warning, but please convert this representation to the 'new' one. I believe on the driver side it should not be too complicated to support having a few of these properties moved to a NAND chip subnode and still support the below binding. Just be very clear that if the legacy bindings are used, only a single chip is supported.
Quoted 91 lines
ti,gpmc-nand example:
nand@0,0 { compatible = "ti,omap2-nand"; reg = <0 0 4>; /* device IO registers */ interrupt-parent = <&gpmc>; interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */ <1 IRQ_TYPE_NONE>; /* termcount */ ti,nand-xfer-type = "prefetch-dma"; ti,nand-ecc-opt = "bch16"; ti,elm-id = <&elm>; #address-cells = <1>; #size-cells = <1>; /* NAND generic properties */ nand-bus-width = <8>; rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */ /* GPMC properties*/ gpmc,device-width = <1>; partition@0 { label = "NAND.SPL"; reg = <0x00000000 0x00040000>; }; partition@1 { label = "NAND.SPL.backup1"; reg = <0x00040000 0x00040000>; }; };nand-controller example:
nand-controller { #address-cells = <1>; #size-cells = <0>; cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */ /* controller specific properties */ nand@0 { reg = <0>; /* Native CS */ nand-use-soft-ecc-engine; nand-ecc-algo = "bch"; /* controller specific properties */ }; nand@1 { reg = <1>; /* GPIO CS */ }; };Quoted 23 lines
While at it you might also want to drop the rb-gpios property from ingenic,nand.yaml, which also defines it a second time.
Quoted 19 lines
Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>Cc Tony Lindgren <[email protected]>Cc Roger Quadros <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +0
-0@@ -53,6 +53,11 @@ properties: enum: [8, 16] default: 8Quoted 12 lines
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml properties: · line 63
Quoted 8 lines
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +5
-0+ rb-gpios: + description: + GPIO connection to R/B signal from NAND chip + maxItems: 1 + patternProperties: "@[0-9a-f]+$": $ref: "/schemas/mtd/partitions/partition.yaml"Thanks,
Miquèl
Quoted 3 lines
cheers,
-roger
Thanks,
Miquèl
Miquel,
Quoted 22 lines · Miquel Raynal
Hi Roger,
[email protected] wrote on Thu, 9 Dec 2021 12:08:07 +0200:
Quoted 18 lines
Hi Miquel,
Quoted 14 lines · Miquel Raynal
Hi Rob,
[email protected] wrote on Mon, 6 Dec 2021 11:42:09 -0600:
Quoted 6 lines
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in
nand-controller.yaml. I seems like the real problem is that this file does not refer to it. Can you update the fix?
Quoted 5 lines
Quoted 2 lines
I don't think we can refer to
nand-controller.yamlright now as we are not fully compatible with it yet. Please see examples below.This is a *very* wrong way of defining a NAND setup. I will take the patch to silence the warning, but please convert this representation to
Thanks!
Quoted 4 lines
the 'new' one. I believe on the driver side it should not be too complicated to support having a few of these properties moved to a NAND chip subnode and still support the below binding. Just be very clear that if the legacy bindings are used, only a single chip is supported.
I agree with you. It has been that way since ages. I will look at cleaning it up whenever possible for me. I think we will have to support the old bindings as well as the new one going forward as many legacy platforms are using it.
cheers,
-roger
Quoted 99 lines
Quoted 92 lines
ti,gpmc-nand example:
nand@0,0 { compatible = "ti,omap2-nand"; reg = <0 0 4>; /* device IO registers */ interrupt-parent = <&gpmc>; interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */ <1 IRQ_TYPE_NONE>; /* termcount */ ti,nand-xfer-type = "prefetch-dma"; ti,nand-ecc-opt = "bch16"; ti,elm-id = <&elm>; #address-cells = <1>; #size-cells = <1>; /* NAND generic properties */ nand-bus-width = <8>; rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */ /* GPMC properties*/ gpmc,device-width = <1>; partition@0 { label = "NAND.SPL"; reg = <0x00000000 0x00040000>; }; partition@1 { label = "NAND.SPL.backup1"; reg = <0x00040000 0x00040000>; }; };nand-controller example:
nand-controller { #address-cells = <1>; #size-cells = <0>; cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */ /* controller specific properties */ nand@0 { reg = <0>; /* Native CS */ nand-use-soft-ecc-engine; nand-ecc-algo = "bch"; /* controller specific properties */ }; nand@1 { reg = <1>; /* GPIO CS */ }; };Quoted 23 lines
While at it you might also want to drop the rb-gpios property from ingenic,nand.yaml, which also defines it a second time.
Quoted 19 lines
Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>Cc Tony Lindgren <[email protected]>Cc Roger Quadros <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +0
-0@@ -53,6 +53,11 @@ properties: enum: [8, 16] default: 8Quoted 12 lines
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml properties: · line 63
Quoted 8 lines
Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml +5
-0+ rb-gpios: + description: + GPIO connection to R/B signal from NAND chip + maxItems: 1 + patternProperties: "@[0-9a-f]+$": $ref: "/schemas/mtd/partitions/partition.yaml"Thanks,
MiquèlQuoted 3 lines
cheers,
-rogerThanks,
Miquèl
Miquel Raynal
maintainerHi Roger,
Quoted 24 lines
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 6 lines
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in
nand-controller.yaml. I seems like the real problem is that this file does not refer to it. Can you update the fix?Quoted 5 lines
Quoted 2 lines
I don't think we can refer to
nand-controller.yamlright now as we are not fully compatible with it yet. Please see examples below.This is a *very* wrong way of defining a NAND setup. I will take the patch to silence the warning, but please convert this representation to
Thanks!
Quoted 4 lines
the 'new' one. I believe on the driver side it should not be too complicated to support having a few of these properties moved to a NAND chip subnode and still support the below binding. Just be very clear that if the legacy bindings are used, only a single chip is supported.
Quoted 4 lines
I agree with you. It has been that way since ages. I will look at cleaning it up whenever possible for me. I think we will have to support the old bindings as well as the new one going forward as many legacy platforms are using it.
Yes of course, this is even a primary requirement.
Thanks,
Miquèl
Quoted 7 lines · Rob Herring
With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected)Add the missing definition for 'rb-gpios'.
Quoted 9 lines
Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>Cc Tony Lindgren <[email protected]>Cc Roger Quadros <[email protected]>Signed-off-by Rob Herring <[email protected]>Reviewed-by Thierry Reding <[email protected]>Reviewed-by Roger Quadros <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel