Skip to contentSkip to conversation

xfs: bug fixes for 5.16-rc4

GIT PULL Merged Darrick J. Wong 2 participants 2 messages Dec 11, 2021 – Dec 12, 2021 VFS

lore
Share & tools
lore
#0 lore raw

Hi Linus,

Please pull this branch for 5.16-rc4 that fixes a race between a readonly remount process and other processes that hold a file IOLOCK on files that previously experienced copy on write, that could result in severe filesystem corruption if the filesystem is then remounted rw. I think this is fairly rare (since the only reliable reproducer I have that fits the second criteria is the experimental xfs_scrub program), but the race is clear, so we still need to fix this.

The branch merges cleanly against upstream as of a few minutes ago. Please let me know if anything else strange happens during the merge process.

--D

The following changes since commit e445976537ad139162980bee015b7364e5b64fff:

xfs: remove incorrect ASSERT in xfs_rename (2021-12-01 17:27:48 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.16-fixes-3

for you to fetch changes up to 089558bc7ba785c03815a49c89e28ad9b8de51f9:

xfs: remove all COW fork extents when remounting readonly (2021-12-07 10:17:29 -0800)

----------------------------------------------------------------
Fixes for 5.16-rc4:
- Fix a data corruption vector that can result from the ro remount process failing to clear all speculative preallocations from files and the rw remount process not noticing the incomplete cleanup.

----------------------------------------------------------------
Darrick J. Wong (1):
xfs: remove all COW fork extents when remounting readonly

 fs/xfs/xfs_super.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)