Skip to contentSkip to conversation

usb: storage: do not use UAS with Logitec LGB-4BNHUC

PATCH In review Alexandre Courbot 2 participants 5 messages Dec 12, 2021 – Dec 20, 2021

Subsystems (2)
USB USB mass storage driver
lore
Share & tools
lore

Alexandre Courbot

author
#0 lore raw

PATCH 1/1 usb: storage: do not use UAS with Logitec LGB-4BNHUC

This 4-drives USB 3.1 bay gets unhappy when used with UAS:

	sd 10:0:0:0: [sdb] tag#18 uas_eh_abort_handler 0 uas-tag 5 inflight: CMD IN
	sd 10:0:0:0: [sdb] tag#18 CDB: Read(16) 88 00 00 00 00 00 00 9d 42 30 00 00 04 00 00 00

It works perfectly fine as a regular mass-storage device, so prevent UAS from being used with it.

Signed-off-by Alexandre Courbot <[email protected]>
---
 drivers/usb/storage/unusual_uas.h | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/usb/storage/unusual_uas.h +6 -0
index b34b858d82a6..9ef09cabef50 100644
@@ -52,6 +52,12 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
 
+UNUSUAL_DEV(0x0789, 0x0296, 0x0000, 0x9999,
+		"Logitec",
+		"LGB-4BNHUC",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_IGNORE_UAS),
+
 /*
  * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
  * commands in UAS mode.  Observed with the 1.28 firmware; are there others?
Signature · 1 line
2.34.1
#1 lore raw
Quoted 8 lines · Alexandre Courbot

This 4-drives USB 3.1 bay gets unhappy when used with UAS:

	sd 10:0:0:0: [sdb] tag#18 uas_eh_abort_handler 0 uas-tag 5 inflight: CMD IN
	sd 10:0:0:0: [sdb] tag#18 CDB: Read(16) 88 00 00 00 00 00 00 9d 42 30 00 00 04 00 00 00

It works perfectly fine as a regular mass-storage device, so prevent UAS from being used with it.

Hi,

this is a big drastic a fix. s it always that command? Have you tried less drastic quirks?

    Regards
        Oliver

author
#2 lore raw

Hi Oliver,

Quoted 8 lines · Oliver Neukum
Quoted 5 lines · Alexandre Courbot

This 4-drives USB 3.1 bay gets unhappy when used with UAS:

      sd 10:0:0:0: [sdb] tag#18 uas_eh_abort_handler 0 uas-tag 5 inflight: CMD IN
      sd 10:0:0:0: [sdb] tag#18 CDB: Read(16) 88 00 00 00 00 00 00 9d 42 30 00 00 04 00 00 00
Quoted 7 lines
Quoted 3 lines

It works perfectly fine as a regular mass-storage device, so prevent UAS from being used with it.

Hi,

this is a big drastic a fix. s it always that command? Have you tried less drastic quirks?

Unfortunately I am not familiar with the storage subsystem so I'm not sure which quirks would be good candidates to try, would you have suggestions? As for the command, reproduction is rather random and I did not keep traces of all instances.

I just noticed that users with similar issues reported that disabling UAS fixed the problem and sure enough it did in my case as well. The bay is used with a NAS so I'd rather not mess too much with it, but I am willing to experiment a bit (after double-checking my backups) if you have good leads to suggest.

Cheers,
Alex.

#3 lore raw
Quoted 4 lines · Alexandre Courbot

Unfortunately I am not familiar with the storage subsystem so I'm not sure which quirks would be good candidates to try, would you have suggestions? As for the command, reproduction is rather random and I did not keep traces of all instances.

Hi,

could you try "fgkm" ?

    Regards
        Oliver

author
#4 lore raw
Quoted 8 lines · Oliver Neukum
Quoted 4 lines · Alexandre Courbot

Unfortunately I am not familiar with the storage subsystem so I'm not sure which quirks would be good candidates to try, would you have suggestions? As for the command, reproduction is rather random and I did not keep traces of all instances.

Quoted 4 lines

Hi,

could you try "fgkm" ?

Trying with this and will narrow down if it looks stable. Please expect a few weeks before the (hopefully more refined) patch.

Cheers,
Alex.