Skip to contentSkip to conversation

linux-next: build failure after merge of the gpio-brgl tree

DISCUSSION [email protected] 4 participants 4 messages Dec 13, 2021 – Dec 17, 2021

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
| ^~~~~
cc1: all warnings being treated as errors

Caused by commit

19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")

I used the tree from yesterday instead.

#1 lore raw
Quoted 10 lines · On 12/13/2021 12:31 PM, [email protected] wrote:

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
| ^~~~~
cc1: all warnings being treated as errors

Quoted 5 lines

Caused by commit

   19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")

I used the tree from yesterday instead.

Doh! Should have double checked the code as the diff was not giving enough context. This patch should simply be dropped, not even build tested by Xiang it seems.

Signature · 1 line
Florian
#2 lore raw

Hi all,

Quoted 14 lines · On Mon, 13 Dec 2021 19:12:05 -0800 Florian Fainelli <[email protected]>…
Quoted 12 lines · On 12/13/2021 12:31 PM, [email protected] wrote:

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
| ^~~~~
cc1: all warnings being treated as errors

Caused by commit

Quoted 7 lines
Quoted 3 lines
   19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")

I used the tree from yesterday instead.

Doh! Should have double checked the code as the diff was not giving enough context. This patch should simply be dropped, not even build tested by Xiang it seems.

Today, I have reverted that commit. Please remove or revert it ASAP.

Signature · 2 lines
Cheers,
Stephen Rothwell
#3 lore raw
Quoted 26 lines · Stephen Rothwell

Hi all,

Quoted 14 lines · On Mon, 13 Dec 2021 19:12:05 -0800 Florian Fainelli <[email protected]>…
Quoted 12 lines · On 12/13/2021 12:31 PM, [email protected] wrote:

Hi all,

After merging the gpio-brgl tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
| ^~~~~
cc1: all warnings being treated as errors

Caused by commit

Quoted 7 lines
Quoted 3 lines
   19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")

I used the tree from yesterday instead.

Doh! Should have double checked the code as the diff was not giving enough context. This patch should simply be dropped, not even build tested by Xiang it seems.

Quoted 5 lines

Today, I have reverted that commit. Please remove or revert it ASAP.

--
Cheers,
Stephen Rothwell

Done, sorry for the delay.

Bartosz