Skip to contentSkip to conversation

uuid: Discourage people from using UAPI header in new code

PATCH Superseded Andy Shevchenko 2 participants 5 messages Dec 13, 2021 – Dec 16, 2021 Intel management engine (mei)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 uuid: Discourage people from using UAPI header in new code

Discourage people from using UAPI header in new code by adding a note.

---
 include/uapi/linux/uuid.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/linux/uuid.h +1 -0
index e5a7eecef7c3..32615dc5f0cf 100644
@@ -1,4 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/* DO NOT USE in new code! This is solely for MEI due to legacy reasons */
 /*
  * UUID/GUID definition
  *
Signature · 1 line
2.33.0
#1 lore raw

PATCH 2/2 uuid: Remove licence boilerplate text from the header

Remove licence boilerplate text from the UAPI header.

---
 include/uapi/linux/uuid.h | 9 ---------
 1 file changed, 9 deletions(-)
include/uapi/linux/uuid.h +0 -9
index 32615dc5f0cf..c0f4bd9b040e 100644
@@ -5,15 +5,6 @@
  *
  * Copyright (C) 2010, Intel Corp.
  *	Huang Ying <[email protected]>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version
- * 2 as published by the Free Software Foundation;
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #ifndef _UAPI_LINUX_UUID_H_
Signature · 1 line
2.33.0
#2 lore raw
In reply to Andy Shevchenko
Quoted 1 line · Andy Shevchenko

Discourage people from using UAPI header in new code by adding a note.

Christoph, can we get this applied please, otherwise we will never get rid of the old ugly types.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 6 lines · Christoph Hellwig

Both patches looks good to me:

Given that the uuid tree isn't in linux-next anymore due to inactivity, can you send them to Andrew for inclusion in -mm with my ACK?

Sure, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko