pinctrl: Get rid of duplicate of_node assignment in the drivers
Subsystems (21)
PATCH v2 1/2 pinctrl: Get rid of duplicate of_node assignment in the drivers
GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove these assignment all at once.
For the details one may look into the of_gpio_dev_init() implementation.
---
v2: no changes
drivers/pinctrl/actions/pinctrl-owl.c | 1 - drivers/pinctrl/bcm/pinctrl-bcm2835.c | 1 - drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 1 - drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 1 - drivers/pinctrl/cirrus/pinctrl-lochnagar.c | 3 --- drivers/pinctrl/mediatek/pinctrl-moore.c | 7 +++---- drivers/pinctrl/mediatek/pinctrl-paris.c | 5 ++--- drivers/pinctrl/pinctrl-amd.c | 3 --- drivers/pinctrl/pinctrl-at91-pio4.c | 1 - drivers/pinctrl/pinctrl-at91.c | 1 - drivers/pinctrl/pinctrl-digicolor.c | 5 ++--- drivers/pinctrl/pinctrl-mcp23s08.c | 1 - drivers/pinctrl/pinctrl-ocelot.c | 1 - drivers/pinctrl/pinctrl-oxnas.c | 1 - drivers/pinctrl/pinctrl-pic32.c | 2 +- drivers/pinctrl/pinctrl-stmfx.c | 1 - drivers/pinctrl/pinctrl-sx150x.c | 3 --- drivers/pinctrl/pinctrl-xway.c | 1 - drivers/pinctrl/qcom/pinctrl-msm.c | 1 - drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 1 - drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 1 - drivers/pinctrl/renesas/pinctrl-rza2.c | 1 - drivers/pinctrl/spear/pinctrl-plgpio.c | 1 - drivers/pinctrl/vt8500/pinctrl-wmt.c | 1 - 24 files changed, 8 insertions(+), 37 deletions(-)
drivers/pinctrl/actions/pinctrl-owl.c +0 -1
@@ -874,7 +874,6 @@ static int owl_gpio_init(struct owl_pinctrl *pctrl) chip->label =dev_name (pctrl->dev); chip->parent = pctrl->dev; chip->owner =THIS_MODULE ; - chip->of_node = pctrl->dev->of_node; pctrl->irq_chip.name = chip->of_node->name; pctrl->irq_chip.irq_ack = owl_gpio_irq_ack;
drivers/pinctrl/bcm/pinctrl-bcm2835.c +0 -1
@@ -1222,7 +1222,6 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev) pc->gpio_chip = *pdata->gpio_chip; pc->gpio_chip.parent = dev; - pc->gpio_chip.of_node = np;for (i =0 ; i <BCM2835_NUM_BANKS ; i++) {unsigned long events;
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +0 -1
@@ -836,7 +836,6 @@ static int iproc_gpio_probe(struct platform_device *pdev) chip->num_banks = (ngpios +NGPIOS_PER_BANK -1 ) /NGPIOS_PER_BANK ; gc->label =dev_name (dev); gc->parent = dev; - gc->of_node = dev->of_node; gc->request = iproc_gpio_request; gc->free = iproc_gpio_free; gc->direction_input = iproc_gpio_direction_input;
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c +0 -1
@@ -648,7 +648,6 @@ static int nsp_gpio_probe(struct platform_device *pdev) gc->ngpio = val; gc->label =dev_name (dev); gc->parent = dev; - gc->of_node = dev->of_node; gc->request = gpiochip_generic_request; gc->free = gpiochip_generic_free; gc->direction_input = nsp_gpio_direction_input;
drivers/pinctrl/cirrus/pinctrl-lochnagar.c +0 -3
@@ -1161,9 +1161,6 @@ static int lochnagar_pin_probe(struct platform_device *pdev) priv->gpio_chip.can_sleep = true; priv->gpio_chip.parent = dev; priv->gpio_chip.base =-1 ; -#ifdef CONFIG_OF_GPIO - priv->gpio_chip.of_node = dev->of_node; -#endif switch (lochnagar->type) {case LOCHNAGAR1 :
drivers/pinctrl/mediatek/pinctrl-moore.c +3 -4
@@ -519,7 +519,7 @@ static int mtk_gpio_set_config(struct gpio_chip *chip, unsigned int offset,return mtk_eint_set_debounce (hw->eint, desc->eint.eint_n, debounce); } -static int mtk_build_gpiochip (struct mtk_pinctrl *hw,struct device_node *np) +static int mtk_build_gpiochip (struct mtk_pinctrl *hw) {struct gpio_chip *chip = &hw->chip;int ret;
@@ -536,7 +536,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw, struct device_node *np) chip->set_config = mtk_gpio_set_config; chip->base =-1 ; chip->ngpio = hw->soc->npins; - chip->of_node = np; chip->of_gpio_n_cells =2 ; ret =gpiochip_add_data (chip, hw);
@@ -550,7 +549,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw, struct device_node *np)* Documentation/devicetree/bindings/gpio/gpio.txt on how to * bind pinctrl and gpio drivers via the "gpio-ranges" property. */ -if (!of_find_property (np,"gpio-ranges" ,NULL )) { +if (!of_find_property (hw->dev->of_node,"gpio-ranges" ,NULL )) { ret =gpiochip_add_pin_range (chip,dev_name (hw->dev),0 ,0 , chip->ngpio);if (ret <0 ) {
@@ -691,7 +690,7 @@ int mtk_moore_pinctrl_probe(struct platform_device *pdev, "Failed to add EINT, but pinctrl still can work\n");/* Build gpiochip should be after pinctrl_enable is done */ - err =mtk_build_gpiochip (hw, pdev->dev.of_node); + err =mtk_build_gpiochip (hw);if (err) {dev_err (&pdev->dev,"Failed to add gpio_chip\n" );return err;
drivers/pinctrl/mediatek/pinctrl-paris.c +2 -3
@@ -895,7 +895,7 @@ static int mtk_gpio_set_config(struct gpio_chip *chip, unsigned int offset,return mtk_eint_set_debounce (hw->eint, desc->eint.eint_n, debounce); } -static int mtk_build_gpiochip (struct mtk_pinctrl *hw,struct device_node *np) +static int mtk_build_gpiochip (struct mtk_pinctrl *hw) {struct gpio_chip *chip = &hw->chip;int ret;
@@ -913,7 +913,6 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw, struct device_node *np) chip->set_config = mtk_gpio_set_config; chip->base =-1 ; chip->ngpio = hw->soc->npins; - chip->of_node = np; chip->of_gpio_n_cells =2 ; ret =gpiochip_add_data (chip, hw);
@@ -1037,7 +1036,7 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev, "Failed to add EINT, but pinctrl still can work\n");/* Build gpiochip should be after pinctrl_enable is done */ - err =mtk_build_gpiochip (hw, pdev->dev.of_node); + err =mtk_build_gpiochip (hw);if (err) {dev_err (&pdev->dev,"Failed to add gpio_chip\n" );return err;
drivers/pinctrl/pinctrl-amd.c +0 -3
@@ -1009,9 +1009,6 @@ static int amd_gpio_probe(struct platform_device *pdev) gpio_dev->gc.owner =THIS_MODULE ; gpio_dev->gc.parent = &pdev->dev; gpio_dev->gc.ngpio =resource_size (res) /4 ; -#if defined(CONFIG_OF_GPIO ) - gpio_dev->gc.of_node = pdev->dev.of_node; -#endif gpio_dev->hwbank_num = gpio_dev->gc.ngpio /64 ; gpio_dev->groups = kerncz_groups;
drivers/pinctrl/pinctrl-at91-pio4.c +0 -1
@@ -1136,7 +1136,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev) } atmel_pioctrl->gpio_chip = &atmel_gpio_chip; - atmel_pioctrl->gpio_chip->of_node = dev->of_node; atmel_pioctrl->gpio_chip->ngpio = atmel_pioctrl->npins; atmel_pioctrl->gpio_chip->label =dev_name (dev); atmel_pioctrl->gpio_chip->parent = dev;
drivers/pinctrl/pinctrl-at91.c +0 -1
@@ -1868,7 +1868,6 @@ static int at91_gpio_probe(struct platform_device *pdev) at91_chip->chip = at91_gpio_template; chip = &at91_chip->chip; - chip->of_node = np; chip->label =dev_name (&pdev->dev); chip->parent = &pdev->dev; chip->owner =THIS_MODULE ;
drivers/pinctrl/pinctrl-digicolor.c +2 -3
@@ -233,7 +233,7 @@ static void dc_gpio_set(struct gpio_chip *chip, unsigned gpio, int value)spin_unlock_irqrestore (&pmap->lock, flags); } -static int dc_gpiochip_add (struct dc_pinmap *pmap,struct device_node *np) +static int dc_gpiochip_add (struct dc_pinmap *pmap) {struct gpio_chip *chip = &pmap->chip;int ret;
@@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap, struct device_node *np) chip->set = dc_gpio_set; chip->base =-1 ; chip->ngpio =PINS_COUNT ; - chip->of_node = np; chip->of_gpio_n_cells =2 ;spin_lock_init (&pmap->lock);
@@ -326,7 +325,7 @@ static int dc_pinctrl_probe(struct platform_device *pdev)return PTR_ERR (pmap->pctl); } -return dc_gpiochip_add (pmap, pdev->dev.of_node); +return dc_gpiochip_add (pmap); }static const struct of_device_id dc_pinctrl_ids[] = {
drivers/pinctrl/pinctrl-mcp23s08.c +0 -1
@@ -551,7 +551,6 @@ int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev, mcp->chip.set = mcp23s08_set;#ifdef CONFIG_OF_GPIO mcp->chip.of_gpio_n_cells =2 ; - mcp->chip.of_node = dev->of_node;#endif mcp->chip.base = base;
drivers/pinctrl/pinctrl-ocelot.c +0 -1
@@ -1748,7 +1748,6 @@ static int ocelot_gpiochip_register(struct platform_device *pdev, gc->ngpio = info->desc->npins; gc->parent = &pdev->dev; gc->base =-1 ; - gc->of_node = info->dev->of_node; gc->label ="ocelot-gpio" ; irq =irq_of_parse_and_map (gc->of_node,0 );
drivers/pinctrl/pinctrl-oxnas.c +0 -1
@@ -1232,7 +1232,6 @@ static int oxnas_gpio_probe(struct platform_device *pdev) bank->id = id; bank->gpio_chip.parent = &pdev->dev; - bank->gpio_chip.of_node = np; bank->gpio_chip.ngpio = ngpios; girq = &bank->gpio_chip.irq; girq->chip = &bank->irq_chip;
drivers/pinctrl/pinctrl-pic32.c +1 -1
@@ -2241,7 +2241,7 @@ static int pic32_gpio_probe(struct platform_device *pdev) } bank->gpio_chip.parent = &pdev->dev; - bank->gpio_chip.of_node = np; + girq = &bank->gpio_chip.irq; girq->chip = &bank->irq_chip; girq->parent_handler = pic32_gpio_irq_handler;
drivers/pinctrl/pinctrl-stmfx.c +0 -1
@@ -675,7 +675,6 @@ static int stmfx_pinctrl_probe(struct platform_device *pdev) pctl->gpio_chip.base =-1 ; pctl->gpio_chip.ngpio = pctl->pctl_desc.npins; pctl->gpio_chip.can_sleep = true; - pctl->gpio_chip.of_node = np; pctl->irq_chip.name =dev_name (pctl->dev); pctl->irq_chip.irq_mask = stmfx_pinctrl_irq_mask;
drivers/pinctrl/pinctrl-sx150x.c +0 -3
@@ -1163,9 +1163,6 @@ static int sx150x_probe(struct i2c_client *client, pctl->gpio.set = sx150x_gpio_set; pctl->gpio.set_config = gpiochip_generic_config; pctl->gpio.parent = dev; -#ifdef CONFIG_OF_GPIO - pctl->gpio.of_node = dev->of_node; -#endif pctl->gpio.can_sleep = true; pctl->gpio.label =devm_kstrdup (dev, client->name,GFP_KERNEL );if (!pctl->gpio.label)
drivers/pinctrl/pinctrl-xway.c +0 -1
@@ -1763,7 +1763,6 @@ static int pinmux_xway_probe(struct platform_device *pdev)/* register the gpio chip */ xway_chip.parent = &pdev->dev; xway_chip.owner =THIS_MODULE ; - xway_chip.of_node = pdev->dev.of_node; ret =devm_gpiochip_add_data (&pdev->dev, &xway_chip,NULL );if (ret) {dev_err (&pdev->dev,"Failed to register gpio chip\n" );
drivers/pinctrl/qcom/pinctrl-msm.c +0 -1
@@ -1264,7 +1264,6 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) chip->label =dev_name (pctrl->dev); chip->parent = pctrl->dev; chip->owner =THIS_MODULE ; - chip->of_node = pctrl->dev->of_node;if (msm_gpio_needs_valid_mask (pctrl)) chip->init_valid_mask = msm_gpio_init_valid_mask;
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c +0 -1
@@ -773,7 +773,6 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev) pctrl->chip = pm8xxx_gpio_template; pctrl->chip.base =-1 ; pctrl->chip.parent = &pdev->dev; - pctrl->chip.of_node = pdev->dev.of_node; pctrl->chip.of_gpio_n_cells =2 ; pctrl->chip.label =dev_name (pctrl->dev); pctrl->chip.ngpio = pctrl->npins;
drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c +0 -1
@@ -857,7 +857,6 @@ static int pm8xxx_mpp_probe(struct platform_device *pdev) pctrl->chip = pm8xxx_mpp_template; pctrl->chip.base =-1 ; pctrl->chip.parent = &pdev->dev; - pctrl->chip.of_node = pdev->dev.of_node; pctrl->chip.of_gpio_n_cells =2 ; pctrl->chip.label =dev_name (pctrl->dev); pctrl->chip.ngpio = pctrl->npins;
drivers/pinctrl/renesas/pinctrl-rza2.c +0 -1
@@ -240,7 +240,6 @@ static int rza2_gpio_register(struct rza2_pinctrl_priv *priv)int ret; chip.label =devm_kasprintf (priv->dev,GFP_KERNEL ,"%pOFn" , np); - chip.of_node = np; chip.parent = priv->dev; chip.ngpio = priv->npins;
drivers/pinctrl/spear/pinctrl-plgpio.c +0 -1
@@ -581,7 +581,6 @@ static int plgpio_probe(struct platform_device *pdev) plgpio->chip.label =dev_name (&pdev->dev); plgpio->chip.parent = &pdev->dev; plgpio->chip.owner =THIS_MODULE ; - plgpio->chip.of_node = pdev->dev.of_node;if (!IS_ERR (plgpio->clk)) { ret =clk_prepare (plgpio->clk);
drivers/pinctrl/vt8500/pinctrl-wmt.c +0 -1
@@ -565,7 +565,6 @@ int wmt_pinctrl_probe(struct platform_device *pdev, data->gpio_chip = wmt_gpio_chip; data->gpio_chip.parent = &pdev->dev; - data->gpio_chip.of_node = pdev->dev.of_node; data->gpio_chip.ngpio = data->nbanks *32 ;platform_set_drvdata (pdev, data);
Signature · 1 line
2.33.0
PATCH v2 2/2 pinctrl: Propagate firmware node from a parent device
When creating MFD platform devices the firmware node is left unset. This, in particular, prevents GPIO library to use it for different purposes. Propagate firmware node from the parent device and let GPIO library do the right thing.
While at it, slightly modify the headers to reflect the usage of APIs.
---
v2: fixed compilation bug (LKP), due to above reshuffle headers in the rest
drivers/pinctrl/cirrus/pinctrl-madera-core.c | 5 ++++- drivers/pinctrl/pinctrl-as3722.c | 13 +++++++------ drivers/pinctrl/pinctrl-da9062.c | 6 +++--- drivers/pinctrl/pinctrl-max77620.c | 10 ++++++---- drivers/pinctrl/pinctrl-rk805.c | 12 ++++++------ 5 files changed, 26 insertions(+), 20 deletions(-)
drivers/pinctrl/cirrus/pinctrl-madera-core.c +4 -1
@@ -8,8 +8,10 @@#include <linux/err.h> #include <linux/module.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <linux/regmap.h> #include <linux/slab.h> +#include <linux/pinctrl/machine.h> #include <linux/pinctrl/pinctrl.h> #include <linux/pinctrl/pinmux.h>
@@ -1004,13 +1006,14 @@ static int madera_pin_probe(struct platform_device *pdev)dev_dbg (&pdev->dev,"%s\n" , __func__); +device_set_node (&pdev->dev,dev_fwnode (pdev->dev.parent)); + priv =devm_kzalloc (&pdev->dev,sizeof (*priv),GFP_KERNEL );if (!priv)return -ENOMEM ; priv->dev = &pdev->dev; priv->madera = madera; - pdev->dev.of_node = madera->dev->of_node;switch (madera->type) {case CS47L15 :
drivers/pinctrl/pinctrl-as3722.c +7 -6
@@ -23,19 +23,20 @@#include <linux/delay.h> #include <linux/gpio/driver.h> #include <linux/kernel.h> +#include <linux/mod_device_table.h> #include <linux/module.h> #include <linux/mfd/as3722.h> -#include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> +#include <linux/pm.h> +#include <linux/property.h> +#include <linux/slab.h> +#include <linux/pinctrl/consumer.h> #include <linux/pinctrl/machine.h> #include <linux/pinctrl/pinctrl.h> #include <linux/pinctrl/pinconf-generic.h> #include <linux/pinctrl/pinconf.h> #include <linux/pinctrl/pinmux.h> -#include <linux/pm.h> -#include <linux/slab.h> #include "core.h" #include "pinconf.h"
@@ -551,12 +552,13 @@ static int as3722_pinctrl_probe(struct platform_device *pdev)struct as3722_pctrl_info *as_pci;int ret; +device_set_node (&pdev->dev,dev_fwnode (pdev->dev.parent)); + as_pci =devm_kzalloc (&pdev->dev,sizeof (*as_pci),GFP_KERNEL );if (!as_pci)return -ENOMEM ; as_pci->dev = &pdev->dev; - as_pci->dev->of_node = pdev->dev.parent->of_node; as_pci->as3722 =dev_get_drvdata (pdev->dev.parent);platform_set_drvdata (pdev, as_pci);
@@ -578,7 +580,6 @@ static int as3722_pinctrl_probe(struct platform_device *pdev) as_pci->gpio_chip = as3722_gpio_chip; as_pci->gpio_chip.parent = &pdev->dev; - as_pci->gpio_chip.of_node = pdev->dev.parent->of_node; ret =gpiochip_add_data (&as_pci->gpio_chip, as_pci);if (ret <0 ) {dev_err (&pdev->dev,"Couldn't register gpiochip, %d\n" , ret);
drivers/pinctrl/pinctrl-da9062.c +3 -3
@@ -14,6 +14,7 @@#include <linux/bits.h> #include <linux/module.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <linux/regmap.h> #include <linux/gpio/driver.h>
@@ -256,6 +257,8 @@ static int da9062_pctl_probe(struct platform_device *pdev)struct da9062_pctl *pctl;int i; +device_set_node (&pdev->dev,dev_fwnode (pdev->dev.parent)); + pctl =devm_kzalloc (&pdev->dev,sizeof (*pctl),GFP_KERNEL );if (!pctl)return -ENOMEM ;
@@ -277,9 +280,6 @@ static int da9062_pctl_probe(struct platform_device *pdev) pctl->gc = reference_gc; pctl->gc.label =dev_name (&pdev->dev); pctl->gc.parent = &pdev->dev; -#ifdef CONFIG_OF_GPIO - pctl->gc.of_node = parent->of_node; -#endif platform_set_drvdata (pdev, pctl);
drivers/pinctrl/pinctrl-max77620.c +6 -4
@@ -11,13 +11,14 @@#include <linux/mfd/max77620.h> #include <linux/module.h> -#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/property.h> +#include <linux/regmap.h> +#include <linux/pinctrl/pinctrl.h> #include <linux/pinctrl/pinconf-generic.h> #include <linux/pinctrl/pinconf.h> #include <linux/pinctrl/pinmux.h> -#include <linux/platform_device.h> -#include <linux/regmap.h> #include "core.h" #include "pinconf.h"
@@ -551,12 +552,13 @@ static int max77620_pinctrl_probe(struct platform_device *pdev)struct max77620_pctrl_info *mpci;int i; +device_set_node (&pdev->dev,dev_fwnode (pdev->dev.parent)); + mpci =devm_kzalloc (&pdev->dev,sizeof (*mpci),GFP_KERNEL );if (!mpci)return -ENOMEM ; mpci->dev = &pdev->dev; - mpci->dev->of_node = pdev->dev.parent->of_node; mpci->rmap = max77620->rmap; mpci->pins = max77620_pins_desc;
drivers/pinctrl/pinctrl-rk805.c +6 -6
@@ -13,17 +13,17 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/mfd/rk808.h> -#include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> +#include <linux/pm.h> +#include <linux/property.h> +#include <linux/slab.h> +#include <linux/pinctrl/consumer.h> #include <linux/pinctrl/machine.h> #include <linux/pinctrl/pinctrl.h> #include <linux/pinctrl/pinconf-generic.h> #include <linux/pinctrl/pinconf.h> #include <linux/pinctrl/pinmux.h> -#include <linux/pm.h> -#include <linux/slab.h> #include "core.h" #include "pinconf.h"
@@ -420,18 +420,18 @@ static int rk805_pinctrl_probe(struct platform_device *pdev)struct rk805_pctrl_info *pci;int ret; +device_set_node (&pdev->dev,dev_fwnode (pdev->dev.parent)); + pci =devm_kzalloc (&pdev->dev,sizeof (*pci),GFP_KERNEL );if (!pci)return -ENOMEM ; pci->dev = &pdev->dev; - pci->dev->of_node = pdev->dev.parent->of_node; pci->rk808 =dev_get_drvdata (pdev->dev.parent); pci->pinctrl_desc = rk805_pinctrl_desc; pci->gpio_chip = rk805_gpio_chip; pci->gpio_chip.parent = &pdev->dev; - pci->gpio_chip.of_node = pdev->dev.parent->of_node;platform_set_drvdata (pdev, pci);
Signature · 1 line
2.33.0
Re: [PATCH v2 2/2] pinctrl: Propagate firmware node from a parent device
Quoted 10 lines · Andy Shevchenko
When creating MFD platform devices the firmware node is left unset. This, in particular, prevents GPIO library to use it for different purposes. Propagate firmware node from the parent device and let GPIO library do the right thing.
While at it, slightly modify the headers to reflect the usage of APIs.
Signed-off-by Andy Shevchenko <[email protected]>---
v2: fixed compilation bug (LKP), due to above reshuffle headers in the rest
...
Quoted 1 line
+#include <
linux/mod_device_table.h>
He-h, updated code, updated bugs...
Linus, can you, please, apply the first patch if you have no objections, so I won't spam a lot of people again with no changes beneath?
Signature · 2 lines
With Best Regards, Andy Shevchenko
kernel test robot
build botRe: [PATCH v2 2/2] pinctrl: Propagate firmware node from a parent device
In reply to Andy ShevchenkoI love your patch! Yet something to improve:
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on linusw-pinctrl/devel]
[cannot apply to geert-renesas-drivers/renesas-pinctrl v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/pinctrl-Get-rid-of-duplicate-of_node-assignment-in-the-drivers/20211214-210027 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel config: x86_64-randconfig-a012-20211214 (https://download.01.org/0day-ci/archive/20211214/202112142358.CrwPNZbA-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/fb259425f395e043cd3ef074641937e28d0cffb9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andy-Shevchenko/pinctrl-Get-rid-of-duplicate-of_node-assignment-in-the-drivers/20211214-210027 git checkout fb259425f395e043cd3ef074641937e28d0cffb9
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> drivers/pinctrl/pinctrl-max77620.c:649:64: error: array has incomplete element type 'const struct platform_device_id'
static const struct platform_device_id max77620_pinctrl_devtype[] = {
^
include/linux/platform_device.h:21:8: note: forward declaration of 'struct platform_device_id'
struct platform_device_id;
^1 error generated.
vim +649 drivers/pinctrl/pinctrl-max77620.c
2df723d49cdafb6 Laxman Dewangan 2016-05-13 648
2df723d49cdafb6 Laxman Dewangan 2016-05-13 @649 static const struct platform_device_id max77620_pinctrl_devtype[] = {
2df723d49cdafb6 Laxman Dewangan 2016-05-13 650 { .name = "max77620-pinctrl", },
2df723d49cdafb6 Laxman Dewangan 2016-05-13 651 { .name = "max20024-pinctrl", },
2df723d49cdafb6 Laxman Dewangan 2016-05-13 652 {},
2df723d49cdafb6 Laxman Dewangan 2016-05-13 653 };
2df723d49cdafb6 Laxman Dewangan 2016-05-13 654 MODULE_DEVICE_TABLE(platform, max77620_pinctrl_devtype);2df723d49cdafb6 Laxman Dewangan 2016-05-13 655
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Re: [PATCH v2 2/2] pinctrl: Propagate firmware node from a parent device
In reply to Andy ShevchenkoQuoted 5 lines · Andy Shevchenko
When creating MFD platform devices the firmware node is left unset. This, in particular, prevents GPIO library to use it for different purposes. Propagate firmware node from the parent device and let GPIO library do the right thing.
I came across the same thing this week. By populating the of_compatible field of the mfd_cell, the child device will have the appropriate firmware node populated. Unfortunately that currently means that I'll have to put every device type in the MFD instead of in an of_match_table in the child driver itself. Figuring that out is one of the next things on my list.
Quoted 9 lines · Andy Shevchenko
GPIO library does copy the
of_nodefrom the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove these assignment all at once.For the details one may look into the
of_gpio_dev_init()implementation.Signed-off-by Andy Shevchenko <[email protected]>---
v2: no changes
Applied this patch 1/2 of the v2 patch set!
Yours,
Linus Walleij