More preparation for multi gt patches
Subsystems (4)
v8 cover More preparation for multi gt patches
Hi,
the first patch concludes the first stage of refactoring which makes the use of intel_gt on the different subsystem. It's taken from Matt's series and it has alread been reviewed. The patch has just been replaced before any multitile patches and I think it can be already pushed.
Patch 2-10 hides i915->gt behind the to_gt() wrapper proposed by Michał. Finally i915->gt changes to i915->gt0.
The last six patches abstract the ggtt reference forcing the use of the ggtt in the gt structure rather than in the i915.
Thanks a lot Matt for the reviews.
Andi
Changelog:
==========
Patchwork: https://patchwork.freedesktop.org/series/97020/
v7 -> v8:
- Removed patch 11 from v7 that was allocating statically the ggtt in the gt structure instead of a dynamic allocation. As Matt pointed out, we can have GT's sharing the same GGTT.
- The whole i915->ggtt to gt->ggtt patch is split in 5 patches instead of one single to make it easier to review.
- The last patch removes i915->ggtt and allocates the gt->ggtt with drmm_kzalloc in the early probe and mock device.
v6 -> v7:
- Patch 1: add a note about the double presence of __intel_gt_init_early() and intel_gt_init_early().
- Added all Matt's r-b's for patches 2-10.
- Added a patch 12 that moves the i915->ggtt into gt->ggtt.
v5 -> v6:
- fixed the assignement of i915->gt->ggtt = ggtt in the mock gem device that was making use of it before.
v4 -> v5:
- use to_gt() instead of to_root_gt() and use Michał work done previously.
- split the /i915->gt/to_gt()/ patch in smaller chunks in order to make review easier. (Thanks Lucas)
v3 -> v4:
- the intel_gt_init_early() has been split as it was causing some headaches for the order of the early initialization. The split has been done keeping in mind the coming next patch in the series that wil make this a static function.
v2 -> v3:
- sed -i ... took too much freedom and changed more than it was supposed to.
- fix a compile error which did not appear in my local build
v1 -> v2:
- patch 2: do not use anymore the reference i915->gt but use to_root_gt(), coming from Matt Roper's patch.
- fix some comments from Chris.
Andi Shyti (4):
drm/i915/selftests: Use to_gt() helper drm/i915/pxp: Use to_gt() helper
drm/i915: Rename i915->gt to i915->gt0 drm/i915: Move the GGTT from i915 private data to the GT
Michał Winiarski (8):
drm/i915: Store backpointer to GT in uncore
drm/i915: Introduce to_gt() helper
drm/i915/display: Use to_gt() helper
drm/i915/gt: Use to_gt() helper
drm/i915/gem: Use to_gt() helper
drm/i915/gvt: Use to_gt() helper
drm/i915: Use to_gt() helper
drm/i915: Use to_gt() helper for GGTT accesses
Andi Shyti (4):
drm/i915/selftests: Use to_gt() helper
drm/i915/pxp: Use to_gt() helper
drm/i915: Rename i915->gt to i915->gt0
drm/i915: Remove unused i915->ggtt
Michał Winiarski (12):
drm/i915: Store backpointer to GT in uncore drm/i915: Introduce to_gt() helper drm/i915/display: Use to_gt() helper drm/i915/gt: Use to_gt() helper
drm/i915/gem: Use to_gt() helper
drm/i915/gvt: Use to_gt() helper
drm/i915: Use to_gt() helper
drm/i915/gem: Use to_gt() helper for GGTT accesses drm/i915/display: Use to_gt() helper for GGTT accesses drm/i915/gt: Use to_gt() helper for GGTT accesses drm/i915/selftests: Use to_gt() helper for GGTT accesses drm/i915: Use to_gt() helper for GGTT accesses
.../gpu/drm/i915/display/intel_atomic_plane.c | 4 +- drivers/gpu/drm/i915/display/intel_display.c | 18 +++--- drivers/gpu/drm/i915/display/intel_dpt.c | 2 +- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- .../drm/i915/display/intel_plane_initial.c | 2 +- .../drm/i915/display/skl_universal_plane.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 22 ++++---- drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +- drivers/gpu/drm/i915/gem/i915_gem_create.c | 2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 21 +++---- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 6 +- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 8 +-- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 8 +-- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 8 ++- drivers/gpu/drm/i915/gem/i915_gem_throttle.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 15 ++--- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 12 ++-- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +- .../gpu/drm/i915/gem/selftests/huge_pages.c | 4 +- .../i915/gem/selftests/i915_gem_client_blt.c | 4 +- .../drm/i915/gem/selftests/i915_gem_context.c | 12 ++-- .../drm/i915/gem/selftests/i915_gem_migrate.c | 2 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 45 ++++++++------- .../drm/i915/gem/selftests/i915_gem_object.c | 2 +- drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 14 ++--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 6 +- drivers/gpu/drm/i915/gt/intel_gt.c | 18 ++++-- drivers/gpu/drm/i915/gt/intel_gt.h | 3 +- .../gpu/drm/i915/gt/intel_gt_buffer_pool.c | 7 +-- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- drivers/gpu/drm/i915/gt/mock_engine.c | 10 ++-- drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- drivers/gpu/drm/i915/gt/selftest_engine.c | 2 +- drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 4 +- .../drm/i915/gt/selftest_engine_heartbeat.c | 4 +- drivers/gpu/drm/i915/gt/selftest_execlists.c | 6 +- drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 8 +-- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +- drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_migrate.c | 4 +- drivers/gpu/drm/i915/gt/selftest_mocs.c | 2 +- drivers/gpu/drm/i915/gt/selftest_reset.c | 4 +- .../drm/i915/gt/selftest_ring_submission.c | 4 +- drivers/gpu/drm/i915/gt/selftest_slpc.c | 6 +- drivers/gpu/drm/i915/gt/selftest_timeline.c | 6 +- .../gpu/drm/i915/gt/selftest_workarounds.c | 4 +- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +- drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 2 +- .../drm/i915/gt/uc/selftest_guc_multi_lrc.c | 2 +- drivers/gpu/drm/i915/gvt/dmabuf.c | 2 +- drivers/gpu/drm/i915/gvt/gvt.c | 2 +- drivers/gpu/drm/i915/gvt/scheduler.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 42 +++++++------- drivers/gpu/drm/i915/i915_debugfs_params.c | 4 +- drivers/gpu/drm/i915/i915_driver.c | 39 +++++++------ drivers/gpu/drm/i915/i915_drv.h | 13 +++-- drivers/gpu/drm/i915/i915_gem.c | 39 ++++++------- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +- drivers/gpu/drm/i915/i915_getparam.c | 12 ++-- drivers/gpu/drm/i915/i915_gpu_error.c | 4 +- drivers/gpu/drm/i915/i915_irq.c | 56 +++++++++---------- drivers/gpu/drm/i915/i915_perf.c | 6 +- drivers/gpu/drm/i915/i915_pmu.c | 14 ++--- drivers/gpu/drm/i915/i915_query.c | 2 +- drivers/gpu/drm/i915/i915_sysfs.c | 22 ++++---- drivers/gpu/drm/i915/intel_gvt.c | 2 +- drivers/gpu/drm/i915/intel_uncore.c | 9 +-- drivers/gpu/drm/i915/intel_uncore.h | 3 +- drivers/gpu/drm/i915/intel_wopcm.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 4 +- drivers/gpu/drm/i915/selftests/i915_active.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem.c | 10 ++-- .../gpu/drm/i915/selftests/i915_gem_evict.c | 6 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 30 +++++----- drivers/gpu/drm/i915/selftests/i915_perf.c | 2 +- drivers/gpu/drm/i915/selftests/i915_request.c | 12 ++-- .../gpu/drm/i915/selftests/i915_selftest.c | 4 +- drivers/gpu/drm/i915/selftests/i915_vma.c | 22 ++++---- .../gpu/drm/i915/selftests/igt_flush_test.c | 2 +- .../gpu/drm/i915/selftests/igt_live_test.c | 4 +- .../drm/i915/selftests/intel_memory_region.c | 4 +- drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 +- .../gpu/drm/i915/selftests/mock_gem_device.c | 41 ++++++++------ drivers/gpu/drm/i915/selftests/mock_gtt.c | 11 ++-- drivers/gpu/drm/i915/selftests/mock_gtt.h | 3 +- drivers/gpu/drm/i915/selftests/mock_uncore.c | 2 +- 92 files changed, 418 insertions(+), 386 deletions(-)
Signature · 1 line
2.34.1
PATCH v8 1/16 drm/i915: Store backpointer to GT in uncore
From: Michał Winiarski <[email protected]>
We now support a per-gt uncore, yet we're not able to infer which GT we're operating upon. Let's store a backpointer for now.
At this point the early initialization of the gt needs to be broken in two parts where the first is needed to assign to the gt the i915 private data pointer and the uncore. A temporary function has been made and the two parts are __intel_gt_init_early() and intel_gt_init_early(). This split will be fixed in the future with the multitile patch.
--- drivers/gpu/drm/i915/gt/intel_gt.c | 11 +++++++---- drivers/gpu/drm/i915/gt/intel_gt.h | 1 + drivers/gpu/drm/i915/i915_driver.c | 5 +++-- drivers/gpu/drm/i915/intel_uncore.c | 9 +++++---- drivers/gpu/drm/i915/intel_uncore.h | 3 ++- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 4 ++-- drivers/gpu/drm/i915/selftests/mock_uncore.c | 2 +- 7 files changed, 21 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt.c +7 -4
@@ -25,11 +25,8 @@#include "shmem_utils.h" #include "pxp/intel_pxp.h" -void intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915) +void __intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915) { - gt->i915 = i915; - gt->uncore = &i915->uncore; -spin_lock_init (>->irq_lock);INIT_LIST_HEAD (>->closed_vma);
@@ -48,6 +45,12 @@ void intel_gt_init_early(struct intel_gt *gt, struct drm_i915_private *i915)intel_rps_init_early (>->rps); } +void intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915) +{ + gt->i915 = i915; + gt->uncore = &i915->uncore; +} +int intel_gt_probe_lmem (struct intel_gt *gt) {struct drm_i915_private *i915 = gt->i915;
drivers/gpu/drm/i915/gt/intel_gt.h +1 -0
@@ -35,6 +35,7 @@ static inline struct intel_gt *huc_to_gt(struct intel_huc *huc) }void intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915); +void __intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915);void intel_gt_init_hw_early (struct intel_gt *gt,struct i915_ggtt *ggtt);int intel_gt_probe_lmem (struct intel_gt *gt);int intel_gt_init_mmio (struct intel_gt *gt);
drivers/gpu/drm/i915/i915_driver.c +3 -2
@@ -314,8 +314,9 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)intel_device_info_subplatform_init (dev_priv);intel_step_init (dev_priv); +intel_gt_init_early (&dev_priv->gt, dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug); -intel_uncore_init_early (&dev_priv->uncore, dev_priv); +intel_uncore_init_early (&dev_priv->uncore, &dev_priv->gt);spin_lock_init (&dev_priv->irq_lock);spin_lock_init (&dev_priv->gpu_error.lock);
@@ -346,7 +347,7 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)intel_wopcm_init_early (&dev_priv->wopcm); -intel_gt_init_early (&dev_priv->gt, dev_priv); +__intel_gt_init_early (&dev_priv->gt, dev_priv);i915_gem_init_early (dev_priv);
drivers/gpu/drm/i915/intel_uncore.c +5 -4
@@ -2061,12 +2061,13 @@ void intel_uncore_cleanup_mmio(struct intel_uncore *uncore) }void intel_uncore_init_early (struct intel_uncore *uncore, -struct drm_i915_private *i915) +struct intel_gt *gt) {spin_lock_init (&uncore->lock); - uncore->i915 = i915; - uncore->rpm = &i915->runtime_pm; - uncore->debug = &i915->mmio_debug; + uncore->i915 = gt->i915; + uncore->gt = gt; + uncore->rpm = >->i915->runtime_pm; + uncore->debug = >->i915->mmio_debug; }static void uncore_raw_init (struct intel_uncore *uncore)
drivers/gpu/drm/i915/intel_uncore.h +2 -1
@@ -129,6 +129,7 @@ struct intel_uncore {void __iomem *regs;struct drm_i915_private *i915; +struct intel_gt *gt;struct intel_runtime_pm *rpm;spinlock_t lock;/** lock is also taken in irq contexts. */
@@ -217,7 +218,7 @@ u32 intel_uncore_read_with_mcr_steering(struct intel_uncore *uncore,void intel_uncore_mmio_debug_init_early (struct intel_uncore_mmio_debug *mmio_debug);void intel_uncore_init_early (struct intel_uncore *uncore, -struct drm_i915_private *i915); +struct intel_gt *gt);int intel_uncore_setup_mmio (struct intel_uncore *uncore);int intel_uncore_init_mmio (struct intel_uncore *uncore); void intel_uncore_prune_engine_fw_domains(struct intel_uncore *uncore,
drivers/gpu/drm/i915/selftests/mock_gem_device.c +2 -2
@@ -175,12 +175,12 @@ struct drm_i915_private *mock_gem_device(void)mkwrite_device_info (i915)->memory_regions =REGION_SMEM ;intel_memory_regions_hw_probe (i915); -mock_uncore_init (&i915->uncore, i915); -spin_lock_init (&i915->gpu_error.lock);i915_gem_init__mm (i915);intel_gt_init_early (&i915->gt, i915); +__intel_gt_init_early (&i915->gt, i915); +mock_uncore_init (&i915->uncore, i915);atomic_inc (&i915->gt.wakeref.count);/* disable; no hw support */ i915->gt.awake = -ENODEV ;
drivers/gpu/drm/i915/selftests/mock_uncore.c +1 -1
@@ -42,7 +42,7 @@ __nop_read(64)void mock_uncore_init (struct intel_uncore *uncore,struct drm_i915_private *i915) { -intel_uncore_init_early (uncore, i915); +intel_uncore_init_early (uncore, &i915->gt);ASSIGN_RAW_WRITE_MMIO_VFUNCS (uncore, nop);ASSIGN_RAW_READ_MMIO_VFUNCS (uncore, nop);
Signature · 1 line
2.34.1
PATCH v8 2/16 drm/i915: Introduce to_gt() helper
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
To allow further refactoring and abstract away the fact that GT is stored inside i915 private.
No functional changes.
--- drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 7 +------ drivers/gpu/drm/i915/i915_drv.h | 5 +++++ 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c +1 -6
@@ -9,11 +9,6 @@#include "intel_engine_pm.h" #include "intel_gt_buffer_pool.h" -static struct intel_gt *to_gt (struct intel_gt_buffer_pool *pool) -{ - return container_of(pool, struct intel_gt, buffer_pool); -} -static struct list_head *bucket_for_size (struct intel_gt_buffer_pool *pool,size_t sz) {
@@ -141,7 +136,7 @@ static struct intel_gt_buffer_pool_node * node_create(struct intel_gt_buffer_pool *pool, size_t sz, enum i915_map_type type) { - struct intel_gt *gt = to_gt(pool); + struct intel_gt *gt = container_of(pool, struct intel_gt, buffer_pool);struct intel_gt_buffer_pool_node *node;struct drm_i915_gem_object *obj;
drivers/gpu/drm/i915/i915_drv.h +5 -0
@@ -1077,6 +1077,11 @@ static inline struct drm_i915_private *pdev_to_i915(struct pci_dev *pdev)return pci_get_drvdata (pdev); } +static inline struct intel_gt *to_gt (struct drm_i915_private *i915) +{ +return &i915->gt; +} +/* Simple iterator over all initialised engines */ #define for_each_engine (engine__, dev_priv__, id__) \ for ((id__) = 0; \
Signature · 1 line
2.34.1
PATCH v8 3/16 drm/i915/display: Use to_gt() helper
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
--- .../gpu/drm/i915/display/intel_atomic_plane.c | 4 ++-- drivers/gpu/drm/i915/display/intel_display.c | 18 +++++++++--------- drivers/gpu/drm/i915/display/intel_dpt.c | 2 +- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- .../gpu/drm/i915/display/skl_universal_plane.c | 2 +- 5 files changed, 14 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/display/intel_atomic_plane.c +2 -2
@@ -819,7 +819,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane,* maximum clocks following a vblank miss (see do_rps_boost()). */ if (!state->rps_interactive) { -intel_rps_mark_interactive (&dev_priv->gt.rps, true); +intel_rps_mark_interactive (&to_gt (dev_priv)->rps, true); state->rps_interactive = true; }
@@ -853,7 +853,7 @@ intel_cleanup_plane_fb(struct drm_plane *plane,return ;if (state->rps_interactive) { -intel_rps_mark_interactive (&dev_priv->gt.rps, false); +intel_rps_mark_interactive (&to_gt (dev_priv)->rps, false); state->rps_interactive = false; }
drivers/gpu/drm/i915/display/intel_display.c +9 -9
@@ -843,7 +843,7 @@ __intel_display_resume(struct drm_device *dev,static bool gpu_reset_clobbers_display (struct drm_i915_private *dev_priv) {return (INTEL_INFO (dev_priv)->gpu_reset_clobbers_display && -intel_has_gpu_reset (&dev_priv->gt)); +intel_has_gpu_reset (to_gt (dev_priv))); }void intel_display_prepare_reset (struct drm_i915_private *dev_priv)
@@ -862,14 +862,14 @@ void intel_display_prepare_reset(struct drm_i915_private *dev_priv)return ;/* We have a modeset vs reset deadlock, defensively unbreak it. */ -set_bit (I915_RESET_MODESET , &dev_priv->gt.reset.flags); +set_bit (I915_RESET_MODESET , &to_gt (dev_priv)->reset.flags);smp_mb__after_atomic (); -wake_up_bit (&dev_priv->gt.reset.flags,I915_RESET_MODESET ); +wake_up_bit (&to_gt (dev_priv)->reset.flags,I915_RESET_MODESET );if (atomic_read (&dev_priv->gpu_error.pending_fb_pin)) {drm_dbg_kms (&dev_priv->drm,"Modeset potentially stuck, unbreaking through wedging\n" ); -intel_gt_set_wedged (&dev_priv->gt); +intel_gt_set_wedged (to_gt (dev_priv)); }/*
@@ -920,7 +920,7 @@ void intel_display_finish_reset(struct drm_i915_private *dev_priv)return ;/* reset doesn't touch the display */ -if (!test_bit (I915_RESET_MODESET , &dev_priv->gt.reset.flags)) +if (!test_bit (I915_RESET_MODESET , &to_gt (dev_priv)->reset.flags))return ; state =fetch_and_zero (&dev_priv->modeset_restore_state);
@@ -958,7 +958,7 @@ void intel_display_finish_reset(struct drm_i915_private *dev_priv)drm_modeset_acquire_fini (ctx);mutex_unlock (&dev->mode_config.mutex); -clear_bit_unlock (I915_RESET_MODESET , &dev_priv->gt.reset.flags); +clear_bit_unlock (I915_RESET_MODESET , &to_gt (dev_priv)->reset.flags); }static void icl_set_pipe_chicken (const struct intel_crtc_state *crtc_state)
@@ -8513,19 +8513,19 @@ static void intel_atomic_commit_fence_wait(struct intel_atomic_state *intel_statfor (;;) {prepare_to_wait (&intel_state->commit_ready.wait, &wait_fence,TASK_UNINTERRUPTIBLE ); -prepare_to_wait (bit_waitqueue (&dev_priv->gt.reset.flags, +prepare_to_wait (bit_waitqueue (&to_gt (dev_priv)->reset.flags,I915_RESET_MODESET ), &wait_reset,TASK_UNINTERRUPTIBLE );if (i915_sw_fence_done (&intel_state->commit_ready) || -test_bit (I915_RESET_MODESET , &dev_priv->gt.reset.flags)) +test_bit (I915_RESET_MODESET , &to_gt (dev_priv)->reset.flags))break ;schedule (); }finish_wait (&intel_state->commit_ready.wait, &wait_fence); -finish_wait (bit_waitqueue (&dev_priv->gt.reset.flags, +finish_wait (bit_waitqueue (&to_gt (dev_priv)->reset.flags,I915_RESET_MODESET ), &wait_reset); }
drivers/gpu/drm/i915/display/intel_dpt.c +1 -1
@@ -264,7 +264,7 @@ intel_dpt_create(struct intel_framebuffer *fb) vm = &dpt->vm; - vm->gt = &i915->gt; + vm->gt =to_gt (i915); vm->i915 = i915; vm->dma = i915->drm.dev; vm->total = (size /sizeof (gen8_pte_t)) *I915_GTT_PAGE_SIZE ;
drivers/gpu/drm/i915/display/intel_overlay.c +1 -1
@@ -1382,7 +1382,7 @@ void intel_overlay_setup(struct drm_i915_private *dev_priv)if (!HAS_OVERLAY (dev_priv))return ; - engine = dev_priv->gt.engine[RCS0 ]; + engine =to_gt (dev_priv)->engine[RCS0 ];if (!engine || !engine->kernel_context)return ;
drivers/gpu/drm/i915/display/skl_universal_plane.c +1 -1
@@ -1737,7 +1737,7 @@ static bool bo_has_valid_encryption(struct drm_i915_gem_object *obj) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -return intel_pxp_key_check (&i915->gt.pxp, obj, false) ==0 ; +return intel_pxp_key_check (&to_gt (i915)->pxp, obj, false) ==0 ; }static bool pxp_is_borked (struct drm_i915_gem_object *obj)
Signature · 1 line
2.34.1
PATCH v8 4/16 drm/i915/gt: Use to_gt() helper
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
--- drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +- drivers/gpu/drm/i915/gt/intel_rps.c | 12 ++++++------ drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- drivers/gpu/drm/i915/gt/mock_engine.c | 10 +++++----- drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- drivers/gpu/drm/i915/gt/selftest_engine.c | 2 +- drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_execlists.c | 6 +++--- drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 8 ++++---- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +- drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_migrate.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_mocs.c | 2 +- drivers/gpu/drm/i915/gt/selftest_reset.c | 2 +- drivers/gpu/drm/i915/gt/selftest_ring_submission.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_slpc.c | 6 +++--- drivers/gpu/drm/i915/gt/selftest_timeline.c | 6 +++--- drivers/gpu/drm/i915/gt/selftest_workarounds.c | 4 ++-- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +- drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 2 +- drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c | 2 +- 23 files changed, 46 insertions(+), 46 deletions(-)
drivers/gpu/drm/i915/gt/intel_engine_user.c +1 -1
@@ -116,7 +116,7 @@ static void set_scheduler_caps(struct drm_i915_private *i915) disabled |= (I915_SCHEDULER_CAP_ENABLED |I915_SCHEDULER_CAP_PRIORITY ); -if (intel_uc_uses_guc_submission (&i915->gt.uc)) +if (intel_uc_uses_guc_submission (&to_gt (i915)->uc)) enabled |=I915_SCHEDULER_CAP_STATIC_PRIORITY_MAP ;for (i =0 ; i <ARRAY_SIZE (map); i++) {
drivers/gpu/drm/i915/gt/intel_ggtt.c +1 -1
@@ -1232,7 +1232,7 @@ int i915_ggtt_probe_hw(struct drm_i915_private *i915) {int ret; - ret =ggtt_probe_hw (&i915->ggtt, &i915->gt); + ret =ggtt_probe_hw (&i915->ggtt,to_gt (i915));if (ret)return ret;
drivers/gpu/drm/i915/gt/intel_rps.c +6 -6
@@ -2302,7 +2302,7 @@ unsigned long i915_read_mch_val(void)return 0 ; with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -struct intel_ips *ips = &i915->gt.rps.ips; +struct intel_ips *ips = &to_gt (i915)->rps.ips;spin_lock_irq (&mchdev_lock); chipset_val =__ips_chipset_val (ips);
@@ -2329,7 +2329,7 @@ bool i915_gpu_raise(void)if (!i915)return false; - rps = &i915->gt.rps; + rps = &to_gt (i915)->rps;spin_lock_irq (&mchdev_lock);if (rps->max_freq_softlimit < rps->max_freq)
@@ -2356,7 +2356,7 @@ bool i915_gpu_lower(void)if (!i915)return false; - rps = &i915->gt.rps; + rps = &to_gt (i915)->rps;spin_lock_irq (&mchdev_lock);if (rps->max_freq_softlimit > rps->min_freq)
@@ -2382,7 +2382,7 @@ bool i915_gpu_busy(void)if (!i915)return false; - ret = i915->gt.awake; + ret =to_gt (i915)->awake;drm_dev_put (&i915->drm);return ret;
@@ -2405,11 +2405,11 @@ bool i915_gpu_turbo_disable(void)if (!i915)return false; - rps = &i915->gt.rps; + rps = &to_gt (i915)->rps;spin_lock_irq (&mchdev_lock); rps->max_freq_softlimit = rps->min_freq; - ret = !__gen5_rps_set (&i915->gt.rps, rps->min_freq); + ret = !__gen5_rps_set (&to_gt (i915)->rps, rps->min_freq);spin_unlock_irq (&mchdev_lock);drm_dev_put (&i915->drm);
drivers/gpu/drm/i915/gt/intel_workarounds.c +1 -1
@@ -929,7 +929,7 @@ hsw_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)static void gen9_wa_init_mcr (struct drm_i915_private *i915,struct i915_wa_list *wal) { -const struct sseu_dev_info *sseu = &i915->gt.info.sseu; +const struct sseu_dev_info *sseu = &to_gt (i915)->info.sseu;unsigned int slice, subslice;u32 mcr, mcr_mask;
drivers/gpu/drm/i915/gt/mock_engine.c +5 -5
@@ -345,7 +345,7 @@ struct intel_engine_cs *mock_engine(struct drm_i915_private *i915,struct mock_engine *engine;GEM_BUG_ON (id >=I915_NUM_ENGINES ); -GEM_BUG_ON (!i915->gt.uncore); +GEM_BUG_ON (!to_gt (i915)->uncore); engine =kzalloc (sizeof (*engine) +PAGE_SIZE ,GFP_KERNEL );if (!engine)
@@ -353,8 +353,8 @@ struct intel_engine_cs *mock_engine(struct drm_i915_private *i915,/* minimal engine setup for requests */ engine->base.i915 = i915; - engine->base.gt = &i915->gt; - engine->base.uncore = i915->gt.uncore; + engine->base.gt =to_gt (i915); + engine->base.uncore =to_gt (i915)->uncore;snprintf (engine->base.name,sizeof (engine->base.name),"%s" , name); engine->base.id = id; engine->base.mask =BIT (id);
@@ -377,8 +377,8 @@ struct intel_engine_cs *mock_engine(struct drm_i915_private *i915, engine->base.release = mock_engine_release; - i915->gt.engine[id] = &engine->base; - i915->gt.engine_class[0 ][id] = &engine->base; +to_gt (i915)->engine[id] = &engine->base; +to_gt (i915)->engine_class[0 ][id] = &engine->base;/* fake hw queue */ spin_lock_init (&engine->hw_lock);
drivers/gpu/drm/i915/gt/selftest_context.c +1 -1
@@ -442,7 +442,7 @@ int intel_context_live_selftests(struct drm_i915_private *i915)SUBTEST (live_active_context), SUBTEST(live_remote_context), }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);if (intel_gt_is_wedged (gt))return 0 ;
drivers/gpu/drm/i915/gt/selftest_engine.c +1 -1
@@ -12,7 +12,7 @@ int intel_engine_live_selftests(struct drm_i915_private *i915) live_engine_pm_selftests, NULL, }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);typeof (*tests) *fn;for (fn = tests; *fn; fn++) {
drivers/gpu/drm/i915/gt/selftest_engine_cs.c +2 -2
@@ -361,10 +361,10 @@ int intel_engine_cs_perf_selftests(struct drm_i915_private *i915) SUBTEST(perf_mi_noop), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }static int intel_mmio_bases_check (void *arg)
drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c +2 -2
@@ -378,13 +378,13 @@ int intel_heartbeat_live_selftests(struct drm_i915_private *i915)int saved_hangcheck;int err; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; saved_hangcheck = i915->params.enable_hangcheck; i915->params.enable_hangcheck =INT_MAX ; - err =intel_gt_live_subtests (tests, &i915->gt); + err =intel_gt_live_subtests (tests,to_gt (i915)); i915->params.enable_hangcheck = saved_hangcheck;return err;
drivers/gpu/drm/i915/gt/selftest_execlists.c +3 -3
@@ -4502,11 +4502,11 @@ int intel_execlists_live_selftests(struct drm_i915_private *i915) SUBTEST(live_virtual_reset), }; -if (i915->gt.submission_method !=INTEL_SUBMISSION_ELSP ) +if (to_gt (i915)->submission_method !=INTEL_SUBMISSION_ELSP )return 0 ; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gt/selftest_gt_pm.c +4 -4
@@ -193,10 +193,10 @@ int intel_gt_pm_live_selftests(struct drm_i915_private *i915) SUBTEST(live_gt_resume), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }int intel_gt_pm_late_selftests (struct drm_i915_private *i915)
@@ -210,8 +210,8 @@ int intel_gt_pm_late_selftests(struct drm_i915_private *i915) SUBTEST(live_rc6_ctx_wa), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gt/selftest_hangcheck.c +1 -1
@@ -2018,7 +2018,7 @@ int intel_hangcheck_live_selftests(struct drm_i915_private *i915)SUBTEST (igt_reset_evict_fence), SUBTEST(igt_handle_error), }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);intel_wakeref_t wakeref;int err;
drivers/gpu/drm/i915/gt/selftest_lrc.c +1 -1
@@ -1847,5 +1847,5 @@ int intel_lrc_live_selftests(struct drm_i915_private *i915)if (!HAS_LOGICAL_RING_CONTEXTS (i915))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gt/selftest_migrate.c +2 -2
@@ -442,7 +442,7 @@ int intel_migrate_live_selftests(struct drm_i915_private *i915)SUBTEST (thread_global_copy), SUBTEST(thread_global_clear), }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);if (!gt->migrate.context)return 0 ;
@@ -658,7 +658,7 @@ int intel_migrate_perf_selftests(struct drm_i915_private *i915)SUBTEST (perf_clear_blt), SUBTEST(perf_copy_blt), }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);if (intel_gt_is_wedged (gt))return 0 ;
drivers/gpu/drm/i915/gt/selftest_mocs.c +1 -1
@@ -451,5 +451,5 @@ int intel_mocs_live_selftests(struct drm_i915_private *i915)if (!get_mocs_settings (i915, &table))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gt/selftest_reset.c +1 -1
@@ -376,7 +376,7 @@ int intel_reset_live_selftests(struct drm_i915_private *i915)SUBTEST (igt_atomic_reset), SUBTEST(igt_atomic_engine_reset), }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);if (!intel_has_gpu_reset (gt))return 0 ;
drivers/gpu/drm/i915/gt/selftest_ring_submission.c +2 -2
@@ -291,8 +291,8 @@ int intel_ring_submission_live_selftests(struct drm_i915_private *i915) SUBTEST(live_ctx_switch_wa), }; -if (i915->gt.submission_method >INTEL_SUBMISSION_RING ) +if (to_gt (i915)->submission_method >INTEL_SUBMISSION_RING )return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gt/selftest_slpc.c +3 -3
@@ -39,7 +39,7 @@ static int slpc_set_max_freq(struct intel_guc_slpc *slpc, u32 freq)static int live_slpc_clamp_min (void *arg) {struct drm_i915_private *i915 = arg; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);struct intel_guc_slpc *slpc = >->uc.guc.slpc;struct intel_rps *rps = >->rps;struct intel_engine_cs *engine;
@@ -166,7 +166,7 @@ static int live_slpc_clamp_min(void *arg)static int live_slpc_clamp_max (void *arg) {struct drm_i915_private *i915 = arg; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);struct intel_guc_slpc *slpc;struct intel_rps *rps;struct intel_engine_cs *engine;
@@ -304,7 +304,7 @@ int intel_slpc_live_selftests(struct drm_i915_private *i915) SUBTEST(live_slpc_clamp_min), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_live_subtests (tests, i915);
drivers/gpu/drm/i915/gt/selftest_timeline.c +3 -3
@@ -159,7 +159,7 @@ static int mock_hwsp_freelist(void *arg)INIT_RADIX_TREE (&state.cachelines,GFP_KERNEL ); state.prng =I915_RND_STATE_INITIALIZER (i915_selftest.random_seed); - state.gt = &i915->gt; + state.gt =to_gt (i915);/* * Create a bunch of timelines and check that their HWSP do not overlap.
@@ -1416,8 +1416,8 @@ int intel_timeline_live_selftests(struct drm_i915_private *i915) SUBTEST(live_hwsp_rollover_user), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gt/selftest_workarounds.c +2 -2
@@ -1387,8 +1387,8 @@ int intel_workarounds_live_selftests(struct drm_i915_private *i915) SUBTEST(live_engine_reset_workarounds), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +1 -1
@@ -623,7 +623,7 @@ int intel_guc_slpc_enable(struct intel_guc_slpc *slpc)if (unlikely (ret <0 ))return ret; -intel_guc_pm_intrmsk_enable (&i915->gt); +intel_guc_pm_intrmsk_enable (to_gt (i915));slpc_get_rp_values (slpc);
drivers/gpu/drm/i915/gt/uc/selftest_guc.c +1 -1
@@ -115,7 +115,7 @@ int intel_guc_live_selftests(struct drm_i915_private *i915)static const struct i915_subtest tests[] = {SUBTEST (intel_guc_scrub_ctbs), }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);if (intel_gt_is_wedged (gt))return 0 ;
drivers/gpu/drm/i915/gt/uc/selftest_guc_multi_lrc.c +1 -1
@@ -167,7 +167,7 @@ int intel_guc_multi_lrc_live_selftests(struct drm_i915_private *i915)static const struct i915_subtest tests[] = {SUBTEST (intel_guc_multi_lrc_basic), }; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);if (intel_gt_is_wedged (gt))return 0 ;
Signature · 1 line
2.34.1
PATCH v8 5/16 drm/i915/gem: Use to_gt() helper
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 22 ++++++++-------- drivers/gpu/drm/i915/gem/i915_gem_create.c | 2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 +-- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 6 +++-- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 6 ++--- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_throttle.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 12 ++++----- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +- .../gpu/drm/i915/gem/selftests/huge_pages.c | 4 +-- .../i915/gem/selftests/i915_gem_client_blt.c | 2 +- .../drm/i915/gem/selftests/i915_gem_context.c | 10 +++---- .../drm/i915/gem/selftests/i915_gem_migrate.c | 2 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 26 ++++++++++--------- 15 files changed, 55 insertions(+), 50 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_context.c +11 -11
@@ -237,7 +237,7 @@ static int proto_context_set_persistence(struct drm_i915_private *i915,* colateral damage, and we should not pretend we can by * exposing the interface. */ -if (!intel_has_reset_engine (&i915->gt)) +if (!intel_has_reset_engine (to_gt (i915)))return -ENODEV ; pc->user_flags &= ~BIT (UCONTEXT_PERSISTENCE );
@@ -254,7 +254,7 @@ static int proto_context_set_protected(struct drm_i915_private *i915,if (!protected) { pc->uses_protected_content = false; - }else if (!intel_pxp_is_enabled (&i915->gt.pxp)) { + }else if (!intel_pxp_is_enabled (&to_gt (i915)->pxp)) { ret = -ENODEV ; }else if ((pc->user_flags &BIT (UCONTEXT_RECOVERABLE )) || !(pc->user_flags &BIT (UCONTEXT_BANNABLE ))) {
@@ -268,8 +268,8 @@ static int proto_context_set_protected(struct drm_i915_private *i915,*/ pc->pxp_wakeref =intel_runtime_pm_get (&i915->runtime_pm); -if (!intel_pxp_is_active (&i915->gt.pxp)) - ret =intel_pxp_start (&i915->gt.pxp); +if (!intel_pxp_is_active (&to_gt (i915)->pxp)) + ret =intel_pxp_start (&to_gt (i915)->pxp); }return ret;
@@ -571,7 +571,7 @@ set_proto_ctx_engines_parallel_submit(struct i915_user_extension __user *base,intel_engine_mask_t prev_mask;/* FIXME: This is NIY for execlists */ -if (!(intel_uc_uses_guc_submission (&i915->gt.uc))) +if (!(intel_uc_uses_guc_submission (&to_gt (i915)->uc)))return -ENODEV ;if (get_user (slot, &ext->engine_index))
@@ -833,7 +833,7 @@ static int set_proto_ctx_sseu(struct drm_i915_file_private *fpriv, sseu = &pc->legacy_rcs_sseu; } - ret =i915_gem_user_to_context_sseu (&i915->gt, &user_sseu, sseu); + ret =i915_gem_user_to_context_sseu (to_gt (i915), &user_sseu, sseu);if (ret)return ret;
@@ -1044,7 +1044,7 @@ static struct i915_gem_engines *alloc_engines(unsigned int count)static struct i915_gem_engines *default_engines (struct i915_gem_context *ctx,struct intel_sseu rcs_sseu) { -const struct intel_gt *gt = &ctx->i915->gt; +const struct intel_gt *gt =to_gt (ctx->i915);struct intel_engine_cs *engine;struct i915_gem_engines *e, *err;enum intel_engine_id id;
@@ -1521,7 +1521,7 @@ static int __context_set_persistence(struct i915_gem_context *ctx, bool state)* colateral damage, and we should not pretend we can by * exposing the interface. */ -if (!intel_has_reset_engine (&ctx->i915->gt)) +if (!intel_has_reset_engine (to_gt (ctx->i915)))return -ENODEV ;i915_gem_context_clear_persistence (ctx);
@@ -1559,7 +1559,7 @@ i915_gem_create_context(struct drm_i915_private *i915, }else if (HAS_FULL_PPGTT (i915)) {struct i915_ppgtt *ppgtt; - ppgtt =i915_ppgtt_create (&i915->gt,0 ); + ppgtt =i915_ppgtt_create (to_gt (i915),0 );if (IS_ERR (ppgtt)) {drm_dbg (&i915->drm,"PPGTT setup failed (%ld)\n" ,PTR_ERR (ppgtt));
@@ -1742,7 +1742,7 @@ int i915_gem_vm_create_ioctl(struct drm_device *dev, void *data,if (args->flags)return -EINVAL ; - ppgtt =i915_ppgtt_create (&i915->gt,0 ); + ppgtt =i915_ppgtt_create (to_gt (i915),0 );if (IS_ERR (ppgtt))return PTR_ERR (ppgtt);
@@ -2194,7 +2194,7 @@ int i915_gem_context_create_ioctl(struct drm_device *dev, void *data,if (args->flags &I915_CONTEXT_CREATE_FLAGS_UNKNOWN )return -EINVAL ; - ret =intel_gt_terminally_wedged (&i915->gt); + ret =intel_gt_terminally_wedged (to_gt (i915));if (ret)return ret;
drivers/gpu/drm/i915/gem/i915_gem_create.c +1 -1
@@ -379,7 +379,7 @@ static int ext_set_protected(struct i915_user_extension __user *base, void *dataif (ext.flags)return -EINVAL ; -if (!intel_pxp_is_enabled (&ext_data->i915->gt.pxp)) +if (!intel_pxp_is_enabled (&to_gt (ext_data->i915)->pxp))return -ENODEV ; ext_data->flags |=I915_BO_PROTECTED ;
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +2 -2
@@ -2372,9 +2372,9 @@ static int eb_submit(struct i915_execbuffer *eb)return err; } -static int num_vcs_engines (const struct drm_i915_private *i915) +static int num_vcs_engines (struct drm_i915_private *i915) { -return hweight_long (VDBOX_MASK (&i915->gt)); +return hweight_long (VDBOX_MASK (to_gt (i915))); }/*
drivers/gpu/drm/i915/gem/i915_gem_mman.c +1 -1
@@ -646,7 +646,7 @@ mmap_offset_attach(struct drm_i915_gem_object *obj, goto insert;/* Attempt to reap some mmap space from dead objects */ - err =intel_gt_retire_requests_timeout (&i915->gt,MAX_SCHEDULE_TIMEOUT , + err =intel_gt_retire_requests_timeout (to_gt (i915),MAX_SCHEDULE_TIMEOUT ,NULL );if (err) goto err;
drivers/gpu/drm/i915/gem/i915_gem_phys.c +4 -2
@@ -19,6 +19,7 @@static int i915_gem_object_get_pages_phys (struct drm_i915_gem_object *obj) {struct address_space *mapping = obj->base.filp->f_mapping; +struct drm_i915_private *i915 =to_i915 (obj->base.dev);struct scatterlist *sg;struct sg_table *st;dma_addr_t dma;
@@ -73,7 +74,7 @@ static int i915_gem_object_get_pages_phys(struct drm_i915_gem_object *obj) dst +=PAGE_SIZE ; } -intel_gt_chipset_flush (&to_i915 (obj->base.dev)->gt); +intel_gt_chipset_flush (to_gt (i915));/* We're no longer struct page backed */ obj->mem_flags &= ~I915_BO_FLAG_STRUCT_PAGE ;
@@ -140,6 +141,7 @@ int i915_gem_object_pwrite_phys(struct drm_i915_gem_object *obj, {void *vaddr =sg_page (obj->mm.pages->sgl) + args->offset;char __user *user_data =u64_to_user_ptr (args->data_ptr); +struct drm_i915_private *i915 =to_i915 (obj->base.dev);int err; err = i915_gem_object_wait(obj,
@@ -159,7 +161,7 @@ int i915_gem_object_pwrite_phys(struct drm_i915_gem_object *obj,return -EFAULT ;drm_clflush_virt_range (vaddr, args->size); -intel_gt_chipset_flush (&to_i915 (obj->base.dev)->gt); +intel_gt_chipset_flush (to_gt (i915));i915_gem_object_flush_frontbuffer (obj,ORIGIN_CPU );return 0 ;
drivers/gpu/drm/i915/gem/i915_gem_pm.c +3 -3
@@ -35,7 +35,7 @@ void i915_gem_suspend(struct drm_i915_private *i915)* state. Fortunately, the kernel_context is disposable and we do * not rely on its state. */ -intel_gt_suspend_prepare (&i915->gt); +intel_gt_suspend_prepare (to_gt (i915));i915_gem_drain_freed_objects (i915); }
@@ -153,7 +153,7 @@ void i915_gem_suspend_late(struct drm_i915_private *i915)* machine in an unusable condition. */ -intel_gt_suspend_late (&i915->gt); +intel_gt_suspend_late (to_gt (i915));spin_lock_irqsave (&i915->mm.obj_lock, flags);for (phase = phases; *phase; phase++) {
@@ -223,7 +223,7 @@ void i915_gem_resume(struct drm_i915_private *i915)* guarantee that the context image is complete. So let's just reset * it and start again. */ -intel_gt_resume (&i915->gt); +intel_gt_resume (to_gt (i915)); ret =lmem_restore (i915,I915_TTM_BACKUP_ALLOW_GPU );GEM_WARN_ON (ret);
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +1 -1
@@ -153,7 +153,7 @@ i915_gem_shrink(struct i915_gem_ww_ctx *ww,*/ if (shrink &I915_SHRINK_ACTIVE )/* Retire requests to unpin all idle contexts */ -intel_gt_retire_requests (&i915->gt); +intel_gt_retire_requests (to_gt (i915));/* * As we may completely rewrite the (un)bound list whilst unbinding
drivers/gpu/drm/i915/gem/i915_gem_throttle.c +2 -1
@@ -38,12 +38,13 @@ i915_gem_throttle_ioctl(struct drm_device *dev, void *data, {const unsigned long recent_enough = jiffies -DRM_I915_THROTTLE_JIFFIES ;struct drm_i915_file_private *file_priv = file->driver_priv; +struct drm_i915_private *i915 =to_i915 (dev);struct i915_gem_context *ctx;unsigned long idx;long ret;/* ABI: return -EIO if already wedged */ - ret =intel_gt_terminally_wedged (&to_i915 (dev)->gt); + ret =intel_gt_terminally_wedged (to_gt (i915));if (ret)return ret;
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +6 -6
@@ -397,7 +397,7 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo,enum i915_cache_level src_level, dst_level;int ret; -if (!i915->gt.migrate.context ||intel_gt_is_wedged (&i915->gt)) +if (!to_gt (i915)->migrate.context ||intel_gt_is_wedged (to_gt (i915)))return ERR_PTR (-EINVAL );/* With fail_gpu_migration, we always perform a GPU clear. */
@@ -410,8 +410,8 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo, !I915_SELFTEST_ONLY(fail_gpu_migration))return ERR_PTR (-EINVAL ); -intel_engine_pm_get (i915->gt.migrate.context->engine); - ret =intel_context_migrate_clear (i915->gt.migrate.context, dep, +intel_engine_pm_get (to_gt (i915)->migrate.context->engine); + ret =intel_context_migrate_clear (to_gt (i915)->migrate.context, dep, dst_st->sgl, dst_level,i915_ttm_gtt_binds_lmem (dst_mem),0 , &rq);
@@ -423,8 +423,8 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo,return ERR_CAST (src_rsgt); src_level =i915_ttm_cache_level (i915, bo->resource, src_ttm); -intel_engine_pm_get (i915->gt.migrate.context->engine); - ret = intel_context_migrate_copy(i915->gt.migrate.context, +intel_engine_pm_get (to_gt (i915)->migrate.context->engine); + ret = intel_context_migrate_copy(to_gt(i915)->migrate.context, dep, src_rsgt->table.sgl, src_level, i915_ttm_gtt_binds_lmem(bo->resource),
@@ -435,7 +435,7 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo,i915_refct_sgt_put (src_rsgt); } -intel_engine_pm_put (i915->gt.migrate.context->engine); +intel_engine_pm_put (to_gt (i915)->migrate.context->engine);if (ret && rq) {i915_request_wait (rq,0 ,MAX_SCHEDULE_TIMEOUT );
drivers/gpu/drm/i915/gem/i915_gem_userptr.c +1 -1
@@ -529,7 +529,7 @@ i915_gem_userptr_ioctl(struct drm_device *dev,* On almost all of the older hw, we cannot tell the GPU that * a page is readonly. */ -if (!dev_priv->gt.vm->has_read_only) +if (!to_gt (dev_priv)->vm->has_read_only)return -ENODEV ; }
drivers/gpu/drm/i915/gem/selftests/huge_pages.c +2 -2
@@ -1705,7 +1705,7 @@ int i915_gem_huge_page_mock_selftests(void)mkwrite_device_info (dev_priv)->ppgtt_type =INTEL_PPGTT_FULL ;mkwrite_device_info (dev_priv)->ppgtt_size =48 ; - ppgtt =i915_ppgtt_create (&dev_priv->gt,0 ); + ppgtt =i915_ppgtt_create (to_gt (dev_priv),0 );if (IS_ERR (ppgtt)) { err =PTR_ERR (ppgtt); goto out_unlock;
@@ -1747,7 +1747,7 @@ int i915_gem_huge_page_live_selftests(struct drm_i915_private *i915)return 0 ; } -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_live_subtests (tests, i915);
drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c +1 -1
@@ -592,7 +592,7 @@ int i915_gem_client_blt_live_selftests(struct drm_i915_private *i915) SUBTEST(igt_client_tiled_blits), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_live_subtests (tests, i915);
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +5 -5
@@ -90,7 +90,7 @@ static int live_nop_switch(void *arg) }if (i915_request_wait (rq,0 ,10 *HZ ) <0 ) {pr_err ("Failed to populated %d contexts\n" , nctx); -intel_gt_set_wedged (&i915->gt); +intel_gt_set_wedged (to_gt (i915));i915_request_put (rq); err = -EIO ; goto out_file;
@@ -146,7 +146,7 @@ static int live_nop_switch(void *arg)if (i915_request_wait (rq,0 ,HZ /5 ) <0 ) {pr_err ("Switching between %ld contexts timed out\n" , prime); -intel_gt_set_wedged (&i915->gt); +intel_gt_set_wedged (to_gt (i915));i915_request_put (rq);break ; }
@@ -1223,7 +1223,7 @@ __igt_ctx_sseu(struct drm_i915_private *i915,return 0 ;if (flags &TEST_RESET ) -igt_global_reset_lock (&i915->gt); +igt_global_reset_lock (to_gt (i915)); obj =i915_gem_object_create_internal (i915,PAGE_SIZE );if (IS_ERR (obj)) {
@@ -1306,7 +1306,7 @@ __igt_ctx_sseu(struct drm_i915_private *i915, out_unlock:if (flags &TEST_RESET ) -igt_global_reset_unlock (&i915->gt); +igt_global_reset_unlock (to_gt (i915));if (ret)pr_err ("%s: Failed with %d!\n" , name, ret);
@@ -1877,7 +1877,7 @@ int i915_gem_context_live_selftests(struct drm_i915_private *i915) SUBTEST(igt_vm_isolation), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_live_subtests (tests, i915);
drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c +1 -1
@@ -261,5 +261,5 @@ int i915_gem_migrate_live_selftests(struct drm_i915_private *i915)if (!HAS_LMEM (i915))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +14 -12
@@ -84,6 +84,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj, struct rnd_state *prng) {const unsigned long npages = obj->base.size /PAGE_SIZE ; +struct drm_i915_private *i915 =to_i915 (obj->base.dev);struct i915_ggtt_view view;struct i915_vma *vma;unsigned long page;
@@ -141,7 +142,7 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj,if (offset >= obj->base.size) goto out; -intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt); +intel_gt_flush_ggtt_writes (to_gt (i915)); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); cpu =kmap (p) +offset_in_page (offset);
@@ -175,6 +176,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj, {const unsigned int nreal = obj->scratch /PAGE_SIZE ;const unsigned long npages = obj->base.size /PAGE_SIZE ; +struct drm_i915_private *i915 =to_i915 (obj->base.dev);struct i915_vma *vma;unsigned long page;int err;
@@ -234,7 +236,7 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj,if (offset >= obj->base.size)continue ; -intel_gt_flush_ggtt_writes (&to_i915 (obj->base.dev)->gt); +intel_gt_flush_ggtt_writes (to_gt (i915)); p =i915_gem_object_get_page (obj, offset >>PAGE_SHIFT ); cpu =kmap (p) +offset_in_page (offset);
@@ -616,14 +618,14 @@ static bool assert_mmap_offset(struct drm_i915_private *i915,static void disable_retire_worker (struct drm_i915_private *i915) {i915_gem_driver_unregister__shrinker (i915); -intel_gt_pm_get (&i915->gt); -cancel_delayed_work_sync (&i915->gt.requests.retire_work); +intel_gt_pm_get (to_gt (i915)); +cancel_delayed_work_sync (&to_gt (i915)->requests.retire_work); }static void restore_retire_worker (struct drm_i915_private *i915) {igt_flush_test (i915); -intel_gt_pm_put (&i915->gt); +intel_gt_pm_put (to_gt (i915));i915_gem_driver_register__shrinker (i915); }
@@ -651,8 +653,8 @@ static int igt_mmap_offset_exhaustion(void *arg)/* Disable background reaper */ disable_retire_worker (i915); -GEM_BUG_ON (!i915->gt.awake); -intel_gt_retire_requests (&i915->gt); +GEM_BUG_ON (!to_gt (i915)->awake); +intel_gt_retire_requests (to_gt (i915));i915_gem_drain_freed_objects (i915);/* Trim the device mmap space to only a page */
@@ -728,7 +730,7 @@ static int igt_mmap_offset_exhaustion(void *arg)/* Now fill with busy dead objects that we expect to reap */ for (loop =0 ; loop <3 ; loop++) { -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))break ; obj =i915_gem_object_create_internal (i915,PAGE_SIZE );
@@ -942,7 +944,7 @@ static int __igt_mmap(struct drm_i915_private *i915, }if (type ==I915_MMAP_TYPE_GTT ) -intel_gt_flush_ggtt_writes (&i915->gt); +intel_gt_flush_ggtt_writes (to_gt (i915)); err =wc_check (obj);if (err == -ENXIO )
@@ -1049,7 +1051,7 @@ static int __igt_mmap_access(struct drm_i915_private *i915, goto out_unmap; } -intel_gt_flush_ggtt_writes (&i915->gt); +intel_gt_flush_ggtt_writes (to_gt (i915)); err =access_process_vm (current, addr, &x,sizeof (x),0 );if (err !=sizeof (x)) {
@@ -1065,7 +1067,7 @@ static int __igt_mmap_access(struct drm_i915_private *i915, goto out_unmap; } -intel_gt_flush_ggtt_writes (&i915->gt); +intel_gt_flush_ggtt_writes (to_gt (i915)); err =__get_user (y, ptr);if (err) {
@@ -1165,7 +1167,7 @@ static int __igt_mmap_gpu(struct drm_i915_private *i915, }if (type ==I915_MMAP_TYPE_GTT ) -intel_gt_flush_ggtt_writes (&i915->gt); +intel_gt_flush_ggtt_writes (to_gt (i915));for_each_uabi_engine (engine, i915) {struct i915_request *rq;
Signature · 1 line
2.34.1
PATCH v8 6/16 drm/i915/gvt: Use to_gt() helper
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
--- drivers/gpu/drm/i915/gvt/gvt.c | 2 +- drivers/gpu/drm/i915/gvt/scheduler.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gvt/gvt.c +1 -1
@@ -205,7 +205,7 @@ int intel_gvt_init_device(struct drm_i915_private *i915)spin_lock_init (&gvt->scheduler.mmio_context_lock);mutex_init (&gvt->lock);mutex_init (&gvt->sched_lock); - gvt->gt = &i915->gt; + gvt->gt =to_gt (i915); i915->gvt = gvt;init_device_info (gvt);
drivers/gpu/drm/i915/gvt/scheduler.c +1 -1
@@ -1386,7 +1386,7 @@ int intel_vgpu_setup_submission(struct intel_vgpu *vgpu)enum intel_engine_id i;int ret; - ppgtt =i915_ppgtt_create (&i915->gt,I915_BO_ALLOC_PM_EARLY ); + ppgtt =i915_ppgtt_create (to_gt (i915),I915_BO_ALLOC_PM_EARLY );if (IS_ERR (ppgtt))return PTR_ERR (ppgtt);
Signature · 1 line
2.34.1
PATCH v8 7/16 drm/i915/selftests: Use to_gt() helper
In reply to Andi ShytiUse to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
--- drivers/gpu/drm/i915/selftests/i915_active.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem.c | 2 +- .../gpu/drm/i915/selftests/i915_gem_evict.c | 6 ++-- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +-- drivers/gpu/drm/i915/selftests/i915_perf.c | 2 +- drivers/gpu/drm/i915/selftests/i915_request.c | 10 +++---- .../gpu/drm/i915/selftests/i915_selftest.c | 4 +-- .../gpu/drm/i915/selftests/igt_flush_test.c | 2 +- .../gpu/drm/i915/selftests/igt_live_test.c | 4 +-- .../drm/i915/selftests/intel_memory_region.c | 4 +-- drivers/gpu/drm/i915/selftests/intel_uncore.c | 2 +- .../gpu/drm/i915/selftests/mock_gem_device.c | 30 +++++++++---------- drivers/gpu/drm/i915/selftests/mock_gtt.c | 6 ++-- drivers/gpu/drm/i915/selftests/mock_uncore.c | 2 +- 14 files changed, 40 insertions(+), 40 deletions(-)
drivers/gpu/drm/i915/selftests/i915_active.c +1 -1
@@ -254,7 +254,7 @@ int i915_active_live_selftests(struct drm_i915_private *i915) SUBTEST(live_active_barrier), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_subtests (tests, i915);
drivers/gpu/drm/i915/selftests/i915_gem.c +1 -1
@@ -248,7 +248,7 @@ int i915_gem_live_selftests(struct drm_i915_private *i915) SUBTEST(igt_gem_ww_ctx), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_live_subtests (tests, i915);
drivers/gpu/drm/i915/selftests/i915_gem_evict.c +3 -3
@@ -545,7 +545,7 @@ int i915_gem_evict_mock_selftests(void)return -ENOMEM ;with_intel_runtime_pm (&i915->runtime_pm, wakeref) - err = i915_subtests(tests, &i915->gt); + err = i915_subtests(tests, to_gt(i915));mock_destroy_device (i915);return err;
@@ -557,8 +557,8 @@ int i915_gem_evict_live_selftests(struct drm_i915_private *i915) SUBTEST(igt_evict_contexts), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +2 -2
@@ -155,7 +155,7 @@ static int igt_ppgtt_alloc(void *arg)if (!HAS_PPGTT (dev_priv))return 0 ; - ppgtt =i915_ppgtt_create (&dev_priv->gt,0 ); + ppgtt =i915_ppgtt_create (to_gt (dev_priv),0 );if (IS_ERR (ppgtt))return PTR_ERR (ppgtt);
@@ -1053,7 +1053,7 @@ static int exercise_ppgtt(struct drm_i915_private *dev_priv,if (IS_ERR (file))return PTR_ERR (file); - ppgtt =i915_ppgtt_create (&dev_priv->gt,0 ); + ppgtt =i915_ppgtt_create (to_gt (dev_priv),0 );if (IS_ERR (ppgtt)) { err =PTR_ERR (ppgtt); goto out_free;
drivers/gpu/drm/i915/selftests/i915_perf.c +1 -1
@@ -424,7 +424,7 @@ int i915_perf_live_selftests(struct drm_i915_private *i915)if (!perf->metrics_kobj || !perf->ops.enable_metric_set)return 0 ; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ; err =alloc_empty_config (&i915->perf);
drivers/gpu/drm/i915/selftests/i915_request.c +5 -5
@@ -841,7 +841,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)__i915_gem_object_flush_map (obj,0 ,64 );i915_gem_object_unpin_map (obj); -intel_gt_chipset_flush (&i915->gt); +intel_gt_chipset_flush (to_gt (i915)); vma =i915_vma_instance (obj, &i915->ggtt.vm,NULL );if (IS_ERR (vma)) {
@@ -982,7 +982,7 @@ static struct i915_vma *recursive_batch(struct drm_i915_private *i915)if (IS_ERR (obj))return ERR_CAST (obj); - vma =i915_vma_instance (obj, i915->gt.vm,NULL ); + vma =i915_vma_instance (obj,to_gt (i915)->vm,NULL );if (IS_ERR (vma)) { err =PTR_ERR (vma); goto err;
@@ -1014,7 +1014,7 @@ static struct i915_vma *recursive_batch(struct drm_i915_private *i915)__i915_gem_object_flush_map (obj,0 ,64 );i915_gem_object_unpin_map (obj); -intel_gt_chipset_flush (&i915->gt); +intel_gt_chipset_flush (to_gt (i915));return vma;
@@ -1700,7 +1700,7 @@ int i915_request_live_selftests(struct drm_i915_private *i915) SUBTEST(live_breadcrumbs_smoketest), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_subtests (tests, i915);
@@ -3091,7 +3091,7 @@ int i915_request_perf_selftests(struct drm_i915_private *i915) SUBTEST(perf_parallel_engines), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_subtests (tests, i915);
drivers/gpu/drm/i915/selftests/i915_selftest.c +2 -2
@@ -298,10 +298,10 @@ int __i915_live_setup(void *data)struct drm_i915_private *i915 = data;/* The selftests expect an idle system */ -if (intel_gt_pm_wait_for_idle (&i915->gt)) +if (intel_gt_pm_wait_for_idle (to_gt (i915)))return -EIO ; -return intel_gt_terminally_wedged (&i915->gt); +return intel_gt_terminally_wedged (to_gt (i915)); }int __i915_live_teardown (int err,void *data)
drivers/gpu/drm/i915/selftests/igt_flush_test.c +1 -1
@@ -14,7 +14,7 @@int igt_flush_test (struct drm_i915_private *i915) { -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);int ret =intel_gt_is_wedged (gt) ? -EIO :0 ;cond_resched ();
drivers/gpu/drm/i915/selftests/igt_live_test.c +2 -2
@@ -16,7 +16,7 @@ int igt_live_test_begin(struct igt_live_test *t,const char *func, const char *name) { - struct intel_gt *gt = &i915->gt; + struct intel_gt *gt = to_gt(i915);struct intel_engine_cs *engine;enum intel_engine_id id;int err;
@@ -57,7 +57,7 @@ int igt_live_test_end(struct igt_live_test *t)return -EIO ; } -for_each_engine (engine, &i915->gt, id) { +for_each_engine (engine,to_gt (i915), id) {if (t->reset_engine[id] ==i915_reset_engine_count (&i915->gpu_error, engine))continue ;
drivers/gpu/drm/i915/selftests/intel_memory_region.c +2 -2
@@ -1217,7 +1217,7 @@ int intel_memory_region_live_selftests(struct drm_i915_private *i915)return 0 ; } -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_live_subtests (tests, i915);
@@ -1229,7 +1229,7 @@ int intel_memory_region_perf_selftests(struct drm_i915_private *i915) SUBTEST(perf_memcpy), }; -if (intel_gt_is_wedged (&i915->gt)) +if (intel_gt_is_wedged (to_gt (i915)))return 0 ;return i915_live_subtests (tests, i915);
drivers/gpu/drm/i915/selftests/intel_uncore.c +1 -1
@@ -344,5 +344,5 @@ int intel_uncore_live_selftests(struct drm_i915_private *i915) SUBTEST(live_forcewake_domains), }; -return intel_gt_live_subtests (tests, &i915->gt); +return intel_gt_live_subtests (tests,to_gt (i915)); }
drivers/gpu/drm/i915/selftests/mock_gem_device.c +15 -15
@@ -45,7 +45,7 @@void mock_device_flush (struct drm_i915_private *i915) { -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);struct intel_engine_cs *engine;enum intel_engine_id id;
@@ -64,7 +64,7 @@ static void mock_device_release(struct drm_device *dev) goto out;mock_device_flush (i915); -intel_gt_driver_remove (&i915->gt); +intel_gt_driver_remove (to_gt (i915));i915_gem_drain_workqueue (i915);i915_gem_drain_freed_objects (i915);
@@ -73,7 +73,7 @@ static void mock_device_release(struct drm_device *dev)destroy_workqueue (i915->wq);intel_region_ttm_device_fini (i915); -intel_gt_driver_late_release (&i915->gt); +intel_gt_driver_late_release (to_gt (i915));intel_memory_regions_driver_release (i915);drm_mode_config_cleanup (&i915->drm);
@@ -178,11 +178,11 @@ struct drm_i915_private *mock_gem_device(void)spin_lock_init (&i915->gpu_error.lock);i915_gem_init__mm (i915); -intel_gt_init_early (&i915->gt, i915); -__intel_gt_init_early (&i915->gt, i915); +intel_gt_init_early (to_gt (i915), i915); +__intel_gt_init_early (to_gt (i915), i915);mock_uncore_init (&i915->uncore, i915); -atomic_inc (&i915->gt.wakeref.count);/* disable; no hw support */ - i915->gt.awake = -ENODEV ; +atomic_inc (&to_gt (i915)->wakeref.count);/* disable; no hw support */ +to_gt (i915)->awake = -ENODEV ; ret =intel_region_ttm_device_init (i915);if (ret)
@@ -195,19 +195,19 @@ struct drm_i915_private *mock_gem_device(void)mock_init_contexts (i915);mock_init_ggtt (i915, &i915->ggtt); - i915->gt.vm =i915_vm_get (&i915->ggtt.vm); +to_gt (i915)->vm =i915_vm_get (&i915->ggtt.vm);mkwrite_device_info (i915)->platform_engine_mask =BIT (0 ); - i915->gt.info.engine_mask =BIT (0 ); +to_gt (i915)->info.engine_mask =BIT (0 ); - i915->gt.engine[RCS0 ] =mock_engine (i915,"mock" ,RCS0 ); -if (!i915->gt.engine[RCS0 ]) +to_gt (i915)->engine[RCS0 ] =mock_engine (i915,"mock" ,RCS0 ); +if (!to_gt (i915)->engine[RCS0 ]) goto err_unlock; -if (mock_engine_init (i915->gt.engine[RCS0 ])) +if (mock_engine_init (to_gt (i915)->engine[RCS0 ])) goto err_context; -__clear_bit (I915_WEDGED , &i915->gt.reset.flags); +__clear_bit (I915_WEDGED , &to_gt (i915)->reset.flags);intel_engines_driver_register (i915); i915->do_release = true;
@@ -216,13 +216,13 @@ struct drm_i915_private *mock_gem_device(void)return i915; err_context: -intel_gt_driver_remove (&i915->gt); +intel_gt_driver_remove (to_gt (i915)); err_unlock:destroy_workqueue (i915->wq); err_drv:intel_region_ttm_device_fini (i915); err_ttm: -intel_gt_driver_late_release (&i915->gt); +intel_gt_driver_late_release (to_gt (i915));intel_memory_regions_driver_release (i915);drm_mode_config_cleanup (&i915->drm);mock_destroy_device (i915);
drivers/gpu/drm/i915/selftests/mock_gtt.c +3 -3
@@ -70,7 +70,7 @@ struct i915_ppgtt *mock_ppgtt(struct drm_i915_private *i915, const char *name)if (!ppgtt)return NULL ; - ppgtt->vm.gt = &i915->gt; + ppgtt->vm.gt =to_gt (i915); ppgtt->vm.i915 = i915; ppgtt->vm.total =round_down (U64_MAX ,PAGE_SIZE ); ppgtt->vm.dma = i915->drm.dev;
@@ -110,7 +110,7 @@ void mock_init_ggtt(struct drm_i915_private *i915, struct i915_ggtt *ggtt) {memset (ggtt,0 ,sizeof (*ggtt)); - ggtt->vm.gt = &i915->gt; + ggtt->vm.gt =to_gt (i915); ggtt->vm.i915 = i915; ggtt->vm.is_ggtt = true;
@@ -132,7 +132,7 @@ void mock_init_ggtt(struct drm_i915_private *i915, struct i915_ggtt *ggtt) ggtt->vm.vma_ops.clear_pages = clear_pages;i915_address_space_init (&ggtt->vm,VM_CLASS_GGTT ); - i915->gt.ggtt = ggtt; +to_gt (i915)->ggtt = ggtt; }void mock_fini_ggtt (struct i915_ggtt *ggtt)
drivers/gpu/drm/i915/selftests/mock_uncore.c +1 -1
@@ -42,7 +42,7 @@ __nop_read(64)void mock_uncore_init (struct intel_uncore *uncore,struct drm_i915_private *i915) { -intel_uncore_init_early (uncore, &i915->gt); +intel_uncore_init_early (uncore,to_gt (i915));ASSIGN_RAW_WRITE_MMIO_VFUNCS (uncore, nop);ASSIGN_RAW_READ_MMIO_VFUNCS (uncore, nop);
Signature · 1 line
2.34.1
PATCH v8 8/16 drm/i915/pxp: Use to_gt() helper
In reply to Andi ShytiUse to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
--- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c +3 -1
@@ -16,7 +16,9 @@static inline struct intel_pxp *i915_dev_to_pxp (struct device *i915_kdev) { -return &kdev_to_i915 (i915_kdev)->gt.pxp; +struct drm_i915_private *i915 =kdev_to_i915 (i915_kdev); + +return &to_gt (i915)->pxp; } static int intel_pxp_tee_io_message(struct intel_pxp *pxp,
Signature · 1 line
2.34.1
PATCH v8 9/16 drm/i915: Use to_gt() helper
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
Use to_gt() helper consistently throughout the codebase. Pure mechanical s/i915->gt/to_gt(i915). No functional changes.
--- drivers/gpu/drm/i915/i915_debugfs.c | 38 +++++++-------- drivers/gpu/drm/i915/i915_debugfs_params.c | 4 +- drivers/gpu/drm/i915/i915_driver.c | 32 ++++++------- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 16 +++---- drivers/gpu/drm/i915/i915_getparam.c | 10 ++-- drivers/gpu/drm/i915/i915_gpu_error.c | 4 +- drivers/gpu/drm/i915/i915_irq.c | 56 +++++++++++----------- drivers/gpu/drm/i915/i915_perf.c | 2 +- drivers/gpu/drm/i915/i915_pmu.c | 14 +++--- drivers/gpu/drm/i915/i915_query.c | 2 +- drivers/gpu/drm/i915/i915_sysfs.c | 22 ++++----- drivers/gpu/drm/i915/intel_gvt.c | 2 +- drivers/gpu/drm/i915/intel_wopcm.c | 2 +- 14 files changed, 103 insertions(+), 103 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +19 -19
@@ -65,7 +65,7 @@ static int i915_capabilities(struct seq_file *m, void *data)intel_device_info_print_static (INTEL_INFO (i915), &p);intel_device_info_print_runtime (RUNTIME_INFO (i915), &p);i915_print_iommu_status (i915, &p); -intel_gt_info_print (&i915->gt.info, &p); +intel_gt_info_print (&to_gt (i915)->info, &p);intel_driver_caps_print (&i915->caps, &p);kernel_param_lock (THIS_MODULE );
@@ -293,7 +293,7 @@ static int i915_gpu_info_open(struct inode *inode, struct file *file) gpu =NULL ;with_intel_runtime_pm (&i915->runtime_pm, wakeref) - gpu = i915_gpu_coredump(&i915->gt, ALL_ENGINES); + gpu = i915_gpu_coredump(to_gt(i915), ALL_ENGINES);if (IS_ERR (gpu))return PTR_ERR (gpu);
@@ -351,7 +351,7 @@ static const struct file_operations i915_error_state_fops = {static int i915_frequency_info (struct seq_file *m,void *unused) {struct drm_i915_private *i915 =node_to_i915 (m->private); -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);struct drm_printer p =drm_seq_file_printer (m);intel_gt_pm_frequency_dump (gt, &p);
@@ -439,11 +439,11 @@ static int i915_swizzle_info(struct seq_file *m, void *data)static int i915_rps_boost_info (struct seq_file *m,void *data) {struct drm_i915_private *dev_priv =node_to_i915 (m->private); -struct intel_rps *rps = &dev_priv->gt.rps; +struct intel_rps *rps = &to_gt (dev_priv)->rps;seq_printf (m,"RPS enabled? %s\n" ,yesno (intel_rps_is_enabled (rps)));seq_printf (m,"RPS active? %s\n" ,yesno (intel_rps_is_active (rps))); -seq_printf (m,"GPU busy? %s\n" ,yesno (dev_priv->gt.awake)); +seq_printf (m,"GPU busy? %s\n" ,yesno (to_gt (dev_priv)->awake));seq_printf (m,"Boosts outstanding? %d\n" ,atomic_read (&rps->num_waiters));seq_printf (m,"Interactive? %d\n" ,READ_ONCE (rps->power.interactive));
@@ -476,7 +476,7 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused)seq_printf (m,"Runtime power status: %s\n" ,enableddisabled (!dev_priv->power_domains.init_wakeref)); -seq_printf (m,"GPU idle: %s\n" ,yesno (!dev_priv->gt.awake)); +seq_printf (m,"GPU idle: %s\n" ,yesno (!to_gt (dev_priv)->awake));seq_printf (m,"IRQs disabled: %s\n" ,yesno (!intel_irqs_enabled (dev_priv)));#ifdef CONFIG_PM
@@ -508,18 +508,18 @@ static int i915_engine_info(struct seq_file *m, void *unused) wakeref =intel_runtime_pm_get (&i915->runtime_pm);seq_printf (m,"GT awake? %s [%d], %llums\n" , -yesno (i915->gt.awake), -atomic_read (&i915->gt.wakeref.count), -ktime_to_ms (intel_gt_get_awake_time (&i915->gt))); +yesno (to_gt (i915)->awake), +atomic_read (&to_gt (i915)->wakeref.count), +ktime_to_ms (intel_gt_get_awake_time (to_gt (i915))));seq_printf (m,"CS timestamp frequency: %u Hz, %d ns\n" , - i915->gt.clock_frequency, - i915->gt.clock_period_ns); +to_gt (i915)->clock_frequency, +to_gt (i915)->clock_period_ns); p =drm_seq_file_printer (m);for_each_uabi_engine (engine, i915)intel_engine_dump (engine, &p,"%s\n" , engine->name); -intel_gt_show_timelines (&i915->gt, &p, i915_request_show_with_schedule); +intel_gt_show_timelines (to_gt (i915), &p, i915_request_show_with_schedule);intel_runtime_pm_put (&i915->runtime_pm, wakeref);
@@ -558,14 +558,14 @@ static int i915_wedged_get(void *data, u64 *val) {struct drm_i915_private *i915 = data; -return intel_gt_debugfs_reset_show (&i915->gt, val); +return intel_gt_debugfs_reset_show (to_gt (i915), val); }static int i915_wedged_set (void *data,u64 val) {struct drm_i915_private *i915 = data; -return intel_gt_debugfs_reset_store (&i915->gt, val); +return intel_gt_debugfs_reset_store (to_gt (i915), val); } DEFINE_SIMPLE_ATTRIBUTE(i915_wedged_fops,
@@ -581,7 +581,7 @@ i915_perf_noa_delay_set(void *data, u64 val)* This would lead to infinite waits as we're doing timestamp * difference on the CS with only 32bits. */ -if (intel_gt_ns_to_clock_interval (&i915->gt, val) >U32_MAX ) +if (intel_gt_ns_to_clock_interval (to_gt (i915), val) >U32_MAX )return -EINVAL ;atomic64_set (&i915->perf.noa_programming_delay, val);
@@ -671,7 +671,7 @@ i915_drop_caches_set(void *data, u64 val)DRM_DEBUG ("Dropping caches: 0x%08llx [0x%08llx]\n" , val, val &DROP_ALL ); - ret =gt_drop_caches (&i915->gt, val); + ret =gt_drop_caches (to_gt (i915), val);if (ret)return ret;
@@ -702,7 +702,7 @@ DEFINE_SIMPLE_ATTRIBUTE(i915_drop_caches_fops,static int i915_sseu_status (struct seq_file *m,void *unused) {struct drm_i915_private *i915 =node_to_i915 (m->private); -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);return intel_sseu_status (m, gt); }
@@ -711,14 +711,14 @@ static int i915_forcewake_open(struct inode *inode, struct file *file) {struct drm_i915_private *i915 = inode->i_private; -return intel_gt_pm_debugfs_forcewake_user_open (&i915->gt); +return intel_gt_pm_debugfs_forcewake_user_open (to_gt (i915)); }static int i915_forcewake_release (struct inode *inode,struct file *file) {struct drm_i915_private *i915 = inode->i_private; -return intel_gt_pm_debugfs_forcewake_user_release (&i915->gt); +return intel_gt_pm_debugfs_forcewake_user_release (to_gt (i915)); }static const struct file_operations i915_forcewake_fops = {
drivers/gpu/drm/i915/i915_debugfs_params.c +2 -2
@@ -40,8 +40,8 @@ static int notify_guc(struct drm_i915_private *i915) {int ret =0 ; -if (intel_uc_uses_guc_submission (&i915->gt.uc)) - ret =intel_guc_global_policies_update (&i915->gt.uc.guc); +if (intel_uc_uses_guc_submission (&to_gt (i915)->uc)) + ret =intel_guc_global_policies_update (&to_gt (i915)->uc.guc);return ret; }
drivers/gpu/drm/i915/i915_driver.c +16 -16
@@ -291,7 +291,7 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)static void sanitize_gpu (struct drm_i915_private *i915) {if (!INTEL_INFO (i915)->gpu_reset_clobbers_display) -__intel_gt_reset (&i915->gt,ALL_ENGINES ); +__intel_gt_reset (to_gt (i915),ALL_ENGINES ); }/**
@@ -314,9 +314,9 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)intel_device_info_subplatform_init (dev_priv);intel_step_init (dev_priv); -intel_gt_init_early (&dev_priv->gt, dev_priv); +intel_gt_init_early (to_gt (dev_priv), dev_priv);intel_uncore_mmio_debug_init_early (&dev_priv->mmio_debug); -intel_uncore_init_early (&dev_priv->uncore, &dev_priv->gt); +intel_uncore_init_early (&dev_priv->uncore,to_gt (dev_priv));spin_lock_init (&dev_priv->irq_lock);spin_lock_init (&dev_priv->gpu_error.lock);
@@ -347,7 +347,7 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)intel_wopcm_init_early (&dev_priv->wopcm); -__intel_gt_init_early (&dev_priv->gt, dev_priv); +__intel_gt_init_early (to_gt (dev_priv), dev_priv);i915_gem_init_early (dev_priv);
@@ -368,7 +368,7 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv) err_gem:i915_gem_cleanup_early (dev_priv); -intel_gt_driver_late_release (&dev_priv->gt); +intel_gt_driver_late_release (to_gt (dev_priv));intel_region_ttm_device_fini (dev_priv); err_ttm:vlv_suspend_cleanup (dev_priv);
@@ -387,7 +387,7 @@ static void i915_driver_late_release(struct drm_i915_private *dev_priv)intel_irq_fini (dev_priv);intel_power_domains_cleanup (dev_priv);i915_gem_cleanup_early (dev_priv); -intel_gt_driver_late_release (&dev_priv->gt); +intel_gt_driver_late_release (to_gt (dev_priv));intel_region_ttm_device_fini (dev_priv);vlv_suspend_cleanup (dev_priv);i915_workqueues_cleanup (dev_priv);
@@ -430,7 +430,7 @@ static int i915_driver_mmio_probe(struct drm_i915_private *dev_priv)intel_setup_mchbar (dev_priv);intel_device_info_runtime_init (dev_priv); - ret =intel_gt_init_mmio (&dev_priv->gt); + ret =intel_gt_init_mmio (to_gt (dev_priv));if (ret) goto err_uncore;
@@ -587,9 +587,9 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)if (ret) goto err_ggtt; -intel_gt_init_hw_early (&dev_priv->gt, &dev_priv->ggtt); +intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); - ret =intel_gt_probe_lmem (&dev_priv->gt); + ret =intel_gt_probe_lmem (to_gt (dev_priv));if (ret) goto err_mem_regions;
@@ -702,7 +702,7 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)/* Depends on sysfs having been initialized */ i915_perf_register (dev_priv); -intel_gt_driver_register (&dev_priv->gt); +intel_gt_driver_register (to_gt (dev_priv));intel_display_driver_register (dev_priv);
@@ -730,7 +730,7 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)intel_display_driver_unregister (dev_priv); -intel_gt_driver_unregister (&dev_priv->gt); +intel_gt_driver_unregister (to_gt (dev_priv));i915_perf_unregister (dev_priv);i915_pmu_unregister (dev_priv);
@@ -763,7 +763,7 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv)intel_device_info_print_static (INTEL_INFO (dev_priv), &p);intel_device_info_print_runtime (RUNTIME_INFO (dev_priv), &p);i915_print_iommu_status (dev_priv, &p); -intel_gt_info_print (&dev_priv->gt.info, &p); +intel_gt_info_print (&to_gt (dev_priv)->info, &p); }if (IS_ENABLED (CONFIG_DRM_I915_DEBUG ))
@@ -1385,7 +1385,7 @@ static int i915_drm_resume_early(struct drm_device *dev)intel_uncore_resume_early (&dev_priv->uncore); -intel_gt_check_and_clear_faults (&dev_priv->gt); +intel_gt_check_and_clear_faults (to_gt (dev_priv));intel_display_power_resume_early (dev_priv);
@@ -1568,7 +1568,7 @@ static int intel_runtime_suspend(struct device *kdev)*/ i915_gem_runtime_suspend (dev_priv); -intel_gt_runtime_suspend (&dev_priv->gt); +intel_gt_runtime_suspend (to_gt (dev_priv));intel_runtime_pm_disable_interrupts (dev_priv);
@@ -1584,7 +1584,7 @@ static int intel_runtime_suspend(struct device *kdev)intel_runtime_pm_enable_interrupts (dev_priv); -intel_gt_runtime_resume (&dev_priv->gt); +intel_gt_runtime_resume (to_gt (dev_priv));enable_rpm_wakeref_asserts (rpm);
@@ -1672,7 +1672,7 @@ static int intel_runtime_resume(struct device *kdev)* No point of rolling back things in case of an error, as the best * we can do is to hope that things will still work (and disable RPM). */ -intel_gt_runtime_resume (&dev_priv->gt); +intel_gt_runtime_resume (to_gt (dev_priv));/* * On VLV/CHV display interrupts are part of the display
drivers/gpu/drm/i915/i915_drv.h +1 -1
@@ -1553,7 +1553,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_PXP (dev_priv) ((IS_ENABLED(CONFIG_DRM_I915_PXP) && \ INTEL_INFO(dev_priv)->has_pxp) && \ - VDBOX_MASK(&dev_priv->gt)) + VDBOX_MASK(to_gt(dev_priv)))#define HAS_GMCH (dev_priv) (INTEL_INFO(dev_priv)->display.has_gmch)
drivers/gpu/drm/i915/i915_gem.c +8 -8
@@ -1049,7 +1049,7 @@ int i915_gem_init(struct drm_i915_private *dev_priv)if (ret)return ret; -intel_uc_fetch_firmwares (&dev_priv->gt.uc); +intel_uc_fetch_firmwares (&to_gt (dev_priv)->uc);intel_wopcm_init (&dev_priv->wopcm); ret =i915_init_ggtt (dev_priv);
@@ -1069,7 +1069,7 @@ int i915_gem_init(struct drm_i915_private *dev_priv)*/ intel_init_clock_gating (dev_priv); - ret =intel_gt_init (&dev_priv->gt); + ret =intel_gt_init (to_gt (dev_priv));if (ret) goto err_unlock;
@@ -1085,7 +1085,7 @@ int i915_gem_init(struct drm_i915_private *dev_priv)i915_gem_drain_workqueue (dev_priv);if (ret != -EIO ) -intel_uc_cleanup_firmwares (&dev_priv->gt.uc); +intel_uc_cleanup_firmwares (&to_gt (dev_priv)->uc);if (ret == -EIO ) {/*
@@ -1093,10 +1093,10 @@ int i915_gem_init(struct drm_i915_private *dev_priv)* as wedged. But we only want to do this when the GPU is angry, * for all other failure, such as an allocation failure, bail. */ -if (!intel_gt_is_wedged (&dev_priv->gt)) { +if (!intel_gt_is_wedged (to_gt (dev_priv))) {i915_probe_error (dev_priv,"Failed to initialize GPU, declaring it wedged!\n" ); -intel_gt_set_wedged (&dev_priv->gt); +intel_gt_set_wedged (to_gt (dev_priv)); }/* Minimal basic recovery for KMS */
@@ -1127,7 +1127,7 @@ void i915_gem_driver_remove(struct drm_i915_private *dev_priv)intel_wakeref_auto_fini (&dev_priv->ggtt.userfault_wakeref);i915_gem_suspend_late (dev_priv); -intel_gt_driver_remove (&dev_priv->gt); +intel_gt_driver_remove (to_gt (dev_priv)); dev_priv->uabi_engines =RB_ROOT ;/* Flush any outstanding unpin_work. */
@@ -1138,9 +1138,9 @@ void i915_gem_driver_remove(struct drm_i915_private *dev_priv)void i915_gem_driver_release (struct drm_i915_private *dev_priv) { -intel_gt_driver_release (&dev_priv->gt); +intel_gt_driver_release (to_gt (dev_priv)); -intel_uc_cleanup_firmwares (&dev_priv->gt.uc); +intel_uc_cleanup_firmwares (&to_gt (dev_priv)->uc);i915_gem_drain_freed_objects (dev_priv);
drivers/gpu/drm/i915/i915_getparam.c +5 -5
@@ -13,7 +13,7 @@ int i915_getparam_ioctl(struct drm_device *dev, void *data, {struct drm_i915_private *i915 =to_i915 (dev);struct pci_dev *pdev =to_pci_dev (dev->dev); -const struct sseu_dev_info *sseu = &i915->gt.info.sseu; +const struct sseu_dev_info *sseu = &to_gt (i915)->info.sseu;drm_i915_getparam_t *param = data;int value =0 ;
@@ -82,8 +82,8 @@ int i915_getparam_ioctl(struct drm_device *dev, void *data,break ;case I915_PARAM_HAS_GPU_RESET : value = i915->params.enable_hangcheck && -intel_has_gpu_reset (&i915->gt); -if (value &&intel_has_reset_engine (&i915->gt)) +intel_has_gpu_reset (to_gt (i915)); +if (value &&intel_has_reset_engine (to_gt (i915))) value =2 ;break ;case I915_PARAM_HAS_RESOURCE_STREAMER :
@@ -96,7 +96,7 @@ int i915_getparam_ioctl(struct drm_device *dev, void *data, value = sseu->min_eu_in_pool;break ;case I915_PARAM_HUC_STATUS : - value =intel_huc_check_status (&i915->gt.uc.huc); + value =intel_huc_check_status (&to_gt (i915)->uc.huc);if (value <0 )return value;break ;
@@ -158,7 +158,7 @@ int i915_getparam_ioctl(struct drm_device *dev, void *data,return -ENODEV ;break ;case I915_PARAM_CS_TIMESTAMP_FREQUENCY : - value = i915->gt.clock_frequency; + value =to_gt (i915)->clock_frequency;break ;case I915_PARAM_MMAP_GTT_COHERENT : value =INTEL_INFO (i915)->has_coherent_ggtt;
drivers/gpu/drm/i915/i915_gpu_error.c +2 -2
@@ -505,7 +505,7 @@ static void error_print_context(struct drm_i915_error_state_buf *m,const char *header, const struct i915_gem_context_coredump *ctx) { - const u32 period = m->i915->gt.clock_period_ns; + const u32 period = to_gt(m->i915)->clock_period_ns; err_printf(m, "%s%s[%d] prio %d, guilty %d active %d, runtime total %lluns, avg %lluns\n", header, ctx->comm, ctx->pid, ctx->sched_attr.priority,
@@ -1846,7 +1846,7 @@ i915_gpu_coredump_alloc(struct drm_i915_private *i915, gfp_t gfp) error->time =ktime_get_real (); error->boottime =ktime_get_boottime (); - error->uptime =ktime_sub (ktime_get (), i915->gt.last_init_time); + error->uptime =ktime_sub (ktime_get (),to_gt (i915)->last_init_time); error->capture = jiffies;capture_gen (error);
drivers/gpu/drm/i915/i915_irq.c +28 -28
211 lines not on this page · raw message
drivers/gpu/drm/i915/i915_perf.c +1 -1
@@ -4443,7 +4443,7 @@ void i915_perf_init(struct drm_i915_private *i915)mutex_init (&perf->lock);/* Choose a representative limit */ - oa_sample_rate_hard_limit = i915->gt.clock_frequency /2 ; + oa_sample_rate_hard_limit =to_gt (i915)->clock_frequency /2 ;mutex_init (&perf->metrics_lock);idr_init_base (&perf->metrics_idr,1 );
drivers/gpu/drm/i915/i915_pmu.c +7 -7
@@ -210,8 +210,8 @@ static void init_rc6(struct i915_pmu *pmu)struct drm_i915_private *i915 =container_of (pmu,typeof (*i915), pmu);intel_wakeref_t wakeref; - with_intel_runtime_pm(i915->gt.uncore->rpm, wakeref) { - pmu->sample[__I915_SAMPLE_RC6].cur =__get_rc6 (&i915->gt); + with_intel_runtime_pm(to_gt(i915)->uncore->rpm, wakeref) { + pmu->sample[__I915_SAMPLE_RC6].cur =__get_rc6 (to_gt (i915)); pmu->sample[__I915_SAMPLE_RC6_LAST_REPORTED].cur = pmu->sample[__I915_SAMPLE_RC6].cur; pmu->sleep_last =ktime_get_raw ();
@@ -222,7 +222,7 @@ static void park_rc6(struct drm_i915_private *i915) {struct i915_pmu *pmu = &i915->pmu; - pmu->sample[__I915_SAMPLE_RC6].cur =__get_rc6 (&i915->gt); + pmu->sample[__I915_SAMPLE_RC6].cur =__get_rc6 (to_gt (i915)); pmu->sleep_last =ktime_get_raw (); }
@@ -419,7 +419,7 @@ static enum hrtimer_restart i915_sample(struct hrtimer *hrtimer)struct drm_i915_private *i915 = container_of(hrtimer, struct drm_i915_private, pmu.timer);struct i915_pmu *pmu = &i915->pmu; -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);unsigned int period_ns;ktime_t now;
@@ -476,7 +476,7 @@ engine_event_status(struct intel_engine_cs *engine,static int config_status (struct drm_i915_private *i915,u64 config) { -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);switch (config) {case I915_PMU_ACTUAL_FREQUENCY :
@@ -601,10 +601,10 @@ static u64 __i915_pmu_event_read(struct perf_event *event) val =READ_ONCE (pmu->irq_count);break ;case I915_PMU_RC6_RESIDENCY : - val =get_rc6 (&i915->gt); + val =get_rc6 (to_gt (i915));break ;case I915_PMU_SOFTWARE_GT_AWAKE_TIME : - val =ktime_to_ns (intel_gt_get_awake_time (&i915->gt)); + val =ktime_to_ns (intel_gt_get_awake_time (to_gt (i915)));break ; } }
drivers/gpu/drm/i915/i915_query.c +1 -1
@@ -31,7 +31,7 @@ static int copy_query_item(void *query_hdr, size_t query_sz,static int query_topology_info (struct drm_i915_private *dev_priv,struct drm_i915_query_item *query_item) { -const struct sseu_dev_info *sseu = &dev_priv->gt.info.sseu; +const struct sseu_dev_info *sseu = &to_gt (dev_priv)->info.sseu;struct drm_i915_query_topology_info topo;u32 slice_length, subslice_length, eu_length, total_length;int ret;
drivers/gpu/drm/i915/i915_sysfs.c +11 -11
@@ -52,7 +52,7 @@ static u32 calc_residency(struct drm_i915_private *dev_priv,u64 res =0 ;with_intel_runtime_pm (&dev_priv->runtime_pm, wakeref) - res = intel_rc6_residency_us(&dev_priv->gt.rc6, reg); + res = intel_rc6_residency_us(&to_gt(dev_priv)->rc6, reg);return DIV_ROUND_CLOSEST_ULL (res,1000 ); }
@@ -260,7 +260,7 @@ static ssize_t gt_act_freq_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf) { struct drm_i915_private *i915 = kdev_minor_to_i915(kdev); -struct intel_rps *rps = &i915->gt.rps; +struct intel_rps *rps = &to_gt (i915)->rps;return sysfs_emit (buf,"%d\n" ,intel_rps_read_actual_frequency (rps)); }
@@ -269,7 +269,7 @@ static ssize_t gt_cur_freq_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf) { struct drm_i915_private *i915 = kdev_minor_to_i915(kdev); -struct intel_rps *rps = &i915->gt.rps; +struct intel_rps *rps = &to_gt (i915)->rps;return sysfs_emit (buf,"%d\n" ,intel_rps_get_requested_frequency (rps)); }
@@ -277,7 +277,7 @@ static ssize_t gt_cur_freq_mhz_show(struct device *kdev,static ssize_t gt_boost_freq_mhz_show (struct device *kdev,struct device_attribute *attr,char *buf) {struct drm_i915_private *i915 =kdev_minor_to_i915 (kdev); -struct intel_rps *rps = &i915->gt.rps; +struct intel_rps *rps = &to_gt (i915)->rps;return sysfs_emit (buf,"%d\n" ,intel_rps_get_boost_frequency (rps)); }
@@ -287,7 +287,7 @@ static ssize_t gt_boost_freq_mhz_store(struct device *kdev, const char *buf, size_t count) {struct drm_i915_private *dev_priv =kdev_minor_to_i915 (kdev); -struct intel_rps *rps = &dev_priv->gt.rps; +struct intel_rps *rps = &to_gt (dev_priv)->rps;ssize_t ret;u32 val;
@@ -304,7 +304,7 @@ static ssize_t vlv_rpe_freq_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf) { struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev); -struct intel_rps *rps = &dev_priv->gt.rps; +struct intel_rps *rps = &to_gt (dev_priv)->rps;return sysfs_emit (buf,"%d\n" ,intel_gpu_freq (rps, rps->efficient_freq)); }
@@ -312,7 +312,7 @@ static ssize_t vlv_rpe_freq_mhz_show(struct device *kdev,static ssize_t gt_max_freq_mhz_show (struct device *kdev,struct device_attribute *attr,char *buf) {struct drm_i915_private *dev_priv =kdev_minor_to_i915 (kdev); -struct intel_gt *gt = &dev_priv->gt; +struct intel_gt *gt =to_gt (dev_priv);struct intel_rps *rps = >->rps;return sysfs_emit (buf,"%d\n" ,intel_rps_get_max_frequency (rps));
@@ -323,7 +323,7 @@ static ssize_t gt_max_freq_mhz_store(struct device *kdev, const char *buf, size_t count) {struct drm_i915_private *dev_priv =kdev_minor_to_i915 (kdev); -struct intel_gt *gt = &dev_priv->gt; +struct intel_gt *gt =to_gt (dev_priv);struct intel_rps *rps = >->rps;ssize_t ret;u32 val;
@@ -340,7 +340,7 @@ static ssize_t gt_max_freq_mhz_store(struct device *kdev,static ssize_t gt_min_freq_mhz_show (struct device *kdev,struct device_attribute *attr,char *buf) {struct drm_i915_private *i915 =kdev_minor_to_i915 (kdev); -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);struct intel_rps *rps = >->rps;return sysfs_emit (buf,"%d\n" ,intel_rps_get_min_frequency (rps));
@@ -351,7 +351,7 @@ static ssize_t gt_min_freq_mhz_store(struct device *kdev, const char *buf, size_t count) {struct drm_i915_private *i915 =kdev_minor_to_i915 (kdev); -struct intel_rps *rps = &i915->gt.rps; +struct intel_rps *rps = &to_gt (i915)->rps;ssize_t ret;u32 val;
@@ -381,7 +381,7 @@ static DEVICE_ATTR(gt_RPn_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL);static ssize_t gt_rp_mhz_show (struct device *kdev,struct device_attribute *attr,char *buf) {struct drm_i915_private *dev_priv =kdev_minor_to_i915 (kdev); -struct intel_rps *rps = &dev_priv->gt.rps; +struct intel_rps *rps = &to_gt (dev_priv)->rps;u32 val;if (attr == &dev_attr_gt_RP0_freq_mhz)
drivers/gpu/drm/i915/intel_gvt.c +1 -1
@@ -109,7 +109,7 @@ int intel_gvt_init(struct drm_i915_private *dev_priv)return 0 ; } -if (intel_uc_wants_guc_submission (&dev_priv->gt.uc)) { +if (intel_uc_wants_guc_submission (&to_gt (dev_priv)->uc)) {drm_err (&dev_priv->drm,"i915 GVT-g loading failed due to Graphics virtualization is not yet supported with GuC submission\n" );return -EIO ;
drivers/gpu/drm/i915/intel_wopcm.c +1 -1
@@ -220,7 +220,7 @@ static bool __wopcm_regs_locked(struct intel_uncore *uncore,void intel_wopcm_init (struct intel_wopcm *wopcm) {struct drm_i915_private *i915 =wopcm_to_i915 (wopcm); -struct intel_gt *gt = &i915->gt; +struct intel_gt *gt =to_gt (i915);u32 guc_fw_size =intel_uc_fw_get_upload_size (>->uc.guc.fw);u32 huc_fw_size =intel_uc_fw_get_upload_size (>->uc.huc.fw);u32 ctx_rsvd =context_reserved_size (i915);
Signature · 1 line
2.34.1
PATCH v8 10/16 drm/i915: Rename i915->gt to i915->gt0
In reply to Andi ShytiIn preparation of the multitile support, highlight the root GT by calling it gt0 inside the drm i915 private data.
--- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -2
@@ -1005,7 +1005,7 @@ struct drm_i915_private {struct i915_perf perf;/* Abstract the submission mechanism (legacy ringbuffer or execlists) away */ -struct intel_gt gt; +struct intel_gt gt0; struct { struct i915_gem_contexts {
@@ -1079,7 +1079,7 @@ static inline struct drm_i915_private *pdev_to_i915(struct pci_dev *pdev)static inline struct intel_gt *to_gt (struct drm_i915_private *i915) { -return &i915->gt; +return &i915->gt0; }/* Simple iterator over all initialised engines */
Signature · 1 line
2.34.1
PATCH v8 11/16 drm/i915/gem: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one.
Use to_gt() for all i915->ggtt accesses to help with the future refactoring.
--- drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 19 ++++++++++--------- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 6 +++--- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 8 +++++--- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 15 ++++++++------- .../i915/gem/selftests/i915_gem_client_blt.c | 2 +- .../drm/i915/gem/selftests/i915_gem_context.c | 2 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 19 ++++++++++--------- .../drm/i915/gem/selftests/i915_gem_object.c | 2 +- 11 files changed, 42 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_context.h +1 -1
@@ -174,7 +174,7 @@ i915_gem_context_get_eb_vm(struct i915_gem_context *ctx) vm = ctx->vm;if (!vm) - vm = &ctx->i915->ggtt.vm; + vm = &to_gt (ctx->i915)->ggtt->vm; vm =i915_vm_get (vm);return vm;
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +1 -1
@@ -1106,7 +1106,7 @@ static inline struct i915_ggtt *cache_to_ggtt(struct reloc_cache *cache) {struct drm_i915_private *i915 = container_of(cache, struct i915_execbuffer, reloc_cache)->i915; -return &i915->ggtt; +return to_gt (i915)->ggtt; }static void reloc_cache_reset (struct reloc_cache *cache,struct i915_execbuffer *eb)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +10 -9
@@ -295,7 +295,7 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)struct drm_device *dev = obj->base.dev;struct drm_i915_private *i915 =to_i915 (dev);struct intel_runtime_pm *rpm = &i915->runtime_pm; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;bool write = area->vm_flags &VM_WRITE ;struct i915_gem_ww_ctx ww;intel_wakeref_t wakeref;
@@ -388,16 +388,16 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)assert_rpm_wakelock_held (rpm);/* Mark as being mmapped into userspace for later revocation */ -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);if (!i915_vma_set_userfault (vma) && !obj->userfault_count++) -list_add (&obj->userfault_link, &i915->ggtt.userfault_list); -mutex_unlock (&i915->ggtt.vm.mutex); +list_add (&obj->userfault_link, &to_gt (i915)->ggtt->userfault_list); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex);/* Track the mmo associated with the fenced vma */ vma->mmo = mmo;if (CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND ) -intel_wakeref_auto (&i915->ggtt.userfault_wakeref, +intel_wakeref_auto (&to_gt (i915)->ggtt->userfault_wakeref,msecs_to_jiffies_timeout (CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND ));if (write) {
@@ -512,7 +512,7 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)* wakeref. */ wakeref =intel_runtime_pm_get (&i915->runtime_pm); -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);if (!obj->userfault_count) goto out;
@@ -530,7 +530,7 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)wmb (); out: -mutex_unlock (&i915->ggtt.vm.mutex); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex);intel_runtime_pm_put (&i915->runtime_pm, wakeref); }
@@ -733,13 +733,14 @@ i915_gem_dumb_mmap_offset(struct drm_file *file,u32 handle, u64 *offset) { + struct drm_i915_private *i915 = to_i915(dev);enum i915_mmap_type mmap_type;if (HAS_LMEM (to_i915 (dev))) mmap_type =I915_MMAP_TYPE_FIXED ;else if (boot_cpu_has (X86_FEATURE_PAT )) mmap_type =I915_MMAP_TYPE_WC ; -else if (!i915_ggtt_has_aperture (&to_i915 (dev)->ggtt)) +else if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return -ENODEV ;else mmap_type =I915_MMAP_TYPE_GTT ;
@@ -787,7 +788,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data,switch (args->flags) {case I915_MMAP_OFFSET_GTT : -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return -ENODEV ; type =I915_MMAP_TYPE_GTT ;break ;
drivers/gpu/drm/i915/gem/i915_gem_pm.c +1 -1
@@ -23,7 +23,7 @@ void i915_gem_suspend(struct drm_i915_private *i915) {GEM_TRACE ("%s\n" ,dev_name (i915->drm.dev)); -intel_wakeref_auto (&i915->ggtt.userfault_wakeref,0 ); +intel_wakeref_auto (&to_gt (i915)->ggtt->userfault_wakeref,0 );flush_workqueue (i915->wq);/*
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +3 -3
@@ -403,9 +403,9 @@ i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr I915_SHRINK_VMAPS);/* We also want to clear any cached iomaps as they wrap vmap */ -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);list_for_each_entry_safe (vma, next, - &i915->ggtt.vm.bound_list, vm_link) { + &to_gt (i915)->ggtt->vm.bound_list, vm_link) {unsigned long count = vma->node.size >>PAGE_SHIFT ;if (!vma->iomap ||i915_vma_is_active (vma))
@@ -414,7 +414,7 @@ i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptrif (__i915_vma_unbind (vma) ==0 ) freed_pages += count; } -mutex_unlock (&i915->ggtt.vm.mutex); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex); *(unsigned long *)ptr += freed_pages;return NOTIFY_DONE ;
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +5 -3
@@ -71,7 +71,7 @@ void i915_gem_stolen_remove_node(struct drm_i915_private *i915,static int i915_adjust_stolen (struct drm_i915_private *i915,struct resource *dsm) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct intel_uncore *uncore = ggtt->vm.gt->uncore;struct resource *r;
@@ -579,6 +579,7 @@ i915_pages_create_for_stolen(struct drm_device *dev,static int i915_gem_object_get_pages_stolen (struct drm_i915_gem_object *obj) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);struct sg_table *pages = i915_pages_create_for_stolen(obj->base.dev, obj->stolen->start,
@@ -586,7 +587,7 @@ static int i915_gem_object_get_pages_stolen(struct drm_i915_gem_object *obj)if (IS_ERR (pages))return PTR_ERR (pages); -dbg_poison (&to_i915 (obj->base.dev)->ggtt, +dbg_poison (to_gt (i915)->ggtt,sg_dma_address (pages->sgl),sg_dma_len (pages->sgl),POISON_INUSE );
@@ -599,9 +600,10 @@ static int i915_gem_object_get_pages_stolen(struct drm_i915_gem_object *obj)static void i915_gem_object_put_pages_stolen (struct drm_i915_gem_object *obj,struct sg_table *pages) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);/* Should only be called from i915_gem_object_release_stolen() */ -dbg_poison (&to_i915 (obj->base.dev)->ggtt, +dbg_poison (to_gt (i915)->ggtt,sg_dma_address (pages->sgl),sg_dma_len (pages->sgl),POISON_FREE );
drivers/gpu/drm/i915/gem/i915_gem_tiling.c +8 -7
@@ -181,7 +181,8 @@ static int i915_gem_object_fence_prepare(struct drm_i915_gem_object *obj, int tiling_mode, unsigned int stride) { - struct i915_ggtt *ggtt = &to_i915(obj->base.dev)->ggtt; + struct drm_i915_private *i915 = to_i915(obj->base.dev); +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct i915_vma *vma, *vn;LIST_HEAD (unbind);int ret =0 ;
@@ -336,7 +337,7 @@ i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,struct drm_i915_gem_object *obj;int err; -if (!dev_priv->ggtt.num_fences) +if (!to_gt (dev_priv)->ggtt->num_fences)return -EOPNOTSUPP ; obj =i915_gem_object_lookup (file, args->handle);
@@ -362,9 +363,9 @@ i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data, args->stride =0 ; }else {if (args->tiling_mode ==I915_TILING_X ) - args->swizzle_mode =to_i915 (dev)->ggtt.bit_6_swizzle_x; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_x;else - args->swizzle_mode =to_i915 (dev)->ggtt.bit_6_swizzle_y; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_y;/* Hide bit 17 swizzling from the user. This prevents old Mesa * from aborting the application on sw fallbacks to bit 17,
@@ -419,7 +420,7 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,struct drm_i915_gem_object *obj;int err = -ENOENT ; -if (!dev_priv->ggtt.num_fences) +if (!to_gt (dev_priv)->ggtt->num_fences)return -EOPNOTSUPP ;rcu_read_lock ();
@@ -435,10 +436,10 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,switch (args->tiling_mode) {case I915_TILING_X : - args->swizzle_mode = dev_priv->ggtt.bit_6_swizzle_x; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_x;break ;case I915_TILING_Y : - args->swizzle_mode = dev_priv->ggtt.bit_6_swizzle_y; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_y;break ;default :case I915_TILING_NONE :
drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c +1 -1
@@ -543,7 +543,7 @@ static bool has_bit17_swizzle(int sw)static bool bad_swizzling (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;if (i915->quirks &QUIRK_PIN_SWIZZLED_PAGES )return true;
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +1 -1
@@ -1374,7 +1374,7 @@ static int igt_ctx_readonly(void *arg) goto out_file; } - vm = ctx->vm ?: &i915->ggtt.alias->vm; + vm = ctx->vm ?: &to_gt (i915)->ggtt->alias->vm;if (!vm || !vm->has_read_only) { err =0 ; goto out_file;
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +10 -9
@@ -307,7 +307,7 @@ static int igt_partial_tiling(void *arg)int tiling;int err; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ;/* We want to check the page mapping and fencing of a large object
@@ -320,7 +320,7 @@ static int igt_partial_tiling(void *arg) obj =huge_gem_object (i915, nreal <<PAGE_SHIFT , - (1 +next_prime_number (i915->ggtt.vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT ); + (1 +next_prime_number (to_gt (i915)->ggtt->vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT );if (IS_ERR (obj))return PTR_ERR (obj);
@@ -366,10 +366,10 @@ static int igt_partial_tiling(void *arg) tile.tiling = tiling;switch (tiling) {case I915_TILING_X : - tile.swizzle = i915->ggtt.bit_6_swizzle_x; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_x;break ;case I915_TILING_Y : - tile.swizzle = i915->ggtt.bit_6_swizzle_y; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_y;break ; }
@@ -440,7 +440,7 @@ static int igt_smoke_tiling(void *arg)IGT_TIMEOUT (end);int err; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ;/*
@@ -457,7 +457,7 @@ static int igt_smoke_tiling(void *arg) obj =huge_gem_object (i915, nreal <<PAGE_SHIFT , - (1 +next_prime_number (i915->ggtt.vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT ); + (1 +next_prime_number (to_gt (i915)->ggtt->vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT );if (IS_ERR (obj))return PTR_ERR (obj);
@@ -486,10 +486,10 @@ static int igt_smoke_tiling(void *arg)break ;case I915_TILING_X : - tile.swizzle = i915->ggtt.bit_6_swizzle_x; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_x;break ;case I915_TILING_Y : - tile.swizzle = i915->ggtt.bit_6_swizzle_y; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_y;break ; }
@@ -856,6 +856,7 @@ static int wc_check(struct drm_i915_gem_object *obj)static bool can_mmap (struct drm_i915_gem_object *obj,enum i915_mmap_type type) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);bool no_map;if (obj->ops->mmap_offset)
@@ -864,7 +865,7 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)return false;if (type ==I915_MMAP_TYPE_GTT && - !i915_ggtt_has_aperture (&to_i915 (obj->base.dev)->ggtt)) + !i915_ggtt_has_aperture (to_gt (i915)->ggtt))return false;i915_gem_object_lock (obj,NULL );
drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c +1 -1
@@ -43,7 +43,7 @@ static int igt_gem_huge(void *arg) obj =huge_gem_object (i915, nreal *PAGE_SIZE , - i915->ggtt.vm.total +PAGE_SIZE ); +to_gt (i915)->ggtt->vm.total +PAGE_SIZE );if (IS_ERR (obj))return PTR_ERR (obj);
Signature · 1 line
2.34.1
RE: [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT accesses
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Andi Shyti
Sent: Tuesday, December 14, 2021 11:34 AM
To: Intel GFX <[email protected]>; DRI Devel <[email protected]>
Cc: Winiarski, Michal <[email protected]>; Andi Shyti <[email protected]>; De Marchi, Lucas <[email protected]>; Chris Wilson <[email protected]>; Andi Shyti <[email protected]>
Subject: [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT accesses
From: Michał Winiarski <[email protected]>
GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one. Use to_gt() for all i915->ggtt accesses to help with the future refactoring.
--- drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 19 ++++++++++--------- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 6 +++--- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 8 +++++--- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 15 ++++++++------- .../i915/gem/selftests/i915_gem_client_blt.c | 2 +- .../drm/i915/gem/selftests/i915_gem_context.c | 2 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 19 ++++++++++--------- .../drm/i915/gem/selftests/i915_gem_object.c | 2 +- 11 files changed, 42 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_context.h +1 -1
@@ -174,7 +174,7 @@ i915_gem_context_get_eb_vm(struct i915_gem_context *ctx) vm = ctx->vm;if (!vm) - vm = &ctx->i915->ggtt.vm; + vm = &to_gt (ctx->i915)->ggtt->vm; vm =i915_vm_get (vm);return vm;
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +1 -1
@@ -1106,7 +1106,7 @@ static inline struct i915_ggtt *cache_to_ggtt(struct reloc_cache *cache) {struct drm_i915_private *i915 = container_of(cache, struct i915_execbuffer, reloc_cache)->i915; -return &i915->ggtt; +return to_gt (i915)->ggtt; } static void reloc_cache_reset(struct reloc_cache *cache, struct i915_execbuffer *eb) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index 1ca5c062974e..a9effb34d7ed 100644
drivers/gpu/drm/i915/gem/i915_gem_mman.c +10 -9
@@ -295,7 +295,7 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)struct drm_device *dev = obj->base.dev;struct drm_i915_private *i915 =to_i915 (dev);struct intel_runtime_pm *rpm = &i915->runtime_pm; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;bool write = area->vm_flags &VM_WRITE ;struct i915_gem_ww_ctx ww;intel_wakeref_t wakeref;
@@ -388,16 +388,16 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)assert_rpm_wakelock_held (rpm);/* Mark as being mmapped into userspace for later revocation */ -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);if (!i915_vma_set_userfault (vma) && !obj->userfault_count++) -list_add (&obj->userfault_link, &i915->ggtt.userfault_list); -mutex_unlock (&i915->ggtt.vm.mutex); +list_add (&obj->userfault_link, &to_gt (i915)->ggtt->userfault_list); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex);/* Track the mmo associated with the fenced vma */ vma->mmo = mmo;if (CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND ) -intel_wakeref_auto (&i915->ggtt.userfault_wakeref, +intel_wakeref_auto (&to_gt (i915)->ggtt->userfault_wakeref,msecs_to_jiffies_timeout (CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND ));if (write) {
@@ -512,7 +512,7 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)* wakeref. */ wakeref =intel_runtime_pm_get (&i915->runtime_pm); -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);if (!obj->userfault_count) goto out;
@@ -530,7 +530,7 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)wmb (); out: -mutex_unlock (&i915->ggtt.vm.mutex); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex);intel_runtime_pm_put (&i915->runtime_pm, wakeref); }
@@ -733,13 +733,14 @@ i915_gem_dumb_mmap_offset(struct drm_file *file,u32 handle, u64 *offset) { + struct drm_i915_private *i915 = to_i915(dev);enum i915_mmap_type mmap_type;if (HAS_LMEM (to_i915 (dev))) mmap_type =I915_MMAP_TYPE_FIXED ;else if (boot_cpu_has (X86_FEATURE_PAT )) mmap_type =I915_MMAP_TYPE_WC ; -else if (!i915_ggtt_has_aperture (&to_i915 (dev)->ggtt)) +else if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return -ENODEV ;else mmap_type =I915_MMAP_TYPE_GTT ;
@@ -787,7 +788,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data,switch (args->flags) {case I915_MMAP_OFFSET_GTT : -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return -ENODEV ; type =I915_MMAP_TYPE_GTT ;break ;
drivers/gpu/drm/i915/gem/i915_gem_pm.c +1 -1
@@ -23,7 +23,7 @@ void i915_gem_suspend(struct drm_i915_private *i915) {GEM_TRACE ("%s\n" ,dev_name (i915->drm.dev)); -intel_wakeref_auto (&i915->ggtt.userfault_wakeref,0 ); +intel_wakeref_auto (&to_gt (i915)->ggtt->userfault_wakeref,0 );flush_workqueue (i915->wq);/*
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +2 -2
@@ -403,9 +403,9 @@ i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr I915_SHRINK_VMAPS);/* We also want to clear any cached iomaps as they wrap vmap */ -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);list_for_each_entry_safe (vma, next, - &i915->ggtt.vm.bound_list, vm_link) { + &to_gt (i915)->ggtt->vm.bound_list, vm_link) {unsigned long count = vma->node.size >>PAGE_SHIFT ; if (!vma->iomap || i915_vma_is_active(vma)) @@ -414,7 +414,7 @@ i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr
if (__i915_vma_unbind(vma) == 0)
freed_pages += count;
}
- mutex_unlock(&i915->ggtt.vm.mutex);
+ mutex_unlock(&to_gt(i915)->ggtt->vm.mutex);
*(unsigned long *)ptr += freed_pages;
return NOTIFY_DONE;
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +5 -3
@@ -71,7 +71,7 @@ void i915_gem_stolen_remove_node(struct drm_i915_private *i915, static int i915_adjust_stolen(struct drm_i915_private *i915, struct resource *dsm) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct intel_uncore *uncore = ggtt->vm.gt->uncore;struct resource *r;
@@ -579,6 +579,7 @@ i915_pages_create_for_stolen(struct drm_device *dev,static int i915_gem_object_get_pages_stolen (struct drm_i915_gem_object *obj) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);struct sg_table *pages = i915_pages_create_for_stolen(obj->base.dev, obj->stolen->start,
@@ -586,7 +587,7 @@ static int i915_gem_object_get_pages_stolen(struct drm_i915_gem_object *obj)if (IS_ERR (pages))return PTR_ERR (pages); -dbg_poison (&to_i915 (obj->base.dev)->ggtt, +dbg_poison (to_gt (i915)->ggtt,sg_dma_address (pages->sgl),sg_dma_len (pages->sgl),POISON_INUSE );
@@ -599,9 +600,10 @@ static int i915_gem_object_get_pages_stolen(struct drm_i915_gem_object *obj) static void i915_gem_object_put_pages_stolen(struct drm_i915_gem_object *obj, struct sg_table *pages) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);/* Should only be called from i915_gem_object_release_stolen() */ -dbg_poison (&to_i915 (obj->base.dev)->ggtt, +dbg_poison (to_gt (i915)->ggtt,sg_dma_address (pages->sgl),sg_dma_len (pages->sgl),POISON_FREE );
drivers/gpu/drm/i915/gem/i915_gem_tiling.c +3 -2
@@ -181,7 +181,8 @@ static int i915_gem_object_fence_prepare(struct drm_i915_gem_object *obj, int tiling_mode, unsigned int stride) { - struct i915_ggtt *ggtt = &to_i915(obj->base.dev)->ggtt; + struct drm_i915_private *i915 = to_i915(obj->base.dev); +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct i915_vma *vma, *vn;LIST_HEAD (unbind);int ret =0 ;
@@ -336,7 +337,7 @@ i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,struct drm_i915_gem_object *obj;int err; -if (!dev_priv->ggtt.num_fences) +if (!to_gt (dev_priv)->ggtt->num_fences)return -EOPNOTSUPP ; obj = i915_gem_object_lookup(file, args->handle); @@ -362,9 +363,9 @@ i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,
args->stride = 0;
} else {
if (args->tiling_mode == I915_TILING_X)
- args->swizzle_mode = to_i915(dev)->ggtt.bit_6_swizzle_x;
+ args->swizzle_mode = to_gt(dev_priv)->ggtt->bit_6_swizzle_x;
else
- args->swizzle_mode = to_i915(dev)->ggtt.bit_6_swizzle_y;
+ args->swizzle_mode = to_gt(dev_priv)->ggtt->bit_6_swizzle_y;
/* Hide bit 17 swizzling from the user. This prevents old Mesa
* from aborting the application on sw fallbacks to bit 17, @@ -419,7 +420,7 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,
struct drm_i915_gem_object *obj;
int err = -ENOENT;
- if (!dev_priv->ggtt.num_fences)
+ if (!to_gt(dev_priv)->ggtt->num_fences)
return -EOPNOTSUPP;
rcu_read_lock();
@@ -435,10 +436,10 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,
switch (args->tiling_mode) {
case I915_TILING_X:
- args->swizzle_mode = dev_priv->ggtt.bit_6_swizzle_x;
+ args->swizzle_mode = to_gt(dev_priv)->ggtt->bit_6_swizzle_x;
break;
case I915_TILING_Y:
- args->swizzle_mode = dev_priv->ggtt.bit_6_swizzle_y;
+ args->swizzle_mode = to_gt(dev_priv)->ggtt->bit_6_swizzle_y;
break;
default:
case I915_TILING_NONE:
drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c +1 -1
@@ -543,7 +543,7 @@ static bool has_bit17_swizzle(int sw)static bool bad_swizzling (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;if (i915->quirks &QUIRK_PIN_SWIZZLED_PAGES )return true;
drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +1 -1
@@ -1374,7 +1374,7 @@ static int igt_ctx_readonly(void *arg) goto out_file; } - vm = ctx->vm ?: &i915->ggtt.alias->vm; + vm = ctx->vm ?: &to_gt (i915)->ggtt->alias->vm;if (!vm || !vm->has_read_only) { err =0 ; goto out_file;
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +1 -1
@@ -307,7 +307,7 @@ static int igt_partial_tiling(void *arg)int tiling;int err; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ;/* We want to check the page mapping and fencing of a large object @@ -320,7 +320,7 @@ static int igt_partial_tiling(void *arg)
obj = huge_gem_object(i915,
nreal << PAGE_SHIFT,
- (1 + next_prime_number(i915->ggtt.vm.total >> PAGE_SHIFT)) << PAGE_SHIFT);
+ (1 + next_prime_number(to_gt(i915)->ggtt->vm.total >>
+PAGE_SHIFT)) << PAGE_SHIFT);
if (IS_ERR(obj))
return PTR_ERR(obj);
@@ -366,10 +366,10 @@ static int igt_partial_tiling(void *arg)
tile.tiling = tiling;
switch (tiling) {
case I915_TILING_X:
- tile.swizzle = i915->ggtt.bit_6_swizzle_x;
+ tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_x;
break;
case I915_TILING_Y:
- tile.swizzle = i915->ggtt.bit_6_swizzle_y;
+ tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_y;
break;
}
@@ -440,7 +440,7 @@ static int igt_smoke_tiling(void *arg)
IGT_TIMEOUT(end);
int err;
- if (!i915_ggtt_has_aperture(&i915->ggtt))
+ if (!i915_ggtt_has_aperture(to_gt(i915)->ggtt))
return 0;
/*
@@ -457,7 +457,7 @@ static int igt_smoke_tiling(void *arg)
obj = huge_gem_object(i915,
nreal << PAGE_SHIFT,
- (1 + next_prime_number(i915->ggtt.vm.total >> PAGE_SHIFT)) << PAGE_SHIFT);
+ (1 + next_prime_number(to_gt(i915)->ggtt->vm.total >>
+PAGE_SHIFT)) << PAGE_SHIFT);
if (IS_ERR(obj))
return PTR_ERR(obj);
@@ -486,10 +486,10 @@ static int igt_smoke_tiling(void *arg)
break;
case I915_TILING_X:
- tile.swizzle = i915->ggtt.bit_6_swizzle_x;
+ tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_x;
break;
case I915_TILING_Y:
- tile.swizzle = i915->ggtt.bit_6_swizzle_y;
+ tile.swizzle = to_gt(i915)->ggtt->bit_6_swizzle_y;
break;
}
@@ -856,6 +856,7 @@ static int wc_check(struct drm_i915_gem_object *obj)
static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type) {
+ struct drm_i915_private *i915 = to_i915(obj->base.dev);
bool no_map;
if (obj->ops->mmap_offset)
@@ -864,7 +865,7 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)
return false;
if (type == I915_MMAP_TYPE_GTT &&
- !i915_ggtt_has_aperture(&to_i915(obj->base.dev)->ggtt))
+ !i915_ggtt_has_aperture(to_gt(i915)->ggtt))
return false;
i915_gem_object_lock(obj, NULL);
drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c +1 -1
@@ -43,7 +43,7 @@ static int igt_gem_huge(void *arg) obj =huge_gem_object (i915, nreal *PAGE_SIZE , - i915->ggtt.vm.total +PAGE_SIZE ); +to_gt (i915)->ggtt->vm.total +PAGE_SIZE );if (IS_ERR (obj))return PTR_ERR (obj);
--
2.34.1
- Reviewed-by : Sujaritha Sundaresan <[email protected]>
Re: [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiQuoted 10 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>
Quoted 379 lines
--- drivers/gpu/drm/i915/gem/i915_gem_context.h | 2 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 19 ++++++++++--------- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 6 +++--- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 8 +++++--- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 15 ++++++++------- .../i915/gem/selftests/i915_gem_client_blt.c | 2 +- .../drm/i915/gem/selftests/i915_gem_context.c | 2 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 19 ++++++++++--------- .../drm/i915/gem/selftests/i915_gem_object.c | 2 +- 11 files changed, 42 insertions(+), 37 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_context.h +1
-1@@ -174,7 +174,7 @@ i915_gem_context_get_eb_vm(struct i915_gem_context *ctx) vm = ctx->vm;if (!vm) - vm = &ctx->i915->ggtt.vm; + vm = &to_gt (ctx->i915)->ggtt->vm; vm =i915_vm_get (vm);return vm;drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +1
-1@@ -1106,7 +1106,7 @@ static inline struct i915_ggtt *cache_to_ggtt(struct reloc_cache *cache) {struct drm_i915_private *i915 = container_of(cache, struct i915_execbuffer, reloc_cache)->i915; -return &i915->ggtt; +return to_gt (i915)->ggtt; }static void reloc_cache_reset (struct reloc_cache *cache,struct i915_execbuffer *eb)drivers/gpu/drm/i915/gem/i915_gem_mman.c +10
-9@@ -295,7 +295,7 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)struct drm_device *dev = obj->base.dev;struct drm_i915_private *i915 =to_i915 (dev);struct intel_runtime_pm *rpm = &i915->runtime_pm; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;bool write = area->vm_flags &VM_WRITE ;struct i915_gem_ww_ctx ww;intel_wakeref_t wakeref;@@ -388,16 +388,16 @@ static vm_fault_t vm_fault_gtt(struct vm_fault *vmf)assert_rpm_wakelock_held (rpm);/* Mark as being mmapped into userspace for later revocation */ -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);if (!i915_vma_set_userfault (vma) && !obj->userfault_count++) -list_add (&obj->userfault_link, &i915->ggtt.userfault_list); -mutex_unlock (&i915->ggtt.vm.mutex); +list_add (&obj->userfault_link, &to_gt (i915)->ggtt->userfault_list); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex);/* Track the mmo associated with the fenced vma */ vma->mmo = mmo;if (CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND ) -intel_wakeref_auto (&i915->ggtt.userfault_wakeref, +intel_wakeref_auto (&to_gt (i915)->ggtt->userfault_wakeref,msecs_to_jiffies_timeout (CONFIG_DRM_I915_USERFAULT_AUTOSUSPEND ));if (write) {@@ -512,7 +512,7 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)* wakeref. */ wakeref =intel_runtime_pm_get (&i915->runtime_pm); -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);if (!obj->userfault_count) goto out;@@ -530,7 +530,7 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj)wmb (); out: -mutex_unlock (&i915->ggtt.vm.mutex); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex);intel_runtime_pm_put (&i915->runtime_pm, wakeref); }@@ -733,13 +733,14 @@ i915_gem_dumb_mmap_offset(struct drm_file *file,u32 handle, u64 *offset) { + struct drm_i915_private *i915 = to_i915(dev);enum i915_mmap_type mmap_type;if (HAS_LMEM (to_i915 (dev))) mmap_type =I915_MMAP_TYPE_FIXED ;else if (boot_cpu_has (X86_FEATURE_PAT )) mmap_type =I915_MMAP_TYPE_WC ; -else if (!i915_ggtt_has_aperture (&to_i915 (dev)->ggtt)) +else if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return -ENODEV ;else mmap_type =I915_MMAP_TYPE_GTT ;@@ -787,7 +788,7 @@ i915_gem_mmap_offset_ioctl(struct drm_device *dev, void *data,switch (args->flags) {case I915_MMAP_OFFSET_GTT : -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return -ENODEV ; type =I915_MMAP_TYPE_GTT ;break ;drivers/gpu/drm/i915/gem/i915_gem_pm.c +1
-1@@ -23,7 +23,7 @@ void i915_gem_suspend(struct drm_i915_private *i915) {GEM_TRACE ("%s\n" ,dev_name (i915->drm.dev)); -intel_wakeref_auto (&i915->ggtt.userfault_wakeref,0 ); +intel_wakeref_auto (&to_gt (i915)->ggtt->userfault_wakeref,0 );flush_workqueue (i915->wq);/* drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +3
-3@@ -403,9 +403,9 @@ i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr I915_SHRINK_VMAPS);/* We also want to clear any cached iomaps as they wrap vmap */ -mutex_lock (&i915->ggtt.vm.mutex); +mutex_lock (&to_gt (i915)->ggtt->vm.mutex);list_for_each_entry_safe (vma, next, - &i915->ggtt.vm.bound_list, vm_link) { + &to_gt (i915)->ggtt->vm.bound_list, vm_link) {unsigned long count = vma->node.size >>PAGE_SHIFT ;if (!vma->iomap ||i915_vma_is_active (vma))@@ -414,7 +414,7 @@ i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptrif (__i915_vma_unbind (vma) ==0 ) freed_pages += count; } -mutex_unlock (&i915->ggtt.vm.mutex); +mutex_unlock (&to_gt (i915)->ggtt->vm.mutex); *(unsigned long *)ptr += freed_pages;return NOTIFY_DONE ;drivers/gpu/drm/i915/gem/i915_gem_stolen.c +5
-3@@ -71,7 +71,7 @@ void i915_gem_stolen_remove_node(struct drm_i915_private *i915,static int i915_adjust_stolen (struct drm_i915_private *i915,struct resource *dsm) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct intel_uncore *uncore = ggtt->vm.gt->uncore;struct resource *r;@@ -579,6 +579,7 @@ i915_pages_create_for_stolen(struct drm_device *dev,static int i915_gem_object_get_pages_stolen (struct drm_i915_gem_object *obj) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);struct sg_table *pages = i915_pages_create_for_stolen(obj->base.dev, obj->stolen->start,@@ -586,7 +587,7 @@ static int i915_gem_object_get_pages_stolen(struct drm_i915_gem_object *obj)if (IS_ERR (pages))return PTR_ERR (pages); -dbg_poison (&to_i915 (obj->base.dev)->ggtt, +dbg_poison (to_gt (i915)->ggtt,sg_dma_address (pages->sgl),sg_dma_len (pages->sgl),POISON_INUSE );@@ -599,9 +600,10 @@ static int i915_gem_object_get_pages_stolen(struct drm_i915_gem_object *obj)static void i915_gem_object_put_pages_stolen (struct drm_i915_gem_object *obj,struct sg_table *pages) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);/* Should only be called from i915_gem_object_release_stolen() */ -dbg_poison (&to_i915 (obj->base.dev)->ggtt, +dbg_poison (to_gt (i915)->ggtt,sg_dma_address (pages->sgl),sg_dma_len (pages->sgl),POISON_FREE );drivers/gpu/drm/i915/gem/i915_gem_tiling.c +8
-7@@ -181,7 +181,8 @@ static int i915_gem_object_fence_prepare(struct drm_i915_gem_object *obj, int tiling_mode, unsigned int stride) { - struct i915_ggtt *ggtt = &to_i915(obj->base.dev)->ggtt; + struct drm_i915_private *i915 = to_i915(obj->base.dev); +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct i915_vma *vma, *vn;LIST_HEAD (unbind);int ret =0 ;@@ -336,7 +337,7 @@ i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,struct drm_i915_gem_object *obj;int err; -if (!dev_priv->ggtt.num_fences) +if (!to_gt (dev_priv)->ggtt->num_fences)return -EOPNOTSUPP ; obj =i915_gem_object_lookup (file, args->handle);@@ -362,9 +363,9 @@ i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data, args->stride =0 ; }else {if (args->tiling_mode ==I915_TILING_X ) - args->swizzle_mode =to_i915 (dev)->ggtt.bit_6_swizzle_x; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_x;else - args->swizzle_mode =to_i915 (dev)->ggtt.bit_6_swizzle_y; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_y;/* Hide bit 17 swizzling from the user. This prevents old Mesa * from aborting the application on sw fallbacks to bit 17, @@ -419,7 +420,7 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,struct drm_i915_gem_object *obj;int err = -ENOENT ; -if (!dev_priv->ggtt.num_fences) +if (!to_gt (dev_priv)->ggtt->num_fences)return -EOPNOTSUPP ;rcu_read_lock ();@@ -435,10 +436,10 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,switch (args->tiling_mode) {case I915_TILING_X : - args->swizzle_mode = dev_priv->ggtt.bit_6_swizzle_x; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_x;break ;case I915_TILING_Y : - args->swizzle_mode = dev_priv->ggtt.bit_6_swizzle_y; + args->swizzle_mode =to_gt (dev_priv)->ggtt->bit_6_swizzle_y;break ;default :case I915_TILING_NONE :drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c +1
-1@@ -543,7 +543,7 @@ static bool has_bit17_swizzle(int sw)static bool bad_swizzling (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;if (i915->quirks &QUIRK_PIN_SWIZZLED_PAGES )return true;drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +1
-1@@ -1374,7 +1374,7 @@ static int igt_ctx_readonly(void *arg) goto out_file; } - vm = ctx->vm ?: &i915->ggtt.alias->vm; + vm = ctx->vm ?: &to_gt (i915)->ggtt->alias->vm;if (!vm || !vm->has_read_only) { err =0 ; goto out_file;drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +10
-9@@ -307,7 +307,7 @@ static int igt_partial_tiling(void *arg)int tiling;int err; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ;/* We want to check the page mapping and fencing of a large object @@ -320,7 +320,7 @@ static int igt_partial_tiling(void *arg) obj =huge_gem_object (i915, nreal <<PAGE_SHIFT , - (1 +next_prime_number (i915->ggtt.vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT ); + (1 +next_prime_number (to_gt (i915)->ggtt->vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT );if (IS_ERR (obj))return PTR_ERR (obj);@@ -366,10 +366,10 @@ static int igt_partial_tiling(void *arg) tile.tiling = tiling;switch (tiling) {case I915_TILING_X : - tile.swizzle = i915->ggtt.bit_6_swizzle_x; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_x;break ;case I915_TILING_Y : - tile.swizzle = i915->ggtt.bit_6_swizzle_y; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_y;break ; }@@ -440,7 +440,7 @@ static int igt_smoke_tiling(void *arg)IGT_TIMEOUT (end);int err; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ;/* @@ -457,7 +457,7 @@ static int igt_smoke_tiling(void *arg) obj =huge_gem_object (i915, nreal <<PAGE_SHIFT , - (1 +next_prime_number (i915->ggtt.vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT ); + (1 +next_prime_number (to_gt (i915)->ggtt->vm.total >>PAGE_SHIFT )) <<PAGE_SHIFT );if (IS_ERR (obj))return PTR_ERR (obj);@@ -486,10 +486,10 @@ static int igt_smoke_tiling(void *arg)break ;case I915_TILING_X : - tile.swizzle = i915->ggtt.bit_6_swizzle_x; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_x;break ;case I915_TILING_Y : - tile.swizzle = i915->ggtt.bit_6_swizzle_y; + tile.swizzle =to_gt (i915)->ggtt->bit_6_swizzle_y;break ; }@@ -856,6 +856,7 @@ static int wc_check(struct drm_i915_gem_object *obj)static bool can_mmap (struct drm_i915_gem_object *obj,enum i915_mmap_type type) { +struct drm_i915_private *i915 =to_i915 (obj->base.dev);bool no_map;if (obj->ops->mmap_offset)@@ -864,7 +865,7 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)return false;if (type ==I915_MMAP_TYPE_GTT && - !i915_ggtt_has_aperture (&to_i915 (obj->base.dev)->ggtt)) + !i915_ggtt_has_aperture (to_gt (i915)->ggtt))return false;i915_gem_object_lock (obj,NULL );drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c +1
-1@@ -43,7 +43,7 @@ static int igt_gem_huge(void *arg) obj =huge_gem_object (i915, nreal *PAGE_SIZE , - i915->ggtt.vm.total +PAGE_SIZE ); +to_gt (i915)->ggtt->vm.total +PAGE_SIZE );if (IS_ERR (obj))return PTR_ERR (obj);Signature · 1 line
2.34.1
Signature · 5 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
PATCH v8 12/16 drm/i915/display: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one.
Use to_gt() for all i915->ggtt accesses to help with the future refactoring.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_plane_initial.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +1 -1
@@ -595,7 +595,7 @@ static void ivb_fbc_activate(struct intel_fbc *fbc)else if (DISPLAY_VER (i915) ==9 )skl_fbc_program_cfb_stride (fbc); -if (i915->ggtt.num_fences) +if (to_gt (i915)->ggtt->num_fences)snb_fbc_program_fence (fbc); intel_de_write(i915, ILK_DPFC_CONTROL,
drivers/gpu/drm/i915/display/intel_fbdev.c +1 -1
@@ -180,7 +180,7 @@ static int intelfb_create(struct drm_fb_helper *helper,struct drm_device *dev = helper->dev;struct drm_i915_private *dev_priv =to_i915 (dev);struct pci_dev *pdev =to_pci_dev (dev_priv->drm.dev); -struct i915_ggtt *ggtt = &dev_priv->ggtt; +struct i915_ggtt *ggtt =to_gt (dev_priv)->ggtt;const struct i915_ggtt_view view = { .type =I915_GGTT_VIEW_NORMAL , };
drivers/gpu/drm/i915/display/intel_plane_initial.c +1 -1
@@ -94,7 +94,7 @@ initial_plane_vma(struct drm_i915_private *i915, goto err_obj; } - vma =i915_vma_instance (obj, &i915->ggtt.vm,NULL ); + vma =i915_vma_instance (obj, &to_gt (i915)->ggtt->vm,NULL );if (IS_ERR (vma)) goto err_obj;
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v8 12/16] drm/i915/display: Use to_gt() helper for GGTT accesses
Quoted 47 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_plane_initial.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_fbc.c +1
-1@@ -595,7 +595,7 @@ static void ivb_fbc_activate(struct intel_fbc *fbc)else if (DISPLAY_VER (i915) ==9 )skl_fbc_program_cfb_stride (fbc); -if (i915->ggtt.num_fences) +if (to_gt (i915)->ggtt->num_fences)snb_fbc_program_fence (fbc); intel_de_write(i915, ILK_DPFC_CONTROL,drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1@@ -180,7 +180,7 @@ static int intelfb_create(struct drm_fb_helper *helper,struct drm_device *dev = helper->dev;struct drm_i915_private *dev_priv =to_i915 (dev);struct pci_dev *pdev =to_pci_dev (dev_priv->drm.dev); -struct i915_ggtt *ggtt = &dev_priv->ggtt; +struct i915_ggtt *ggtt =to_gt (dev_priv)->ggtt;const struct i915_ggtt_view view = { .type =I915_GGTT_VIEW_NORMAL , };drivers/gpu/drm/i915/display/intel_plane_initial.c +0
-0
drivers/gpu/drm/i915/display/intel_plane_initial.c initial_plane_vma(struct drm_i915_private *i915, · line 99
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_plane_initial.c +1
-1@@ -94,7 +94,7 @@ initial_plane_vma(struct drm_i915_private *i915, goto err_obj; } - vma =i915_vma_instance (obj, &i915->ggtt.vm,NULL ); + vma =i915_vma_instance (obj, &to_gt (i915)->ggtt->vm,NULL );if (IS_ERR (vma)) goto err_obj;
Quoted 1 line
Re: [PATCH v8 12/16] drm/i915/display: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiQuoted 10 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>
Quoted 48 lines
--- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_plane_initial.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_fbc.c +1
-1@@ -595,7 +595,7 @@ static void ivb_fbc_activate(struct intel_fbc *fbc)else if (DISPLAY_VER (i915) ==9 )skl_fbc_program_cfb_stride (fbc); -if (i915->ggtt.num_fences) +if (to_gt (i915)->ggtt->num_fences)snb_fbc_program_fence (fbc); intel_de_write(i915, ILK_DPFC_CONTROL,drivers/gpu/drm/i915/display/intel_fbdev.c +1
-1@@ -180,7 +180,7 @@ static int intelfb_create(struct drm_fb_helper *helper,struct drm_device *dev = helper->dev;struct drm_i915_private *dev_priv =to_i915 (dev);struct pci_dev *pdev =to_pci_dev (dev_priv->drm.dev); -struct i915_ggtt *ggtt = &dev_priv->ggtt; +struct i915_ggtt *ggtt =to_gt (dev_priv)->ggtt;const struct i915_ggtt_view view = { .type =I915_GGTT_VIEW_NORMAL , };drivers/gpu/drm/i915/display/intel_plane_initial.c +1
-1@@ -94,7 +94,7 @@ initial_plane_vma(struct drm_i915_private *i915, goto err_obj; } - vma =i915_vma_instance (obj, &i915->ggtt.vm,NULL ); + vma =i915_vma_instance (obj, &to_gt (i915)->ggtt->vm,NULL );if (IS_ERR (vma)) goto err_obj;Signature · 1 line
2.34.1
Signature · 5 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
PATCH v8 13/16 drm/i915/gt: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one.
Use to_gt() for all i915->ggtt accesses to help with the future refactoring.
--- drivers/gpu/drm/i915/gt/intel_ggtt.c | 14 +++++++------- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 6 +++--- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_reset.c | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/gt/intel_ggtt.c +7 -7
@@ -89,7 +89,7 @@ int i915_ggtt_init_hw(struct drm_i915_private *i915)* beyond the end of the batch buffer, across the page boundary, * and beyond the end of the GTT if we do not provide a guard. */ - ret =ggtt_init_hw (&i915->ggtt); + ret =ggtt_init_hw (to_gt (i915)->ggtt);if (ret)return ret;
@@ -725,14 +725,14 @@ int i915_init_ggtt(struct drm_i915_private *i915) {int ret; - ret =init_ggtt (&i915->ggtt); + ret =init_ggtt (to_gt (i915)->ggtt);if (ret)return ret;if (INTEL_PPGTT (i915) ==INTEL_PPGTT_ALIASING ) { - ret =init_aliasing_ppgtt (&i915->ggtt); + ret =init_aliasing_ppgtt (to_gt (i915)->ggtt);if (ret) -cleanup_init_ggtt (&i915->ggtt); +cleanup_init_ggtt (to_gt (i915)->ggtt); }return 0 ;
@@ -775,7 +775,7 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)*/ void i915_ggtt_driver_release (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;fini_aliasing_ppgtt (ggtt);
@@ -790,7 +790,7 @@ void i915_ggtt_driver_release(struct drm_i915_private *i915)*/ void i915_ggtt_driver_late_release (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;GEM_WARN_ON (kref_read (&ggtt->vm.resv_ref) !=1 );dma_resv_fini (&ggtt->vm._resv);
@@ -1232,7 +1232,7 @@ int i915_ggtt_probe_hw(struct drm_i915_private *i915) {int ret; - ret =ggtt_probe_hw (&i915->ggtt,to_gt (i915)); + ret =ggtt_probe_hw (to_gt (i915)->ggtt,to_gt (i915));if (ret)return ret;
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +3 -3
@@ -728,8 +728,8 @@ static void detect_bit_6_swizzle(struct i915_ggtt *ggtt) swizzle_y =I915_BIT_6_SWIZZLE_NONE ; } - i915->ggtt.bit_6_swizzle_x = swizzle_x; - i915->ggtt.bit_6_swizzle_y = swizzle_y; +to_gt (i915)->ggtt->bit_6_swizzle_x = swizzle_x; +to_gt (i915)->ggtt->bit_6_swizzle_y = swizzle_y; }/*
@@ -896,7 +896,7 @@ void intel_gt_init_swizzling(struct intel_gt *gt)struct intel_uncore *uncore = gt->uncore;if (GRAPHICS_VER (i915) <5 || - i915->ggtt.bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_NONE ) +to_gt (i915)->ggtt->bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_NONE )return ;intel_uncore_rmw (uncore,DISP_ARB_CTL ,0 ,DISP_TILE_SURFACE_SWIZZLING );
drivers/gpu/drm/i915/gt/intel_region_lmem.c +2 -2
@@ -15,7 +15,7 @@static int init_fake_lmem_bar (struct intel_memory_region *mem) {struct drm_i915_private *i915 = mem->i915; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;unsigned long n;int ret;
@@ -131,7 +131,7 @@ intel_gt_setup_fake_lmem(struct intel_gt *gt)if (!i915->params.fake_lmem_start)return ERR_PTR (-ENODEV ); -GEM_BUG_ON (i915_ggtt_has_aperture (&i915->ggtt)); +GEM_BUG_ON (i915_ggtt_has_aperture (to_gt (i915)->ggtt));/* Your mappable aperture belongs to me now! */ mappable_end =pci_resource_len (pdev,2 );
drivers/gpu/drm/i915/gt/selftest_reset.c +1 -1
@@ -19,7 +19,7 @@ __igt_reset_stolen(struct intel_gt *gt,intel_engine_mask_t mask, const char *msg) { - struct i915_ggtt *ggtt = >->i915->ggtt; + struct i915_ggtt *ggtt = gt->ggtt;const struct resource *dsm = >->i915->dsm;resource_size_t num_pages, page;struct intel_engine_cs *engine;
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v8 13/16] drm/i915/gt: Use to_gt() helper for GGTT accesses
Quoted 126 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>--- drivers/gpu/drm/i915/gt/intel_ggtt.c | 14 +++++++------- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 6 +++--- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_reset.c | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-)drivers/gpu/drm/i915/gt/intel_ggtt.c +7
-7@@ -89,7 +89,7 @@ int i915_ggtt_init_hw(struct drm_i915_private *i915)* beyond the end of the batch buffer, across the page boundary, * and beyond the end of the GTT if we do not provide a guard. */ - ret =ggtt_init_hw (&i915->ggtt); + ret =ggtt_init_hw (to_gt (i915)->ggtt);if (ret)return ret;@@ -725,14 +725,14 @@ int i915_init_ggtt(struct drm_i915_private *i915) {int ret; - ret =init_ggtt (&i915->ggtt); + ret =init_ggtt (to_gt (i915)->ggtt);if (ret)return ret;if (INTEL_PPGTT (i915) ==INTEL_PPGTT_ALIASING ) { - ret =init_aliasing_ppgtt (&i915->ggtt); + ret =init_aliasing_ppgtt (to_gt (i915)->ggtt);if (ret) -cleanup_init_ggtt (&i915->ggtt); +cleanup_init_ggtt (to_gt (i915)->ggtt); }return 0 ;@@ -775,7 +775,7 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)*/ void i915_ggtt_driver_release (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;fini_aliasing_ppgtt (ggtt);@@ -790,7 +790,7 @@ void i915_ggtt_driver_release(struct drm_i915_private *i915)*/ void i915_ggtt_driver_late_release (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;GEM_WARN_ON (kref_read (&ggtt->vm.resv_ref) !=1 );dma_resv_fini (&ggtt->vm._resv);@@ -1232,7 +1232,7 @@ int i915_ggtt_probe_hw(struct drm_i915_private *i915) {int ret; - ret =ggtt_probe_hw (&i915->ggtt,to_gt (i915)); + ret =ggtt_probe_hw (to_gt (i915)->ggtt,to_gt (i915));if (ret)return ret;drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +3
-3@@ -728,8 +728,8 @@ static void detect_bit_6_swizzle(struct i915_ggtt *ggtt) swizzle_y =I915_BIT_6_SWIZZLE_NONE ; } - i915->ggtt.bit_6_swizzle_x = swizzle_x; - i915->ggtt.bit_6_swizzle_y = swizzle_y; +to_gt (i915)->ggtt->bit_6_swizzle_x = swizzle_x; +to_gt (i915)->ggtt->bit_6_swizzle_y = swizzle_y; }/* @@ -896,7 +896,7 @@ void intel_gt_init_swizzling(struct intel_gt *gt)struct intel_uncore *uncore = gt->uncore;if (GRAPHICS_VER (i915) <5 || - i915->ggtt.bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_NONE ) +to_gt (i915)->ggtt->bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_NONE )return ;intel_uncore_rmw (uncore,DISP_ARB_CTL ,0 ,DISP_TILE_SURFACE_SWIZZLING );drivers/gpu/drm/i915/gt/intel_region_lmem.c +2
-2@@ -15,7 +15,7 @@static int init_fake_lmem_bar (struct intel_memory_region *mem) {struct drm_i915_private *i915 = mem->i915; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;unsigned long n;int ret;@@ -131,7 +131,7 @@ intel_gt_setup_fake_lmem(struct intel_gt *gt)if (!i915->params.fake_lmem_start)return ERR_PTR (-ENODEV ); -GEM_BUG_ON (i915_ggtt_has_aperture (&i915->ggtt)); +GEM_BUG_ON (i915_ggtt_has_aperture (to_gt (i915)->ggtt));/* Your mappable aperture belongs to me now! */ mappable_end =pci_resource_len (pdev,2 );drivers/gpu/drm/i915/gt/selftest_reset.c +0
-0
drivers/gpu/drm/i915/gt/selftest_reset.c __igt_reset_stolen(struct intel_gt *gt, · line 25
Quoted 8 lines
drivers/gpu/drm/i915/gt/selftest_reset.c +1
-1@@ -19,7 +19,7 @@ __igt_reset_stolen(struct intel_gt *gt,intel_engine_mask_t mask, const char *msg) { - struct i915_ggtt *ggtt = >->i915->ggtt; + struct i915_ggtt *ggtt = gt->ggtt;const struct resource *dsm = >->i915->dsm;resource_size_t num_pages, page;struct intel_engine_cs *engine;
Re: [PATCH v8 13/16] drm/i915/gt: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiQuoted 10 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>
Quoted 127 lines
--- drivers/gpu/drm/i915/gt/intel_ggtt.c | 14 +++++++------- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 6 +++--- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_reset.c | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-)drivers/gpu/drm/i915/gt/intel_ggtt.c +7
-7@@ -89,7 +89,7 @@ int i915_ggtt_init_hw(struct drm_i915_private *i915)* beyond the end of the batch buffer, across the page boundary, * and beyond the end of the GTT if we do not provide a guard. */ - ret =ggtt_init_hw (&i915->ggtt); + ret =ggtt_init_hw (to_gt (i915)->ggtt);if (ret)return ret;@@ -725,14 +725,14 @@ int i915_init_ggtt(struct drm_i915_private *i915) {int ret; - ret =init_ggtt (&i915->ggtt); + ret =init_ggtt (to_gt (i915)->ggtt);if (ret)return ret;if (INTEL_PPGTT (i915) ==INTEL_PPGTT_ALIASING ) { - ret =init_aliasing_ppgtt (&i915->ggtt); + ret =init_aliasing_ppgtt (to_gt (i915)->ggtt);if (ret) -cleanup_init_ggtt (&i915->ggtt); +cleanup_init_ggtt (to_gt (i915)->ggtt); }return 0 ;@@ -775,7 +775,7 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)*/ void i915_ggtt_driver_release (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;fini_aliasing_ppgtt (ggtt);@@ -790,7 +790,7 @@ void i915_ggtt_driver_release(struct drm_i915_private *i915)*/ void i915_ggtt_driver_late_release (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;GEM_WARN_ON (kref_read (&ggtt->vm.resv_ref) !=1 );dma_resv_fini (&ggtt->vm._resv);@@ -1232,7 +1232,7 @@ int i915_ggtt_probe_hw(struct drm_i915_private *i915) {int ret; - ret =ggtt_probe_hw (&i915->ggtt,to_gt (i915)); + ret =ggtt_probe_hw (to_gt (i915)->ggtt,to_gt (i915));if (ret)return ret;drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +3
-3@@ -728,8 +728,8 @@ static void detect_bit_6_swizzle(struct i915_ggtt *ggtt) swizzle_y =I915_BIT_6_SWIZZLE_NONE ; } - i915->ggtt.bit_6_swizzle_x = swizzle_x; - i915->ggtt.bit_6_swizzle_y = swizzle_y; +to_gt (i915)->ggtt->bit_6_swizzle_x = swizzle_x; +to_gt (i915)->ggtt->bit_6_swizzle_y = swizzle_y; }/* @@ -896,7 +896,7 @@ void intel_gt_init_swizzling(struct intel_gt *gt)struct intel_uncore *uncore = gt->uncore;if (GRAPHICS_VER (i915) <5 || - i915->ggtt.bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_NONE ) +to_gt (i915)->ggtt->bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_NONE )return ;intel_uncore_rmw (uncore,DISP_ARB_CTL ,0 ,DISP_TILE_SURFACE_SWIZZLING );drivers/gpu/drm/i915/gt/intel_region_lmem.c +2
-2@@ -15,7 +15,7 @@static int init_fake_lmem_bar (struct intel_memory_region *mem) {struct drm_i915_private *i915 = mem->i915; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;unsigned long n;int ret;@@ -131,7 +131,7 @@ intel_gt_setup_fake_lmem(struct intel_gt *gt)if (!i915->params.fake_lmem_start)return ERR_PTR (-ENODEV ); -GEM_BUG_ON (i915_ggtt_has_aperture (&i915->ggtt)); +GEM_BUG_ON (i915_ggtt_has_aperture (to_gt (i915)->ggtt));/* Your mappable aperture belongs to me now! */ mappable_end =pci_resource_len (pdev,2 );drivers/gpu/drm/i915/gt/selftest_reset.c +1
-1@@ -19,7 +19,7 @@ __igt_reset_stolen(struct intel_gt *gt,intel_engine_mask_t mask, const char *msg) { - struct i915_ggtt *ggtt = >->i915->ggtt; + struct i915_ggtt *ggtt = gt->ggtt;const struct resource *dsm = >->i915->dsm;resource_size_t num_pages, page;struct intel_engine_cs *engine;Signature · 1 line
2.34.1
Signature · 5 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
PATCH v8 14/16 drm/i915/selftests: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one.
Use to_gt() for all i915->ggtt accesses to help with the future refactoring.
--- drivers/gpu/drm/i915/selftests/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 6 +++--- drivers/gpu/drm/i915/selftests/i915_request.c | 2 +- drivers/gpu/drm/i915/selftests/i915_vma.c | 2 +- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/selftests/i915_gem.c +4 -4
@@ -41,7 +41,7 @@ static int switch_to_context(struct i915_gem_context *ctx)static void trash_stolen (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;const u64 slot = ggtt->error_capture.start;const resource_size_t size =resource_size (&i915->dsm);unsigned long page;
@@ -99,7 +99,7 @@ static void igt_pm_suspend(struct drm_i915_private *i915)intel_wakeref_t wakeref; with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_suspend (&i915->ggtt); +i915_ggtt_suspend (to_gt (i915)->ggtt);i915_gem_suspend_late (i915); } }
@@ -109,7 +109,7 @@ static void igt_pm_hibernate(struct drm_i915_private *i915)intel_wakeref_t wakeref; with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_suspend (&i915->ggtt); +i915_ggtt_suspend (to_gt (i915)->ggtt);i915_gem_freeze (i915);i915_gem_freeze_late (i915);
@@ -125,7 +125,7 @@ static void igt_pm_resume(struct drm_i915_private *i915)* that runtime-pm just works. */ with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_resume (&i915->ggtt); +i915_ggtt_resume (to_gt (i915)->ggtt);i915_gem_resume (i915); } }
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +3 -3
@@ -1122,7 +1122,7 @@ static int exercise_ggtt(struct drm_i915_private *i915, u64 hole_start, u64 hole_end, unsigned long end_time)) { - struct i915_ggtt *ggtt = &i915->ggtt; + struct i915_ggtt *ggtt = to_gt(i915)->ggtt;u64 hole_start, hole_end, last =0 ;struct drm_mm_node *node;IGT_TIMEOUT (end_time);
@@ -1182,7 +1182,7 @@ static int igt_ggtt_page(void *arg)const unsigned int count =PAGE_SIZE /sizeof (u32);I915_RND_STATE (prng);struct drm_i915_private *i915 = arg; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct drm_i915_gem_object *obj;intel_wakeref_t wakeref;struct drm_mm_node tmp;
@@ -2110,7 +2110,7 @@ int i915_gem_gtt_live_selftests(struct drm_i915_private *i915) SUBTEST(igt_cs_tlb), }; -GEM_BUG_ON (offset_in_page (i915->ggtt.vm.total)); +GEM_BUG_ON (offset_in_page (to_gt (i915)->ggtt->vm.total));return i915_subtests (tests, i915); }
drivers/gpu/drm/i915/selftests/i915_request.c +1 -1
@@ -843,7 +843,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)intel_gt_chipset_flush (to_gt (i915)); - vma =i915_vma_instance (obj, &i915->ggtt.vm,NULL ); + vma =i915_vma_instance (obj, &to_gt (i915)->ggtt->vm,NULL );if (IS_ERR (vma)) { err =PTR_ERR (vma); goto err;
drivers/gpu/drm/i915/selftests/i915_vma.c +1 -1
@@ -967,7 +967,7 @@ static int igt_vma_remapped_gtt(void *arg)intel_wakeref_t wakeref;int err =0 ; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ; obj =i915_gem_object_create_internal (i915,10 *10 *PAGE_SIZE );
drivers/gpu/drm/i915/selftests/mock_gem_device.c +1 -1
@@ -69,7 +69,7 @@ static void mock_device_release(struct drm_device *dev)i915_gem_drain_workqueue (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (&i915->ggtt); +mock_fini_ggtt (to_gt (i915)->ggtt);destroy_workqueue (i915->wq);intel_region_ttm_device_fini (i915);
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v8 14/16] drm/i915/selftests: Use to_gt() helper for GGTT accesses
Quoted 120 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>--- drivers/gpu/drm/i915/selftests/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 6 +++--- drivers/gpu/drm/i915/selftests/i915_request.c | 2 +- drivers/gpu/drm/i915/selftests/i915_vma.c | 2 +- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)drivers/gpu/drm/i915/selftests/i915_gem.c +4
-4@@ -41,7 +41,7 @@ static int switch_to_context(struct i915_gem_context *ctx)static void trash_stolen (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;const u64 slot = ggtt->error_capture.start;const resource_size_t size =resource_size (&i915->dsm);unsigned long page;@@ -99,7 +99,7 @@ static void igt_pm_suspend(struct drm_i915_private *i915)intel_wakeref_t wakeref; with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_suspend (&i915->ggtt); +i915_ggtt_suspend (to_gt (i915)->ggtt);i915_gem_suspend_late (i915); } }@@ -109,7 +109,7 @@ static void igt_pm_hibernate(struct drm_i915_private *i915)intel_wakeref_t wakeref; with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_suspend (&i915->ggtt); +i915_ggtt_suspend (to_gt (i915)->ggtt);i915_gem_freeze (i915);i915_gem_freeze_late (i915);@@ -125,7 +125,7 @@ static void igt_pm_resume(struct drm_i915_private *i915)* that runtime-pm just works. */ with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_resume (&i915->ggtt); +i915_ggtt_resume (to_gt (i915)->ggtt);i915_gem_resume (i915); } }drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +3
-3@@ -1122,7 +1122,7 @@ static int exercise_ggtt(struct drm_i915_private *i915, u64 hole_start, u64 hole_end, unsigned long end_time)) { - struct i915_ggtt *ggtt = &i915->ggtt; + struct i915_ggtt *ggtt = to_gt(i915)->ggtt;u64 hole_start, hole_end, last =0 ;struct drm_mm_node *node;IGT_TIMEOUT (end_time);@@ -1182,7 +1182,7 @@ static int igt_ggtt_page(void *arg)const unsigned int count =PAGE_SIZE /sizeof (u32);I915_RND_STATE (prng);struct drm_i915_private *i915 = arg; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct drm_i915_gem_object *obj;intel_wakeref_t wakeref;struct drm_mm_node tmp;@@ -2110,7 +2110,7 @@ int i915_gem_gtt_live_selftests(struct drm_i915_private *i915) SUBTEST(igt_cs_tlb), }; -GEM_BUG_ON (offset_in_page (i915->ggtt.vm.total)); +GEM_BUG_ON (offset_in_page (to_gt (i915)->ggtt->vm.total));return i915_subtests (tests, i915); }drivers/gpu/drm/i915/selftests/i915_request.c +1
-1@@ -843,7 +843,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)intel_gt_chipset_flush (to_gt (i915)); - vma =i915_vma_instance (obj, &i915->ggtt.vm,NULL ); + vma =i915_vma_instance (obj, &to_gt (i915)->ggtt->vm,NULL );if (IS_ERR (vma)) { err =PTR_ERR (vma); goto err;drivers/gpu/drm/i915/selftests/i915_vma.c +1
-1@@ -967,7 +967,7 @@ static int igt_vma_remapped_gtt(void *arg)intel_wakeref_t wakeref;int err =0 ; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ; obj =i915_gem_object_create_internal (i915,10 *10 *PAGE_SIZE );drivers/gpu/drm/i915/selftests/mock_gem_device.c +0
-0
drivers/gpu/drm/i915/selftests/mock_gem_device.c static void mock_device_release(struct drm_device *dev) · line 75
Quoted 8 lines
drivers/gpu/drm/i915/selftests/mock_gem_device.c +1
-1@@ -69,7 +69,7 @@ static void mock_device_release(struct drm_device *dev)i915_gem_drain_workqueue (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (&i915->ggtt); +mock_fini_ggtt (to_gt (i915)->ggtt);destroy_workqueue (i915->wq);intel_region_ttm_device_fini (i915);
Re: [PATCH v8 14/16] drm/i915/selftests: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiQuoted 10 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>
Quoted 121 lines
--- drivers/gpu/drm/i915/selftests/i915_gem.c | 8 ++++---- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 6 +++--- drivers/gpu/drm/i915/selftests/i915_request.c | 2 +- drivers/gpu/drm/i915/selftests/i915_vma.c | 2 +- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)drivers/gpu/drm/i915/selftests/i915_gem.c +4
-4@@ -41,7 +41,7 @@ static int switch_to_context(struct i915_gem_context *ctx)static void trash_stolen (struct drm_i915_private *i915) { -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;const u64 slot = ggtt->error_capture.start;const resource_size_t size =resource_size (&i915->dsm);unsigned long page;@@ -99,7 +99,7 @@ static void igt_pm_suspend(struct drm_i915_private *i915)intel_wakeref_t wakeref; with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_suspend (&i915->ggtt); +i915_ggtt_suspend (to_gt (i915)->ggtt);i915_gem_suspend_late (i915); } }@@ -109,7 +109,7 @@ static void igt_pm_hibernate(struct drm_i915_private *i915)intel_wakeref_t wakeref; with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_suspend (&i915->ggtt); +i915_ggtt_suspend (to_gt (i915)->ggtt);i915_gem_freeze (i915);i915_gem_freeze_late (i915);@@ -125,7 +125,7 @@ static void igt_pm_resume(struct drm_i915_private *i915)* that runtime-pm just works. */ with_intel_runtime_pm(&i915->runtime_pm, wakeref) { -i915_ggtt_resume (&i915->ggtt); +i915_ggtt_resume (to_gt (i915)->ggtt);i915_gem_resume (i915); } }drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +3
-3@@ -1122,7 +1122,7 @@ static int exercise_ggtt(struct drm_i915_private *i915, u64 hole_start, u64 hole_end, unsigned long end_time)) { - struct i915_ggtt *ggtt = &i915->ggtt; + struct i915_ggtt *ggtt = to_gt(i915)->ggtt;u64 hole_start, hole_end, last =0 ;struct drm_mm_node *node;IGT_TIMEOUT (end_time);@@ -1182,7 +1182,7 @@ static int igt_ggtt_page(void *arg)const unsigned int count =PAGE_SIZE /sizeof (u32);I915_RND_STATE (prng);struct drm_i915_private *i915 = arg; -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct drm_i915_gem_object *obj;intel_wakeref_t wakeref;struct drm_mm_node tmp;@@ -2110,7 +2110,7 @@ int i915_gem_gtt_live_selftests(struct drm_i915_private *i915) SUBTEST(igt_cs_tlb), }; -GEM_BUG_ON (offset_in_page (i915->ggtt.vm.total)); +GEM_BUG_ON (offset_in_page (to_gt (i915)->ggtt->vm.total));return i915_subtests (tests, i915); }drivers/gpu/drm/i915/selftests/i915_request.c +1
-1@@ -843,7 +843,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)intel_gt_chipset_flush (to_gt (i915)); - vma =i915_vma_instance (obj, &i915->ggtt.vm,NULL ); + vma =i915_vma_instance (obj, &to_gt (i915)->ggtt->vm,NULL );if (IS_ERR (vma)) { err =PTR_ERR (vma); goto err;drivers/gpu/drm/i915/selftests/i915_vma.c +1
-1@@ -967,7 +967,7 @@ static int igt_vma_remapped_gtt(void *arg)intel_wakeref_t wakeref;int err =0 ; -if (!i915_ggtt_has_aperture (&i915->ggtt)) +if (!i915_ggtt_has_aperture (to_gt (i915)->ggtt))return 0 ; obj =i915_gem_object_create_internal (i915,10 *10 *PAGE_SIZE );drivers/gpu/drm/i915/selftests/mock_gem_device.c +1
-1@@ -69,7 +69,7 @@ static void mock_device_release(struct drm_device *dev)i915_gem_drain_workqueue (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (&i915->ggtt); +mock_fini_ggtt (to_gt (i915)->ggtt);destroy_workqueue (i915->wq);intel_region_ttm_device_fini (i915);Signature · 1 line
2.34.1
Signature · 5 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
PATCH v8 15/16 drm/i915: Use to_gt() helper for GGTT accesses
In reply to Andi ShytiFrom: Michał Winiarski <[email protected]>
GGTT is currently available both through i915->ggtt and gt->ggtt, and we eventually want to get rid of the i915->ggtt one.
Use to_gt() for all i915->ggtt accesses to help with the future refactoring.
--- drivers/gpu/drm/i915/gvt/dmabuf.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/gpu/drm/i915/i915_driver.c | 8 ++++---- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 23 ++++++++++++----------- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++--- drivers/gpu/drm/i915/i915_getparam.c | 2 +- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 8 files changed, 26 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/gvt/dmabuf.c +1 -1
@@ -84,7 +84,7 @@ static int vgpu_gem_get_pages(kfree (st);return ret; } - gtt_entries = (gen8_pte_t __iomem *)dev_priv->ggtt.gsm + + gtt_entries = (gen8_pte_t __iomem *)to_gt (dev_priv)->ggtt->gsm + (fb_info->start >>PAGE_SHIFT );for_each_sg (st->sgl, sg, page_num, i) { dma_addr_t dma_addr =
drivers/gpu/drm/i915/i915_debugfs.c +2 -2
@@ -390,9 +390,9 @@ static int i915_swizzle_info(struct seq_file *m, void *data)intel_wakeref_t wakeref;seq_printf (m,"bit6 swizzle for X-tiling = %s\n" , -swizzle_string (dev_priv->ggtt.bit_6_swizzle_x)); +swizzle_string (to_gt (dev_priv)->ggtt->bit_6_swizzle_x));seq_printf (m,"bit6 swizzle for Y-tiling = %s\n" , -swizzle_string (dev_priv->ggtt.bit_6_swizzle_y)); +swizzle_string (to_gt (dev_priv)->ggtt->bit_6_swizzle_y));if (dev_priv->quirks &QUIRK_PIN_SWIZZLED_PAGES )seq_puts (m,"L-shaped memory detected\n" );
drivers/gpu/drm/i915/i915_driver.c +4 -4
@@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)i915_perf_init (dev_priv); +intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); + ret =i915_ggtt_probe_hw (dev_priv);if (ret) goto err_perf;
@@ -587,8 +589,6 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)if (ret) goto err_ggtt; -intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); - ret =intel_gt_probe_lmem (to_gt (dev_priv));if (ret) goto err_mem_regions;
@@ -1146,7 +1146,7 @@ static int i915_drm_suspend(struct drm_device *dev)/* Must be called before GGTT is suspended. */ intel_dpt_suspend (dev_priv); -i915_ggtt_suspend (&dev_priv->ggtt); +i915_ggtt_suspend (to_gt (dev_priv)->ggtt);i915_save_display (dev_priv);
@@ -1270,7 +1270,7 @@ static int i915_drm_resume(struct drm_device *dev)if (ret)drm_err (&dev_priv->drm,"failed to re-enable GGTT\n" ); -i915_ggtt_resume (&dev_priv->ggtt); +i915_ggtt_resume (to_gt (dev_priv)->ggtt);/* Must be called after GGTT is resumed. */ intel_dpt_resume (dev_priv);
drivers/gpu/drm/i915/i915_drv.h +1 -1
@@ -1762,7 +1762,7 @@ static inline bool i915_gem_object_needs_bit17_swizzle(struct drm_i915_gem_objec {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -return i915->ggtt.bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_9_10_17 && +return to_gt (i915)->ggtt->bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_9_10_17 &&i915_gem_object_is_tiled (obj); }
drivers/gpu/drm/i915/i915_gem.c +12 -11
@@ -88,7 +88,8 @@ int i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data, struct drm_file *file) { - struct i915_ggtt *ggtt = &to_i915(dev)->ggtt; + struct drm_i915_private *i915 = to_i915(dev); +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct drm_i915_gem_get_aperture *args = data;struct i915_vma *vma;u64 pinned;
@@ -289,7 +290,7 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj, bool write) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct i915_vma *vma;struct i915_gem_ww_ctx ww;int ret;
@@ -350,7 +351,7 @@ static void i915_gem_gtt_cleanup(struct drm_i915_gem_object *obj, struct i915_vma *vma) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;i915_gem_object_unpin_pages (obj);if (drm_mm_node_allocated (node)) {
@@ -366,7 +367,7 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj, const struct drm_i915_gem_pread *args) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;intel_wakeref_t wakeref;struct drm_mm_node node;void __user *user_data;
@@ -522,7 +523,7 @@ i915_gem_gtt_pwrite_fast(struct drm_i915_gem_object *obj, const struct drm_i915_gem_pwrite *args) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct intel_runtime_pm *rpm = &i915->runtime_pm;intel_wakeref_t wakeref;struct drm_mm_node node;
@@ -823,7 +824,7 @@ void i915_gem_runtime_suspend(struct drm_i915_private *i915)*/ list_for_each_entry_safe (obj, on, - &i915->ggtt.userfault_list, userfault_link) + &to_gt (i915)->ggtt->userfault_list, userfault_link)__i915_gem_object_release_mmap_gtt (obj);/*
@@ -831,8 +832,8 @@ void i915_gem_runtime_suspend(struct drm_i915_private *i915)* in use by hardware (i.e. they are pinned), we should not be powering * down! All other fences will be reacquired by the user upon waking. */ -for (i =0 ; i < i915->ggtt.num_fences; i++) { -struct i915_fence_reg *reg = &i915->ggtt.fence_regs[i]; +for (i =0 ; i <to_gt (i915)->ggtt->num_fences; i++) { +struct i915_fence_reg *reg = &to_gt (i915)->ggtt->fence_regs[i];/* * Ideally we want to assert that the fence register is not
@@ -873,7 +874,7 @@ i915_gem_object_ggtt_pin_ww(struct drm_i915_gem_object *obj, u64 size, u64 alignment, u64 flags) { struct drm_i915_private *i915 = to_i915(obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct i915_vma *vma;int ret;
@@ -1101,7 +1102,7 @@ int i915_gem_init(struct drm_i915_private *dev_priv)/* Minimal basic recovery for KMS */ ret =i915_ggtt_enable_hw (dev_priv); -i915_ggtt_resume (&dev_priv->ggtt); +i915_ggtt_resume (to_gt (dev_priv)->ggtt);intel_init_clock_gating (dev_priv); }
@@ -1124,7 +1125,7 @@ void i915_gem_driver_unregister(struct drm_i915_private *i915)void i915_gem_driver_remove (struct drm_i915_private *dev_priv) { -intel_wakeref_auto_fini (&dev_priv->ggtt.userfault_wakeref); +intel_wakeref_auto_fini (&to_gt (dev_priv)->ggtt->userfault_wakeref);i915_gem_suspend_late (dev_priv);intel_gt_driver_remove (to_gt (dev_priv));
drivers/gpu/drm/i915/i915_gem_gtt.c +3 -3
@@ -56,7 +56,7 @@ void i915_gem_gtt_finish_pages(struct drm_i915_gem_object *obj, struct sg_table *pages) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;/* XXX This does not prevent more requests being submitted! */ if (unlikely (ggtt->do_idle_maps))
@@ -103,7 +103,7 @@ int i915_gem_gtt_reserve(struct i915_address_space *vm,GEM_BUG_ON (!IS_ALIGNED (size,I915_GTT_PAGE_SIZE ));GEM_BUG_ON (!IS_ALIGNED (offset,I915_GTT_MIN_ALIGNMENT ));GEM_BUG_ON (range_overflows (offset, size, vm->total)); -GEM_BUG_ON (vm == &vm->i915->ggtt.alias->vm); +GEM_BUG_ON (vm == &to_gt (vm->i915)->ggtt->alias->vm);GEM_BUG_ON (drm_mm_node_allocated (node)); node->size = size;
@@ -201,7 +201,7 @@ int i915_gem_gtt_insert(struct i915_address_space *vm,GEM_BUG_ON (start >= end);GEM_BUG_ON (start >0 && !IS_ALIGNED (start,I915_GTT_PAGE_SIZE ));GEM_BUG_ON (end <U64_MAX && !IS_ALIGNED (end,I915_GTT_PAGE_SIZE )); -GEM_BUG_ON (vm == &vm->i915->ggtt.alias->vm); +GEM_BUG_ON (vm == &to_gt (vm->i915)->ggtt->alias->vm);GEM_BUG_ON (drm_mm_node_allocated (node));if (unlikely (range_overflows (start, size, end)))
drivers/gpu/drm/i915/i915_getparam.c +1 -1
@@ -31,7 +31,7 @@ int i915_getparam_ioctl(struct drm_device *dev, void *data, value = pdev->revision;break ;case I915_PARAM_NUM_FENCES_AVAIL : - value = i915->ggtt.num_fences; + value =to_gt (i915)->ggtt->num_fences;break ;case I915_PARAM_HAS_OVERLAY : value = !!i915->overlay;
drivers/gpu/drm/i915/i915_perf.c +2 -2
@@ -1630,7 +1630,7 @@ static int alloc_noa_wait(struct i915_perf_stream *stream)struct drm_i915_gem_object *bo;struct i915_vma *vma;const u64 delay_ticks =0xffffffffffffffff - -intel_gt_ns_to_clock_interval (stream->perf->i915->ggtt.vm.gt, +intel_gt_ns_to_clock_interval (to_gt (stream->perf->i915)->ggtt->vm.gt,atomic64_read (&stream->perf->noa_programming_delay));const u32 base = stream->engine->mmio_base;#define CS_GPR (x) GEN8_RING_CS_GPR(base, x)
@@ -3542,7 +3542,7 @@ i915_perf_open_ioctl_locked(struct i915_perf *perf,static u64 oa_exponent_to_ns (struct i915_perf *perf,int exponent) { -return intel_gt_clock_interval_to_ns (perf->i915->ggtt.vm.gt, +return intel_gt_clock_interval_to_ns (to_gt (perf->i915)->ggtt->vm.gt,2ULL << exponent); }
Signature · 1 line
2.34.1
Re: [PATCH v8 15/16] drm/i915: Use to_gt() helper for GGTT accesses
Quoted 55 lines · Andi Shyti
From: Michał Winiarski <[email protected]>
GGTT is currently available both through
i915->ggttandgt->ggtt, and we eventually want to get rid of thei915->ggttone.
Useto_gt()for alli915->ggttaccesses to help with the future refactoring.Signed-off-by Michał Winiarski <[email protected]>Cc Michal Wajdeczko <[email protected]>Signed-off-by Andi Shyti <[email protected]>--- drivers/gpu/drm/i915/gvt/dmabuf.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/gpu/drm/i915/i915_driver.c | 8 ++++---- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 23 ++++++++++++----------- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++--- drivers/gpu/drm/i915/i915_getparam.c | 2 +- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 8 files changed, 26 insertions(+), 25 deletions(-)drivers/gpu/drm/i915/gvt/dmabuf.c +1
-1@@ -84,7 +84,7 @@ static int vgpu_gem_get_pages(kfree (st);return ret; } - gtt_entries = (gen8_pte_t __iomem *)dev_priv->ggtt.gsm + + gtt_entries = (gen8_pte_t __iomem *)to_gt (dev_priv)->ggtt->gsm + (fb_info->start >>PAGE_SHIFT );for_each_sg (st->sgl, sg, page_num, i) { dma_addr_t dma_addr =drivers/gpu/drm/i915/i915_debugfs.c +2
-2@@ -390,9 +390,9 @@ static int i915_swizzle_info(struct seq_file *m, void *data)intel_wakeref_t wakeref;seq_printf (m,"bit6 swizzle for X-tiling = %s\n" , -swizzle_string (dev_priv->ggtt.bit_6_swizzle_x)); +swizzle_string (to_gt (dev_priv)->ggtt->bit_6_swizzle_x));seq_printf (m,"bit6 swizzle for Y-tiling = %s\n" , -swizzle_string (dev_priv->ggtt.bit_6_swizzle_y)); +swizzle_string (to_gt (dev_priv)->ggtt->bit_6_swizzle_y));if (dev_priv->quirks &QUIRK_PIN_SWIZZLED_PAGES )seq_puts (m,"L-shaped memory detected\n" );drivers/gpu/drm/i915/i915_driver.c +0
-0
drivers/gpu/drm/i915/i915_driver.c static int i915_driver_hw_probe(struct drm_i915_private *dev_priv) · line 575
Quoted 5 lines
drivers/gpu/drm/i915/i915_driver.c +2
-0@@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)i915_perf_init (dev_priv); +intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); +
Does moving this call earlier in the function need to happen in patch #13 rather than here? That patch converts the internals of i915_ggtt_probe_hw() to use to_gt()->ggtt, but I believe until this patch that pointer is uninitialized.
Matt
Quoted 209 lines
drivers/gpu/drm/i915/i915_driver.c +2
-4ret =i915_ggtt_probe_hw (dev_priv);if (ret) goto err_perf;@@ -587,8 +589,6 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)if (ret) goto err_ggtt; -intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); - ret =intel_gt_probe_lmem (to_gt (dev_priv));if (ret) goto err_mem_regions;@@ -1146,7 +1146,7 @@ static int i915_drm_suspend(struct drm_device *dev)/* Must be called before GGTT is suspended. */ intel_dpt_suspend (dev_priv); -i915_ggtt_suspend (&dev_priv->ggtt); +i915_ggtt_suspend (to_gt (dev_priv)->ggtt);i915_save_display (dev_priv);@@ -1270,7 +1270,7 @@ static int i915_drm_resume(struct drm_device *dev)if (ret)drm_err (&dev_priv->drm,"failed to re-enable GGTT\n" ); -i915_ggtt_resume (&dev_priv->ggtt); +i915_ggtt_resume (to_gt (dev_priv)->ggtt);/* Must be called after GGTT is resumed. */ intel_dpt_resume (dev_priv);drivers/gpu/drm/i915/i915_drv.h +1
-1@@ -1762,7 +1762,7 @@ static inline bool i915_gem_object_needs_bit17_swizzle(struct drm_i915_gem_objec {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -return i915->ggtt.bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_9_10_17 && +return to_gt (i915)->ggtt->bit_6_swizzle_x ==I915_BIT_6_SWIZZLE_9_10_17 &&i915_gem_object_is_tiled (obj); }drivers/gpu/drm/i915/i915_gem.c +12
-11@@ -88,7 +88,8 @@ int i915_gem_get_aperture_ioctl(struct drm_device *dev, void *data, struct drm_file *file) { - struct i915_ggtt *ggtt = &to_i915(dev)->ggtt; + struct drm_i915_private *i915 = to_i915(dev); +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct drm_i915_gem_get_aperture *args = data;struct i915_vma *vma;u64 pinned;@@ -289,7 +290,7 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj, bool write) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct i915_vma *vma;struct i915_gem_ww_ctx ww;int ret;@@ -350,7 +351,7 @@ static void i915_gem_gtt_cleanup(struct drm_i915_gem_object *obj, struct i915_vma *vma) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;i915_gem_object_unpin_pages (obj);if (drm_mm_node_allocated (node)) {@@ -366,7 +367,7 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj, const struct drm_i915_gem_pread *args) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;intel_wakeref_t wakeref;struct drm_mm_node node;void __user *user_data;@@ -522,7 +523,7 @@ i915_gem_gtt_pwrite_fast(struct drm_i915_gem_object *obj, const struct drm_i915_gem_pwrite *args) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct intel_runtime_pm *rpm = &i915->runtime_pm;intel_wakeref_t wakeref;struct drm_mm_node node;@@ -823,7 +824,7 @@ void i915_gem_runtime_suspend(struct drm_i915_private *i915)*/ list_for_each_entry_safe (obj, on, - &i915->ggtt.userfault_list, userfault_link) + &to_gt (i915)->ggtt->userfault_list, userfault_link)__i915_gem_object_release_mmap_gtt (obj);/* @@ -831,8 +832,8 @@ void i915_gem_runtime_suspend(struct drm_i915_private *i915)* in use by hardware (i.e. they are pinned), we should not be powering * down! All other fences will be reacquired by the user upon waking. */ -for (i =0 ; i < i915->ggtt.num_fences; i++) { -struct i915_fence_reg *reg = &i915->ggtt.fence_regs[i]; +for (i =0 ; i <to_gt (i915)->ggtt->num_fences; i++) { +struct i915_fence_reg *reg = &to_gt (i915)->ggtt->fence_regs[i];/* * Ideally we want to assert that the fence register is not @@ -873,7 +874,7 @@ i915_gem_object_ggtt_pin_ww(struct drm_i915_gem_object *obj, u64 size, u64 alignment, u64 flags) { struct drm_i915_private *i915 = to_i915(obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;struct i915_vma *vma;int ret;@@ -1101,7 +1102,7 @@ int i915_gem_init(struct drm_i915_private *dev_priv)/* Minimal basic recovery for KMS */ ret =i915_ggtt_enable_hw (dev_priv); -i915_ggtt_resume (&dev_priv->ggtt); +i915_ggtt_resume (to_gt (dev_priv)->ggtt);intel_init_clock_gating (dev_priv); }@@ -1124,7 +1125,7 @@ void i915_gem_driver_unregister(struct drm_i915_private *i915)void i915_gem_driver_remove (struct drm_i915_private *dev_priv) { -intel_wakeref_auto_fini (&dev_priv->ggtt.userfault_wakeref); +intel_wakeref_auto_fini (&to_gt (dev_priv)->ggtt->userfault_wakeref);i915_gem_suspend_late (dev_priv);intel_gt_driver_remove (to_gt (dev_priv));drivers/gpu/drm/i915/i915_gem_gtt.c +3
-3@@ -56,7 +56,7 @@ void i915_gem_gtt_finish_pages(struct drm_i915_gem_object *obj, struct sg_table *pages) {struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct i915_ggtt *ggtt = &i915->ggtt; +struct i915_ggtt *ggtt =to_gt (i915)->ggtt;/* XXX This does not prevent more requests being submitted! */ if (unlikely (ggtt->do_idle_maps))@@ -103,7 +103,7 @@ int i915_gem_gtt_reserve(struct i915_address_space *vm,GEM_BUG_ON (!IS_ALIGNED (size,I915_GTT_PAGE_SIZE ));GEM_BUG_ON (!IS_ALIGNED (offset,I915_GTT_MIN_ALIGNMENT ));GEM_BUG_ON (range_overflows (offset, size, vm->total)); -GEM_BUG_ON (vm == &vm->i915->ggtt.alias->vm); +GEM_BUG_ON (vm == &to_gt (vm->i915)->ggtt->alias->vm);GEM_BUG_ON (drm_mm_node_allocated (node)); node->size = size;@@ -201,7 +201,7 @@ int i915_gem_gtt_insert(struct i915_address_space *vm,GEM_BUG_ON (start >= end);GEM_BUG_ON (start >0 && !IS_ALIGNED (start,I915_GTT_PAGE_SIZE ));GEM_BUG_ON (end <U64_MAX && !IS_ALIGNED (end,I915_GTT_PAGE_SIZE )); -GEM_BUG_ON (vm == &vm->i915->ggtt.alias->vm); +GEM_BUG_ON (vm == &to_gt (vm->i915)->ggtt->alias->vm);GEM_BUG_ON (drm_mm_node_allocated (node));if (unlikely (range_overflows (start, size, end)))drivers/gpu/drm/i915/i915_getparam.c +1
-1@@ -31,7 +31,7 @@ int i915_getparam_ioctl(struct drm_device *dev, void *data, value = pdev->revision;break ;case I915_PARAM_NUM_FENCES_AVAIL : - value = i915->ggtt.num_fences; + value =to_gt (i915)->ggtt->num_fences;break ;case I915_PARAM_HAS_OVERLAY : value = !!i915->overlay;drivers/gpu/drm/i915/i915_perf.c +2
-2@@ -1630,7 +1630,7 @@ static int alloc_noa_wait(struct i915_perf_stream *stream)struct drm_i915_gem_object *bo;struct i915_vma *vma;const u64 delay_ticks =0xffffffffffffffff - -intel_gt_ns_to_clock_interval (stream->perf->i915->ggtt.vm.gt, +intel_gt_ns_to_clock_interval (to_gt (stream->perf->i915)->ggtt->vm.gt,atomic64_read (&stream->perf->noa_programming_delay));const u32 base = stream->engine->mmio_base;#define CS_GPR (x) GEN8_RING_CS_GPR(base, x)@@ -3542,7 +3542,7 @@ i915_perf_open_ioctl_locked(struct i915_perf *perf,static u64 oa_exponent_to_ns (struct i915_perf *perf,int exponent) { -return intel_gt_clock_interval_to_ns (perf->i915->ggtt.vm.gt, +return intel_gt_clock_interval_to_ns (to_gt (perf->i915)->ggtt->vm.gt,2ULL << exponent); }Signature · 1 line
2.34.1
Signature · 5 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
Re: [PATCH v8 15/16] drm/i915: Use to_gt() helper for GGTT accesses
Hi Matt,
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)i915_perf_init (dev_priv);
Quoted 7 lines
drivers/gpu/drm/i915/i915_driver.c static int i915_driver_hw_probe(struct drm_i915_private *dev_priv) · line 575
Quoted 2 lines
drivers/gpu/drm/i915/i915_driver.c +2
-0+intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); +Does moving this call earlier in the function need to happen in patch #13 rather than here? That patch converts the internals of
i915_ggtt_probe_hw()to use to_gt()->ggtt, but I believe until this patch that pointer is uninitialized.
yes... you cought me lazy... I will move it to #13.
Thanks,
Andi
PATCH v8 16/16 drm/i915: Remove unused i915->ggtt
In reply to Andi ShytiThe reference to the GGTT from the private date is not used anymore. Remove it.
--- drivers/gpu/drm/i915/gt/intel_gt.c | 7 +++++-- drivers/gpu/drm/i915/gt/intel_gt.h | 2 +- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_drv.h | 2 -- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 20 ++++++++++--------- drivers/gpu/drm/i915/selftests/i915_vma.c | 20 ++++++++++--------- .../gpu/drm/i915/selftests/mock_gem_device.c | 9 +++++++-- drivers/gpu/drm/i915/selftests/mock_gtt.c | 9 ++++----- drivers/gpu/drm/i915/selftests/mock_gtt.h | 3 ++- 9 files changed, 44 insertions(+), 32 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt.c +5 -2
@@ -3,6 +3,7 @@* Copyright © 2019 Intel Corporation */ +#include <drm/drm_managed.h> #include <drm/intel-gtt.h> #include "intel_gt_debugfs.h"
@@ -85,9 +86,11 @@ int intel_gt_probe_lmem(struct intel_gt *gt)return 0 ; } -void intel_gt_init_hw_early (struct intel_gt *gt,struct i915_ggtt *ggtt) +int intel_gt_assign_ggtt (struct intel_gt *gt) { - gt->ggtt = ggtt; + gt->ggtt =drmm_kzalloc (>->i915->drm,sizeof (*gt->ggtt),GFP_KERNEL ); + +return gt->ggtt ?0 : -ENOMEM ; }static const struct intel_mmio_range icl_l3bank_steering_table[] = {
drivers/gpu/drm/i915/gt/intel_gt.h +1 -1
@@ -36,7 +36,7 @@ static inline struct intel_gt *huc_to_gt(struct intel_huc *huc)void intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915);void __intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915); -void intel_gt_init_hw_early (struct intel_gt *gt,struct i915_ggtt *ggtt); +int intel_gt_assign_ggtt (struct intel_gt *gt);int intel_gt_probe_lmem (struct intel_gt *gt);int intel_gt_init_mmio (struct intel_gt *gt);int __must_check intel_gt_init_hw (struct intel_gt *gt);
drivers/gpu/drm/i915/i915_driver.c +3 -1
@@ -571,7 +571,9 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)i915_perf_init (dev_priv); -intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); + ret =intel_gt_assign_ggtt (to_gt (dev_priv)); +if (ret) + goto err_perf; ret =i915_ggtt_probe_hw (dev_priv);if (ret)
drivers/gpu/drm/i915/i915_drv.h +0 -2
@@ -838,8 +838,6 @@ struct drm_i915_private {struct drm_atomic_state *modeset_restore_state;struct drm_modeset_acquire_ctx reset_ctx; -struct i915_ggtt ggtt;/* VM representing the global address space */ -struct i915_gem_mm mm;/* Kernel Modesetting */
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +11 -9
@@ -1737,26 +1737,28 @@ int i915_gem_gtt_mock_selftests(void) SUBTEST(igt_gtt_insert), };struct drm_i915_private *i915; -struct i915_ggtt *ggtt; +struct intel_gt *gt;int err; i915 =mock_gem_device ();if (!i915)return -ENOMEM ; - ggtt =kmalloc (sizeof (*ggtt),GFP_KERNEL ); -if (!ggtt) { - err = -ENOMEM ; +/* allocate the ggtt */ + err =intel_gt_assign_ggtt (to_gt (i915)); +if (err) goto out_put; - } -mock_init_ggtt (i915, ggtt); - err =i915_subtests (tests, ggtt); + gt =to_gt (i915); + +mock_init_ggtt (gt); + + err =i915_subtests (tests, gt->ggtt);mock_device_flush (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (ggtt); -kfree (ggtt); +mock_fini_ggtt (gt->ggtt); + out_put:mock_destroy_device (i915);return err;
drivers/gpu/drm/i915/selftests/i915_vma.c +11 -9
@@ -907,26 +907,28 @@ int i915_vma_mock_selftests(void) SUBTEST(igt_vma_partial), };struct drm_i915_private *i915; -struct i915_ggtt *ggtt; +struct intel_gt *gt;int err; i915 =mock_gem_device ();if (!i915)return -ENOMEM ; - ggtt =kmalloc (sizeof (*ggtt),GFP_KERNEL ); -if (!ggtt) { - err = -ENOMEM ; +/* allocate the ggtt */ + err =intel_gt_assign_ggtt (to_gt (i915)); +if (err) goto out_put; - } -mock_init_ggtt (i915, ggtt); - err =i915_subtests (tests, ggtt); + gt =to_gt (i915); + +mock_init_ggtt (gt); + + err =i915_subtests (tests, gt->ggtt);mock_device_flush (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (ggtt); -kfree (ggtt); +mock_fini_ggtt (gt->ggtt); + out_put:mock_destroy_device (i915);return err;
drivers/gpu/drm/i915/selftests/mock_gem_device.c +7 -2
@@ -194,8 +194,13 @@ struct drm_i915_private *mock_gem_device(void)mock_init_contexts (i915); -mock_init_ggtt (i915, &i915->ggtt); -to_gt (i915)->vm =i915_vm_get (&i915->ggtt.vm); +/* allocate the ggtt */ + ret =intel_gt_assign_ggtt (to_gt (i915)); +if (ret) + goto err_unlock; + +mock_init_ggtt (to_gt (i915)); +to_gt (i915)->vm =i915_vm_get (&to_gt (i915)->ggtt->vm);mkwrite_device_info (i915)->platform_engine_mask =BIT (0 );to_gt (i915)->info.engine_mask =BIT (0 );
drivers/gpu/drm/i915/selftests/mock_gtt.c +4 -5
@@ -106,12 +106,12 @@ static void mock_unbind_ggtt(struct i915_address_space *vm, { } -void mock_init_ggtt (struct drm_i915_private *i915,struct i915_ggtt *ggtt) +void mock_init_ggtt (struct intel_gt *gt) { -memset (ggtt,0 ,sizeof (*ggtt)); +struct i915_ggtt *ggtt = gt->ggtt; - ggtt->vm.gt =to_gt (i915); - ggtt->vm.i915 = i915; + ggtt->vm.gt = gt; + ggtt->vm.i915 = gt->i915; ggtt->vm.is_ggtt = true; ggtt->gmadr = (struct resource )DEFINE_RES_MEM (0 ,2048 *PAGE_SIZE );
@@ -132,7 +132,6 @@ void mock_init_ggtt(struct drm_i915_private *i915, struct i915_ggtt *ggtt) ggtt->vm.vma_ops.clear_pages = clear_pages;i915_address_space_init (&ggtt->vm,VM_CLASS_GGTT ); -to_gt (i915)->ggtt = ggtt; }void mock_fini_ggtt (struct i915_ggtt *ggtt)
drivers/gpu/drm/i915/selftests/mock_gtt.h +2 -1
@@ -27,8 +27,9 @@struct drm_i915_private ;struct i915_ggtt ; +struct intel_gt ; -void mock_init_ggtt (struct drm_i915_private *i915,struct i915_ggtt *ggtt); +void mock_init_ggtt (struct intel_gt *gt);void mock_fini_ggtt (struct i915_ggtt *ggtt);struct i915_ppgtt *mock_ppgtt (struct drm_i915_private *i915,const char *name);
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v8 16/16] drm/i915: Remove unused i915->ggtt
Quoted 2 lines · Andi Shyti
The reference to the GGTT from the private date is not used anymore. Remove it.
-Quick spellcheck for "data".
Quoted 221 lines
Suggested-by Matt Roper <[email protected]>Signed-off-by Andi Shyti <[email protected]>Cc Michał Winiarski <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gt.c | 7 +++++-- drivers/gpu/drm/i915/gt/intel_gt.h | 2 +- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_drv.h | 2 -- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 20 ++++++++++--------- drivers/gpu/drm/i915/selftests/i915_vma.c | 20 ++++++++++--------- .../gpu/drm/i915/selftests/mock_gem_device.c | 9 +++++++-- drivers/gpu/drm/i915/selftests/mock_gtt.c | 9 ++++----- drivers/gpu/drm/i915/selftests/mock_gtt.h | 3 ++- 9 files changed, 44 insertions(+), 32 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +5
-2@@ -3,6 +3,7 @@* Copyright © 2019 Intel Corporation */ +#include <drm/drm_managed.h> #include <drm/intel-gtt.h> #include "intel_gt_debugfs.h" @@ -85,9 +86,11 @@ int intel_gt_probe_lmem(struct intel_gt *gt)return 0 ; } -void intel_gt_init_hw_early (struct intel_gt *gt,struct i915_ggtt *ggtt) +int intel_gt_assign_ggtt (struct intel_gt *gt) { - gt->ggtt = ggtt; + gt->ggtt =drmm_kzalloc (>->i915->drm,sizeof (*gt->ggtt),GFP_KERNEL ); + +return gt->ggtt ?0 : -ENOMEM ; }static const struct intel_mmio_range icl_l3bank_steering_table[] = {drivers/gpu/drm/i915/gt/intel_gt.h +1
-1@@ -36,7 +36,7 @@ static inline struct intel_gt *huc_to_gt(struct intel_huc *huc)void intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915);void __intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915); -void intel_gt_init_hw_early (struct intel_gt *gt,struct i915_ggtt *ggtt); +int intel_gt_assign_ggtt (struct intel_gt *gt);int intel_gt_probe_lmem (struct intel_gt *gt);int intel_gt_init_mmio (struct intel_gt *gt);int __must_check intel_gt_init_hw (struct intel_gt *gt);drivers/gpu/drm/i915/i915_driver.c +3
-1@@ -571,7 +571,9 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)i915_perf_init (dev_priv); -intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); + ret =intel_gt_assign_ggtt (to_gt (dev_priv)); +if (ret) + goto err_perf; ret =i915_ggtt_probe_hw (dev_priv);if (ret)drivers/gpu/drm/i915/i915_drv.h +0
-2@@ -838,8 +838,6 @@ struct drm_i915_private {struct drm_atomic_state *modeset_restore_state;struct drm_modeset_acquire_ctx reset_ctx; -struct i915_ggtt ggtt;/* VM representing the global address space */ -struct i915_gem_mm mm;/* Kernel Modesetting */ drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +11
-9@@ -1737,26 +1737,28 @@ int i915_gem_gtt_mock_selftests(void) SUBTEST(igt_gtt_insert), };struct drm_i915_private *i915; -struct i915_ggtt *ggtt; +struct intel_gt *gt;int err; i915 =mock_gem_device ();if (!i915)return -ENOMEM ; - ggtt =kmalloc (sizeof (*ggtt),GFP_KERNEL ); -if (!ggtt) { - err = -ENOMEM ; +/* allocate the ggtt */ + err =intel_gt_assign_ggtt (to_gt (i915)); +if (err) goto out_put; - } -mock_init_ggtt (i915, ggtt); - err =i915_subtests (tests, ggtt); + gt =to_gt (i915); + +mock_init_ggtt (gt); + + err =i915_subtests (tests, gt->ggtt);mock_device_flush (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (ggtt); -kfree (ggtt); +mock_fini_ggtt (gt->ggtt); + out_put:mock_destroy_device (i915);return err;drivers/gpu/drm/i915/selftests/i915_vma.c +11
-9@@ -907,26 +907,28 @@ int i915_vma_mock_selftests(void) SUBTEST(igt_vma_partial), };struct drm_i915_private *i915; -struct i915_ggtt *ggtt; +struct intel_gt *gt;int err; i915 =mock_gem_device ();if (!i915)return -ENOMEM ; - ggtt =kmalloc (sizeof (*ggtt),GFP_KERNEL ); -if (!ggtt) { - err = -ENOMEM ; +/* allocate the ggtt */ + err =intel_gt_assign_ggtt (to_gt (i915)); +if (err) goto out_put; - } -mock_init_ggtt (i915, ggtt); - err =i915_subtests (tests, ggtt); + gt =to_gt (i915); + +mock_init_ggtt (gt); + + err =i915_subtests (tests, gt->ggtt);mock_device_flush (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (ggtt); -kfree (ggtt); +mock_fini_ggtt (gt->ggtt); + out_put:mock_destroy_device (i915);return err;drivers/gpu/drm/i915/selftests/mock_gem_device.c +7
-2@@ -194,8 +194,13 @@ struct drm_i915_private *mock_gem_device(void)mock_init_contexts (i915); -mock_init_ggtt (i915, &i915->ggtt); -to_gt (i915)->vm =i915_vm_get (&i915->ggtt.vm); +/* allocate the ggtt */ + ret =intel_gt_assign_ggtt (to_gt (i915)); +if (ret) + goto err_unlock; + +mock_init_ggtt (to_gt (i915)); +to_gt (i915)->vm =i915_vm_get (&to_gt (i915)->ggtt->vm);mkwrite_device_info (i915)->platform_engine_mask =BIT (0 );to_gt (i915)->info.engine_mask =BIT (0 );drivers/gpu/drm/i915/selftests/mock_gtt.c +4
-5@@ -106,12 +106,12 @@ static void mock_unbind_ggtt(struct i915_address_space *vm, { } -void mock_init_ggtt (struct drm_i915_private *i915,struct i915_ggtt *ggtt) +void mock_init_ggtt (struct intel_gt *gt) { -memset (ggtt,0 ,sizeof (*ggtt)); +struct i915_ggtt *ggtt = gt->ggtt; - ggtt->vm.gt =to_gt (i915); - ggtt->vm.i915 = i915; + ggtt->vm.gt = gt; + ggtt->vm.i915 = gt->i915; ggtt->vm.is_ggtt = true; ggtt->gmadr = (struct resource )DEFINE_RES_MEM (0 ,2048 *PAGE_SIZE );@@ -132,7 +132,6 @@ void mock_init_ggtt(struct drm_i915_private *i915, struct i915_ggtt *ggtt) ggtt->vm.vma_ops.clear_pages = clear_pages;i915_address_space_init (&ggtt->vm,VM_CLASS_GGTT ); -to_gt (i915)->ggtt = ggtt; }void mock_fini_ggtt (struct i915_ggtt *ggtt)drivers/gpu/drm/i915/selftests/mock_gtt.h +0
-0
drivers/gpu/drm/i915/selftests/mock_gtt.h line 35
Quoted 10 lines
drivers/gpu/drm/i915/selftests/mock_gtt.h +2
-1@@ -27,8 +27,9 @@struct drm_i915_private ;struct i915_ggtt ; +struct intel_gt ; -void mock_init_ggtt (struct drm_i915_private *i915,struct i915_ggtt *ggtt); +void mock_init_ggtt (struct intel_gt *gt);void mock_fini_ggtt (struct i915_ggtt *ggtt);struct i915_ppgtt *mock_ppgtt (struct drm_i915_private *i915,const char *name);
Seems like a straightforward change.
Re: [PATCH v8 16/16] drm/i915: Remove unused i915->ggtt
In reply to Andi ShytiQuoted 2 lines · Andi Shyti
The reference to the GGTT from the private date is not used anymore. Remove it.
You may want to also mention here that tile0's ggtt will now be dynamically allocated (and auto-deallocated on driver unload by the drmm_* infrastructure).
Otherwise,
Matt
Quoted 234 lines
Suggested-by Matt Roper <[email protected]>Signed-off-by Andi Shyti <[email protected]>Cc Michał Winiarski <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gt.c | 7 +++++-- drivers/gpu/drm/i915/gt/intel_gt.h | 2 +- drivers/gpu/drm/i915/i915_driver.c | 4 +++- drivers/gpu/drm/i915/i915_drv.h | 2 -- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 20 ++++++++++--------- drivers/gpu/drm/i915/selftests/i915_vma.c | 20 ++++++++++--------- .../gpu/drm/i915/selftests/mock_gem_device.c | 9 +++++++-- drivers/gpu/drm/i915/selftests/mock_gtt.c | 9 ++++----- drivers/gpu/drm/i915/selftests/mock_gtt.h | 3 ++- 9 files changed, 44 insertions(+), 32 deletions(-)drivers/gpu/drm/i915/gt/intel_gt.c +5
-2@@ -3,6 +3,7 @@* Copyright © 2019 Intel Corporation */ +#include <drm/drm_managed.h> #include <drm/intel-gtt.h> #include "intel_gt_debugfs.h" @@ -85,9 +86,11 @@ int intel_gt_probe_lmem(struct intel_gt *gt)return 0 ; } -void intel_gt_init_hw_early (struct intel_gt *gt,struct i915_ggtt *ggtt) +int intel_gt_assign_ggtt (struct intel_gt *gt) { - gt->ggtt = ggtt; + gt->ggtt =drmm_kzalloc (>->i915->drm,sizeof (*gt->ggtt),GFP_KERNEL ); + +return gt->ggtt ?0 : -ENOMEM ; }static const struct intel_mmio_range icl_l3bank_steering_table[] = {drivers/gpu/drm/i915/gt/intel_gt.h +1
-1@@ -36,7 +36,7 @@ static inline struct intel_gt *huc_to_gt(struct intel_huc *huc)void intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915);void __intel_gt_init_early (struct intel_gt *gt,struct drm_i915_private *i915); -void intel_gt_init_hw_early (struct intel_gt *gt,struct i915_ggtt *ggtt); +int intel_gt_assign_ggtt (struct intel_gt *gt);int intel_gt_probe_lmem (struct intel_gt *gt);int intel_gt_init_mmio (struct intel_gt *gt);int __must_check intel_gt_init_hw (struct intel_gt *gt);drivers/gpu/drm/i915/i915_driver.c +3
-1@@ -571,7 +571,9 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)i915_perf_init (dev_priv); -intel_gt_init_hw_early (to_gt (dev_priv), &dev_priv->ggtt); + ret =intel_gt_assign_ggtt (to_gt (dev_priv)); +if (ret) + goto err_perf; ret =i915_ggtt_probe_hw (dev_priv);if (ret)drivers/gpu/drm/i915/i915_drv.h +0
-2@@ -838,8 +838,6 @@ struct drm_i915_private {struct drm_atomic_state *modeset_restore_state;struct drm_modeset_acquire_ctx reset_ctx; -struct i915_ggtt ggtt;/* VM representing the global address space */ -struct i915_gem_mm mm;/* Kernel Modesetting */ drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +11
-9@@ -1737,26 +1737,28 @@ int i915_gem_gtt_mock_selftests(void) SUBTEST(igt_gtt_insert), };struct drm_i915_private *i915; -struct i915_ggtt *ggtt; +struct intel_gt *gt;int err; i915 =mock_gem_device ();if (!i915)return -ENOMEM ; - ggtt =kmalloc (sizeof (*ggtt),GFP_KERNEL ); -if (!ggtt) { - err = -ENOMEM ; +/* allocate the ggtt */ + err =intel_gt_assign_ggtt (to_gt (i915)); +if (err) goto out_put; - } -mock_init_ggtt (i915, ggtt); - err =i915_subtests (tests, ggtt); + gt =to_gt (i915); + +mock_init_ggtt (gt); + + err =i915_subtests (tests, gt->ggtt);mock_device_flush (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (ggtt); -kfree (ggtt); +mock_fini_ggtt (gt->ggtt); + out_put:mock_destroy_device (i915);return err;drivers/gpu/drm/i915/selftests/i915_vma.c +11
-9@@ -907,26 +907,28 @@ int i915_vma_mock_selftests(void) SUBTEST(igt_vma_partial), };struct drm_i915_private *i915; -struct i915_ggtt *ggtt; +struct intel_gt *gt;int err; i915 =mock_gem_device ();if (!i915)return -ENOMEM ; - ggtt =kmalloc (sizeof (*ggtt),GFP_KERNEL ); -if (!ggtt) { - err = -ENOMEM ; +/* allocate the ggtt */ + err =intel_gt_assign_ggtt (to_gt (i915)); +if (err) goto out_put; - } -mock_init_ggtt (i915, ggtt); - err =i915_subtests (tests, ggtt); + gt =to_gt (i915); + +mock_init_ggtt (gt); + + err =i915_subtests (tests, gt->ggtt);mock_device_flush (i915);i915_gem_drain_freed_objects (i915); -mock_fini_ggtt (ggtt); -kfree (ggtt); +mock_fini_ggtt (gt->ggtt); + out_put:mock_destroy_device (i915);return err;drivers/gpu/drm/i915/selftests/mock_gem_device.c +7
-2@@ -194,8 +194,13 @@ struct drm_i915_private *mock_gem_device(void)mock_init_contexts (i915); -mock_init_ggtt (i915, &i915->ggtt); -to_gt (i915)->vm =i915_vm_get (&i915->ggtt.vm); +/* allocate the ggtt */ + ret =intel_gt_assign_ggtt (to_gt (i915)); +if (ret) + goto err_unlock; + +mock_init_ggtt (to_gt (i915)); +to_gt (i915)->vm =i915_vm_get (&to_gt (i915)->ggtt->vm);mkwrite_device_info (i915)->platform_engine_mask =BIT (0 );to_gt (i915)->info.engine_mask =BIT (0 );drivers/gpu/drm/i915/selftests/mock_gtt.c +4
-5@@ -106,12 +106,12 @@ static void mock_unbind_ggtt(struct i915_address_space *vm, { } -void mock_init_ggtt (struct drm_i915_private *i915,struct i915_ggtt *ggtt) +void mock_init_ggtt (struct intel_gt *gt) { -memset (ggtt,0 ,sizeof (*ggtt)); +struct i915_ggtt *ggtt = gt->ggtt; - ggtt->vm.gt =to_gt (i915); - ggtt->vm.i915 = i915; + ggtt->vm.gt = gt; + ggtt->vm.i915 = gt->i915; ggtt->vm.is_ggtt = true; ggtt->gmadr = (struct resource )DEFINE_RES_MEM (0 ,2048 *PAGE_SIZE );@@ -132,7 +132,6 @@ void mock_init_ggtt(struct drm_i915_private *i915, struct i915_ggtt *ggtt) ggtt->vm.vma_ops.clear_pages = clear_pages;i915_address_space_init (&ggtt->vm,VM_CLASS_GGTT ); -to_gt (i915)->ggtt = ggtt; }void mock_fini_ggtt (struct i915_ggtt *ggtt)drivers/gpu/drm/i915/selftests/mock_gtt.h +2
-1@@ -27,8 +27,9 @@struct drm_i915_private ;struct i915_ggtt ; +struct intel_gt ; -void mock_init_ggtt (struct drm_i915_private *i915,struct i915_ggtt *ggtt); +void mock_init_ggtt (struct intel_gt *gt);void mock_fini_ggtt (struct i915_ggtt *ggtt);struct i915_ppgtt *mock_ppgtt (struct drm_i915_private *i915,const char *name);Signature · 1 line
2.34.1
Signature · 5 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More preparation for multi gt patches
In reply to Andi Shyti== Series Details ==
== Series Details ==
Series: More preparation for multi gt patches
URL : https://patchwork.freedesktop.org/series/98032/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 9213cee2d3f1 drm/i915: Store backpointer to GT in uncore 03c38fe5890e drm/i915: Introduce to_gt() helper 3396a9399332 drm/i915/display: Use to_gt() helper c55e7cf11a96 drm/i915/gt: Use to_gt() helper c76f51bbcc77 drm/i915/gem: Use to_gt() helper 8080a5ab6c26 drm/i915/gvt: Use to_gt() helper 15c86f199591 drm/i915/selftests: Use to_gt() helper 157bd8ae7fcb drm/i915/pxp: Use to_gt() helper 5208b9d94f5e drm/i915: Use to_gt() helper 3168444a49c9 drm/i915: Rename i915->gt to i915->gt0 816cc046ac41 drm/i915/gem: Use to_gt() helper for GGTT accesses -:302: WARNING:LONG_LINE: line length of 112 exceeds 100 columns #302: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:323: + (1 + next_prime_number(to_gt(i915)->ggtt->vm.total >> PAGE_SHIFT)) << PAGE_SHIFT);
-:333: WARNING:LONG_LINE: line length of 112 exceeds 100 columns #333: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:460:
+ (1 + next_prime_number(to_gt(i915)->ggtt->vm.total >> PAGE_SHIFT)) << PAGE_SHIFT);
total: 0 errors, 2 warnings, 0 checks, 287 lines checked 0391dffccd54 drm/i915/display: Use to_gt() helper for GGTT accesses 3ee8899bc707 drm/i915/gt: Use to_gt() helper for GGTT accesses 5f031aaa1681 drm/i915/selftests: Use to_gt() helper for GGTT accesses b78e5bf18426 drm/i915: Use to_gt() helper for GGTT accesses 9fbfb3c53e54 drm/i915: Remove unused i915->ggtt
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More preparation for multi gt patches
In reply to Andi Shyti== Series Details ==
== Series Details ==
Series: More preparation for multi gt patches
URL : https://patchwork.freedesktop.org/series/98032/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for More preparation for multi gt patches
In reply to Andi Shyti== Series Details ==
== Series Details ==
Series: More preparation for multi gt patches
URL : https://patchwork.freedesktop.org/series/98032/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11002 -> Patchwork_21849
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/index.html
Participating hosts (46 -> 36)
------------------------------
Additional (1): fi-kbl-soraka
Missing (11): bat-dg1-6 bat-dg1-5 fi-hsw-4200u fi-icl-u2 fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-ctg-p8600 fi-bdw-samus bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21849 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-bsw-kefka: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-bsw-kefka/igt@amdgpu/[email protected]
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271]) +8 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-kbl-soraka/igt@gem_exec_fence@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][7] ([i915#1886] / [i915#2291])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][8] -> [INCOMPLETE][9] ([i915#3303])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/fi-hsw-4770/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-hsw-4770/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-kbl-soraka/igt@[email protected]
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-skl-6600u: NOTRUN -> [SKIP][12] ([fdo#109271]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#533])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-kbl-soraka/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: NOTRUN -> [FAIL][15] ([i915#4547])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][16] ([fdo#109271] / [i915#1436] / [i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-hsw-4770/igt@[email protected]
#### Possible fixes ####
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [INCOMPLETE][17] ([i915#4547]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/fi-skl-6600u/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [INCOMPLETE][19] ([i915#2940]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/fi-bsw-kefka/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-bsw-kefka/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][21] ([i915#2722] / [i915#4312]) -> [FAIL][22] ([i915#4312])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/fi-skl-6600u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/fi-skl-6600u/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11002 -> Patchwork_21849
CI-20190529: 20190529
CI_DRM_11002: 8dabbcc22a6b77b358ff35d31adbaa653ab45857 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6307: be84fe4f151bc092e068cab5cd0cd19c34948b40 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21849: 9fbfb3c53e54bb4bafce3e081a35abce076f48d3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9fbfb3c53e54 drm/i915: Remove unused i915->ggtt b78e5bf18426 drm/i915: Use to_gt() helper for GGTT accesses 5f031aaa1681 drm/i915/selftests: Use to_gt() helper for GGTT accesses 3ee8899bc707 drm/i915/gt: Use to_gt() helper for GGTT accesses 0391dffccd54 drm/i915/display: Use to_gt() helper for GGTT accesses 816cc046ac41 drm/i915/gem: Use to_gt() helper for GGTT accesses 3168444a49c9 drm/i915: Rename i915->gt to i915->gt0 5208b9d94f5e drm/i915: Use to_gt() helper157bd8ae7fcb drm/i915/pxp: Use to_gt() helper15c86f199591 drm/i915/selftests: Use to_gt() helper 8080a5ab6c26 drm/i915/gvt: Use to_gt() helperc76f51bbcc77 drm/i915/gem: Use to_gt() helperc55e7cf11a96 drm/i915/gt: Use to_gt() helper3396a9399332 drm/i915/display: Use to_gt() helper 03c38fe5890e drm/i915: Introduce to_gt() helper 9213cee2d3f1 drm/i915: Store backpointer to GT in uncore
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for More preparation for multi gt patches
In reply to Andi Shyti== Series Details ==
== Series Details ==
Series: More preparation for multi gt patches
URL : https://patchwork.freedesktop.org/series/98032/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11002_full -> Patchwork_21849_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21849_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_21849_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21849_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-skl: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl8/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_21849_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-snb: ([PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [FAIL][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53]) ([i915#4338])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][54] -> [SKIP][55] ([i915#658])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb2/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb8/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +4 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl3/igt@gem_ctx_isolation@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl4/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][58] -> [INCOMPLETE][59] ([i915#4547])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl4/igt@gem_exec_capture@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl8/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2842]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk5/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl7/igt@gem_exec_fair@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][64] -> [FAIL][65] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-tglb8/igt@gem_exec_fair@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][66] -> [FAIL][67] ([i915#2842])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl6/igt@gem_exec_fair@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][68] -> [SKIP][69] ([i915#2190])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-tglb1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@gem_lmem_swapping@parallel-multi:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#4613])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#4613]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]
* igt@gem_lmem_swapping@random-engines:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#4613])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#4613])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@gem_pxp@fail-invalid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#4270])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@gem_pxp@regular-baseline-src-copy-readible:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271]) +59 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@[email protected]
* igt@gen9_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#2856])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][78] ([i915#454])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][79] -> [FAIL][80] ([i915#454])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb7/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#4281])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][82] -> [DMESG-WARN][83] ([i915#118])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk4/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#111614]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#110725] / [fdo#111614])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#111615])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3886]) +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#111615] / [i915#3689])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#3886]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#3689])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3689] / [i915#3886])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#3886])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [fdo#111827]) +7 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [PASS][94] -> [DMESG-WARN][95] ([i915#1982])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl8/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl6/igt@[email protected]
* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109278] / [i915#1149])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109284] / [fdo#111827]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [fdo#111827]) +5 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-0-75:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109284] / [fdo#111827]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][100] ([i915#1319])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][101] ([i915#1319])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][102] ([i915#2105])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#3319])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x170-rapid-movement:
- shard-glk: NOTRUN -> [SKIP][104] ([fdo#109271]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk2/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#3359])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-32x32-onscreen:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278]) +6 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109279] / [i915#3359])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][108] -> [FAIL][109] ([i915#72])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk8/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109274] / [fdo#109278]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][111] ([fdo#111825]) +11 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-apl: [PASS][112] -> [FAIL][113] ([i915#2346])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl3/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [PASS][114] -> [FAIL][115] ([i915#2346])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb5/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-forked-move:
- shard-skl: NOTRUN -> [SKIP][116] ([fdo#109271]) +14 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@[email protected]
* igt@kms_dsc@basic-dsc-enable:
- shard-iclb: NOTRUN -> [SKIP][117] ([i915#3840])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][118] -> [INCOMPLETE][119] ([i915#180] / [i915#1982])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl8/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl1/igt@[email protected]
- shard-kbl: [PASS][120] -> [INCOMPLETE][121] ([i915#180] / [i915#636])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl4/igt@[email protected]
* igt@kms_flip@2x-blocking-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][122] ([fdo#109274]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@kms_flip@2x-blocking-wf_vblank.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][123] -> [FAIL][124] ([i915#2122]) +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl4/igt@kms_flip@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][125] -> [FAIL][126] ([i915#2122])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@kms_flip@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][127] -> [DMESG-WARN][128] ([i915#180]) +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl4/igt@kms_flip@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#2672])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-iclb: [PASS][130] -> [SKIP][131] ([i915#3701])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb2/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-skl: NOTRUN -> [SKIP][132] ([fdo#109271] / [i915#2672])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][133] ([fdo#109280]) +2 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][134] -> [FAIL][135] ([i915#1188])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl7/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl8/igt@[email protected]
* igt@kms_hdr@static-swap:
- shard-tglb: NOTRUN -> [SKIP][136] ([i915#1187])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#533])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl7/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: NOTRUN -> [DMESG-WARN][138] ([i915#180])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][139] ([fdo#108145] / [i915#265])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][140] ([fdo#108145] / [i915#265]) +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][141] ([fdo#108145] / [i915#265]) +1 similar issue
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][142] ([i915#3536])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]
* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][143] ([i915#3536])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-tglb: NOTRUN -> [SKIP][144] ([i915#2920])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-tglb: NOTRUN -> [FAIL][145] ([i915#132] / [i915#3467])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_psr@psr2_basic.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][146] -> [SKIP][147] ([fdo#109441]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][148] ([fdo#109441]) +1 similar issue
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][149] -> [FAIL][150] ([i915#31])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk6/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk1/igt@[email protected]
* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][151] ([fdo#109309])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][152] ([fdo#109271]) +77 similar issues
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][153] ([i915#2530]) +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
* igt@perf@blocking:
- shard-skl: NOTRUN -> [FAIL][154] ([i915#1542])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]
* igt@perf@enable-disable:
- shard-skl: [PASS][155] -> [FAIL][156] ([i915#1352])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl7/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl1/igt@[email protected]
* igt@sysfs_clients@fair-0:
- shard-tglb: NOTRUN -> [SKIP][157] ([i915#2994]) +1 similar issue
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][158] ([fdo#109271] / [i915#2994]) +2 similar issues
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][159] ([fdo#109271] / [i915#2994])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]
* igt@sysfs_clients@fair-7:
- shard-iclb: NOTRUN -> [SKIP][160] ([i915#2994])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]
* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][161] ([fdo#109271] / [i915#2994])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: ([PASS][162], [TIMEOUT][163]) ([i915#3063]) -> [PASS][164] +1 similar issue
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-rkl-1/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-rkl-4/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-rkl-6/igt@[email protected]
* igt@gem_ex
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/index.html
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More preparation for multi gt patches
Quoted 35 lines · Patchwork
== Series Details ==
Series: More preparation for multi gt patches
URL : https://patchwork.freedesktop.org/series/98032/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_11002_full->Patchwork_21849_full
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
Patchwork_21849_fullabsolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
Patchwork_21849_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.Participating hosts (10 -> 10)
------------------------------No changes in participating hosts
Possible new issues
-------------------Here are the unknown changes that may have been introduced in
Patchwork_21849_full:
Quoted 7 lines
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb4/igt@gem_exec_fair@[email protected]
https://gitlab.freedesktop.org/drm/intel/-/issues/2842
Quoted 5 lines
* igt@i915_suspend@sysfs-reader:
- shard-skl: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl8/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@[email protected]
Looks similar to this ADL-P issue that was seen only once:
https://gitlab.freedesktop.org/drm/intel/-/issues/4092
The first 10 patches have gone through several clean CI cycles now, so I've pushed those to drm-intel-gt-next. There are just a couple minor comments on the ggtt patches, so we can push the rest of those once the comments are addressed.
BTW, there's one i915->gt reference in the display code that has moved from display/intel_display.c to display/skl_universal_plane.c on drm-intel-next, but that movement hasn't made its way to drm-intel-gt-next yet. This led to a merge conflict while rebuilding drm-tip. I had to use a 'dim cat-to-fixup' to apply the following diff to the drm-intel-gt-next merge commit:
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 158d89b8d490..b3162f49f341 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1737,7 +1737,7 @@ static bool bo_has_valid_encryption(struct drm_i915_gem_object *obj)
{
struct drm_i915_private *i915 = to_i915(obj->base.dev);
- return intel_pxp_key_check(&i915->gt.pxp, obj, false) == 0;
+ return intel_pxp_key_check(&to_gt(i915)->pxp, obj, false) == 0;
}
static bool pxp_is_borked(struct drm_i915_gem_object *obj)Matt
Quoted 434 lines
Known issues
------------Here are the changes found in
Patchwork_21849_fullthat come from known issues:### CI changes ###
#### Issues hit ####
* boot:
- shard-snb: ([PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [FAIL][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53]) ([i915#4338])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][54] -> [SKIP][55] ([i915#658])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb2/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb8/igt@[email protected]* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +4 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl3/igt@gem_ctx_isolation@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl4/igt@gem_ctx_isolation@[email protected]* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][58] -> [INCOMPLETE][59] ([i915#4547])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl4/igt@gem_exec_capture@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl8/igt@gem_exec_capture@[email protected]* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2842]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk5/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk2/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl7/igt@gem_exec_fair@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl3/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][64] -> [FAIL][65] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-tglb8/igt@gem_exec_fair@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb3/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][66] -> [FAIL][67] ([i915#2842])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl6/igt@gem_exec_fair@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl7/igt@gem_exec_fair@[email protected]* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][68] -> [SKIP][69] ([i915#2190])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-tglb1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@gem_lmem_swapping@parallel-multi:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#4613])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#4613]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]* igt@gem_lmem_swapping@random-engines:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#4613])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]* igt@gem_lmem_swapping@smem-oom:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#4613])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@gem_pxp@fail-invalid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#4270])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@gem_pxp@regular-baseline-src-copy-readible:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271]) +59 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@[email protected]* igt@gen9_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#2856])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][78] ([i915#454])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][79] -> [FAIL][80] ([i915#454])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb7/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@i915_pm_dc@dc9-dpms:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#4281])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][82] -> [DMESG-WARN][83] ([i915#118])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk4/igt@[email protected]* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#111614]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#110725] / [fdo#111614])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#111615])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3886]) +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html* igt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#111615] / [i915#3689])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs.html* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#3886]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#3689])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3689] / [i915#3886])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#3886])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [fdo#111827]) +7 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [PASS][94] -> [DMESG-WARN][95] ([i915#1982])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl8/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl6/igt@[email protected]* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109278] / [i915#1149])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109284] / [fdo#111827]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [fdo#111827]) +5 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@[email protected]* igt@kms_color_chamelium@pipe-b-ctm-0-75:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109284] / [fdo#111827]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][100] ([i915#1319])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@[email protected]* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][101] ([i915#1319])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][102] ([i915#2105])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/igt@[email protected]* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#3319])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_cursor_crc@pipe-b-cursor-512x170-rapid-movement:
- shard-glk: NOTRUN -> [SKIP][104] ([fdo#109271]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk2/igt@[email protected]* igt@kms_cursor_crc@pipe-c-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#3359])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_cursor_crc@pipe-d-cursor-32x32-onscreen:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278]) +6 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109279] / [i915#3359])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][108] -> [FAIL][109] ([i915#72])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk8/igt@[email protected]* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109274] / [fdo#109278]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][111] ([fdo#111825]) +11 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-apl: [PASS][112] -> [FAIL][113] ([i915#2346])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl3/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [PASS][114] -> [FAIL][115] ([i915#2346])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb5/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@kms_cursor_legacy@pipe-d-forked-move:
- shard-skl: NOTRUN -> [SKIP][116] ([fdo#109271]) +14 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@[email protected]* igt@kms_dsc@basic-dsc-enable:
- shard-iclb: NOTRUN -> [SKIP][117] ([i915#3840])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@[email protected]* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][118] -> [INCOMPLETE][119] ([i915#180] / [i915#1982])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl8/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl1/igt@[email protected]
- shard-kbl: [PASS][120] -> [INCOMPLETE][121] ([i915#180] / [i915#636])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl4/igt@[email protected]* igt@kms_flip@2x-blocking-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][122] ([fdo#109274]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@kms_flip@2x-blocking-wf_vblank.html* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][123] -> [FAIL][124] ([i915#2122]) +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl4/igt@kms_flip@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@kms_flip@[email protected]* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][125] -> [FAIL][126] ([i915#2122])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@kms_flip@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk8/igt@kms_flip@[email protected]* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][127] -> [DMESG-WARN][128] ([i915#180]) +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl4/igt@kms_flip@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl8/igt@kms_flip@[email protected]* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#2672])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-iclb: [PASS][130] -> [SKIP][131] ([i915#3701])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb2/igt@[email protected]* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-skl: NOTRUN -> [SKIP][132] ([fdo#109271] / [i915#2672])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][133] ([fdo#109280]) +2 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite.html* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][134] -> [FAIL][135] ([i915#1188])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl7/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl8/igt@[email protected]* igt@kms_hdr@static-swap:
- shard-tglb: NOTRUN -> [SKIP][136] ([i915#1187])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#533])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl7/igt@[email protected]* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: NOTRUN -> [DMESG-WARN][138] ([i915#180])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl7/igt@[email protected]* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][139] ([fdo#108145] / [i915#265])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][140] ([fdo#108145] / [i915#265]) +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/igt@[email protected]* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][141] ([fdo#108145] / [i915#265]) +1 similar issue
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][142] ([i915#3536])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][143] ([i915#3536])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-tglb: NOTRUN -> [SKIP][144] ([i915#2920])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_psr@psr2_basic:
- shard-tglb: NOTRUN -> [FAIL][145] ([i915#132] / [i915#3467])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@kms_psr@psr2_basic.html* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][146] -> [SKIP][147] ([fdo#109441]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][148] ([fdo#109441]) +1 similar issue
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html* igt@kms_setmode@basic:
- shard-glk: [PASS][149] -> [FAIL][150] ([i915#31])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk6/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk1/igt@[email protected]* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][151] ([fdo#109309])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][152] ([fdo#109271]) +77 similar issues
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][153] ([i915#2530]) +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]* igt@perf@blocking:
- shard-skl: NOTRUN -> [FAIL][154] ([i915#1542])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]* igt@perf@enable-disable:
- shard-skl: [PASS][155] -> [FAIL][156] ([i915#1352])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl7/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl1/igt@[email protected]* igt@sysfs_clients@fair-0:
- shard-tglb: NOTRUN -> [SKIP][157] ([i915#2994]) +1 similar issue
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][158] ([fdo#109271] / [i915#2994]) +2 similar issues
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][159] ([fdo#109271] / [i915#2994])
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/igt@[email protected]* igt@sysfs_clients@fair-7:
- shard-iclb: NOTRUN -> [SKIP][160] ([i915#2994])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/igt@[email protected]* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][161] ([fdo#109271] / [i915#2994])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/igt@[email protected]#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: ([PASS][162], [TIMEOUT][163]) ([i915#3063]) -> [PASS][164] +1 similar issue
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-rkl-1/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-rkl-4/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-rkl-6/igt@[email protected]* igt@gem_ex
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/index.html
Signature · 5 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More preparation for multi gt patches
Hi Matt,
Quoted 12 lines
The first 10 patches have gone through several clean CI cycles now, so I've pushed those to drm-intel-gt-next. There are just a couple minor comments on the ggtt patches, so we can push the rest of those once the comments are addressed.
BTW, there's one
i915->gtreference in the display code that has moved fromdisplay/intel_display.ctodisplay/skl_universal_plane.con drm-intel-next, but that movement hasn't made its way to drm-intel-gt-next yet. This led to a merge conflict while rebuilding drm-tip. I had to use a 'dim cat-to-fixup' to apply the following diff to the drm-intel-gt-next merge commit:
Quoted 13 lines
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 158d89b8d490..b3162f49f341 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1737,7 +1737,7 @@ static bool bo_has_valid_encryption(struct drm_i915_gem_object *obj)
{
struct drm_i915_private *i915 = to_i915(obj->base.dev);
- return intel_pxp_key_check(&i915->gt.pxp, obj, false) == 0;
+ return intel_pxp_key_check(&to_gt(i915)->pxp, obj, false) == 0;
}
static bool pxp_is_borked(struct drm_i915_gem_object *obj)thanks for pointing this out.
Andi
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More preparation for multi gt patches
In reply to Matt RoperRegressions are related to https://gitlab.freedesktop.org/drm/intel/-/issues/2842
igt@gem_exec_fair@.* - fail - Failed assertion: iqr[nchild / 2] < result[nchild / 2], Child frame IQR .*ms exceeded median threshold .*m s
https://gitlab.freedesktop.org/drm/intel/-/issues/4817
igt@i915_suspend@sysfs-reader - incomplete - PM: suspend entry (deep)
I think re-reporting is not required as we may haver results from another rev.
Lakshmi.
-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: Friday, December 17, 2021 10:11 PM
To: [email protected]
Cc: Andi Shyti <[email protected]>; Vudum, Lakshminarayana <[email protected]>
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More preparation for multi gt patches
Quoted 37 lines · Patchwork
== Series Details ==
Series: More preparation for multi gt patches
URL : https://patchwork.freedesktop.org/series/98032/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_11002_full->Patchwork_21849_full
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
Patchwork_21849_fullabsolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
Patchwork_21849_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.Participating hosts (10 -> 10)
------------------------------No changes in participating hosts
Possible new issues
-------------------Here are the unknown changes that may have been introduced in
Patchwork_21849_full:### IGT changes ###
Quoted 7 lines
#### Possible regressions ####
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][1]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb4/i
gt@gem_exec_fair@[email protected]
https://gitlab.freedesktop.org/drm/intel/-/issues/2842
Quoted 7 lines
* igt@i915_suspend@sysfs-reader:
- shard-skl: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl8/igt@[email protected]
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/i
gt@[email protected]
Looks similar to this ADL-P issue that was seen only once:
https://gitlab.freedesktop.org/drm/intel/-/issues/4092
The first 10 patches have gone through several clean CI cycles now, so I've pushed those to drm-intel-gt-next. There are just a couple minor comments on the ggtt patches, so we can push the rest of those once the comments are addressed.
BTW, there's one i915->gt reference in the display code that has moved from display/intel_display.c to display/skl_universal_plane.c on drm-intel-next, but that movement hasn't made its way to drm-intel-gt-next yet. This led to a merge conflict while rebuilding drm-tip. I had to use a 'dim cat-to-fixup' to apply the following diff to the drm-intel-gt-next merge commit:
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 158d89b8d490..b3162f49f341 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -1737,7 +1737,7 @@ static bool bo_has_valid_encryption(struct drm_i915_gem_object *obj)
{
struct drm_i915_private *i915 = to_i915(obj->base.dev);
- return intel_pxp_key_check(&i915->gt.pxp, obj, false) == 0;
+ return intel_pxp_key_check(&to_gt(i915)->pxp, obj, false) == 0;
}
static bool pxp_is_borked(struct drm_i915_gem_object *obj)Matt
Quoted 592 lines
Known issues
------------Here are the changes found in
Patchwork_21849_fullthat come from known issues:### CI changes ###
#### Issues hit ####
* boot:
- shard-snb: ([PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [FAIL][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53]) ([i915#4338])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb7/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb4/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-snb2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb5/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb4/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/boot.html
[53]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-snb2/bo
ot.html### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][54] -> [SKIP][55] ([i915#658])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb2/igt@[email protected]
[55]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb8/i
gt@[email protected]* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +4 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl3/igt@gem_ctx_isolation@[email protected]
[57]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl4/ig
t@gem_ctx_isolation@[email protected]* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][58] -> [INCOMPLETE][59] ([i915#4547])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl4/igt@gem_exec_capture@[email protected]
[59]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl8/ig
t@gem_exec_capture@[email protected]* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2842]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk5/igt@gem_exec_fair@[email protected]
[61]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk2/ig
t@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl7/igt@gem_exec_fair@[email protected]
[63]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl3/ig
t@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][64] -> [FAIL][65] ([i915#2842])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-tglb8/igt@gem_exec_fair@[email protected]
[65]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb3/i
gt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][66] -> [FAIL][67] ([i915#2842])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl6/igt@gem_exec_fair@[email protected]
[67]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl7/ig
t@gem_exec_fair@[email protected]* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][68] -> [SKIP][69] ([i915#2190])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-tglb1/igt@[email protected]
[69]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@gem_lmem_swapping@parallel-multi:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#4613])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#4613]) +1 similar issue
[72]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/i
gt@[email protected]* igt@gem_lmem_swapping@random-engines:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#4613])
[73]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/ig
t@[email protected]* igt@gem_lmem_swapping@smem-oom:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#4613])
[74]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@gem_pxp@fail-invalid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#4270])
[75]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@gem_pxp@regular-baseline-src-copy-readible:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271]) +59 similar issues
[76]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/ig
t@[email protected]* igt@gen9_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#2856])
[77]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][78] ([i915#454])
[78]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/ig
t@[email protected]* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][79] -> [FAIL][80] ([i915#454])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb7/igt@[email protected]
[80]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@i915_pm_dc@dc9-dpms:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#4281])
[81]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][82] -> [DMESG-WARN][83] ([i915#118])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@[email protected]
[83]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk4/ig
t@[email protected]* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#111614]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#110725] / [fdo#111614])
[85]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#111615])
[86]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3886]) +3 similar issues
[87]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/ig
t@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html* igt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#111615] / [i915#3689])
[88]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@kms_ccs@pipe-a-ccs-on-another-bo-yf_tiled_ccs.html* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#3886]) +2 similar issues
[89]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/ig
t@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#3689])
[90]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3689] / [i915#3886])
[91]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#3886])
[92]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/ig
t@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [fdo#111827]) +7 similar issues
[93]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/ig
t@[email protected]* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [PASS][94] -> [DMESG-WARN][95] ([i915#1982])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl8/igt@[email protected]
[95]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl6/ig
t@[email protected]* igt@kms_color@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109278] / [i915#1149])
[96]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109284] / [fdo#111827]) +1 similar issue
[97]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [fdo#111827]) +5 similar issues
[98]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/ig
t@[email protected]* igt@kms_color_chamelium@pipe-b-ctm-0-75:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109284] / [fdo#111827]) +3 similar issues
[99]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/i
gt@[email protected]* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][100] ([i915#1319])
[100]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/ig
t@[email protected]* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][101] ([i915#1319])
[101]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/ig
t@[email protected]* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][102] ([i915#2105])
[102]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/ig
t@[email protected]* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#3319])
[103]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_cursor_crc@pipe-b-cursor-512x170-rapid-movement:
- shard-glk: NOTRUN -> [SKIP][104] ([fdo#109271]) +1 similar issue
[104]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk2/ig
t@[email protected]* igt@kms_cursor_crc@pipe-c-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#3359])
[105]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_cursor_crc@pipe-d-cursor-32x32-onscreen:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278]) +6 similar issues
[106]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/i
gt@[email protected]* igt@kms_cursor_crc@pipe-d-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109279] / [i915#3359])
[107]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][108] -> [FAIL][109] ([i915#72])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@[email protected]
[109]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk8/ig
t@[email protected]* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109274] / [fdo#109278]) +1 similar issue
[110]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/i
gt@[email protected]* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][111] ([fdo#111825]) +11 similar issues
[111]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/i
gt@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-apl: [PASS][112] -> [FAIL][113] ([i915#2346])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl3/igt@[email protected]
[113]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/ig
t@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [PASS][114] -> [FAIL][115] ([i915#2346])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb5/igt@[email protected]
[115]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@kms_cursor_legacy@pipe-d-forked-move:
- shard-skl: NOTRUN -> [SKIP][116] ([fdo#109271]) +14 similar issues
[116]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/i
gt@[email protected]* igt@kms_dsc@basic-dsc-enable:
- shard-iclb: NOTRUN -> [SKIP][117] ([i915#3840])
[117]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@[email protected]* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][118] -> [INCOMPLETE][119] ([i915#180] / [i915#1982])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl8/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl1/igt@[email protected]
- shard-kbl: [PASS][120] -> [INCOMPLETE][121] ([i915#180] / [i915#636])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-kbl2/igt@[email protected]
[121]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl4/ig
t@[email protected]* igt@kms_flip@2x-blocking-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][122] ([fdo#109274]) +2 similar issues
[122]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@kms_flip@2x-blocking-wf_vblank.html* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][123] -> [FAIL][124] ([i915#2122]) +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl4/igt@kms_flip@[email protected]
[124]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl10/i
gt@kms_flip@[email protected]* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][125] -> [FAIL][126] ([i915#2122])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk8/igt@kms_flip@[email protected]
[126]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk8/ig
t@kms_flip@[email protected]* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][127] -> [DMESG-WARN][128] ([i915#180]) +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-apl4/igt@kms_flip@[email protected]
[128]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl8/ig
t@kms_flip@[email protected]* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][129] ([fdo#109271] / [i915#2672])
[129]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl3/ig
t@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-iclb: [PASS][130] -> [SKIP][131] ([i915#3701])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb4/igt@[email protected]
[131]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb2/i
gt@[email protected]* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-skl: NOTRUN -> [SKIP][132] ([fdo#109271] / [i915#2672])
[132]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/ig
t@[email protected]* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][133] ([fdo#109280]) +2 similar issues
[133]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb7/i
gt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite.h tml* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][134] -> [FAIL][135] ([i915#1188])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl7/igt@[email protected]
[135]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl8/ig
t@[email protected]* igt@kms_hdr@static-swap:
- shard-tglb: NOTRUN -> [SKIP][136] ([i915#1187])
[136]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#533])
[137]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl7/ig
t@[email protected]* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: NOTRUN -> [DMESG-WARN][138] ([i915#180])
[138]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl7/ig
t@[email protected]* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][139] ([fdo#108145] / [i915#265])
[139]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/ig
t@[email protected]* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][140] ([fdo#108145] / [i915#265]) +1 similar issue
[140]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl6/ig
t@[email protected]* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][141] ([fdo#108145] / [i915#265]) +1 similar issue
[141]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/ig
t@[email protected]* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][142] ([i915#3536])
[142]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/i
gt@[email protected]* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][143] ([i915#3536])
[143]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-tglb: NOTRUN -> [SKIP][144] ([i915#2920])
[144]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_psr@psr2_basic:
- shard-tglb: NOTRUN -> [FAIL][145] ([i915#132] / [i915#3467])
[145]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@kms_psr@psr2_basic.html* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][146] -> [SKIP][147] ([fdo#109441]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[147]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb8/i
gt@kms_psr@psr2_cursor_plane_move.html* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][148] ([fdo#109441]) +1 similar issue
[148]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/i
gt@kms_psr@psr2_primary_mmap_cpu.html* igt@kms_setmode@basic:
- shard-glk: [PASS][149] -> [FAIL][150] ([i915#31])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-glk6/igt@[email protected]
[150]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-glk1/ig
t@[email protected]* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][151] ([fdo#109309])
[151]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][152] ([fdo#109271]) +77 similar issues
[152]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/ig
t@[email protected]* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][153] ([i915#2530]) +1 similar issue
[153]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb7/i
gt@[email protected]* igt@perf@blocking:
- shard-skl: NOTRUN -> [FAIL][154] ([i915#1542])
[154]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/ig
t@[email protected]* igt@perf@enable-disable:
- shard-skl: [PASS][155] -> [FAIL][156] ([i915#1352])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-skl7/igt@[email protected]
[156]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl1/ig
t@[email protected]* igt@sysfs_clients@fair-0:
- shard-tglb: NOTRUN -> [SKIP][157] ([i915#2994]) +1 similar issue
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-tglb6/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][158] ([fdo#109271] / [i915#2994]) +2 similar issues
[158]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-apl2/ig
t@[email protected]* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][159] ([fdo#109271] / [i915#2994])
[159]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-skl4/ig
t@[email protected]* igt@sysfs_clients@fair-7:
- shard-iclb: NOTRUN -> [SKIP][160] ([i915#2994])
[160]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-iclb5/i
gt@[email protected]* igt@sysfs_clients@sema-50:
- shard-kbl: NOTRUN -> [SKIP][161] ([fdo#109271] / [i915#2994])
[161]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-kbl2/ig
t@[email protected]#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: ([PASS][162], [TIMEOUT][163]) ([i915#3063]) -> [PASS][164] +1 similar issue
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-rkl-1/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11002/shard-rkl-4/igt@[email protected]
[164]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/shard-rkl-6/i
gt@[email protected]
Quoted 6 lines
* igt@gem_ex
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21849/index.html
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for More preparation for multi gt patches (rev2)
In reply to Andi Shyti== Series Details ==
== Series Details ==
Series: More preparation for multi gt patches (rev2)
URL : https://patchwork.freedesktop.org/series/98032/
State : failure
== Summary ==
Applying: drm/i915: Store backpointer to GT in uncore
Applying: drm/i915: Introduce to_gt() helper
Applying: drm/i915/display: Use to_gt() helper
Applying: drm/i915/gt: Use to_gt() helper
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gt/uc/selftest_guc.c
Falling back to patching base and 3-way merge... Auto-merging drivers/gpu/drm/i915/gt/uc/selftest_guc.c
warning: quoted CRLF detected
Applying: drm/i915/gem: Use to_gt() helper
Applying: drm/i915/gvt: Use to_gt() helper
Applying: drm/i915/selftests: Use to_gt() helper
Applying: drm/i915/pxp: Use to_gt() helper
Applying: drm/i915: Use to_gt() helper
Applying: drm/i915: Rename i915->gt to i915->gt0
Applying: drm/i915/gem: Use to_gt() helper for GGTT accesses
error: corrupt patch at line 44
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0011 drm/i915/gem: Use to_gt() helper for GGTT accesses When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".