qemu.bbclass: drop OLDEST_KERNEL reference
PATCH 1/1 qemu.bbclass: drop OLDEST_KERNEL reference
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.
--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/qemu.bbclass +1 -1
@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels. -QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"
Signature · 1 line
2.32.0
Quoted 4 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.
This would need a qemu backport for riscv32
https://lists.nongnu.org/archive/html/qemu-riscv/2021-12/msg00220.html
Quoted 18 lines
Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +1
-1@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels. -QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"
Quoted 11 lines · Khem Raj
Quoted 4 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.This would need a qemu backport for riscv32
https://lists.nongnu.org/archive/html/qemu-riscv/2021-12/msg00220.html
Thanks, Khem. I'll publish a V2 with that addition.
-Matt
Quoted 19 lines
Quoted 19 lines
Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +1
-1@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels. -QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"
Quoted 14 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 8 lines
meta/classes/qemu.bbclass +1
-1@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels. -QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"
Rather worryingly this breaks a few docs packages for reproducibility:
http://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20211219-6kkv1f8k/packages/diff-html/
which raises a number of questions in my mind. Investigation is needed as the hashes clearly aren't encoding everything they should :(.
Cheers,
Richard
Quoted 23 lines · Richard Purdie
Quoted 21 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +1
-1@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels. -QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}"
Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 1 line
meta/classes/qemu.bbclass +0
-0QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"Rather worryingly this breaks a few docs packages for reproducibility:
http://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20211219-6kkv1f8k/packages/diff-html/
which raises a number of questions in my mind. Investigation is needed as the hashes clearly aren't encoding everything they should :(.
I think the problem is in manpages.bbclass - the ":append" for adding to the pkg_postinst/pkg_postrm functions is in the wrong place. Fixing them so the ":append" is at the end, rather than before "${MAN_PKG}", causes the function text and dependencies to show up in dumpsig output again.
-Matt
Quoted 5 lines
Cheers,
Richard
Quoted 31 lines · Matt Madison
Quoted 29 lines · Richard Purdie
Quoted 14 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 8 lines
meta/classes/qemu.bbclass +1
-1@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels. -QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"Rather worryingly this breaks a few docs packages for reproducibility:
http://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20211219-6kkv1f8k/packages/diff-html/
Quoted 8 lines
Quoted 2 lines
which raises a number of questions in my mind. Investigation is needed as the hashes clearly aren't encoding everything they should :(.
I think the problem is in manpages.bbclass - the ":append" for adding to the pkg_postinst/pkg_postrm functions is in the wrong place. Fixing them so the ":append" is at the end, rather than before "${MAN_PKG}", causes the function text and dependencies to show up in dumpsig output again.
I agree, I'd come to the same conclusion and there is a patch in master-next testing on the autobuilder to see if that does resolve the issue. I've not sent it out yet as invalidating the data from a reproducibility perspective is tricky.
Cheers,
Richard
Quoted 14 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 8 lines
meta/classes/qemu.bbclass +1
-1@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels. -QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"
I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)
We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Cheers,
Richard
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.
Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our OLDEST_KERNEL setting for aarch64 (3.14.0) is
higher than the UNAME_MINIMUM_RELEASE definition in QEMU (3.8.0).
Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
-Matt
Quoted 7 lines
Cheers,
Richard
Quoted 40 lines · Matt Madison
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our
OLDEST_KERNELsetting for aarch64 (3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Quoted 7 lines
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
meta/classes/allarch.bbclass +3 -0
@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "") + if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuances of # the target machine that aren't important for "all" arch # packages.
Cheers,
Richard
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 60 lines · Richard Purdie via lists.openembedded.org
Quoted 40 lines · Matt Madison
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our
OLDEST_KERNELsetting for aarch64 (3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Quoted 7 lines
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
meta/classes/allarch.bbclass +0
-0
meta/classes/allarch.bbclass python () { · line 51
Quoted 9 lines
meta/classes/allarch.bbclass +3
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "") + if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuances of # the target machine that aren't important for "all" arch # packages.
Sorry, that isn't quite right. We want to just remove the append to write_config which generates the qemu wrapper which will probably need a little more invasive juggling of the code to make it easier...
Cheers,
Richard
Quoted 64 lines · Richard Purdie
Quoted 61 lines · Richard Purdie via lists.openembedded.org
Quoted 40 lines · Matt Madison
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our
OLDEST_KERNELsetting for aarch64 (3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Quoted 7 lines
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
meta/classes/allarch.bbclass +0
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "")
Quoted 12 lines
meta/classes/allarch.bbclass python () { · line 51
Quoted 8 lines
meta/classes/allarch.bbclass +3
-0+ if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuances of # the target machine that aren't important for "all" arch # packages.Sorry, that isn't quite right. We want to just remove the append to
write_configwhich generates the qemu wrapper which will probably need a little more invasive juggling of the code to make it easier...
Your patch to disable the qemu wrapper for allarch looks like a good solution. Hopefully, that will work OK across the board.
Thanks,
-Matt
Quoted 5 lines
Cheers,
Richard
Quoted 79 lines · Matt Madison
Quoted 64 lines · Richard Purdie
Quoted 61 lines · Richard Purdie via lists.openembedded.org
Quoted 40 lines · Matt Madison
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our
OLDEST_KERNELsetting for aarch64 (3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Quoted 7 lines
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
meta/classes/allarch.bbclass +0
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "")Quoted 12 lines
meta/classes/allarch.bbclass python () { · line 51
Quoted 8 lines
meta/classes/allarch.bbclass +3
-0+ if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuances of # the target machine that aren't important for "all" arch # packages.Sorry, that isn't quite right. We want to just remove the append to
write_configwhich generates the qemu wrapper which will probably need a little more invasive juggling of the code to make it easier...
Quoted 2 lines
Your patch to disable the qemu wrapper for allarch looks like a good solution. Hopefully, that will work OK across the board.
It seemed to be so I've merged it. Am hoping this resolves things!
Cheers,
Richard
Quoted 81 lines · Richard Purdie
Quoted 79 lines · Matt Madison
Quoted 76 lines · Richard Purdie
Quoted 60 lines · Richard Purdie via lists.openembedded.org
Quoted 40 lines · Matt Madison
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our
OLDEST_KERNELsetting for aarch64 (3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Quoted 7 lines
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
meta/classes/allarch.bbclass +0
-0meta/classes/allarch.bbclass python () { · line 51
Quoted 9 lines
meta/classes/allarch.bbclass +3
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "") + if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuances of # the target machine that aren't important for "all" arch # packages.Sorry, that isn't quite right. We want to just remove the append to
write_configwhich generates the qemu wrapper which will probably need a little more invasive juggling of the code to make it easier...
Quoted 4 lines
Quoted 2 lines
Your patch to disable the qemu wrapper for allarch looks like a good solution. Hopefully, that will work OK across the board.
It seemed to be so I've merged it. Am hoping this resolves things!
Drat. Unfortunately, it only works if allarch is inherited after meson (which inherits qemu). So cantarell-fonts checks out OK, but wayland-protocols doesn't, since it inherits allarch first.
-Matt
Quoted 5 lines
Cheers,
Richard
Quoted 83 lines · Matt Madison
Quoted 81 lines · Richard Purdie
Quoted 79 lines · Matt Madison
Quoted 76 lines · Richard Purdie
Quoted 60 lines · Richard Purdie via lists.openembedded.org
Quoted 40 lines · Matt Madison
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our
OLDEST_KERNELsetting for aarch64 (3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Quoted 7 lines
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
meta/classes/allarch.bbclass +0
-0meta/classes/allarch.bbclass python () { · line 51
Quoted 9 lines
meta/classes/allarch.bbclass +3
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "") + if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuances of # the target machine that aren't important for "all" arch # packages.Sorry, that isn't quite right. We want to just remove the append to
write_configwhich generates the qemu wrapper which will probably need a little more invasive juggling of the code to make it easier...
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Your patch to disable the qemu wrapper for allarch looks like a good solution. Hopefully, that will work OK across the board.
It seemed to be so I've merged it. Am hoping this resolves things!
Drat. Unfortunately, it only works if allarch is inherited after meson (which inherits qemu). So cantarell-fonts checks out OK, but wayland-protocols doesn't, since it inherits allarch first.
Probably easy to fix but hard to spot new problems :/
Cheers,
Richard
Quoted 87 lines · Richard Purdie
Quoted 86 lines · Matt Madison
Quoted 84 lines · Richard Purdie
Quoted 81 lines · Matt Madison
Quoted 64 lines · Richard Purdie
Quoted 61 lines · Richard Purdie via lists.openembedded.org
Quoted 40 lines · Matt Madison
Quoted 19 lines · Richard Purdie
Quoted 17 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path, binary): # this dance). For others (e.g. arm) a -cpu option is not necessary, since the # qemu-arm default CPU supports all required architecture levels.Quoted 8 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, binary): · line 60
Quoted 5 lines
meta/classes/qemu.bbclass +1
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL} ${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" +QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" % d.getVar('PACKAGE_ARCH')) or ""}" QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true, this is causing autobuilder failures and there was also a user report of issues with it.
Bummer. I think this is because our
OLDEST_KERNELsetting for aarch64 (3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 5 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/steps/13/logs/stdio
(centos7 aarch64 build)We'll have to find a different way to fix the allarch issue (more details welcome on which package shows the issue).
Quoted 7 lines
I ran into the issue with cantarell-fonts and wayland-protocols, but any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86 and one of the (aarch64) machines in my layer, and that was reporting the signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
meta/classes/allarch.bbclass +0
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "")Quoted 12 lines
meta/classes/allarch.bbclass python () { · line 51
Quoted 8 lines
meta/classes/allarch.bbclass +3
-0+ if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuances of # the target machine that aren't important for "all" arch # packages.Sorry, that isn't quite right. We want to just remove the append to
write_configwhich generates the qemu wrapper which will probably need a little more invasive juggling of the code to make it easier...Your patch to disable the qemu wrapper for allarch looks like a good solution. Hopefully, that will work OK across the board.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
It seemed to be so I've merged it. Am hoping this resolves things!
Drat. Unfortunately, it only works if allarch is inherited after meson (which inherits qemu). So cantarell-fonts checks out OK, but wayland-protocols doesn't, since it inherits allarch first.
Probably easy to fix but hard to spot new problems :/
would an insane check similar to native-last be of help here?
Quoted 15 lines
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160277): https://lists.openembedded.org/g/openembedded-core/message/160277
Mute This Topic: https://lists.openembedded.org/mt/87752526/3647476
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 120 lines
-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Konrad Weihmann
Sent: den 9 januari 2022 10:24
To: Richard Purdie <[email protected]>
Cc: Patches and discussions about the oe-core layer <openembedded- [email protected]>
Subject: Re: [OE-core][PATCH] qemu.bbclass: dropOLDEST_KERNELreferenceQuoted 9 lines · Richard Purdie
Quoted 8 lines · Matt Madison
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
Quoted 2 lines · Richard Purdie
On Fri, 2022-01-07 at 12:51 +0000, Richard Purdie via
lists.openembedded.org
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines · wrote:
Quoted 8 lines · Matt Madison
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta/classes/qemu.bbclass
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path,
Quoted 4 lines
index
01a7b86ae1..333202b7c4100644meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path,binary):
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 54
Quoted 1 line
meta/classes/qemu.bbclass +0
-0# this dance). For others (e.g. arm) a -cpu option is notnecessary, since the
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 55
Quoted 1 line
meta/classes/qemu.bbclass +0
-0# qemu-arm default CPU supports all required architecturelevels.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 56
Quoted 2 lines
meta/classes/qemu.bbclass +0
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL}${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 56
Quoted 1 line
meta/classes/qemu.bbclass +1
-0+QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 59
Quoted 3 lines
meta/classes/qemu.bbclass +0
-0QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true,
this is causing
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
autobuilder failures and there was also a user report of issues
with it.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Bummer. I think this is because our
OLDEST_KERNELsetting foraarch64
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
(3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 1 line
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/ste
ps/13/logs/stdioQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
(centos7 aarch64 build)
We'll have to find a different way to fix the allarch issue (more
details
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
welcome on which package shows the issue).
I ran into the issue with cantarell-fonts and wayland-protocols,
but
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86
and
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
one of the (aarch64) machines in my layer, and that was reporting
the
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Review
Quoted 7 lines
Quoted 1 line
signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
(quoted diff) +0
-0b/meta/classes/allarch.bbclass
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
meta/classes/allarch.bbclass python () { · line 49
Quoted 11 lines
index
5bd5c44a276..0aadf7bfba6100644meta/classes/allarch.bbclass +3
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "") + if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuancesof
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
meta/classes/allarch.bbclass python () { · line 51
Quoted 4 lines
meta/classes/allarch.bbclass +0
-0# the target machine that aren't important for "all" arch # packages.Sorry, that isn't quite right. We want to just remove the append to
write_configQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
which generates the qemu wrapper which will probably need a little
more invasive
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
juggling of the code to make it easier...
Your patch to disable the qemu wrapper for allarch looks like a good
solution.
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Hopefully, that will work OK across the board.
It seemed to be so I've merged it. Am hoping this resolves things!
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Drat. Unfortunately, it only works if allarch is inherited after meson (which inherits qemu). So cantarell-fonts checks out OK, but wayland-protocols doesn't, since it inherits allarch first.
Probably easy to fix but hard to spot new problems :/
would an insane check similar to native-last be of help here?
That seems like the wrong solution. As far as possible, bbclasses should be designed to be able to inherit them in any order, and it should be possible to rewrite this change so that is still possible to do.
Quoted 4 lines
Quoted 4 lines
Cheers,
Richard
//Peter
Quoted 125 lines · Peter Kjellerstedt
Quoted 125 lines
-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Konrad Weihmann
Sent: den 9 januari 2022 10:24
To: Richard Purdie <[email protected]>
Cc: Patches and discussions about the oe-core layer <openembedded- [email protected]>
Subject: Re: [OE-core][PATCH] qemu.bbclass: dropOLDEST_KERNELreferenceQuoted 9 lines · Richard Purdie
Quoted 8 lines · Matt Madison
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
Quoted 2 lines · Richard Purdie
On Fri, 2022-01-07 at 12:51 +0000, Richard Purdie via
lists.openembedded.org
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines · wrote:
Quoted 8 lines · Matt Madison
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta/classes/qemu.bbclass
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path,
Quoted 4 lines
index
01a7b86ae1..333202b7c4100644meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path,binary):
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 54
Quoted 1 line
meta/classes/qemu.bbclass +0
-0# this dance). For others (e.g. arm) a -cpu option is notnecessary, since the
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 55
Quoted 1 line
meta/classes/qemu.bbclass +0
-0# qemu-arm default CPU supports all required architecturelevels.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 56
Quoted 2 lines
meta/classes/qemu.bbclass +0
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL}${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 56
Quoted 1 line
meta/classes/qemu.bbclass +1
-0+QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 59
Quoted 3 lines
meta/classes/qemu.bbclass +0
-0QEMU_OPTIONS[vardeps] += "QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}" QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't true,
this is causing
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
autobuilder failures and there was also a user report of issues
with it.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Bummer. I think this is because our
OLDEST_KERNELsetting foraarch64
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
(3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU (3.8.0).Quoted 1 line
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/ste
ps/13/logs/stdioQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
(centos7 aarch64 build)
We'll have to find a different way to fix the allarch issue (more
details
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
welcome on which package shows the issue).
I ran into the issue with cantarell-fonts and wayland-protocols,
but
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
any recipe that inherits both allarch and meson should trigger it.
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying qemux86
and
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
one of the (aarch64) machines in my layer, and that was reporting
the
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Review
Quoted 7 lines
Quoted 1 line
signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
(quoted diff) +0
-0b/meta/classes/allarch.bbclass
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
meta/classes/allarch.bbclass python () { · line 49
Quoted 11 lines
index
5bd5c44a276..0aadf7bfba6100644meta/classes/allarch.bbclass +3
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "") + if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due to nuancesof
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
meta/classes/allarch.bbclass python () { · line 51
Quoted 4 lines
meta/classes/allarch.bbclass +0
-0# the target machine that aren't important for "all" arch # packages.Sorry, that isn't quite right. We want to just remove the append to
write_configQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
which generates the qemu wrapper which will probably need a little
more invasive
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
juggling of the code to make it easier...
Your patch to disable the qemu wrapper for allarch looks like a good
solution.
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Hopefully, that will work OK across the board.
It seemed to be so I've merged it. Am hoping this resolves things!
Drat. Unfortunately, it only works if allarch is inherited after meson (which inherits qemu). So cantarell-fonts checks out OK, but wayland-protocols doesn't, since it inherits allarch first.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Probably easy to fix but hard to spot new problems :/
would an insane check similar to native-last be of help here?
That seems like the wrong solution. As far as possible, bbclasses should be designed to be able to inherit them in any order, and it should be possible to rewrite this change so that is still possible to do.
Doing so would be a bit ugly, since it's a Python function. Something like
if bb.data.inherits_class('qemu', d):
d.setVar("qemu_wrapper_cmdline", "defqemu_wrapper_cmdline(data, rootfs_path, library_paths):\n return
'false'\n")
in the anonymous python function in allarch.bbclass would do that.
-Matt
Quoted 17 lines
Quoted 5 lines
Quoted 5 lines
Cheers,
Richard
//Peter
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#160280): https://lists.openembedded.org/g/openembedded-core/message/160280
Mute This Topic: https://lists.openembedded.org/mt/87752526/3618418
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Quoted 162 lines
-----Original Message-----
From: Matt Madison <[email protected]>
Sent: den 9 januari 2022 13:04
To: Peter Kjellerstedt <[email protected]>
Cc: Konrad Weihmann <[email protected]>; Richard Purdie <[email protected]>; Patches and discussions about the oe-core layer <[email protected]>
Subject: Re: [OE-core][PATCH] qemu.bbclass: dropOLDEST_KERNELreferenceQuoted 9 lines · Peter Kjellerstedt
Quoted 9 lines
-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Konrad Weihmann
Sent: den 9 januari 2022 10:24
To: Richard Purdie <[email protected]>
Cc: Patches and discussions about the oe-core layer <openembedded- [email protected]>
Subject: Re: [OE-core][PATCH] qemu.bbclass: dropOLDEST_KERNELreference
Quoted 36 lines
Quoted 36 lines · Richard Purdie
Quoted 9 lines · Matt Madison
Quoted 8 lines
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
Quoted 2 lines · Richard Purdie
On Fri, 2022-01-07 at 12:51 +0000, Richard Purdie via
lists.openembedded.org
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines · wrote:
Quoted 8 lines · Matt Madison
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Matt Madison <[email protected]>--- meta/classes/qemu.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta/classes/qemu.bbclass
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path,
Quoted 4 lines
index
01a7b86ae1..333202b7c4100644meta/classes/qemu.bbclass +0
-0@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path,binary):
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 54
Quoted 1 line
meta/classes/qemu.bbclass +0
-0# this dance). For others (e.g. arm) a -cpu option is notnecessary, since the
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 55
Quoted 1 line
meta/classes/qemu.bbclass +0
-0# qemu-arm default CPU supports all required architecturelevels.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 56
Quoted 2 lines
meta/classes/qemu.bbclass +0
-1-QEMU_OPTIONS = "-r ${OLDEST_KERNEL}${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 56
Quoted 1 line
meta/classes/qemu.bbclass +1
-0+QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/qemu.bbclass +0
-0QEMU_OPTIONS[vardeps] +="QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}"
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/classes/qemu.bbclass def qemu_run_binary(data, rootfs_path, · line 58
Quoted 2 lines
meta/classes/qemu.bbclass +0
-0QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"I've sent a revert for this since the commit message isn't
true,
Quoted 2 lines
Quoted 2 lines
this is causing
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
autobuilder failures and there was also a user report of
issues
Quoted 6 lines
Quoted 6 lines
with it.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Bummer. I think this is because our
OLDEST_KERNELsetting foraarch64
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
(3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU(3.8.0).
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/ste
Quoted 4 lines
Quoted 4 lines
ps/13/logs/stdio
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
(centos7 aarch64 build)
We'll have to find a different way to fix the allarch issue
(more
Quoted 4 lines
Quoted 4 lines
details
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
welcome on which package shows the issue).
I ran into the issue with cantarell-fonts and wayland-
protocols,
Quoted 2 lines
Quoted 2 lines
but
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
any recipe that inherits both allarch and meson should trigger
it.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying
qemux86
Quoted 2 lines
Quoted 2 lines
and
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
one of the (aarch64) machines in my layer, and that was
reporting
Quoted 16 lines
Quoted 16 lines
the
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Review
Quoted 7 lines
Quoted 1 line
signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
(quoted diff) +0
-0b/meta/classes/allarch.bbclass
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
index
5bd5c44a276..0aadf7bfba6100644meta/classes/allarch.bbclass +0
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "")Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/classes/allarch.bbclass python () { · line 49
Quoted 4 lines
meta/classes/allarch.bbclass +3
-0+ if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due tonuances
Quoted 2 lines
Quoted 2 lines
of
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/allarch.bbclass +0
-0# the target machine that aren't important for "all"arch
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
meta/classes/allarch.bbclass python () { · line 51
Quoted 3 lines
meta/classes/allarch.bbclass +0
-0# packages.Sorry, that isn't quite right. We want to just remove the append
to
Quoted 2 lines
Quoted 2 lines
write_configQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
which generates the qemu wrapper which will probably need a
little
Quoted 4 lines
Quoted 4 lines
more invasive
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
juggling of the code to make it easier...
Your patch to disable the qemu wrapper for allarch looks like a
good
Quoted 6 lines
Quoted 6 lines
solution.
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Hopefully, that will work OK across the board.
It seemed to be so I've merged it. Am hoping this resolves things!
Drat. Unfortunately, it only works if allarch is inherited after
meson
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
(which inherits qemu). So cantarell-fonts checks out OK, but wayland-protocols doesn't, since it inherits allarch first.
Probably easy to fix but hard to spot new problems :/
would an insane check similar to native-last be of help here?
That seems like the wrong solution. As far as possible, bbclasses should be designed to be able to inherit them in any order, and it should be
possible
Quoted 1 line
to rewrite this change so that is still possible to do.
Quoted 8 lines
Doing so would be a bit ugly, since it's a Python function. Something like
if
bb.data.inherits_class('qemu', d):
d.setVar("qemu_wrapper_cmdline", "defqemu_wrapper_cmdline(data, rootfs_path, library_paths):\n return
'false'\n")in the anonymous python function in allarch.bbclass would do that.
Ok, that's ugly. How about solving it in qemu.bbclass instead by doing:
def qemu_wrapper_cmdline(data, rootfs_path, library_paths):
import string
if bb.data.inherits_class('allarch', data):
return 'false'
...
Quoted 10 lines
-Matt
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Cheers,
Richard
//Peter
//Peter
Quoted 172 lines · Peter Kjellerstedt
Quoted 163 lines
-----Original Message-----
From: Matt Madison <[email protected]>
Sent: den 9 januari 2022 13:04
To: Peter Kjellerstedt <[email protected]>
Cc: Konrad Weihmann <[email protected]>; Richard Purdie <[email protected]>; Patches and discussions about the oe-core layer <[email protected]>
Subject: Re: [OE-core][PATCH] qemu.bbclass: dropOLDEST_KERNELreferenceQuoted 9 lines · Peter Kjellerstedt
Quoted 9 lines
-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Konrad Weihmann
Sent: den 9 januari 2022 10:24
To: Richard Purdie <[email protected]>
Cc: Patches and discussions about the oe-core layer <openembedded- [email protected]>
Subject: Re: [OE-core][PATCH] qemu.bbclass: dropOLDEST_KERNELreference
Quoted 36 lines
Quoted 36 lines · Richard Purdie
Quoted 9 lines · Matt Madison
Quoted 8 lines
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
Quoted 2 lines · Richard Purdie
On Fri, 2022-01-07 at 12:51 +0000, Richard Purdie via
lists.openembedded.org
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines · wrote:
Quoted 8 lines · Matt Madison
Quoted 6 lines · Richard Purdie
Quoted 4 lines · Matt Madison
which is introducing task hash changes for some
allarch package builds, and should no longer
be needed with recent versions of qemu.Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Signed-off-by: Matt Madison <[email protected]>
---
meta/classes/qemu.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/meta/classes/qemu.bbclass
b/meta/classes/qemu.bbclass
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
index 01a7b86ae1..333202b7c4 100644
--- a/meta/classes/qemu.bbclass
+++ b/meta/classes/qemu.bbclass
@@ -54,7 +54,7 @@ def qemu_run_binary(data, rootfs_path,binary):
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
# this dance). For others (e.g. arm) a -cpu option is not
necessary, since the
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
# qemu-arm default CPU supports all required architecture
levels.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
-QEMU_OPTIONS = "-r ${OLDEST_KERNEL}
${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
+QEMU_OPTIONS = "${@d.getVar("QEMU_EXTRAOPTIONS_%s" %
d.getVar('PACKAGE_ARCH')) or ""}"Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
QEMU_OPTIONS[vardeps] +=
"QEMU_EXTRAOPTIONS_${PACKAGE_ARCH}"
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
QEMU_EXTRAOPTIONS_ppce500v2 = " -cpu e500v2"
I've sent a revert for this since the commit message isn't
true,
Quoted 2 lines
Quoted 2 lines
this is causing
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
autobuilder failures and there was also a user report of
issues
Quoted 6 lines
Quoted 6 lines
with it.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Bummer. I think this is because our
OLDEST_KERNELsetting foraarch64
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
(3.14.0) is
higher than theUNAME_MINIMUM_RELEASEdefinition in QEMU(3.8.0).
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
https://autobuilder.yoctoproject.org/typhoon/#/builders/42/builds/4559/ste
Quoted 4 lines
Quoted 4 lines
ps/13/logs/stdio
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
(centos7 aarch64 build)
We'll have to find a different way to fix the allarch issue
(more
Quoted 4 lines
Quoted 4 lines
details
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
welcome on which package shows the issue).
I ran into the issue with cantarell-fonts and wayland-
protocols,
Quoted 2 lines
Quoted 2 lines
but
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
any recipe that inherits both allarch and meson should trigger
it.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
In my case, I have a layer check job for meta-tegra that runs yocto-check-layer with the --machines option specifying
qemux86
Quoted 2 lines
Quoted 2 lines
and
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
one of the (aarch64) machines in my layer, and that was
reporting
Quoted 16 lines
Quoted 16 lines
the
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Review
Quoted 7 lines
Quoted 1 line
signature changes between the two architectures.
I wonder why we don't detect that with our standard tests? :/
There may be another fix:
(quoted diff) +0
-0b/meta/classes/allarch.bbclass
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
index
5bd5c44a276..0aadf7bfba6100644meta/classes/allarch.bbclass +0
-0@@ -43,6 +43,9 @@ python () { d.setVar("TARGET_LDFLAGS", "none") d.setVar("POPULATESYSROOTDEPS", "")Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/classes/allarch.bbclass python () { · line 49
Quoted 4 lines
meta/classes/allarch.bbclass +3
-0+ if bb.data.inherits_class("meson", d): + d.setVar("do_write_config", ":") + # Avoid this being unnecessarily different due tonuances
Quoted 2 lines
Quoted 2 lines
of
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
meta/classes/allarch.bbclass +0
-0# the target machine that aren't important for "all"arch
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
meta/classes/allarch.bbclass python () { · line 51
Quoted 3 lines
meta/classes/allarch.bbclass +0
-0# packages.Sorry, that isn't quite right. We want to just remove the append
to
Quoted 2 lines
Quoted 2 lines
write_configQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
which generates the qemu wrapper which will probably need a
little
Quoted 4 lines
Quoted 4 lines
more invasive
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
juggling of the code to make it easier...
Your patch to disable the qemu wrapper for allarch looks like a
good
Quoted 6 lines
Quoted 6 lines
solution.
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Hopefully, that will work OK across the board.
It seemed to be so I've merged it. Am hoping this resolves things!
Drat. Unfortunately, it only works if allarch is inherited after
meson
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
(which inherits qemu). So cantarell-fonts checks out OK, but wayland-protocols doesn't, since it inherits allarch first.
Probably easy to fix but hard to spot new problems :/
would an insane check similar to native-last be of help here?
That seems like the wrong solution. As far as possible, bbclasses should be designed to be able to inherit them in any order, and it should be
possible
Quoted 1 line
to rewrite this change so that is still possible to do.
Quoted 8 lines
Doing so would be a bit ugly, since it's a Python function. Something like
if
bb.data.inherits_class('qemu', d):
d.setVar("qemu_wrapper_cmdline", "defqemu_wrapper_cmdline(data, rootfs_path, library_paths):\n return
'false'\n")in the anonymous python function in allarch.bbclass would do that.
Quoted 7 lines
Ok, that's ugly. How about solving it in qemu.bbclass instead by doing:
def
qemu_wrapper_cmdline(data, rootfs_path, library_paths):
import stringif
bb.data.inherits_class('allarch', data):
return 'false'
Unfortunately, that wouldn't fix the problem, since task signatures are computed based on the parsed text of the function, which would still include the reference to the OLDEST_KERNEL variable.
A somewhat less ugly approach might be to just to do:
if bb.data.inherits_class('qemu', d):
d.setVar('QEMU_OPTIONS', '')
along with all the other variable changes in allarch.bbclass.
-Matt
Quoted 16 lines
...Quoted 10 lines
-Matt
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Cheers,
Richard
//Peter
//Peter