Add support for CS35L41 in HDA systems
Subsystems (5)
v5 cover Add support for CS35L41 in HDA systems
Add support for laptops that have CS35L41 connected to an HDA codec by I2S and direct I2C connection to the CPU.
Laptops that use CS35L41 and are SPI will be added in the future, after the support for it is resolved at i2c-multi-instantiate driver. i2c-multi-instantiate thread: https://lkml.org/lkml/2021/12/10/557
Hardware:
- Some laptops have two CS35L41 amplifiers, connected to Realtek ALC287 by an I2S bus and by and direct I2C to the CPU.
- The ALC287 codec is connected to the CPU by an HDA bus.
- The CS35L41 has a DSP which will require firmware to be loaded.
Architecture:
- Creation of a library of shared functions for CS35L41 ASoC and HDA
- HDA codec driver (RealTek) and CS35L41 HDA driver are combined by using component binding, where it uses device names to find the components and bind to the master
- The HDA CS35L41 driver applies pre-defined registers sequences for each action in playback for HDA Sound card
Changes from V4:
- Save index received from ACPI for latter use in DSP Support
- Move CS35L41_DSP1_CCM_CORE_CTRL to regmap_write so doesn't
affect DSP hibernation feature
V4: https://lkml.org/lkml/2021/12/14/487
Changes from V3:
- SPI bus driver starter added
- Use separate modules approach instead of liking library
- Add CSC3551 ACPI _HID for more I2C laptops
- Removed regulators from HDA driver
- Add note about Non-conforming _HID
V3: https://lkml.org/lkml/2021/11/23/723
Changes from V2:
- Not an RFC
- Create a new HDA driver for CS35L41 instead of using the ASoC one
- Use component binding and device names to find the CS35L41 driver
- Create a shared library for ASoC and HDA CS35L41 drivers
v2: https://lkml.org/lkml/2021/10/8/344
Lucas Tanure (9):
ASoC: cs35l41: Convert tables to shared source code
ASoC: cs35l41: Move cs35l41_otp_unpack to shared code
ASoC: cs35l41: Move power initializations to reg_sequence
ASoC: cs35l41: Create shared function for errata patches
ASoC: cs35l41: Create shared function for setting channels
ASoC: cs35l41: Create shared function for boost configuration
hda: cs35l41: Add support for CS35L41 in HDA systems ACPI / scan: Create platform device for CLSA0100 and CSC3551 ACPI
nodes
ALSA: hda/realtek: Add support for Legion 7 16ACHg6 laptop
Stefan Binding (1):
ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops
MAINTAINERS | 2 +
drivers/acpi/scan.c | 3 +
drivers/platform/x86/i2c-multi-instantiate.c | 11 +
include/sound/cs35l41.h | 739 ++++++++++++++++++
sound/pci/hda/Kconfig | 27 +
sound/pci/hda/Makefile | 10 +
sound/pci/hda/cs35l41_hda.c | 527 +++++++++++++
sound/pci/hda/cs35l41_hda.h | 69 ++
sound/pci/hda/cs35l41_hda_i2c.c | 66 ++
sound/pci/hda/cs35l41_hda_spi.c | 63 ++
sound/pci/hda/hda_component.h | 20 +
sound/pci/hda/patch_realtek.c | 144 ++++
sound/soc/codecs/Kconfig | 7 +
sound/soc/codecs/Makefile | 4 +-
sound/soc/codecs/cs35l41-i2c.c | 1 -
.../{cs35l41-tables.c => cs35l41-lib.c} | 355 ++++++++-
sound/soc/codecs/cs35l41-spi.c | 1 -
sound/soc/codecs/cs35l41.c | 360 +--------
sound/soc/codecs/cs35l41.h | 734 -----------------
19 files changed, 2051 insertions(+), 1092 deletions(-)
create mode 100644 sound/pci/hda/cs35l41_hda.c
create mode 100644 sound/pci/hda/cs35l41_hda.h
create mode 100644 sound/pci/hda/cs35l41_hda_i2c.c
create mode 100644 sound/pci/hda/cs35l41_hda_spi.c
create mode 100644 sound/pci/hda/hda_component.h
rename sound/soc/codecs/{cs35l41-tables.c => cs35l41-lib.c} (71%)Signature · 1 line
2.34.1
PATCH v5 1/10 ASoC: cs35l41: Convert tables to shared source code
To support CS35L41 in HDA systems the HDA driver for CS35L41 would have to duplicate some functions that already exist on ASoC driver
So instead of duplicate the code, use the new lib source as a shared resource for both ASoC and HDA
---
include/sound/cs35l41.h | 733 +++++++++++++++++
sound/soc/codecs/Kconfig | 5 +
sound/soc/codecs/Makefile | 4 +-
sound/soc/codecs/cs35l41-i2c.c | 1 -
.../{cs35l41-tables.c => cs35l41-lib.c} | 14 +-
sound/soc/codecs/cs35l41-spi.c | 1 -
sound/soc/codecs/cs35l41.h | 734 ------------------
7 files changed, 753 insertions(+), 739 deletions(-)
rename sound/soc/codecs/{cs35l41-tables.c => cs35l41-lib.c} (98%)include/sound/cs35l41.h +733 -0
@@ -10,6 +10,721 @@#ifndef __CS35L41_H#define __CS35L41_H +#include <linux/regmap.h> + +#define CS35L41_FIRSTREG 0x00000000 +#define CS35L41_LASTREG 0x03804FE8 +#define CS35L41_DEVID 0x00000000 +#define CS35L41_REVID 0x00000004 +#define CS35L41_FABID 0x00000008 +#define CS35L41_RELID 0x0000000C +#define CS35L41_OTPID 0x00000010 +#define CS35L41_SFT_RESET 0x00000020 +#define CS35L41_TEST_KEY_CTL 0x00000040 +#define CS35L41_USER_KEY_CTL 0x00000044 +#define CS35L41_OTP_MEM0 0x00000400 +#define CS35L41_OTP_MEM31 0x0000047C +#define CS35L41_OTP_CTRL0 0x00000500 +#define CS35L41_OTP_CTRL1 0x00000504 +#define CS35L41_OTP_CTRL3 0x00000508 +#define CS35L41_OTP_CTRL4 0x0000050C +#define CS35L41_OTP_CTRL5 0x00000510 +#define CS35L41_OTP_CTRL6 0x00000514 +#define CS35L41_OTP_CTRL7 0x00000518 +#define CS35L41_OTP_CTRL8 0x0000051C +#define CS35L41_PWR_CTRL1 0x00002014 +#define CS35L41_PWR_CTRL2 0x00002018 +#define CS35L41_PWR_CTRL3 0x0000201C +#define CS35L41_CTRL_OVRRIDE 0x00002020 +#define CS35L41_AMP_OUT_MUTE 0x00002024 +#define CS35L41_PROTECT_REL_ERR_IGN 0x00002034 +#define CS35L41_GPIO_PAD_CONTROL 0x0000242C +#define CS35L41_JTAG_CONTROL 0x00002438 +#define CS35L41_PLL_CLK_CTRL 0x00002C04 +#define CS35L41_DSP_CLK_CTRL 0x00002C08 +#define CS35L41_GLOBAL_CLK_CTRL 0x00002C0C +#define CS35L41_DATA_FS_SEL 0x00002C10 +#define CS35L41_TST_FS_MON0 0x00002D10 +#define CS35L41_MDSYNC_EN 0x00003400 +#define CS35L41_MDSYNC_TX_ID 0x00003408 +#define CS35L41_MDSYNC_PWR_CTRL 0x0000340C +#define CS35L41_MDSYNC_DATA_TX 0x00003410 +#define CS35L41_MDSYNC_TX_STATUS 0x00003414 +#define CS35L41_MDSYNC_DATA_RX 0x0000341C +#define CS35L41_MDSYNC_RX_STATUS 0x00003420 +#define CS35L41_MDSYNC_ERR_STATUS 0x00003424 +#define CS35L41_MDSYNC_SYNC_PTE2 0x00003528 +#define CS35L41_MDSYNC_SYNC_PTE3 0x0000352C +#define CS35L41_MDSYNC_SYNC_MSM_STATUS 0x0000353C +#define CS35L41_BSTCVRT_VCTRL1 0x00003800 +#define CS35L41_BSTCVRT_VCTRL2 0x00003804 +#define CS35L41_BSTCVRT_PEAK_CUR 0x00003808 +#define CS35L41_BSTCVRT_SFT_RAMP 0x0000380C +#define CS35L41_BSTCVRT_COEFF 0x00003810 +#define CS35L41_BSTCVRT_SLOPE_LBST 0x00003814 +#define CS35L41_BSTCVRT_SW_FREQ 0x00003818 +#define CS35L41_BSTCVRT_DCM_CTRL 0x0000381C +#define CS35L41_BSTCVRT_DCM_MODE_FORCE 0x00003820 +#define CS35L41_BSTCVRT_OVERVOLT_CTRL 0x00003830 +#define CS35L41_VI_VOL_POL 0x00004000 +#define CS35L41_VIMON_SPKMON_RESYNC 0x00004100 +#define CS35L41_DTEMP_WARN_THLD 0x00004220 +#define CS35L41_DTEMP_CFG 0x00004224 +#define CS35L41_DTEMP_EN 0x00004308 +#define CS35L41_VPVBST_FS_SEL 0x00004400 +#define CS35L41_SP_ENABLES 0x00004800 +#define CS35L41_SP_RATE_CTRL 0x00004804 +#define CS35L41_SP_FORMAT 0x00004808 +#define CS35L41_SP_HIZ_CTRL 0x0000480C +#define CS35L41_SP_FRAME_TX_SLOT 0x00004810 +#define CS35L41_SP_FRAME_RX_SLOT 0x00004820 +#define CS35L41_SP_TX_WL 0x00004830 +#define CS35L41_SP_RX_WL 0x00004840 +#define CS35L41_ASP_CONTROL4 0x00004854 +#define CS35L41_DAC_PCM1_SRC 0x00004C00 +#define CS35L41_ASP_TX1_SRC 0x00004C20 +#define CS35L41_ASP_TX2_SRC 0x00004C24 +#define CS35L41_ASP_TX3_SRC 0x00004C28 +#define CS35L41_ASP_TX4_SRC 0x00004C2C +#define CS35L41_DSP1_RX1_SRC 0x00004C40 +#define CS35L41_DSP1_RX2_SRC 0x00004C44 +#define CS35L41_DSP1_RX3_SRC 0x00004C48 +#define CS35L41_DSP1_RX4_SRC 0x00004C4C +#define CS35L41_DSP1_RX5_SRC 0x00004C50 +#define CS35L41_DSP1_RX6_SRC 0x00004C54 +#define CS35L41_DSP1_RX7_SRC 0x00004C58 +#define CS35L41_DSP1_RX8_SRC 0x00004C5C +#define CS35L41_NGATE1_SRC 0x00004C60 +#define CS35L41_NGATE2_SRC 0x00004C64 +#define CS35L41_AMP_DIG_VOL_CTRL 0x00006000 +#define CS35L41_VPBR_CFG 0x00006404 +#define CS35L41_VBBR_CFG 0x00006408 +#define CS35L41_VPBR_STATUS 0x0000640C +#define CS35L41_VBBR_STATUS 0x00006410 +#define CS35L41_OVERTEMP_CFG 0x00006414 +#define CS35L41_AMP_ERR_VOL 0x00006418 +#define CS35L41_VOL_STATUS_TO_DSP 0x00006450 +#define CS35L41_CLASSH_CFG 0x00006800 +#define CS35L41_WKFET_CFG 0x00006804 +#define CS35L41_NG_CFG 0x00006808 +#define CS35L41_AMP_GAIN_CTRL 0x00006C04 +#define CS35L41_DAC_MSM_CFG 0x00007400 +#define CS35L41_IRQ1_CFG 0x00010000 +#define CS35L41_IRQ1_STATUS 0x00010004 +#define CS35L41_IRQ1_STATUS1 0x00010010 +#define CS35L41_IRQ1_STATUS2 0x00010014 +#define CS35L41_IRQ1_STATUS3 0x00010018 +#define CS35L41_IRQ1_STATUS4 0x0001001C +#define CS35L41_IRQ1_RAW_STATUS1 0x00010090 +#define CS35L41_IRQ1_RAW_STATUS2 0x00010094 +#define CS35L41_IRQ1_RAW_STATUS3 0x00010098 +#define CS35L41_IRQ1_RAW_STATUS4 0x0001009C +#define CS35L41_IRQ1_MASK1 0x00010110 +#define CS35L41_IRQ1_MASK2 0x00010114 +#define CS35L41_IRQ1_MASK3 0x00010118 +#define CS35L41_IRQ1_MASK4 0x0001011C +#define CS35L41_IRQ1_FRC1 0x00010190 +#define CS35L41_IRQ1_FRC2 0x00010194 +#define CS35L41_IRQ1_FRC3 0x00010198 +#define CS35L41_IRQ1_FRC4 0x0001019C +#define CS35L41_IRQ1_EDGE1 0x00010210 +#define CS35L41_IRQ1_EDGE4 0x0001021C +#define CS35L41_IRQ1_POL1 0x00010290 +#define CS35L41_IRQ1_POL2 0x00010294 +#define CS35L41_IRQ1_POL3 0x00010298 +#define CS35L41_IRQ1_POL4 0x0001029C +#define CS35L41_IRQ1_DB3 0x00010318 +#define CS35L41_IRQ2_CFG 0x00010800 +#define CS35L41_IRQ2_STATUS 0x00010804 +#define CS35L41_IRQ2_STATUS1 0x00010810 +#define CS35L41_IRQ2_STATUS2 0x00010814 +#define CS35L41_IRQ2_STATUS3 0x00010818 +#define CS35L41_IRQ2_STATUS4 0x0001081C +#define CS35L41_IRQ2_RAW_STATUS1 0x00010890 +#define CS35L41_IRQ2_RAW_STATUS2 0x00010894 +#define CS35L41_IRQ2_RAW_STATUS3 0x00010898 +#define CS35L41_IRQ2_RAW_STATUS4 0x0001089C +#define CS35L41_IRQ2_MASK1 0x00010910 +#define CS35L41_IRQ2_MASK2 0x00010914 +#define CS35L41_IRQ2_MASK3 0x00010918 +#define CS35L41_IRQ2_MASK4 0x0001091C +#define CS35L41_IRQ2_FRC1 0x00010990 +#define CS35L41_IRQ2_FRC2 0x00010994 +#define CS35L41_IRQ2_FRC3 0x00010998 +#define CS35L41_IRQ2_FRC4 0x0001099C +#define CS35L41_IRQ2_EDGE1 0x00010A10 +#define CS35L41_IRQ2_EDGE4 0x00010A1C +#define CS35L41_IRQ2_POL1 0x00010A90 +#define CS35L41_IRQ2_POL2 0x00010A94 +#define CS35L41_IRQ2_POL3 0x00010A98 +#define CS35L41_IRQ2_POL4 0x00010A9C +#define CS35L41_IRQ2_DB3 0x00010B18 +#define CS35L41_GPIO_STATUS1 0x00011000 +#define CS35L41_GPIO1_CTRL1 0x00011008 +#define CS35L41_GPIO2_CTRL1 0x0001100C +#define CS35L41_MIXER_NGATE_CFG 0x00012000 +#define CS35L41_MIXER_NGATE_CH1_CFG 0x00012004 +#define CS35L41_MIXER_NGATE_CH2_CFG 0x00012008 +#define CS35L41_DSP_MBOX_1 0x00013000 +#define CS35L41_DSP_MBOX_2 0x00013004 +#define CS35L41_DSP_MBOX_3 0x00013008 +#define CS35L41_DSP_MBOX_4 0x0001300C +#define CS35L41_DSP_MBOX_5 0x00013010 +#define CS35L41_DSP_MBOX_6 0x00013014 +#define CS35L41_DSP_MBOX_7 0x00013018 +#define CS35L41_DSP_MBOX_8 0x0001301C +#define CS35L41_DSP_VIRT1_MBOX_1 0x00013020 +#define CS35L41_DSP_VIRT1_MBOX_2 0x00013024 +#define CS35L41_DSP_VIRT1_MBOX_3 0x00013028 +#define CS35L41_DSP_VIRT1_MBOX_4 0x0001302C +#define CS35L41_DSP_VIRT1_MBOX_5 0x00013030 +#define CS35L41_DSP_VIRT1_MBOX_6 0x00013034 +#define CS35L41_DSP_VIRT1_MBOX_7 0x00013038 +#define CS35L41_DSP_VIRT1_MBOX_8 0x0001303C +#define CS35L41_DSP_VIRT2_MBOX_1 0x00013040 +#define CS35L41_DSP_VIRT2_MBOX_2 0x00013044 +#define CS35L41_DSP_VIRT2_MBOX_3 0x00013048 +#define CS35L41_DSP_VIRT2_MBOX_4 0x0001304C +#define CS35L41_DSP_VIRT2_MBOX_5 0x00013050 +#define CS35L41_DSP_VIRT2_MBOX_6 0x00013054 +#define CS35L41_DSP_VIRT2_MBOX_7 0x00013058 +#define CS35L41_DSP_VIRT2_MBOX_8 0x0001305C +#define CS35L41_CLOCK_DETECT_1 0x00014000 +#define CS35L41_TIMER1_CONTROL 0x00015000 +#define CS35L41_TIMER1_COUNT_PRESET 0x00015004 +#define CS35L41_TIMER1_START_STOP 0x0001500C +#define CS35L41_TIMER1_STATUS 0x00015010 +#define CS35L41_TIMER1_COUNT_READBACK 0x00015014 +#define CS35L41_TIMER1_DSP_CLK_CFG 0x00015018 +#define CS35L41_TIMER1_DSP_CLK_STATUS 0x0001501C +#define CS35L41_TIMER2_CONTROL 0x00015100 +#define CS35L41_TIMER2_COUNT_PRESET 0x00015104 +#define CS35L41_TIMER2_START_STOP 0x0001510C +#define CS35L41_TIMER2_STATUS 0x00015110 +#define CS35L41_TIMER2_COUNT_READBACK 0x00015114 +#define CS35L41_TIMER2_DSP_CLK_CFG 0x00015118 +#define CS35L41_TIMER2_DSP_CLK_STATUS 0x0001511C +#define CS35L41_DFT_JTAG_CONTROL 0x00016000 +#define CS35L41_DIE_STS1 0x00017040 +#define CS35L41_DIE_STS2 0x00017044 +#define CS35L41_TEMP_CAL1 0x00017048 +#define CS35L41_TEMP_CAL2 0x0001704C +#define CS35L41_DSP1_XMEM_PACK_0 0x02000000 +#define CS35L41_DSP1_XMEM_PACK_3068 0x02002FF0 +#define CS35L41_DSP1_XMEM_UNPACK32_0 0x02400000 +#define CS35L41_DSP1_XMEM_UNPACK32_2046 0x02401FF8 +#define CS35L41_DSP1_TIMESTAMP_COUNT 0x025C0800 +#define CS35L41_DSP1_SYS_ID 0x025E0000 +#define CS35L41_DSP1_SYS_VERSION 0x025E0004 +#define CS35L41_DSP1_SYS_CORE_ID 0x025E0008 +#define CS35L41_DSP1_SYS_AHB_ADDR 0x025E000C +#define CS35L41_DSP1_SYS_XSRAM_SIZE 0x025E0010 +#define CS35L41_DSP1_SYS_YSRAM_SIZE 0x025E0018 +#define CS35L41_DSP1_SYS_PSRAM_SIZE 0x025E0020 +#define CS35L41_DSP1_SYS_PM_BOOT_SIZE 0x025E0028 +#define CS35L41_DSP1_SYS_FEATURES 0x025E002C +#define CS35L41_DSP1_SYS_FIR_FILTERS 0x025E0030 +#define CS35L41_DSP1_SYS_LMS_FILTERS 0x025E0034 +#define CS35L41_DSP1_SYS_XM_BANK_SIZE 0x025E0038 +#define CS35L41_DSP1_SYS_YM_BANK_SIZE 0x025E003C +#define CS35L41_DSP1_SYS_PM_BANK_SIZE 0x025E0040 +#define CS35L41_DSP1_AHBM_WIN0_CTRL0 0x025E2000 +#define CS35L41_DSP1_AHBM_WIN0_CTRL1 0x025E2004 +#define CS35L41_DSP1_AHBM_WIN1_CTRL0 0x025E2008 +#define CS35L41_DSP1_AHBM_WIN1_CTRL1 0x025E200C +#define CS35L41_DSP1_AHBM_WIN2_CTRL0 0x025E2010 +#define CS35L41_DSP1_AHBM_WIN2_CTRL1 0x025E2014 +#define CS35L41_DSP1_AHBM_WIN3_CTRL0 0x025E2018 +#define CS35L41_DSP1_AHBM_WIN3_CTRL1 0x025E201C +#define CS35L41_DSP1_AHBM_WIN4_CTRL0 0x025E2020 +#define CS35L41_DSP1_AHBM_WIN4_CTRL1 0x025E2024 +#define CS35L41_DSP1_AHBM_WIN5_CTRL0 0x025E2028 +#define CS35L41_DSP1_AHBM_WIN5_CTRL1 0x025E202C +#define CS35L41_DSP1_AHBM_WIN6_CTRL0 0x025E2030 +#define CS35L41_DSP1_AHBM_WIN6_CTRL1 0x025E2034 +#define CS35L41_DSP1_AHBM_WIN7_CTRL0 0x025E2038 +#define CS35L41_DSP1_AHBM_WIN7_CTRL1 0x025E203C +#define CS35L41_DSP1_AHBM_WIN_DBG_CTRL0 0x025E2040 +#define CS35L41_DSP1_AHBM_WIN_DBG_CTRL1 0x025E2044 +#define CS35L41_DSP1_XMEM_UNPACK24_0 0x02800000 +#define CS35L41_DSP1_XMEM_UNPACK24_4093 0x02803FF4 +#define CS35L41_DSP1_CTRL_BASE 0x02B80000 +#define CS35L41_DSP1_CORE_SOFT_RESET 0x02B80010 +#define CS35L41_DSP1_DEBUG 0x02B80040 +#define CS35L41_DSP1_TIMER_CTRL 0x02B80048 +#define CS35L41_DSP1_STREAM_ARB_CTRL 0x02B80050 +#define CS35L41_DSP1_RX1_RATE 0x02B80080 +#define CS35L41_DSP1_RX2_RATE 0x02B80088 +#define CS35L41_DSP1_RX3_RATE 0x02B80090 +#define CS35L41_DSP1_RX4_RATE 0x02B80098 +#define CS35L41_DSP1_RX5_RATE 0x02B800A0 +#define CS35L41_DSP1_RX6_RATE 0x02B800A8 +#define CS35L41_DSP1_RX7_RATE 0x02B800B0 +#define CS35L41_DSP1_RX8_RATE 0x02B800B8 +#define CS35L41_DSP1_TX1_RATE 0x02B80280 +#define CS35L41_DSP1_TX2_RATE 0x02B80288 +#define CS35L41_DSP1_TX3_RATE 0x02B80290 +#define CS35L41_DSP1_TX4_RATE 0x02B80298 +#define CS35L41_DSP1_TX5_RATE 0x02B802A0 +#define CS35L41_DSP1_TX6_RATE 0x02B802A8 +#define CS35L41_DSP1_TX7_RATE 0x02B802B0 +#define CS35L41_DSP1_TX8_RATE 0x02B802B8 +#define CS35L41_DSP1_NMI_CTRL1 0x02B80480 +#define CS35L41_DSP1_NMI_CTRL2 0x02B80488 +#define CS35L41_DSP1_NMI_CTRL3 0x02B80490 +#define CS35L41_DSP1_NMI_CTRL4 0x02B80498 +#define CS35L41_DSP1_NMI_CTRL5 0x02B804A0 +#define CS35L41_DSP1_NMI_CTRL6 0x02B804A8 +#define CS35L41_DSP1_NMI_CTRL7 0x02B804B0 +#define CS35L41_DSP1_NMI_CTRL8 0x02B804B8 +#define CS35L41_DSP1_RESUME_CTRL 0x02B80500 +#define CS35L41_DSP1_IRQ1_CTRL 0x02B80508 +#define CS35L41_DSP1_IRQ2_CTRL 0x02B80510 +#define CS35L41_DSP1_IRQ3_CTRL 0x02B80518 +#define CS35L41_DSP1_IRQ4_CTRL 0x02B80520 +#define CS35L41_DSP1_IRQ5_CTRL 0x02B80528 +#define CS35L41_DSP1_IRQ6_CTRL 0x02B80530 +#define CS35L41_DSP1_IRQ7_CTRL 0x02B80538 +#define CS35L41_DSP1_IRQ8_CTRL 0x02B80540 +#define CS35L41_DSP1_IRQ9_CTRL 0x02B80548 +#define CS35L41_DSP1_IRQ10_CTRL 0x02B80550 +#define CS35L41_DSP1_IRQ11_CTRL 0x02B80558 +#define CS35L41_DSP1_IRQ12_CTRL 0x02B80560 +#define CS35L41_DSP1_IRQ13_CTRL 0x02B80568 +#define CS35L41_DSP1_IRQ14_CTRL 0x02B80570 +#define CS35L41_DSP1_IRQ15_CTRL 0x02B80578 +#define CS35L41_DSP1_IRQ16_CTRL 0x02B80580 +#define CS35L41_DSP1_IRQ17_CTRL 0x02B80588 +#define CS35L41_DSP1_IRQ18_CTRL 0x02B80590 +#define CS35L41_DSP1_IRQ19_CTRL 0x02B80598 +#define CS35L41_DSP1_IRQ20_CTRL 0x02B805A0 +#define CS35L41_DSP1_IRQ21_CTRL 0x02B805A8 +#define CS35L41_DSP1_IRQ22_CTRL 0x02B805B0 +#define CS35L41_DSP1_IRQ23_CTRL 0x02B805B8 +#define CS35L41_DSP1_SCRATCH1 0x02B805C0 +#define CS35L41_DSP1_SCRATCH2 0x02B805C8 +#define CS35L41_DSP1_SCRATCH3 0x02B805D0 +#define CS35L41_DSP1_SCRATCH4 0x02B805D8 +#define CS35L41_DSP1_CCM_CORE_CTRL 0x02BC1000 +#define CS35L41_DSP1_CCM_CLK_OVERRIDE 0x02BC1008 +#define CS35L41_DSP1_XM_MSTR_EN 0x02BC2000 +#define CS35L41_DSP1_XM_CORE_PRI 0x02BC2008 +#define CS35L41_DSP1_XM_AHB_PACK_PL_PRI 0x02BC2010 +#define CS35L41_DSP1_XM_AHB_UP_PL_PRI 0x02BC2018 +#define CS35L41_DSP1_XM_ACCEL_PL0_PRI 0x02BC2020 +#define CS35L41_DSP1_XM_NPL0_PRI 0x02BC2078 +#define CS35L41_DSP1_YM_MSTR_EN 0x02BC20C0 +#define CS35L41_DSP1_YM_CORE_PRI 0x02BC20C8 +#define CS35L41_DSP1_YM_AHB_PACK_PL_PRI 0x02BC20D0 +#define CS35L41_DSP1_YM_AHB_UP_PL_PRI 0x02BC20D8 +#define CS35L41_DSP1_YM_ACCEL_PL0_PRI 0x02BC20E0 +#define CS35L41_DSP1_YM_NPL0_PRI 0x02BC2138 +#define CS35L41_DSP1_PM_MSTR_EN 0x02BC2180 +#define CS35L41_DSP1_PM_PATCH0_ADDR 0x02BC2188 +#define CS35L41_DSP1_PM_PATCH0_EN 0x02BC218C +#define CS35L41_DSP1_PM_PATCH0_DATA_LO 0x02BC2190 +#define CS35L41_DSP1_PM_PATCH0_DATA_HI 0x02BC2194 +#define CS35L41_DSP1_PM_PATCH1_ADDR 0x02BC2198 +#define CS35L41_DSP1_PM_PATCH1_EN 0x02BC219C +#define CS35L41_DSP1_PM_PATCH1_DATA_LO 0x02BC21A0 +#define CS35L41_DSP1_PM_PATCH1_DATA_HI 0x02BC21A4 +#define CS35L41_DSP1_PM_PATCH2_ADDR 0x02BC21A8 +#define CS35L41_DSP1_PM_PATCH2_EN 0x02BC21AC +#define CS35L41_DSP1_PM_PATCH2_DATA_LO 0x02BC21B0 +#define CS35L41_DSP1_PM_PATCH2_DATA_HI 0x02BC21B4 +#define CS35L41_DSP1_PM_PATCH3_ADDR 0x02BC21B8 +#define CS35L41_DSP1_PM_PATCH3_EN 0x02BC21BC +#define CS35L41_DSP1_PM_PATCH3_DATA_LO 0x02BC21C0 +#define CS35L41_DSP1_PM_PATCH3_DATA_HI 0x02BC21C4 +#define CS35L41_DSP1_PM_PATCH4_ADDR 0x02BC21C8 +#define CS35L41_DSP1_PM_PATCH4_EN 0x02BC21CC +#define CS35L41_DSP1_PM_PATCH4_DATA_LO 0x02BC21D0 +#define CS35L41_DSP1_PM_PATCH4_DATA_HI 0x02BC21D4 +#define CS35L41_DSP1_PM_PATCH5_ADDR 0x02BC21D8 +#define CS35L41_DSP1_PM_PATCH5_EN 0x02BC21DC +#define CS35L41_DSP1_PM_PATCH5_DATA_LO 0x02BC21E0 +#define CS35L41_DSP1_PM_PATCH5_DATA_HI 0x02BC21E4 +#define CS35L41_DSP1_PM_PATCH6_ADDR 0x02BC21E8 +#define CS35L41_DSP1_PM_PATCH6_EN 0x02BC21EC +#define CS35L41_DSP1_PM_PATCH6_DATA_LO 0x02BC21F0 +#define CS35L41_DSP1_PM_PATCH6_DATA_HI 0x02BC21F4 +#define CS35L41_DSP1_PM_PATCH7_ADDR 0x02BC21F8 +#define CS35L41_DSP1_PM_PATCH7_EN 0x02BC21FC +#define CS35L41_DSP1_PM_PATCH7_DATA_LO 0x02BC2200 +#define CS35L41_DSP1_PM_PATCH7_DATA_HI 0x02BC2204 +#define CS35L41_DSP1_MPU_XM_ACCESS0 0x02BC3000 +#define CS35L41_DSP1_MPU_YM_ACCESS0 0x02BC3004 +#define CS35L41_DSP1_MPU_WNDW_ACCESS0 0x02BC3008 +#define CS35L41_DSP1_MPU_XREG_ACCESS0 0x02BC300C +#define CS35L41_DSP1_MPU_YREG_ACCESS0 0x02BC3014 +#define CS35L41_DSP1_MPU_XM_ACCESS1 0x02BC3018 +#define CS35L41_DSP1_MPU_YM_ACCESS1 0x02BC301C +#define CS35L41_DSP1_MPU_WNDW_ACCESS1 0x02BC3020 +#define CS35L41_DSP1_MPU_XREG_ACCESS1 0x02BC3024 +#define CS35L41_DSP1_MPU_YREG_ACCESS1 0x02BC302C +#define CS35L41_DSP1_MPU_XM_ACCESS2 0x02BC3030 +#define CS35L41_DSP1_MPU_YM_ACCESS2 0x02BC3034 +#define CS35L41_DSP1_MPU_WNDW_ACCESS2 0x02BC3038 +#define CS35L41_DSP1_MPU_XREG_ACCESS2 0x02BC303C +#define CS35L41_DSP1_MPU_YREG_ACCESS2 0x02BC3044 +#define CS35L41_DSP1_MPU_XM_ACCESS3 0x02BC3048 +#define CS35L41_DSP1_MPU_YM_ACCESS3 0x02BC304C +#define CS35L41_DSP1_MPU_WNDW_ACCESS3 0x02BC3050 +#define CS35L41_DSP1_MPU_XREG_ACCESS3 0x02BC3054 +#define CS35L41_DSP1_MPU_YREG_ACCESS3 0x02BC305C +#define CS35L41_DSP1_MPU_XM_VIO_ADDR 0x02BC3100 +#define CS35L41_DSP1_MPU_XM_VIO_STATUS 0x02BC3104 +#define CS35L41_DSP1_MPU_YM_VIO_ADDR 0x02BC3108 +#define CS35L41_DSP1_MPU_YM_VIO_STATUS 0x02BC310C +#define CS35L41_DSP1_MPU_PM_VIO_ADDR 0x02BC3110 +#define CS35L41_DSP1_MPU_PM_VIO_STATUS 0x02BC3114 +#define CS35L41_DSP1_MPU_LOCK_CONFIG 0x02BC3140 +#define CS35L41_DSP1_MPU_WDT_RST_CTRL 0x02BC3180 +#define CS35L41_DSP1_STRMARB_MSTR0_CFG0 0x02BC5000 +#define CS35L41_DSP1_STRMARB_MSTR0_CFG1 0x02BC5004 +#define CS35L41_DSP1_STRMARB_MSTR0_CFG2 0x02BC5008 +#define CS35L41_DSP1_STRMARB_MSTR1_CFG0 0x02BC5010 +#define CS35L41_DSP1_STRMARB_MSTR1_CFG1 0x02BC5014 +#define CS35L41_DSP1_STRMARB_MSTR1_CFG2 0x02BC5018 +#define CS35L41_DSP1_STRMARB_MSTR2_CFG0 0x02BC5020 +#define CS35L41_DSP1_STRMARB_MSTR2_CFG1 0x02BC5024 +#define CS35L41_DSP1_STRMARB_MSTR2_CFG2 0x02BC5028 +#define CS35L41_DSP1_STRMARB_MSTR3_CFG0 0x02BC5030 +#define CS35L41_DSP1_STRMARB_MSTR3_CFG1 0x02BC5034 +#define CS35L41_DSP1_STRMARB_MSTR3_CFG2 0x02BC5038 +#define CS35L41_DSP1_STRMARB_MSTR4_CFG0 0x02BC5040 +#define CS35L41_DSP1_STRMARB_MSTR4_CFG1 0x02BC5044 +#define CS35L41_DSP1_STRMARB_MSTR4_CFG2 0x02BC5048 +#define CS35L41_DSP1_STRMARB_MSTR5_CFG0 0x02BC5050 +#define CS35L41_DSP1_STRMARB_MSTR5_CFG1 0x02BC5054 +#define CS35L41_DSP1_STRMARB_MSTR5_CFG2 0x02BC5058 +#define CS35L41_DSP1_STRMARB_MSTR6_CFG0 0x02BC5060 +#define CS35L41_DSP1_STRMARB_MSTR6_CFG1 0x02BC5064 +#define CS35L41_DSP1_STRMARB_MSTR6_CFG2 0x02BC5068 +#define CS35L41_DSP1_STRMARB_MSTR7_CFG0 0x02BC5070 +#define CS35L41_DSP1_STRMARB_MSTR7_CFG1 0x02BC5074 +#define CS35L41_DSP1_STRMARB_MSTR7_CFG2 0x02BC5078 +#define CS35L41_DSP1_STRMARB_TX0_CFG0 0x02BC5200 +#define CS35L41_DSP1_STRMARB_TX0_CFG1 0x02BC5204 +#define CS35L41_DSP1_STRMARB_TX1_CFG0 0x02BC5208 +#define CS35L41_DSP1_STRMARB_TX1_CFG1 0x02BC520C +#define CS35L41_DSP1_STRMARB_TX2_CFG0 0x02BC5210 +#define CS35L41_DSP1_STRMARB_TX2_CFG1 0x02BC5214 +#define CS35L41_DSP1_STRMARB_TX3_CFG0 0x02BC5218 +#define CS35L41_DSP1_STRMARB_TX3_CFG1 0x02BC521C +#define CS35L41_DSP1_STRMARB_TX4_CFG0 0x02BC5220 +#define CS35L41_DSP1_STRMARB_TX4_CFG1 0x02BC5224 +#define CS35L41_DSP1_STRMARB_TX5_CFG0 0x02BC5228 +#define CS35L41_DSP1_STRMARB_TX5_CFG1 0x02BC522C +#define CS35L41_DSP1_STRMARB_TX6_CFG0 0x02BC5230 +#define CS35L41_DSP1_STRMARB_TX6_CFG1 0x02BC5234 +#define CS35L41_DSP1_STRMARB_TX7_CFG0 0x02BC5238 +#define CS35L41_DSP1_STRMARB_TX7_CFG1 0x02BC523C +#define CS35L41_DSP1_STRMARB_RX0_CFG0 0x02BC5400 +#define CS35L41_DSP1_STRMARB_RX0_CFG1 0x02BC5404 +#define CS35L41_DSP1_STRMARB_RX1_CFG0 0x02BC5408 +#define CS35L41_DSP1_STRMARB_RX1_CFG1 0x02BC540C +#define CS35L41_DSP1_STRMARB_RX2_CFG0 0x02BC5410 +#define CS35L41_DSP1_STRMARB_RX2_CFG1 0x02BC5414 +#define CS35L41_DSP1_STRMARB_RX3_CFG0 0x02BC5418 +#define CS35L41_DSP1_STRMARB_RX3_CFG1 0x02BC541C +#define CS35L41_DSP1_STRMARB_RX4_CFG0 0x02BC5420 +#define CS35L41_DSP1_STRMARB_RX4_CFG1 0x02BC5424 +#define CS35L41_DSP1_STRMARB_RX5_CFG0 0x02BC5428 +#define CS35L41_DSP1_STRMARB_RX5_CFG1 0x02BC542C +#define CS35L41_DSP1_STRMARB_RX6_CFG0 0x02BC5430 +#define CS35L41_DSP1_STRMARB_RX6_CFG1 0x02BC5434 +#define CS35L41_DSP1_STRMARB_RX7_CFG0 0x02BC5438 +#define CS35L41_DSP1_STRMARB_RX7_CFG1 0x02BC543C +#define CS35L41_DSP1_STRMARB_IRQ0_CFG0 0x02BC5600 +#define CS35L41_DSP1_STRMARB_IRQ0_CFG1 0x02BC5604 +#define CS35L41_DSP1_STRMARB_IRQ0_CFG2 0x02BC5608 +#define CS35L41_DSP1_STRMARB_IRQ1_CFG0 0x02BC5610 +#define CS35L41_DSP1_STRMARB_IRQ1_CFG1 0x02BC5614 +#define CS35L41_DSP1_STRMARB_IRQ1_CFG2 0x02BC5618 +#define CS35L41_DSP1_STRMARB_IRQ2_CFG0 0x02BC5620 +#define CS35L41_DSP1_STRMARB_IRQ2_CFG1 0x02BC5624 +#define CS35L41_DSP1_STRMARB_IRQ2_CFG2 0x02BC5628 +#define CS35L41_DSP1_STRMARB_IRQ3_CFG0 0x02BC5630 +#define CS35L41_DSP1_STRMARB_IRQ3_CFG1 0x02BC5634 +#define CS35L41_DSP1_STRMARB_IRQ3_CFG2 0x02BC5638 +#define CS35L41_DSP1_STRMARB_IRQ4_CFG0 0x02BC5640 +#define CS35L41_DSP1_STRMARB_IRQ4_CFG1 0x02BC5644 +#define CS35L41_DSP1_STRMARB_IRQ4_CFG2 0x02BC5648 +#define CS35L41_DSP1_STRMARB_IRQ5_CFG0 0x02BC5650 +#define CS35L41_DSP1_STRMARB_IRQ5_CFG1 0x02BC5654 +#define CS35L41_DSP1_STRMARB_IRQ5_CFG2 0x02BC5658 +#define CS35L41_DSP1_STRMARB_IRQ6_CFG0 0x02BC5660 +#define CS35L41_DSP1_STRMARB_IRQ6_CFG1 0x02BC5664 +#define CS35L41_DSP1_STRMARB_IRQ6_CFG2 0x02BC5668 +#define CS35L41_DSP1_STRMARB_IRQ7_CFG0 0x02BC5670 +#define CS35L41_DSP1_STRMARB_IRQ7_CFG1 0x02BC5674 +#define CS35L41_DSP1_STRMARB_IRQ7_CFG2 0x02BC5678 +#define CS35L41_DSP1_STRMARB_RESYNC_MSK 0x02BC5A00 +#define CS35L41_DSP1_STRMARB_ERR_STATUS 0x02BC5A08 +#define CS35L41_DSP1_INTPCTL_RES_STATIC 0x02BC6000 +#define CS35L41_DSP1_INTPCTL_RES_DYN 0x02BC6004 +#define CS35L41_DSP1_INTPCTL_NMI_CTRL 0x02BC6008 +#define CS35L41_DSP1_INTPCTL_IRQ_INV 0x02BC6010 +#define CS35L41_DSP1_INTPCTL_IRQ_MODE 0x02BC6014 +#define CS35L41_DSP1_INTPCTL_IRQ_EN 0x02BC6018 +#define CS35L41_DSP1_INTPCTL_IRQ_MSK 0x02BC601C +#define CS35L41_DSP1_INTPCTL_IRQ_FLUSH 0x02BC6020 +#define CS35L41_DSP1_INTPCTL_IRQ_MSKCLR 0x02BC6024 +#define CS35L41_DSP1_INTPCTL_IRQ_FRC 0x02BC6028 +#define CS35L41_DSP1_INTPCTL_IRQ_MSKSET 0x02BC602C +#define CS35L41_DSP1_INTPCTL_IRQ_ERR 0x02BC6030 +#define CS35L41_DSP1_INTPCTL_IRQ_PEND 0x02BC6034 +#define CS35L41_DSP1_INTPCTL_IRQ_GEN 0x02BC6038 +#define CS35L41_DSP1_INTPCTL_TESTBITS 0x02BC6040 +#define CS35L41_DSP1_WDT_CONTROL 0x02BC7000 +#define CS35L41_DSP1_WDT_STATUS 0x02BC7008 +#define CS35L41_DSP1_YMEM_PACK_0 0x02C00000 +#define CS35L41_DSP1_YMEM_PACK_1532 0x02C017F0 +#define CS35L41_DSP1_YMEM_UNPACK32_0 0x03000000 +#define CS35L41_DSP1_YMEM_UNPACK32_1022 0x03000FF8 +#define CS35L41_DSP1_YMEM_UNPACK24_0 0x03400000 +#define CS35L41_DSP1_YMEM_UNPACK24_2045 0x03401FF4 +#define CS35L41_DSP1_PMEM_0 0x03800000 +#define CS35L41_DSP1_PMEM_5114 0x03804FE8 + +/*test regs for emulation bringup*/ +#define CS35L41_PLL_OVR 0x00003018 +#define CS35L41_BST_TEST_DUTY 0x00003900 +#define CS35L41_DIGPWM_IOCTRL 0x0000706C + +/*registers populated by OTP*/ +#define CS35L41_OTP_TRIM_1 0x0000208c +#define CS35L41_OTP_TRIM_2 0x00002090 +#define CS35L41_OTP_TRIM_3 0x00003010 +#define CS35L41_OTP_TRIM_4 0x0000300C +#define CS35L41_OTP_TRIM_5 0x0000394C +#define CS35L41_OTP_TRIM_6 0x00003950 +#define CS35L41_OTP_TRIM_7 0x00003954 +#define CS35L41_OTP_TRIM_8 0x00003958 +#define CS35L41_OTP_TRIM_9 0x0000395C +#define CS35L41_OTP_TRIM_10 0x0000416C +#define CS35L41_OTP_TRIM_11 0x00004160 +#define CS35L41_OTP_TRIM_12 0x00004170 +#define CS35L41_OTP_TRIM_13 0x00004360 +#define CS35L41_OTP_TRIM_14 0x00004448 +#define CS35L41_OTP_TRIM_15 0x0000444C +#define CS35L41_OTP_TRIM_16 0x00006E30 +#define CS35L41_OTP_TRIM_17 0x00006E34 +#define CS35L41_OTP_TRIM_18 0x00006E38 +#define CS35L41_OTP_TRIM_19 0x00006E3C +#define CS35L41_OTP_TRIM_20 0x00006E40 +#define CS35L41_OTP_TRIM_21 0x00006E44 +#define CS35L41_OTP_TRIM_22 0x00006E48 +#define CS35L41_OTP_TRIM_23 0x00006E4C +#define CS35L41_OTP_TRIM_24 0x00006E50 +#define CS35L41_OTP_TRIM_25 0x00006E54 +#define CS35L41_OTP_TRIM_26 0x00006E58 +#define CS35L41_OTP_TRIM_27 0x00006E5C +#define CS35L41_OTP_TRIM_28 0x00006E60 +#define CS35L41_OTP_TRIM_29 0x00006E64 +#define CS35L41_OTP_TRIM_30 0x00007418 +#define CS35L41_OTP_TRIM_31 0x0000741C +#define CS35L41_OTP_TRIM_32 0x00007434 +#define CS35L41_OTP_TRIM_33 0x00007068 +#define CS35L41_OTP_TRIM_34 0x0000410C +#define CS35L41_OTP_TRIM_35 0x0000400C +#define CS35L41_OTP_TRIM_36 0x00002030 + +#define CS35L41_MAX_CACHE_REG 36 +#define CS35L41_OTP_SIZE_WORDS 32 +#define CS35L41_NUM_OTP_ELEM 100 +#define CS35L41_NUM_OTP_MAPS 5 + +#define CS35L41_VALID_PDATA 0x80000000 +#define CS35L41_NUM_SUPPLIES 2 + +#define CS35L41_SCLK_MSTR_MASK 0x10 +#define CS35L41_SCLK_MSTR_SHIFT 4 +#define CS35L41_LRCLK_MSTR_MASK 0x01 +#define CS35L41_LRCLK_MSTR_SHIFT 0 +#define CS35L41_SCLK_INV_MASK 0x40 +#define CS35L41_SCLK_INV_SHIFT 6 +#define CS35L41_LRCLK_INV_MASK 0x04 +#define CS35L41_LRCLK_INV_SHIFT 2 +#define CS35L41_SCLK_FRC_MASK 0x20 +#define CS35L41_SCLK_FRC_SHIFT 5 +#define CS35L41_LRCLK_FRC_MASK 0x02 +#define CS35L41_LRCLK_FRC_SHIFT 1 + +#define CS35L41_AMP_GAIN_PCM_MASK 0x3E0 +#define CS35L41_AMP_GAIN_ZC_MASK 0x0400 +#define CS35L41_AMP_GAIN_ZC_SHIFT 10 + +#define CS35L41_BST_CTL_MASK 0xFF +#define CS35L41_BST_CTL_SEL_MASK 0x03 +#define CS35L41_BST_CTL_SEL_REG 0x00 +#define CS35L41_BST_CTL_SEL_CLASSH 0x01 +#define CS35L41_BST_IPK_MASK 0x7F +#define CS35L41_BST_IPK_SHIFT 0 +#define CS35L41_BST_LIM_MASK 0x4 +#define CS35L41_BST_LIM_SHIFT 2 +#define CS35L41_BST_K1_MASK 0x000000FF +#define CS35L41_BST_K1_SHIFT 0 +#define CS35L41_BST_K2_MASK 0x0000FF00 +#define CS35L41_BST_K2_SHIFT 8 +#define CS35L41_BST_SLOPE_MASK 0x0000FF00 +#define CS35L41_BST_SLOPE_SHIFT 8 +#define CS35L41_BST_LBST_VAL_MASK 0x00000003 +#define CS35L41_BST_LBST_VAL_SHIFT 0 + +#define CS35L41_TEMP_THLD_MASK 0x03 +#define CS35L41_VMON_IMON_VOL_MASK 0x07FF07FF +#define CS35L41_PDM_MODE_MASK 0x01 +#define CS35L41_PDM_MODE_SHIFT 0 + +#define CS35L41_CH_MEM_DEPTH_MASK 0x07 +#define CS35L41_CH_MEM_DEPTH_SHIFT 0 +#define CS35L41_CH_HDRM_CTL_MASK 0x007F0000 +#define CS35L41_CH_HDRM_CTL_SHIFT 16 +#define CS35L41_CH_REL_RATE_MASK 0xFF00 +#define CS35L41_CH_REL_RATE_SHIFT 8 +#define CS35L41_CH_WKFET_DLY_MASK 0x001C +#define CS35L41_CH_WKFET_DLY_SHIFT 2 +#define CS35L41_CH_WKFET_THLD_MASK 0x0F00 +#define CS35L41_CH_WKFET_THLD_SHIFT 8 + +#define CS35L41_HW_NG_SEL_MASK 0x3F00 +#define CS35L41_HW_NG_SEL_SHIFT 8 +#define CS35L41_HW_NG_DLY_MASK 0x0070 +#define CS35L41_HW_NG_DLY_SHIFT 4 +#define CS35L41_HW_NG_THLD_MASK 0x0007 +#define CS35L41_HW_NG_THLD_SHIFT 0 + +#define CS35L41_DSP_NG_ENABLE_MASK 0x00010000 +#define CS35L41_DSP_NG_ENABLE_SHIFT 16 +#define CS35L41_DSP_NG_THLD_MASK 0x7 +#define CS35L41_DSP_NG_THLD_SHIFT 0 +#define CS35L41_DSP_NG_DELAY_MASK 0x0F00 +#define CS35L41_DSP_NG_DELAY_SHIFT 8 + +#define CS35L41_ASP_FMT_MASK 0x0700 +#define CS35L41_ASP_FMT_SHIFT 8 +#define CS35L41_ASP_DOUT_HIZ_MASK 0x03 +#define CS35L41_ASP_DOUT_HIZ_SHIFT 0 +#define CS35L41_ASP_WIDTH_16 0x10 +#define CS35L41_ASP_WIDTH_24 0x18 +#define CS35L41_ASP_WIDTH_32 0x20 +#define CS35L41_ASP_WIDTH_TX_MASK 0xFF0000 +#define CS35L41_ASP_WIDTH_TX_SHIFT 16 +#define CS35L41_ASP_WIDTH_RX_MASK 0xFF000000 +#define CS35L41_ASP_WIDTH_RX_SHIFT 24 +#define CS35L41_ASP_RX1_SLOT_MASK 0x3F +#define CS35L41_ASP_RX1_SLOT_SHIFT 0 +#define CS35L41_ASP_RX2_SLOT_MASK 0x3F00 +#define CS35L41_ASP_RX2_SLOT_SHIFT 8 +#define CS35L41_ASP_RX_WL_MASK 0x3F +#define CS35L41_ASP_TX_WL_MASK 0x3F +#define CS35L41_ASP_RX_WL_SHIFT 0 +#define CS35L41_ASP_TX_WL_SHIFT 0 +#define CS35L41_ASP_SOURCE_MASK 0x7F + +#define CS35L41_INPUT_SRC_ASPRX1 0x08 +#define CS35L41_INPUT_SRC_ASPRX2 0x09 +#define CS35L41_INPUT_SRC_VMON 0x18 +#define CS35L41_INPUT_SRC_IMON 0x19 +#define CS35L41_INPUT_SRC_CLASSH 0x21 +#define CS35L41_INPUT_SRC_VPMON 0x28 +#define CS35L41_INPUT_SRC_VBSTMON 0x29 +#define CS35L41_INPUT_SRC_TEMPMON 0x3A +#define CS35L41_INPUT_SRC_RSVD 0x3B +#define CS35L41_INPUT_DSP_TX1 0x32 +#define CS35L41_INPUT_DSP_TX2 0x33 + +#define CS35L41_PLL_CLK_SEL_MASK 0x07 +#define CS35L41_PLL_CLK_SEL_SHIFT 0 +#define CS35L41_PLL_CLK_EN_MASK 0x10 +#define CS35L41_PLL_CLK_EN_SHIFT 4 +#define CS35L41_PLL_OPENLOOP_MASK 0x0800 +#define CS35L41_PLL_OPENLOOP_SHIFT 11 +#define CS35L41_PLLSRC_SCLK 0 +#define CS35L41_PLLSRC_LRCLK 1 +#define CS35L41_PLLSRC_SELF 3 +#define CS35L41_PLLSRC_PDMCLK 4 +#define CS35L41_PLLSRC_MCLK 5 +#define CS35L41_PLLSRC_SWIRE 7 +#define CS35L41_REFCLK_FREQ_MASK 0x7E0 +#define CS35L41_REFCLK_FREQ_SHIFT 5 + +#define CS35L41_GLOBAL_FS_MASK 0x1F +#define CS35L41_GLOBAL_FS_SHIFT 0 + +#define CS35L41_GLOBAL_EN_MASK 0x01 +#define CS35L41_GLOBAL_EN_SHIFT 0 +#define CS35L41_BST_EN_MASK 0x0030 +#define CS35L41_BST_EN_SHIFT 4 +#define CS35L41_BST_EN_DEFAULT 0x2 +#define CS35L41_AMP_EN_SHIFT 0 +#define CS35L41_AMP_EN_MASK 1 + +#define CS35L41_PDN_DONE_MASK 0x00800000 +#define CS35L41_PDN_DONE_SHIFT 23 +#define CS35L41_PUP_DONE_MASK 0x01000000 +#define CS35L41_PUP_DONE_SHIFT 24 + +#define CS35L36_PUP_DONE_IRQ_UNMASK 0x5F +#define CS35L36_PUP_DONE_IRQ_MASK 0xBF + +#define CS35L41_AMP_SHORT_ERR 0x80000000 +#define CS35L41_BST_SHORT_ERR 0x0100 +#define CS35L41_TEMP_WARN 0x8000 +#define CS35L41_TEMP_ERR 0x00020000 +#define CS35L41_BST_OVP_ERR 0x40 +#define CS35L41_BST_DCM_UVP_ERR 0x80 +#define CS35L41_OTP_BOOT_DONE 0x02 +#define CS35L41_PLL_UNLOCK 0x10 +#define CS35L41_OTP_BOOT_ERR 0x80000000 + +#define CS35L41_AMP_SHORT_ERR_RLS 0x02 +#define CS35L41_BST_SHORT_ERR_RLS 0x04 +#define CS35L41_BST_OVP_ERR_RLS 0x08 +#define CS35L41_BST_UVP_ERR_RLS 0x10 +#define CS35L41_TEMP_WARN_ERR_RLS 0x20 +#define CS35L41_TEMP_ERR_RLS 0x40 + +#define CS35L41_INT1_MASK_DEFAULT 0x7FFCFE3F +#define CS35L41_INT1_UNMASK_PUP 0xFEFFFFFF +#define CS35L41_INT1_UNMASK_PDN 0xFF7FFFFF + +#define CS35L41_GPIO_DIR_MASK 0x80000000 +#define CS35L41_GPIO_DIR_SHIFT 31 +#define CS35L41_GPIO1_CTRL_MASK 0x00030000 +#define CS35L41_GPIO1_CTRL_SHIFT 16 +#define CS35L41_GPIO2_CTRL_MASK 0x07000000 +#define CS35L41_GPIO2_CTRL_SHIFT 24 +#define CS35L41_GPIO_CTRL_OPEN_INT 2 +#define CS35L41_GPIO_CTRL_ACTV_LO 4 +#define CS35L41_GPIO_CTRL_ACTV_HI 5 +#define CS35L41_GPIO_POL_MASK 0x1000 +#define CS35L41_GPIO_POL_SHIFT 12 + +#define CS35L41_AMP_INV_PCM_SHIFT 14 +#define CS35L41_AMP_INV_PCM_MASK BIT(CS35L41_AMP_INV_PCM_SHIFT) +#define CS35L41_AMP_PCM_VOL_SHIFT 3 +#define CS35L41_AMP_PCM_VOL_MASK (0x7FF << 3) +#define CS35L41_AMP_PCM_VOL_MUTE 0x4CF + +#define CS35L41_CHIP_ID 0x35a40 +#define CS35L41R_CHIP_ID 0x35b40 +#define CS35L41_MTLREVID_MASK 0x0F +#define CS35L41_REVID_A0 0xA0 +#define CS35L41_REVID_B0 0xB0 +#define CS35L41_REVID_B2 0xB2 + +#define CS35L41_HALO_CORE_RESET 0x00000200 + +#define CS35L41_FS1_WINDOW_MASK 0x000007FF +#define CS35L41_FS2_WINDOW_MASK 0x00FFF800 +#define CS35L41_FS2_WINDOW_SHIFT 12 + +#define CS35L41_SPI_MAX_FREQ 4000000 +#define CS35L41_REGSTRIDE 4 +enum cs35l41_clk_ids {CS35L41_CLKID_SCLK =0 , CS35L41_CLKID_LRCLK = 1,
@@ -31,4 +746,22 @@ struct cs35l41_platform_data { struct cs35l41_irq_cfg irq_config2; }; +struct cs35l41_otp_packed_element_t { +u32 reg; +u8 shift; +u8 size; +}; + +struct cs35l41_otp_map_element_t { +u32 id; +u32 num_elements; +const struct cs35l41_otp_packed_element_t *map; +u32 bit_offset; +u32 word_offset; +}; + +extern const struct cs35l41_otp_map_element_t cs35l41_otp_map_map[CS35L41_NUM_OTP_MAPS ]; +extern struct regmap_config cs35l41_regmap_i2c; +extern struct regmap_config cs35l41_regmap_spi; +#endif /* __CS35L41_H */
sound/soc/codecs/Kconfig +5 -0
@@ -612,6 +612,11 @@ config SND_SOC_CS35L36 tristate "Cirrus Logic CS35L36 CODEC" depends on I2C +config SND_SOC_CS35L41_LIB + tristate + default y if SND_SOC_CS35L41=y + default m if SND_SOC_CS35L41=m + config SND_SOC_CS35L41 tristate default y if SND_SOC_CS35L41_SPI=y
sound/soc/codecs/Makefile +3 -1
@@ -54,7 +54,8 @@ snd-soc-cs35l33-objs := cs35l33.o snd-soc-cs35l34-objs := cs35l34.o snd-soc-cs35l35-objs := cs35l35.o snd-soc-cs35l36-objs := cs35l36.o -snd-soc-cs35l41-objs := cs35l41.o cs35l41-tables.o +snd-soc-cs35l41-lib-objs := cs35l41-lib.o +snd-soc-cs35l41-objs := cs35l41.o snd-soc-cs35l41-spi-objs := cs35l41-spi.o snd-soc-cs35l41-i2c-objs := cs35l41-i2c.o snd-soc-cs42l42-objs := cs42l42.o
@@ -393,6 +394,7 @@ obj-$(CONFIG_SND_SOC_CS35L34) += snd-soc-cs35l34.o obj-$(CONFIG_SND_SOC_CS35L35) += snd-soc-cs35l35.o obj-$(CONFIG_SND_SOC_CS35L36) += snd-soc-cs35l36.o obj-$(CONFIG_SND_SOC_CS35L41) += snd-soc-cs35l41.o +obj-$(CONFIG_SND_SOC_CS35L41_LIB) += snd-soc-cs35l41-lib.o obj-$(CONFIG_SND_SOC_CS35L41_SPI) += snd-soc-cs35l41-spi.o obj-$(CONFIG_SND_SOC_CS35L41_I2C) += snd-soc-cs35l41-i2c.o obj-$(CONFIG_SND_SOC_CS42L42) += snd-soc-cs42l42.o
sound/soc/codecs/cs35l41-i2c.c +0 -1
@@ -17,7 +17,6 @@#include <linux/platform_device.h> #include <linux/slab.h> -#include <sound/cs35l41.h> #include "cs35l41.h" static const struct i2c_device_id cs35l41_id_i2c[] = {
sound/soc/codecs/cs35l41-lib.c renamed from sound/soc/codecs/cs35l41-tables.c +12 -2
@@ -1,12 +1,16 @@// SPDX-License-Identifier: GPL-2.0 // -// cs35l41-tables.c -- CS35L41 ALSA SoC audio driver +// cs35l41-lib.c -- CS35L41 Common functions for HDA and ASoC Audio drivers // // Copyright 2017-2021 Cirrus Logic, Inc. // // Author: David Rhodes <[email protected]> +// Author: Lucas Tanure <[email protected]> -#include "cs35l41.h" +#include <linux/module.h> +#include <linux/regmap.h> + +#include <sound/cs35l41.h> static const struct reg_default cs35l41_reg[] = { {CS35L41_PWR_CTRL1 ,0x00000000 },
@@ -688,6 +692,7 @@ const struct cs35l41_otp_map_element_t cs35l41_otp_map_map[CS35L41_NUM_OTP_MAPS] .word_offset = 2, }, }; +EXPORT_SYMBOL_GPL (cs35l41_otp_map_map);struct regmap_config cs35l41_regmap_i2c = { .reg_bits = 32,
@@ -721,3 +726,8 @@ struct regmap_config cs35l41_regmap_spi = { .cache_type = REGCACHE_RBTREE, };EXPORT_SYMBOL_GPL (cs35l41_regmap_spi); + +MODULE_DESCRIPTION ("CS35L41 library" ); +MODULE_AUTHOR ("David Rhodes, Cirrus Logic Inc, <[email protected]>" ); +MODULE_AUTHOR ("Lucas Tanure, Cirrus Logic Inc, <[email protected]>" ); +MODULE_LICENSE ("GPL" );
sound/soc/codecs/cs35l41-spi.c +0 -1
@@ -15,7 +15,6 @@#include <linux/platform_device.h> #include <linux/spi/spi.h> -#include <sound/cs35l41.h> #include "cs35l41.h" static const struct spi_device_id cs35l41_id_spi[] = {
sound/soc/codecs/cs35l41.h +0 -734
749 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v5 2/10 ASoC: cs35l41: Move cs35l41_otp_unpack to shared code
In reply to Lucas TanureASoC and HDA will do the same cs35l41_otp_unpack, so move it to shared code
--- include/sound/cs35l41.h | 4 +- sound/soc/codecs/cs35l41-lib.c | 121 ++++++++++++++++++++++++++++++- sound/soc/codecs/cs35l41.c | 125 +-------------------------------- 3 files changed, 122 insertions(+), 128 deletions(-)
include/sound/cs35l41.h +2 -2
@@ -534,7 +534,6 @@#define CS35L41_MAX_CACHE_REG 36#define CS35L41_OTP_SIZE_WORDS 32#define CS35L41_NUM_OTP_ELEM 100 -#define CS35L41_NUM_OTP_MAPS 5#define CS35L41_VALID_PDATA 0x80000000#define CS35L41_NUM_SUPPLIES 2
@@ -760,8 +759,9 @@ struct cs35l41_otp_map_element_t { u32 word_offset; }; -extern const struct cs35l41_otp_map_element_t cs35l41_otp_map_map[CS35L41_NUM_OTP_MAPS ];extern struct regmap_config cs35l41_regmap_i2c;extern struct regmap_config cs35l41_regmap_spi; +int cs35l41_otp_unpack (struct device *dev,struct regmap *regmap); +#endif /* __CS35L41_H */
sound/soc/codecs/cs35l41-lib.c +119 -2
147 lines not on this page · raw message
sound/soc/codecs/cs35l41.c +1 -124
143 lines not on this page · raw message
Signature · 1 line
2.34.1
Re: [PATCH v5 02/10] ASoC: cs35l41: Move cs35l41_otp_unpack to shared code
Quoted 2 lines · Lucas Tanure
ASoC and HDA will do the same
cs35l41_otp_unpack, so move it to shared code
...
sound/soc/codecs/cs35l41-lib.c struct regmap_config cs35l41_regmap_spi = { · line 739
Quoted 8 lines
sound/soc/codecs/cs35l41-lib.c +8
-0+static const struct cs35l41_otp_map_element_t *cs35l41_find_otp_map (u32 otp_id) +{ +int i; + +for (i =0 ; i <ARRAY_SIZE (cs35l41_otp_map_map); i++) { +if (cs35l41_otp_map_map[i].id == otp_id) +return &cs35l41_otp_map_map[i]; + }
The parenthesis could be dropped.
Quoted 18 lines
sound/soc/codecs/cs35l41-lib.c +18
-0+return NULL ; +} +int cs35l41_otp_unpack (struct device *dev,struct regmap *regmap) +{ +const struct cs35l41_otp_map_element_t *otp_map_match; +const struct cs35l41_otp_packed_element_t *otp_map; +int bit_offset, word_offset, ret, i; +unsigned int bit_sum =8 ; +u32 otp_val, otp_id_reg; +u32 *otp_mem; + + otp_mem =kmalloc_array (CS35L41_OTP_SIZE_WORDS ,sizeof (*otp_mem),GFP_KERNEL ); +if (!otp_mem) +return -ENOMEM ; + + ret =regmap_read (regmap,CS35L41_OTPID , &otp_id_reg); +if (ret) { +dev_err (dev,"Read OTP ID failed: %d\n" , ret);
sound/soc/codecs/cs35l41-lib.c struct regmap_config cs35l41_regmap_spi = { · line 769
Quoted 10 lines
sound/soc/codecs/cs35l41-lib.c +10
-0+ goto err_otp_unpack; + } + + otp_map_match =cs35l41_find_otp_map (otp_id_reg); + +if (!otp_map_match) { +dev_err (dev,"OTP Map matching ID %d not found\n" , otp_id_reg); + ret = -EINVAL ; + goto err_otp_unpack; + }
This block could be understood as: assign and check. Surrounding blocks that carry similar value do not have a newline between assignment and check. My suggestion is to drop that newline here so the block looks more cohesive when compared with the rest of the function.
Quoted 27 lines
sound/soc/codecs/cs35l41-lib.c +27
-0+ + ret =regmap_bulk_read (regmap,CS35L41_OTP_MEM0 , otp_mem,CS35L41_OTP_SIZE_WORDS ); +if (ret) { +dev_err (dev,"Read OTP Mem failed: %d\n" , ret); + goto err_otp_unpack; + } + + otp_map = otp_map_match->map; + + bit_offset = otp_map_match->bit_offset; + word_offset = otp_map_match->word_offset; + + ret =regmap_write (regmap,CS35L41_TEST_KEY_CTL ,0x00000055 ); +if (ret) { +dev_err (dev,"Write Unlock key failed 1/2: %d\n" , ret); + goto err_otp_unpack; + } + ret =regmap_write (regmap,CS35L41_TEST_KEY_CTL ,0x000000AA ); +if (ret) { +dev_err (dev,"Write Unlock key failed 2/2: %d\n" , ret); + goto err_otp_unpack; + } + +for (i =0 ; i < otp_map_match->num_elements; i++) { +dev_dbg (dev,"bitoffset= %d, word_offset=%d, bit_sum mod 32=%d\n" , + bit_offset, word_offset, bit_sum %32 ); +if (bit_offset + otp_map[i].size -1 >=32 ) {
sound/soc/codecs/cs35l41-lib.c struct regmap_config cs35l41_regmap_spi = { · line 806
Quoted 10 lines
sound/soc/codecs/cs35l41-lib.c +10
-0+ otp_val = (otp_mem[word_offset] & +GENMASK (31 , bit_offset)) >> bit_offset; + otp_val |= (otp_mem[++word_offset] & +GENMASK (bit_offset + otp_map[i].size -33 ,0 )) << + (32 - bit_offset); + bit_offset += otp_map[i].size -32 ; + }else { + otp_val = (otp_mem[word_offset] & +GENMASK (bit_offset + otp_map[i].size -1 , bit_offset) + ) >> bit_offset;
The ')' looks off (the '>>' too), at least it does not match the convention seen in if-statement above. Choosing single convention could improve the readability.
Quoted 22 lines
sound/soc/codecs/cs35l41-lib.c +22
-0+ bit_offset += otp_map[i].size; + } + bit_sum += otp_map[i].size; + +if (bit_offset ==32 ) { + bit_offset =0 ; + word_offset++; + } + +if (otp_map[i].reg !=0 ) { + ret =regmap_update_bits (regmap, otp_map[i].reg, +GENMASK (otp_map[i].shift + otp_map[i].size -1 , + otp_map[i].shift), + otp_val << otp_map[i].shift); +if (ret <0 ) { +dev_err (dev,"Write OTP val failed: %d\n" , ret); + goto err_otp_unpack; + } + } + } + + ret =regmap_write (regmap,CS35L41_TEST_KEY_CTL ,0x000000CC );
sound/soc/codecs/cs35l41-lib.c struct regmap_config cs35l41_regmap_spi = { · line 838
Quoted 10 lines
sound/soc/codecs/cs35l41-lib.c +10
-0+if (ret) { +dev_err (dev,"Write Lock key failed 1/2: %d\n" , ret); + goto err_otp_unpack; + } + ret =regmap_write (regmap,CS35L41_TEST_KEY_CTL ,0x00000033 ); +if (ret) { +dev_err (dev,"Write Lock key failed 2/2: %d\n" , ret); + goto err_otp_unpack; + } + ret =0 ;
Hmm.. maybe I'm missing something, but isn't the 'ret' already '0' by the time we get here?
Quoted 7 lines
sound/soc/codecs/cs35l41-lib.c +7
-0+err_otp_unpack: +kfree (otp_mem); + +return ret; +} +EXPORT_SYMBOL_GPL (cs35l41_otp_unpack); +
PATCH v5 3/10 ASoC: cs35l41: Move power initializations to reg_sequence
In reply to Lucas TanureASoC and HDA systems for all revisions of CS35L41 will benefit from having this initialization, so add it to reg_sequence of each revision
By moving to reg_sequence all gains are set to zero. And boost, monitoring parts, and class D amplifier are disabled.
--- sound/soc/codecs/cs35l41-lib.c | 3 ++- sound/soc/codecs/cs35l41.c | 20 ++++++-------------- 2 files changed, 8 insertions(+), 15 deletions(-)
sound/soc/codecs/cs35l41-lib.c +2 -1
@@ -17,6 +17,7 @@static const struct reg_default cs35l41_reg[] = { {CS35L41_PWR_CTRL1 ,0x00000000 }, + {CS35L41_PWR_CTRL2 ,0x00000000 }, {CS35L41_PWR_CTRL3 ,0x01000010 }, {CS35L41_GPIO_PAD_CONTROL ,0x00000000 }, {CS35L41_SP_ENABLES ,0x00000000 },
@@ -46,7 +47,7 @@ static const struct reg_default cs35l41_reg[] = { { CS35L41_CLASSH_CFG, 0x000B0405 }, { CS35L41_WKFET_CFG, 0x00000111 }, { CS35L41_NG_CFG, 0x00000033 }, - { CS35L41_AMP_GAIN_CTRL, 0x00000273 }, + { CS35L41_AMP_GAIN_CTRL, 0x00000000 }, { CS35L41_GPIO1_CTRL1, 0xE1000001 }, { CS35L41_GPIO2_CTRL1, 0xE1000001 }, { CS35L41_MIXER_NGATE_CFG, 0x00000000 },
sound/soc/codecs/cs35l41.c +6 -14
@@ -1288,6 +1288,8 @@ static const struct reg_sequence cs35l41_reva0_errata_patch[] = { { CS35L41_DSP1_XM_ACCEL_PL0_PRI, 0x00000000 }, { 0x00000040, 0x0000CCCC }, { 0x00000040, 0x00003333 }, + { CS35L41_PWR_CTRL2, 0x00000000 }, + { CS35L41_AMP_GAIN_CTRL, 0x00000000 }, }; static const struct reg_sequence cs35l41_revb0_errata_patch[] = {
@@ -1301,6 +1303,8 @@ static const struct reg_sequence cs35l41_revb0_errata_patch[] = { { CS35L41_DSP1_XM_ACCEL_PL0_PRI, 0x00000000 }, { 0x00000040, 0x0000CCCC }, { 0x00000040, 0x00003333 }, + { CS35L41_PWR_CTRL2, 0x00000000 }, + { CS35L41_AMP_GAIN_CTRL, 0x00000000 }, }; static const struct reg_sequence cs35l41_revb2_errata_patch[] = {
@@ -1314,6 +1318,8 @@ static const struct reg_sequence cs35l41_revb2_errata_patch[] = { { CS35L41_DSP1_XM_ACCEL_PL0_PRI, 0x00000000 }, { 0x00000040, 0x0000CCCC }, { 0x00000040, 0x00003333 }, + { CS35L41_PWR_CTRL2, 0x00000000 }, + { CS35L41_AMP_GAIN_CTRL, 0x00000000 }, }; static const struct reg_sequence cs35l41_fs_errata_patch[] = {
@@ -1556,20 +1562,6 @@ int cs35l41_probe(struct cs35l41_private *cs35l41, goto err; } - ret =regmap_update_bits (cs35l41->regmap,CS35L41_PWR_CTRL2 , -CS35L41_AMP_EN_MASK ,0 ); -if (ret <0 ) { -dev_err (cs35l41->dev,"Write CS35L41_PWR_CTRL2 failed: %d\n" , ret); - goto err; - } - - ret =regmap_update_bits (cs35l41->regmap,CS35L41_AMP_GAIN_CTRL , -CS35L41_AMP_GAIN_PCM_MASK ,0 ); -if (ret <0 ) { -dev_err (cs35l41->dev,"Write CS35L41_AMP_GAIN_CTRL failed: %d\n" , ret); - goto err; - } - ret =cs35l41_set_pdata (cs35l41);if (ret <0 ) {dev_err (cs35l41->dev,"Set pdata failed: %d\n" , ret);
Signature · 1 line
2.34.1
PATCH v5 4/10 ASoC: cs35l41: Create shared function for errata patches
In reply to Lucas TanureASoC and HDA systems require the same errata patches, so move it to the shared code using a function the correctly applies the patches by revision
Also, move CS35L41_DSP1_CCM_CORE_CTRL write to errata patch function as is required to be written at boot, but not in regmap_register_patch sequence as will affect waking up from hibernation
--- include/sound/cs35l41.h | 1 + sound/soc/codecs/cs35l41-lib.c | 89 ++++++++++++++++++++++++++++++++ sound/soc/codecs/cs35l41.c | 92 ++-------------------------------- 3 files changed, 93 insertions(+), 89 deletions(-)
include/sound/cs35l41.h +1 -0
@@ -763,5 +763,6 @@ extern struct regmap_config cs35l41_regmap_i2c;extern struct regmap_config cs35l41_regmap_spi;int cs35l41_otp_unpack (struct device *dev,struct regmap *regmap); +int cs35l41_register_errata_patch (struct device *dev,struct regmap *reg,unsigned int reg_revid);#endif /* __CS35L41_H */
sound/soc/codecs/cs35l41-lib.c +89 -0
101 lines not on this page · raw message
sound/soc/codecs/cs35l41.c +3 -89
110 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v5 5/10 ASoC: cs35l41: Create shared function for setting channels
In reply to Lucas TanureASoC and HDA will use the same register to set channels for the device
--- include/sound/cs35l41.h | 3 +++ sound/soc/codecs/cs35l41-lib.c | 32 ++++++++++++++++++++++++++++++++ sound/soc/codecs/cs35l41.c | 30 +++--------------------------- 3 files changed, 38 insertions(+), 27 deletions(-)
include/sound/cs35l41.h +3 -0
@@ -764,5 +764,8 @@ extern struct regmap_config cs35l41_regmap_spi;int cs35l41_otp_unpack (struct device *dev,struct regmap *regmap);int cs35l41_register_errata_patch (struct device *dev,struct regmap *reg,unsigned int reg_revid); +int cs35l41_set_channels (struct device *dev,struct regmap *reg, +unsigned int tx_num,unsigned int *tx_slot, +unsigned int rx_num,unsigned int *rx_slot);#endif /* __CS35L41_H */
sound/soc/codecs/cs35l41-lib.c +32 -0
@@ -934,6 +934,38 @@ int cs35l41_register_errata_patch(struct device *dev, struct regmap *reg, unsign }EXPORT_SYMBOL_GPL (cs35l41_register_errata_patch); +int cs35l41_set_channels (struct device *dev,struct regmap *reg, +unsigned int tx_num,unsigned int *tx_slot, +unsigned int rx_num,unsigned int *rx_slot) +{ +unsigned int val, mask; +int i; + +if (tx_num >4 || rx_num >2 ) +return -EINVAL ; + + val =0 ; + mask =0 ; +for (i =0 ; i < rx_num; i++) { +dev_dbg (dev,"rx slot %d position = %d\n" , i, rx_slot[i]); + val |= rx_slot[i] << (i *8 ); + mask |=0x3F << (i *8 ); + } +regmap_update_bits (reg,CS35L41_SP_FRAME_RX_SLOT , mask, val); + + val =0 ; + mask =0 ; +for (i =0 ; i < tx_num; i++) { +dev_dbg (dev,"tx slot %d position = %d\n" , i, tx_slot[i]); + val |= tx_slot[i] << (i *8 ); + mask |=0x3F << (i *8 ); + } +regmap_update_bits (reg,CS35L41_SP_FRAME_TX_SLOT , mask, val); + +return 0 ; +} +EXPORT_SYMBOL_GPL (cs35l41_set_channels); +MODULE_DESCRIPTION ("CS35L41 library" );MODULE_AUTHOR ("David Rhodes, Cirrus Logic Inc, <[email protected]>" );MODULE_AUTHOR ("Lucas Tanure, Cirrus Logic Inc, <[email protected]>" );
sound/soc/codecs/cs35l41.c +3 -27
@@ -751,36 +751,12 @@ static const struct cs_dsp_region cs35l41_dsp1_regions[] = { {. type = WMFW_ADSP2_YM, .base = CS35L41_DSP1_YMEM_UNPACK24_0}, }; -static int cs35l41_set_channel_map (struct snd_soc_dai *dai,unsigned int tx_num, -unsigned int *tx_slot,unsigned int rx_num, -unsigned int *rx_slot) +static int cs35l41_set_channel_map (struct snd_soc_dai *dai,unsigned int tx_n, +unsigned int *tx_slot,unsigned int rx_n,unsigned int *rx_slot) {struct cs35l41_private *cs35l41 =snd_soc_component_get_drvdata (dai->component); -unsigned int val, mask; -int i; - -if (tx_num >4 || rx_num >2 ) -return -EINVAL ; - val =0 ; - mask =0 ; -for (i =0 ; i < rx_num; i++) { -dev_dbg (cs35l41->dev,"rx slot %d position = %d\n" , i, rx_slot[i]); - val |= rx_slot[i] << (i *8 ); - mask |=0x3F << (i *8 ); - } -regmap_update_bits (cs35l41->regmap,CS35L41_SP_FRAME_RX_SLOT , mask, val); - - val =0 ; - mask =0 ; -for (i =0 ; i < tx_num; i++) { -dev_dbg (cs35l41->dev,"tx slot %d position = %d\n" , i, tx_slot[i]); - val |= tx_slot[i] << (i *8 ); - mask |=0x3F << (i *8 ); - } -regmap_update_bits (cs35l41->regmap,CS35L41_SP_FRAME_TX_SLOT , mask, val); - -return 0 ; +return cs35l41_set_channels (cs35l41->dev, cs35l41->regmap, tx_n, tx_slot, rx_n, rx_slot); }static int cs35l41_set_dai_fmt (struct snd_soc_dai *dai,unsigned int fmt)
Signature · 1 line
2.34.1
PATCH v5 6/10 ASoC: cs35l41: Create shared function for boost configuration
In reply to Lucas TanureASoC and HDA will use the same registers to configure internal boost for the device
--- include/sound/cs35l41.h | 2 + sound/soc/codecs/cs35l41-lib.c | 98 ++++++++++++++++++++++++++++++ sound/soc/codecs/cs35l41.c | 105 +-------------------------------- 3 files changed, 102 insertions(+), 103 deletions(-)
include/sound/cs35l41.h +2 -0
@@ -767,5 +767,7 @@ int cs35l41_register_errata_patch(struct device *dev, struct regmap *reg, unsignint cs35l41_set_channels (struct device *dev,struct regmap *reg,unsigned int tx_num,unsigned int *tx_slot,unsigned int rx_num,unsigned int *rx_slot); +int cs35l41_boost_config (struct device *dev,struct regmap *regmap,int boost_ind,int boost_cap, +int boost_ipk);#endif /* __CS35L41_H */
sound/soc/codecs/cs35l41-lib.c +98 -0
104 lines not on this page · raw message
sound/soc/codecs/cs35l41.c +2 -103
123 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH v5 7/10 hda: cs35l41: Add support for CS35L41 in HDA systems
In reply to Lucas TanureAdd support for CS35L41 using a new separated driver that can be used in all upcoming designs
--- MAINTAINERS | 2 + sound/pci/hda/Kconfig | 27 ++ sound/pci/hda/Makefile | 10 + sound/pci/hda/cs35l41_hda.c | 527 ++++++++++++++++++++++++++++++++ sound/pci/hda/cs35l41_hda.h | 69 +++++ sound/pci/hda/cs35l41_hda_i2c.c | 66 ++++ sound/pci/hda/cs35l41_hda_spi.c | 63 ++++ sound/pci/hda/hda_component.h | 20 ++ sound/soc/codecs/Kconfig | 2 + 9 files changed, 786 insertions(+) create mode 100644 sound/pci/hda/cs35l41_hda.c create mode 100644 sound/pci/hda/cs35l41_hda.h create mode 100644 sound/pci/hda/cs35l41_hda_i2c.c create mode 100644 sound/pci/hda/cs35l41_hda_spi.c create mode 100644 sound/pci/hda/hda_component.h
MAINTAINERS +2 -0
@@ -4550,10 +4550,12 @@ F: drivers/media/cec/i2c/ch7322.c CIRRUS LOGIC AUDIO CODEC DRIVERS M: James Schulman <[email protected]> M: David Rhodes <[email protected]> +M: Lucas Tanure <[email protected]> L: [email protected] (moderated for non-subscribers) L: [email protected] S: Maintained F: Documentation/devicetree/bindings/sound/cirrus,cs* +F: sound/pci/hda/cs* F: sound/soc/codecs/cs* CIRRUS LOGIC DSP FIRMWARE DRIVER
sound/pci/hda/Kconfig +27 -0
@@ -91,6 +91,33 @@ config SND_HDA_PATCH_LOADER start up. The "patch" file can be specified via patch module option, such as patch=hda-init. +config SND_HDA_SCODEC_CS35L41 + tristate + default y if SND_HDA_SCODEC_CS35L41_I2C=y + default y if SND_HDA_SCODEC_CS35L41_SPI=y + default m if SND_HDA_SCODEC_CS35L41_I2C=m + default m if SND_HDA_SCODEC_CS35L41_SPI=m + +config SND_HDA_SCODEC_CS35L41_I2C + tristate "Build CS35L41 HD-audio side codec support for I2C Bus" + select SND_HDA_GENERIC + help + Say Y or M here to include CS35L41 I2C HD-audio side codec support + in snd-hda-intel driver, such as ALC287. + +comment "Set to Y if you want auto-loading the side codec driver" + depends on SND_HDA=y && SND_HDA_SCODEC_CS35L41_I2C=m + +config SND_HDA_SCODEC_CS35L41_SPI + tristate "Build CS35L41 HD-audio codec support for SPI Bus" + select SND_HDA_GENERIC + help + Say Y or M here to include CS35L41 SPI HD-audio side codec support + in snd-hda-intel driver, such as ALC287. + +comment "Set to Y if you want auto-loading the side codec driver" + depends on SND_HDA=y && SND_HDA_SCODEC_CS35L41_SPI=m + config SND_HDA_CODEC_REALTEK tristate "Build Realtek HD-audio codec support" select SND_HDA_GENERIC
sound/pci/hda/Makefile +10 -0
@@ -27,6 +27,11 @@ snd-hda-codec-conexant-objs := patch_conexant.o snd-hda-codec-via-objs := patch_via.o snd-hda-codec-hdmi-objs := patch_hdmi.o hda_eld.o +# side codecs +snd-hda-scodec-cs35l41-objs := cs35l41_hda.o +snd-hda-scodec-cs35l41-i2c-objs := cs35l41_hda_i2c.o +snd-hda-scodec-cs35l41-spi-objs := cs35l41_hda_spi.o + # common driver obj-$(CONFIG_SND_HDA) := snd-hda-codec.o
@@ -45,6 +50,11 @@ obj-$(CONFIG_SND_HDA_CODEC_CONEXANT) += snd-hda-codec-conexant.o obj-$(CONFIG_SND_HDA_CODEC_VIA) += snd-hda-codec-via.o obj-$(CONFIG_SND_HDA_CODEC_HDMI) += snd-hda-codec-hdmi.o +# side codecs +obj-$(CONFIG_SND_HDA_SCODEC_CS35L41) += snd-hda-scodec-cs35l41.o +obj-$(CONFIG_SND_HDA_SCODEC_CS35L41_I2C) += snd-hda-scodec-cs35l41-i2c.o +obj-$(CONFIG_SND_HDA_SCODEC_CS35L41_SPI) += snd-hda-scodec-cs35l41-spi.o + # this must be the last entry after codec drivers; # otherwise the codec patches won't be hooked before the PCI probe # when built in kernel
sound/pci/hda/cs35l41_hda.c new file +527 -0
527 lines not on this page · raw message
sound/pci/hda/cs35l41_hda.h new file +69 -0
69 lines not on this page · raw message
sound/pci/hda/cs35l41_hda_i2c.c new file +66 -0
66 lines not on this page · raw message
sound/pci/hda/cs35l41_hda_spi.c new file +63 -0
63 lines not on this page · raw message
sound/pci/hda/hda_component.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* HD audio Component Binding Interface +* +* Copyright (C) 2021 Cirrus Logic, Inc. and +* Cirrus Logic International Semiconductor Ltd. +*/ + +#include <linux/component.h> + +#define HDA_MAX_COMPONENTS 4 +#define HDA_MAX_NAME_SIZE 50 + +struct hda_component { +struct device *dev; +char name[HDA_MAX_NAME_SIZE ]; +void (*playback_hook)(struct device *dev,int action); +int (*set_channel_map)(struct device *dev,unsigned int rx_num,unsigned int *rx_slot, +unsigned int tx_num,unsigned int *tx_slot); +};
sound/soc/codecs/Kconfig +2 -0
@@ -614,6 +614,8 @@ config SND_SOC_CS35L36 config SND_SOC_CS35L41_LIB tristate + default y if SND_HDA_SCODEC_CS35L41=y + default m if SND_HDA_SCODEC_CS35L41=m default y if SND_SOC_CS35L41=y default m if SND_SOC_CS35L41=m
Signature · 1 line
2.34.1
kernel test robot
build botRe: [PATCH v5 07/10] hda: cs35l41: Add support for CS35L41 in HDA systems
I love your patch! Yet something to improve:
Hi Lucas,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20211215]
[cannot apply to broonie-sound/for-next tiwai-sound/for-next rafael-pm/linux-next linus/master v5.16-rc5 v5.16-rc4 v5.16-rc3 v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lucas-Tanure/Add-support-for-CS35L41-in-HDA-systems/20211216-194807 base: 93bf6eee76c0e716f6b32de690b1c52991547bb4 config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211217/202112170043.mK2wMAmZ-lkp(a)intel.com/config) compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/40112a770ed88d6d545d83a800fb9b125204272a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lucas-Tanure/Add-support-for-CS35L41-in-HDA-systems/20211216-194807 git checkout 40112a770ed88d6d545d83a800fb9b125204272a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash sound/pci/hda/
If you fix the issue, kindly add following tag as appropriate
All error/warnings (new ones prefixed by >>):
>> sound/pci/hda/cs35l41_hda.c:180:5: warning: no previous prototype for 'cs35l41_hda_bind' [-Wmissing-prototypes]
180 | int cs35l41_hda_bind(struct device *dev, struct device *master, void *master_data)
| ^~~~~~~~~~~~~~~~
sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_hda_read_acpi':
>> sound/pci/hda/cs35l41_hda.c:315:59: error: invalid use of undefined type 'struct acpi_device'
315 | cs35l41->reset_gpio = fwnode_gpiod_get_index(&adev->fwnode, "reset", cs35l41->index,
| ^~vim +315 sound/pci/hda/cs35l41_hda.c
179
> 180 int cs35l41_hda_bind(struct device *dev, struct device *master, void *master_data)
181 {
182 struct cs35l41_hda *cs35l41 = dev_get_drvdata(dev);
183 struct hda_component *comps = master_data;
184
185 if (comps && cs35l41->index >= 0 && cs35l41->index < HDA_MAX_COMPONENTS)
186 comps = &comps[cs35l41->index];
187 else
188 return -EINVAL;
189
190 if (!comps->dev) {
191 comps->dev = dev;
192 strscpy(comps->name, dev_name(dev), sizeof(comps->name));
193 comps->playback_hook = cs35l41_hda_playback_hook;
194 comps->set_channel_map = cs35l41_hda_channel_map;
195 return 0;
196 }
197
198 return -EBUSY;
199 }
200
201 static void cs35l41_hda_unbind(struct device *dev, struct device *master, void *master_data)
202 {
203 struct cs35l41_hda *cs35l41 = dev_get_drvdata(dev);
204 struct hda_component *comps = master_data;
205
206 if (comps[cs35l41->index].dev == dev)
207 memset(&comps[cs35l41->index], 0, sizeof(*comps));
208 }
209
210 static const struct component_ops cs35l41_hda_comp_ops = {
211 .bind = cs35l41_hda_bind,
212 .unbind = cs35l41_hda_unbind,
213 };
214
215 static int cs35l41_hda_apply_properties(struct cs35l41_hda *cs35l41,
216 const struct cs35l41_hda_hw_config *hw_cfg)
217 {
218 bool internal_boost = false;
219 int ret;
220
221 if (!hw_cfg) {
222 cs35l41->reg_seq = &cs35l41_hda_reg_seq_no_bst;
223 return 0;
224 }
225
226 if (hw_cfg->bst_ind || hw_cfg->bst_cap || hw_cfg->bst_ipk)
227 internal_boost = true;
228
229 switch (hw_cfg->gpio1_func) {
230 case CS35l41_VSPK_SWITCH:
231 regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL,
232 CS35L41_GPIO1_CTRL_MASK, 1 << CS35L41_GPIO1_CTRL_SHIFT);
233 break;
234 case CS35l41_SYNC:
235 regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL,
236 CS35L41_GPIO1_CTRL_MASK, 2 << CS35L41_GPIO1_CTRL_SHIFT);
237 break;
238 }
239
240 switch (hw_cfg->gpio2_func) {
241 case CS35L41_INTERRUPT:
242 regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL,
243 CS35L41_GPIO2_CTRL_MASK, 2 << CS35L41_GPIO2_CTRL_SHIFT);
244 break;
245 }
246
247 if (internal_boost) {
248 cs35l41->reg_seq = &cs35l41_hda_reg_seq_int_bst;
249 if (!(hw_cfg->bst_ind && hw_cfg->bst_cap && hw_cfg->bst_ipk))
250 return -EINVAL;
251 ret = cs35l41_boost_config(cs35l41->dev, cs35l41->regmap,
252 hw_cfg->bst_ind, hw_cfg->bst_cap, hw_cfg->bst_ipk);
253 if (ret)
254 return ret;
255 } else {
256 cs35l41->reg_seq = &cs35l41_hda_reg_seq_ext_bst;
257 }
258
259 ret = cs35l41_hda_channel_map(cs35l41->dev, 0, NULL, 1, (unsigned int *)&hw_cfg->spk_pos);
260 if (ret)
261 return ret;
262
263 return 0;
264 }
265
266 static struct cs35l41_hda_hw_config *cs35l41_hda_read_acpi(struct cs35l41_hda *cs35l41,
267 const char *hid, int id)
268 {
269 struct cs35l41_hda_hw_config *hw_cfg;
270 u32 values[HDA_MAX_COMPONENTS];
271 struct acpi_device *adev;
272 struct device *acpi_dev;
273 char *property;
274 size_t nval;
275 int i, ret;
276
277 adev = acpi_dev_get_first_match_dev(hid, NULL, -1);
278 if (!adev) {
279 dev_err(cs35l41->dev, "Failed to find an ACPI device for %s\n", hid);
280 return ERR_PTR(-ENODEV);
281 }
282
283 acpi_dev = get_device(acpi_get_first_physical_node(adev));
284 acpi_dev_put(adev);
285
286 property = "cirrus,dev-index";
287 ret = device_property_count_u32(acpi_dev, property);
288 if (ret <= 0)
289 goto no_acpi_dsd;
290
291 if (ret > ARRAY_SIZE(values)) {
292 ret = -EINVAL;
293 goto err;
294 }
295 nval = ret;
296
297 ret = device_property_read_u32_array(acpi_dev, property, values, nval);
298 if (ret)
299 goto err;
300
301 cs35l41->index = -1;
302 for (i = 0; i < nval; i++) {
303 if (values[i] == id) {
304 cs35l41->index = i;
305 break;
306 }
307 }
308 if (cs35l41->index == -1) {
309 dev_err(cs35l41->dev, "No index found in %s\n", property);
310 ret = -ENODEV;
311 goto err;
312 }
313
314 /* No devm_ version as CLSA0100, in no_acpi_dsd case, can't use devm version */
> 315 cs35l41->reset_gpio = fwnode_gpiod_get_index(&adev->fwnode, "reset", cs35l41->index, 316 GPIOD_OUT_LOW, "cs35l41-reset");
317
318 hw_cfg = kzalloc(sizeof(*hw_cfg), GFP_KERNEL);
319 if (!hw_cfg) {
320 ret = -ENOMEM;
321 goto err;
322 }
323
324 property = "cirrus,speaker-position";
325 ret = device_property_read_u32_array(acpi_dev, property, values, nval);
326 if (ret)
327 goto err_free;
328 hw_cfg->spk_pos = values[cs35l41->index];
329
330 property = "cirrus,gpio1-func";
331 ret = device_property_read_u32_array(acpi_dev, property, values, nval);
332 if (ret)
333 goto err_free;
334 hw_cfg->gpio1_func = values[cs35l41->index];
335
336 property = "cirrus,gpio2-func";
337 ret = device_property_read_u32_array(acpi_dev, property, values, nval);
338 if (ret)
339 goto err_free;
340 hw_cfg->gpio2_func = values[cs35l41->index];
341
342 property = "cirrus,boost-peak-milliamp";
343 ret = device_property_read_u32_array(acpi_dev, property, values, nval);
344 if (ret == 0)
345 hw_cfg->bst_ipk = values[cs35l41->index];
346
347 property = "cirrus,boost-ind-nanohenry";
348 ret = device_property_read_u32_array(acpi_dev, property, values, nval);
349 if (ret == 0)
350 hw_cfg->bst_ind = values[cs35l41->index];
351
352 property = "cirrus,boost-cap-microfarad";
353 ret = device_property_read_u32_array(acpi_dev, property, values, nval);
354 if (ret == 0)
355 hw_cfg->bst_cap = values[cs35l41->index];
356
357 put_device(acpi_dev);
358
359 return hw_cfg;
360
361 err_free:
362 kfree(hw_cfg);
363 err:
364 put_device(acpi_dev);
365 dev_err(cs35l41->dev, "Failed property %s: %d\n", property, ret);
366
367 return ERR_PTR(ret);
368
369 no_acpi_dsd:
370 /*
371 * Device CLSA0100 doesn't have _DSD so a gpiod_get by the label reset won't work.
372 * And devices created by i2c-multi-instantiate don't have their device struct pointing to
373 * the correct fwnode, so acpi_dev must be used here
374 * And devm functions expect that the device requesting the resource has the correct
375 * fwnode
376 */
377 if (strncmp(hid, "CLSA0100", 8) != 0)
378 return ERR_PTR(-EINVAL);
379
380 /* check I2C address to assign the index */
381 cs35l41->index = id == 0x40 ? 0 : 1;
382 cs35l41->reset_gpio = gpiod_get_index(acpi_dev, NULL, 0, GPIOD_OUT_HIGH);
383 cs35l41->vspk_always_on = true;
384 put_device(acpi_dev);
385
386 return NULL;
387 }
388
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH v5 8/10 ACPI / scan: Create platform device for CLSA0100 and CSC3551 ACPI nodes
In reply to Lucas TanureThe ACPI device with CLSA0100 or CSC3551 is a sound card with multiple instances of CS35L41 connectec by I2C to the main CPU.
We add an ID to the i2c_multi_instantiate_ids list to enumerate all I2C slaves correctly.
--- drivers/acpi/scan.c | 3 +++ drivers/platform/x86/i2c-multi-instantiate.c | 11 +++++++++++ 2 files changed, 14 insertions(+)
drivers/acpi/scan.c +3 -0
@@ -1706,8 +1706,11 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device)static const struct acpi_device_id i2c_multi_instantiate_ids[] = { {"BSG1160" , }, {"BSG2150" , }, + {"CSC3551" , }, {"INT33FE" , }, {"INT3515" , }, +/* Non-conforming _HID for Cirrus Logic already released */ + {"CLSA0100" , }, {} };
drivers/platform/x86/i2c-multi-instantiate.c +11 -0
@@ -147,6 +147,14 @@ static const struct i2c_inst_data int3515_data[] = { {} }; +static const struct i2c_inst_data cs35l41_hda[] = { + {"cs35l41-hda" ,IRQ_RESOURCE_GPIO ,0 }, + {"cs35l41-hda" ,IRQ_RESOURCE_GPIO ,0 }, + {"cs35l41-hda" ,IRQ_RESOURCE_GPIO ,0 }, + {"cs35l41-hda" ,IRQ_RESOURCE_GPIO ,0 }, + {} +}; +/* * Note new device-ids must also be added to i2c_multi_instantiate_ids in * drivers/acpi/scan.c: acpi_device_enumeration_by_parent().
@@ -154,7 +162,10 @@ static const struct i2c_inst_data int3515_data[] = {static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { {"BSG1160" , (unsigned long )bsg1160_data }, {"BSG2150" , (unsigned long )bsg2150_data }, + {"CSC3551" , (unsigned long )cs35l41_hda }, {"INT3515" , (unsigned long )int3515_data }, +/* Non-conforming _HID for Cirrus Logic already released */ + {"CLSA0100" , (unsigned long )cs35l41_hda }, { } };MODULE_DEVICE_TABLE (acpi, i2c_multi_inst_acpi_ids);
Signature · 1 line
2.34.1
PATCH v5 9/10 ALSA: hda/realtek: Add support for Legion 7 16ACHg6 laptop
In reply to Lucas TanureAdd Support for CS35L41 using the component binding method
--- sound/pci/hda/patch_realtek.c | 107 ++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+)
sound/pci/hda/patch_realtek.c +107 -0
@@ -25,6 +25,7 @@#include "hda_auto_parser.h" #include "hda_jack.h" #include "hda_generic.h" +#include "hda_component.h" /* keep halting ALC5505 DSP, for power saving */ #define HALT_REALTEK_ALC5505
@@ -126,6 +127,10 @@ struct alc_spec {unsigned int coef0;struct input_dev *kb_dev;u8 alc_mute_keycode_map[1 ]; + +/* component binding */ +struct component_match *match; +struct hda_component comps[HDA_MAX_COMPONENTS ]; };/*
@@ -6497,6 +6502,102 @@ static void alc287_fixup_legion_15imhg05_speakers(struct hda_codec *codec, } } +static int comp_match_dev_name (struct device *dev,void *data) +{ +return strcmp (dev_name (dev), data) ==0 ; +} + +static int find_comp_by_dev_name (struct alc_spec *spec,const char *name) +{ +int i; + +for (i =0 ; i <HDA_MAX_COMPONENTS ; i++) { +if (strcmp (spec->comps[i].name, name) ==0 ) +return i; + } + +return -ENODEV ; +} + +static int comp_bind (struct device *dev) +{ +struct hda_codec *cdc =dev_to_hda_codec (dev); +struct alc_spec *spec = cdc->spec; + +return component_bind_all (dev, spec->comps); +} + +static void comp_unbind (struct device *dev) +{ +struct hda_codec *cdc =dev_to_hda_codec (dev); +struct alc_spec *spec = cdc->spec; + +component_unbind_all (dev, spec->comps); +} + +static const struct component_master_ops comp_master_ops = { + .bind = comp_bind, + .unbind = comp_unbind, +}; + +static void comp_generic_playback_hook (struct hda_pcm_stream *hinfo,struct hda_codec *cdc, +struct snd_pcm_substream *sub,int action) +{ +struct alc_spec *spec = cdc->spec; +int i; + +for (i =0 ; i <HDA_MAX_COMPONENTS ; i++) { +if (spec->comps[i].dev) + spec->comps[i].playback_hook (spec->comps[i].dev, action); + } +} + +static void alc287_legion_16achg6_playback_hook (struct hda_pcm_stream *hinfo,struct hda_codec *cdc, +struct snd_pcm_substream *sub,int action) +{ +struct alc_spec *spec = cdc->spec; +unsigned int rx_slot; +int i; + +switch (action) { +case HDA_GEN_PCM_ACT_PREPARE : + rx_slot =0 ; + i =find_comp_by_dev_name (spec,"i2c-CLSA0100:00-cs35l41-hda.0" ); +if (i >=0 ) + spec->comps[i].set_channel_map (spec->comps[i].dev,0 ,NULL ,1 , &rx_slot); + + rx_slot =1 ; + i =find_comp_by_dev_name (spec,"i2c-CLSA0100:00-cs35l41-hda.1" ); +if (i >=0 ) + spec->comps[i].set_channel_map (spec->comps[i].dev,0 ,NULL ,1 , &rx_slot); +break ; + } + +comp_generic_playback_hook (hinfo, cdc, sub, action); +} + +static void alc287_fixup_legion_16achg6_speakers (struct hda_codec *cdc,const struct hda_fixup *fix, +int action) +{ +struct device *dev =hda_codec_dev (cdc); +struct alc_spec *spec = cdc->spec; +int ret; + +switch (action) { +case HDA_FIXUP_ACT_PRE_PROBE : +component_match_add (dev, &spec->match, comp_match_dev_name, +"i2c-CLSA0100:00-cs35l41-hda.0" ); +component_match_add (dev, &spec->match, comp_match_dev_name, +"i2c-CLSA0100:00-cs35l41-hda.1" ); + ret =component_master_add_with_match (dev, &comp_master_ops, spec->match); +if (ret) +codec_err (cdc,"Fail to register component aggregator %d\n" , ret); +else + spec->gen.pcm_playback_hook = alc287_legion_16achg6_playback_hook; +break ; + } +} +/* for alc295_fixup_hp_top_speakers */ #include "hp_x360_helper.c"
@@ -6766,6 +6867,7 @@ enum {ALC256_FIXUP_SET_COEF_DEFAULTS ,ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE ,ALC233_FIXUP_NO_AUDIO_JACK , + ALC287_FIXUP_LEGION_16ACHG6, }; static const struct hda_fixup alc269_fixups[] = {
@@ -8490,6 +8592,10 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc233_fixup_no_audio_jack, }, + [ALC287_FIXUP_LEGION_16ACHG6] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc287_fixup_legion_16achg6_speakers, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8899,6 +9005,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x3827 ,"Ideapad S740" ,ALC285_FIXUP_IDEAPAD_S740_COEF ),SND_PCI_QUIRK (0x17aa ,0x3843 ,"Yoga 9i" ,ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP ),SND_PCI_QUIRK (0x17aa ,0x3813 ,"Legion 7i 15IMHG05" ,ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS ), +SND_PCI_QUIRK (0x17aa ,0x3847 ,"Legion 7 16ACHG6" ,ALC287_FIXUP_LEGION_16ACHG6 ),SND_PCI_QUIRK (0x17aa ,0x3852 ,"Lenovo Yoga 7 14ITL5" ,ALC287_FIXUP_YOGA7_14ITL_SPEAKERS ),SND_PCI_QUIRK (0x17aa ,0x3853 ,"Lenovo Yoga 7 15ITL5" ,ALC287_FIXUP_YOGA7_14ITL_SPEAKERS ), SND_PCI_QUIRK(0x17aa, 0x3819, "Lenovo 13s Gen2 ITL", ALC287_FIXUP_13S_GEN2_SPEAKERS),
Signature · 1 line
2.34.1
PATCH v5 10/10 ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops
In reply to Lucas TanureFrom: Stefan Binding <[email protected]>
Add support for two CS35L41 using I2C bus and the component binding method
--- sound/pci/hda/patch_realtek.c | 37 +++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
sound/pci/hda/patch_realtek.c +37 -0
@@ -6552,6 +6552,35 @@ static void comp_generic_playback_hook(struct hda_pcm_stream *hinfo, struct hda_ } } +static void cs35l41_generic_fixup (struct hda_codec *cdc,int action,const char *bus, +const char *hid,int count) +{ +struct device *dev =hda_codec_dev (cdc); +struct alc_spec *spec = cdc->spec; +char *name; +int ret, i; + +switch (action) { +case HDA_FIXUP_ACT_PRE_PROBE : +for (i =0 ; i < count; i++) { + name =devm_kasprintf (dev,GFP_KERNEL , +"%s-%s:00-cs35l41-hda.%d" , bus, hid, i); +component_match_add (dev, &spec->match, comp_match_dev_name, name); + } + ret =component_master_add_with_match (dev, &comp_master_ops, spec->match); +if (ret) +codec_err (cdc,"Fail to register component aggregator %d\n" , ret); +else + spec->gen.pcm_playback_hook = comp_generic_playback_hook; +break ; + } +} + +static void cs35l41_fixup_i2c_two (struct hda_codec *cdc,const struct hda_fixup *fix,int action) +{ +cs35l41_generic_fixup (cdc, action,"i2c" ,"CSC3551" ,2 ); +} +static void alc287_legion_16achg6_playback_hook (struct hda_pcm_stream *hinfo,struct hda_codec *cdc,struct snd_pcm_substream *sub,int action) {
@@ -6868,6 +6897,7 @@ enum {ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE ,ALC233_FIXUP_NO_AUDIO_JACK ,ALC287_FIXUP_LEGION_16ACHG6 , + ALC287_FIXUP_CS35L41_I2C_2, }; static const struct hda_fixup alc269_fixups[] = {
@@ -8596,6 +8626,10 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc287_fixup_legion_16achg6_speakers, }, + [ALC287_FIXUP_CS35L41_I2C_2] = { + .type = HDA_FIXUP_FUNC, + .v.func = cs35l41_fixup_i2c_two, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -9006,6 +9040,9 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x17aa ,0x3843 ,"Yoga 9i" ,ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP ),SND_PCI_QUIRK (0x17aa ,0x3813 ,"Legion 7i 15IMHG05" ,ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS ),SND_PCI_QUIRK (0x17aa ,0x3847 ,"Legion 7 16ACHG6" ,ALC287_FIXUP_LEGION_16ACHG6 ), +SND_PCI_QUIRK (0x17aa ,0x22F1 ,"Thinkpad" ,ALC287_FIXUP_CS35L41_I2C_2 ), +SND_PCI_QUIRK (0x17aa ,0x22F2 ,"Thinkpad" ,ALC287_FIXUP_CS35L41_I2C_2 ), +SND_PCI_QUIRK (0x17aa ,0x22F3 ,"Thinkpad" ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x17aa ,0x3852 ,"Lenovo Yoga 7 14ITL5" ,ALC287_FIXUP_YOGA7_14ITL_SPEAKERS ),SND_PCI_QUIRK (0x17aa ,0x3853 ,"Lenovo Yoga 7 15ITL5" ,ALC287_FIXUP_YOGA7_14ITL_SPEAKERS ), SND_PCI_QUIRK(0x17aa, 0x3819, "Lenovo 13s Gen2 ITL", ALC287_FIXUP_13S_GEN2_SPEAKERS),
Signature · 1 line
2.34.1