Skip to contentSkip to conversation

mmc: dw_mmc: clean up a debug message

PATCH In review Dan Carpenter 3 participants 3 messages Dec 17, 2021 – Dec 21, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: dw_mmc: clean up a debug message

The "0x" prefix is redundant when # flag is used. It prints "0x0x".

---
 drivers/mmc/host/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/dw_mmc.c +1 -1
index f2a14a434bef..bec4796283fe 100644
@@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host,
 		tmout |= (tmp & 0xFFFFFF) << 8;
 
 	mci_writel(host, TMOUT, tmout);
-	dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x",
+	dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x",
 		timeout_ns, tmout >> 8);
 }
 
Signature · 1 line
2.20.1
Reviewed-by Mårten Lindahl on v1 1/1
#1 lore raw
Quoted 23 lines · Dan Carpenter

The "0x" prefix is redundant when # flag is used. It prints "0x0x".

---
 drivers/mmc/host/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/dw_mmc.c +1 -1
index f2a14a434bef..bec4796283fe 100644
@@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host,
 		tmout |= (tmp & 0xFFFFFF) << 8;
 
 	mci_writel(host, TMOUT, tmout);
-	dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x",
+	dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x",
 		timeout_ns, tmout >> 8);
 }
 
Signature · 1 line
2.20.1

Kind regards
Mårten

#2 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

The "0x" prefix is redundant when # flag is used. It prints "0x0x".

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/dw_mmc.c +1 -2
index f2a14a434bef..bec4796283fe 100644
@@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host,
                tmout |= (tmp & 0xFFFFFF) << 8;
 
        mci_writel(host, TMOUT, tmout);
-       dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x",
+       dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x",
                timeout_ns, tmout >> 8);
 }
 
--

2.20.1