Skip to contentSkip to conversation

gpio: sim: fix uninitialized ret variable

PATCH Applied [email protected] 3 participants 3 messages Dec 18, 2021 – Dec 19, 2021 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: sim: fix uninitialized ret variable

From: Tom Rix <[email protected]>

Building with clang returns this error:

gpio-sim.c:889:7: error: variable 'ret' is uninitialized
when used here

ret should be the status of the call to
gpio_sim_make_bank_swnode stored in bank->swnode.

Fixes 83960fcf4818 ("gpio: sim: new testing module")
---
 drivers/gpio/gpio-sim.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpio/gpio-sim.c +2 -1
index ef6145f51c8ae..bef00dcc4dc8f 100644
@@ -886,7 +886,8 @@ static int gpio_sim_device_activate_unlocked(struct gpio_sim_device *dev)
 
 	list_for_each_entry(bank, &dev->bank_list, siblings) {
 		bank->swnode = gpio_sim_make_bank_swnode(bank, swnode);
-		if (ret) {
+		if (IS_ERR(bank->swnode)) {
+			ret = PTR_ERR(bank->swnode);
 			gpio_sim_remove_swnode_recursive(swnode);
 			return ret;
 		}
Signature · 1 line
2.26.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Sat, Dec 18, 2021 at 07:27:12AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

Building with clang returns this error:

Quoted 8 lines

gpio-sim.c:889:7: error: variable 'ret' is uninitialized
when used here

ret should be the status of the call to
gpio_sim_make_bank_swnode stored in bank->swnode.

Fixes 83960fcf4818 ("gpio: sim: new testing module")
Quoted 21 lines
---
 drivers/gpio/gpio-sim.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpio/gpio-sim.c +2 -1
index ef6145f51c8ae..bef00dcc4dc8f 100644
@@ -886,7 +886,8 @@ static int gpio_sim_device_activate_unlocked(struct gpio_sim_device *dev)
 
 	list_for_each_entry(bank, &dev->bank_list, siblings) {
 		bank->swnode = gpio_sim_make_bank_swnode(bank, swnode);
-		if (ret) {
+		if (IS_ERR(bank->swnode)) {
+			ret = PTR_ERR(bank->swnode);
 			gpio_sim_remove_swnode_recursive(swnode);
 			return ret;
 		}
Signature · 1 line
2.26.3
#2 lore raw
In reply to [email protected]
Quoted 32 lines · On Sat, Dec 18, 2021 at 4:27 PM <[email protected]> wrote:

From: Tom Rix <[email protected]>

Building with clang returns this error:

gpio-sim.c:889:7: error: variable 'ret' is uninitialized
when used here

ret should be the status of the call to
gpio_sim_make_bank_swnode stored in bank->swnode.

Fixes 83960fcf4818 ("gpio: sim: new testing module")
---
 drivers/gpio/gpio-sim.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpio/gpio-sim.c +2 -2
index ef6145f51c8ae..bef00dcc4dc8f 100644
@@ -886,7 +886,8 @@ static int gpio_sim_device_activate_unlocked(struct gpio_sim_device *dev)
 
        list_for_each_entry(bank, &dev->bank_list, siblings) {
                bank->swnode = gpio_sim_make_bank_swnode(bank, swnode);
-               if (ret) {
+               if (IS_ERR(bank->swnode)) {
+                       ret = PTR_ERR(bank->swnode);
                        gpio_sim_remove_swnode_recursive(swnode);
                        return ret;
                }
--
Quoted 2 lines

2.26.3

Applied, thanks!

Bart