Skip to contentSkip to conversation

package/connman: add iwd support

PATCH Superseded James Hilliard 2 participants 5 messages Dec 20, 2021 – Dec 22, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/connman: add iwd support

---
 package/connman/connman.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/connman/connman.mk +7 -0
index e5e596c973..d3ebb40a1c 100644
@@ -85,6 +85,13 @@ else
 CONNMAN_CONF_OPTS += --disable-wispr
 endif
 
+ifeq ($(BR2_PACKAGE_IWD),y)
+CONNMAN_CONF_OPTS += --enable-iwd
+else
+CONNMAN_CONF_OPTS += --disable-iwd
+endif
+
+
 define CONNMAN_INSTALL_INIT_SYSV
 	$(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
 endef
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · James Hilliard
---
  package/connman/connman.mk | 7 +++++++
  1 file changed, 7 insertions(+)
package/connman/connman.mk +0 -0
index e5e596c973..d3ebb40a1c 100644

package/connman/connman.mk else · line 89

Quoted 5 lines
package/connman/connman.mk +2 -0
@@ -85,6 +85,13 @@ else
  CONNMAN_CONF_OPTS += --disable-wispr
  endif
 
+ifeq ($(BR2_PACKAGE_IWD),y)
+CONNMAN_CONF_OPTS += --enable-iwd

No need to add iwd to CONNMAN_DEPENDENCIES?

Regards,
Arnout

package/connman/connman.mk else · line 97

Quoted 9 lines
package/connman/connman.mk +5 -0
+else
+CONNMAN_CONF_OPTS += --disable-iwd
+endif
+
+
  define CONNMAN_INSTALL_INIT_SYSV
  	$(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
  endef

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
Quoted 17 lines · Arnout Vandecappelle
Quoted 13 lines · James Hilliard
---
  package/connman/connman.mk | 7 +++++++
  1 file changed, 7 insertions(+)
package/connman/connman.mk +0 -0
index e5e596c973..d3ebb40a1c 100644
@@ -85,6 +85,13 @@ else
  CONNMAN_CONF_OPTS += --disable-wispr
  endif
 
Quoted 4 lines

package/connman/connman.mk else · line 89

Quoted 2 lines
package/connman/connman.mk +2 -0
+ifeq ($(BR2_PACKAGE_IWD),y)
+CONNMAN_CONF_OPTS += --enable-iwd

No need to add iwd to CONNMAN_DEPENDENCIES?

From what I can tell iwd is only needed at runtime.

Quoted 4 lines

Regards,
Arnout

Quoted 9 lines

package/connman/connman.mk else · line 97

Quoted 9 lines
package/connman/connman.mk +5 -0
+else
+CONNMAN_CONF_OPTS += --disable-iwd
+endif
+
+
  define CONNMAN_INSTALL_INIT_SYSV
      $(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
  endef

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 18 lines · James Hilliard
Quoted 17 lines · Arnout Vandecappelle
Quoted 13 lines · James Hilliard
---
   package/connman/connman.mk | 7 +++++++
   1 file changed, 7 insertions(+)
package/connman/connman.mk +0 -0
index e5e596c973..d3ebb40a1c 100644
@@ -85,6 +85,13 @@ else
   CONNMAN_CONF_OPTS += --disable-wispr
   endif
 
Quoted 6 lines
Quoted 4 lines

package/connman/connman.mk else · line 89

Quoted 2 lines
package/connman/connman.mk +2 -0
+ifeq ($(BR2_PACKAGE_IWD),y)
+CONNMAN_CONF_OPTS += --enable-iwd

No need to add iwd to CONNMAN_DEPENDENCIES?

From what I can tell iwd is only needed at runtime.

It helps if you mention that in the commit message :-)

Regards,
Arnout

Quoted 5 lines
Quoted 5 lines

Regards,
Arnout

Quoted 9 lines
Quoted 9 lines

package/connman/connman.mk else · line 97

Quoted 9 lines
package/connman/connman.mk +5 -0
+else
+CONNMAN_CONF_OPTS += --disable-iwd
+endif
+
+
   define CONNMAN_INSTALL_INIT_SYSV
       $(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
   endef

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
Quoted 22 lines · Arnout Vandecappelle
Quoted 18 lines · James Hilliard
Quoted 17 lines · Arnout Vandecappelle
Quoted 13 lines · James Hilliard
---
   package/connman/connman.mk | 7 +++++++
   1 file changed, 7 insertions(+)
package/connman/connman.mk +0 -0
index e5e596c973..d3ebb40a1c 100644
@@ -85,6 +85,13 @@ else
   CONNMAN_CONF_OPTS += --disable-wispr
   endif
 
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

package/connman/connman.mk else · line 89

Quoted 2 lines
package/connman/connman.mk +2 -0
+ifeq ($(BR2_PACKAGE_IWD),y)
+CONNMAN_CONF_OPTS += --enable-iwd

No need to add iwd to CONNMAN_DEPENDENCIES?

From what I can tell iwd is only needed at runtime.

It helps if you mention that in the commit message :-)

Added to commit message in v2:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 9 lines

Regards,
Arnout

Quoted 5 lines
Quoted 5 lines

Regards,
Arnout

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

package/connman/connman.mk else · line 97

Quoted 9 lines
package/connman/connman.mk +5 -0
+else
+CONNMAN_CONF_OPTS += --disable-iwd
+endif
+
+
   define CONNMAN_INSTALL_INIT_SYSV
       $(INSTALL) -m 0755 -D package/connman/S45connman $(TARGET_DIR)/etc/init.d/S45connman
   endef

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot