can: softing_cs: fix memleak on registration failure
Subsystems (4)
PATCH 1/1 can: softing_cs: fix memleak on registration failure
In case device registration fails during probe, the driver state and the embedded platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).
Fixes 0a0b7a5f7a04 ("can: add driver for Softing card")
Cc [email protected] # 2.6.38
Signed-off-by Johan Hovold <[email protected]>
--- drivers/net/can/softing/softing_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/can/softing/softing_cs.c +1 -1
@@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia)return 0 ; platform_failed: -kfree (dev); +platform_device_put (pdev); mem_failed: pcmcia_bad: pcmcia_failed:
Signature · 1 line
2.32.0
Quoted 28 lines · Johan Hovold
In case device registration fails during probe, the driver state and the embedded platform device structure needs to be freed using
platform_device_put()to properly free all resources (e.g. the device name).Fixes 0a0b7a5f7a04 ("can: add driver for Softing card")Cc [email protected] # 2.6.38Signed-off-by Johan Hovold <[email protected]>--- drivers/net/can/softing/softing_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/can/softing/softing_cs.c +1
-1@@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia)return 0 ; platform_failed: -kfree (dev); +platform_device_put (pdev); mem_failed: pcmcia_bad: pcmcia_failed:Signature · 1 line
2.32.0
Reviewed-by Greg Kroah-Hartman <[email protected]>