Skip to contentSkip to conversation

scsi: bsg: Ignore bsg queue registration failures again

PATCH In review Guenter Roeck 2 participants 2 messages Dec 22, 2021 – Dec 23, 2021 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: bsg: Ignore bsg queue registration failures again

Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when scsi_bsg_register_queue() fails"), errors from registering the bsg queue are no longer ignored but returned to the caller. At the same time, the comment in the code still states that errors are ignored. On top of that, the message preporting the problem is printed as dev_info, not dev_err. Both suggest that errors from bsg queue registrations should indeed be ignored.

Cc Jens Axboe <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Jackie Liu <[email protected]>
Fixes 5f7cf82c1d73 ("scsi: bsg: Fix errno when scsi_bsg_register_queue() fails"

---
Commit 5f7cf82c1d73 has proliferated to stable releases, so this patch should probably be backported as well.

Alternatives:
- revert commit 5f7cf82c1d73
- Change the comment to match the code, and print the message as error

 drivers/scsi/scsi_sysfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/scsi/scsi_sysfs.c +2 -3
index d4edce930a4a..caa4ad1f893a 100644
@@ -1391,10 +1391,9 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
 			 * We're treating error on bsg register as non-fatal, so
 			 * pretend nothing went wrong.
 			 */
-			error = PTR_ERR(sdev->bsg_dev);
 			sdev_printk(KERN_INFO, sdev,
-				    "Failed to register bsg queue, errno=%d\n",
-				    error);
+				    "Failed to register bsg queue, errno=%ld\n",
+				    PTR_ERR(sdev->bsg_dev));
 			sdev->bsg_dev = NULL;
 		}
 	}
Signature · 1 line
2.33.0
#1 lore raw
Quoted 7 lines · Guenter Roeck

Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when scsi_bsg_register_queue() fails"), errors from registering the bsg queue are no longer ignored but returned to the caller. At the same time, the comment in the code still states that errors are ignored. On top of that, the message preporting the problem is printed as dev_info, not dev_err. Both suggest that errors from bsg queue registrations should indeed be ignored.

But there is no good reason to ignore it. The proper fix is to fully handle the errors.