Skip to contentSkip to conversation

RDMA/rxe: Use the standard method to produce udp source port

PATCH In review [email protected] 2 participants 2 messages Dec 24, 2021 – Jan 3, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/rxe: Use the standard method to produce udp source port

From: Zhu Yanjun <[email protected]>

Use the standard method to produce udp source port based on the commit 2b880b2e5e03 ("RDMA/mlx5: Define RoCEv2 udp source port when set path").

---
 drivers/infiniband/sw/rxe/rxe_verbs.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
drivers/infiniband/sw/rxe/rxe_verbs.c +18 -0
index 0aa0d7e52773..9a0748ad6417 100644
@@ -451,6 +451,14 @@ static int rxe_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init,
 	return err;
 }
 
+static u16 rxe_get_udp_sport(u32 fl, u32 lqpn, u32 rqpn)
+{
+	if (!fl)
+		fl = rdma_calc_flow_label(lqpn, rqpn);
+
+	return rdma_flow_label_to_udp_sport(fl);
+}
+
 static int rxe_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 			 int mask, struct ib_udata *udata)
 {
@@ -469,6 +477,16 @@ static int rxe_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 	if (err)
 		goto err1;
 
+	if (mask & IB_QP_AV) {
+		if (attr->ah_attr.ah_flags & IB_AH_GRH) {
+			u32 fl = attr->ah_attr.grh.flow_label;
+			u32 lqp = qp->ibqp.qp_num;
+			u32 rqp = qp->attr.dest_qp_num;
+
+			qp->src_port = rxe_get_udp_sport(fl, lqp, rqp);
+		}
+	}
+
 	return 0;
 
 err1:
Signature · 1 line
2.27.0
#1 lore raw
Quoted 17 lines · On Fri, Dec 24, 2021 at 12:27:35PM -0500, [email protected] wrote:

From: Zhu Yanjun <[email protected]>

Use the standard method to produce udp source port based on the commit 2b880b2e5e03 ("RDMA/mlx5: Define RoCEv2 udp source port when set path").

---
 drivers/infiniband/sw/rxe/rxe_verbs.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
drivers/infiniband/sw/rxe/rxe_verbs.c +0 -0
index 0aa0d7e52773..9a0748ad6417 100644
@@ -451,6 +451,14 @@ static int rxe_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init,
 	return err;

drivers/infiniband/sw/rxe/rxe_verbs.c static int rxe_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init, · line 461

Quoted 10 lines
drivers/infiniband/sw/rxe/rxe_verbs.c +8 -0
 }
 
+static u16 rxe_get_udp_sport(u32 fl, u32 lqpn, u32 rqpn)
+{
+	if (!fl)
+		fl = rdma_calc_flow_label(lqpn, rqpn);
+
+	return rdma_flow_label_to_udp_sport(fl);
+}
+

Now, we have three drivers with the same function.

Quoted 23 lines
drivers/infiniband/sw/rxe/rxe_verbs.c +10 -0
 static int rxe_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 			 int mask, struct ib_udata *udata)
 {
@@ -469,6 +477,16 @@ static int rxe_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 	if (err)
 		goto err1;
 
+	if (mask & IB_QP_AV) {
+		if (attr->ah_attr.ah_flags & IB_AH_GRH) {
+			u32 fl = attr->ah_attr.grh.flow_label;
+			u32 lqp = qp->ibqp.qp_num;
+			u32 rqp = qp->attr.dest_qp_num;
+
+			qp->src_port = rxe_get_udp_sport(fl, lqp, rqp);
+		}
+	}
+
 	return 0;
 
 err1:
Signature · 1 line
2.27.0