Skip to contentSkip to conversation

platform/x86: intel_pmc_core: fix memleak on registration failure

PATCH New Simon Bursten 1 participant 1 message Dec 25, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: intel_pmc_core: fix memleak on registration failure

From: Johan Hovold <[email protected]>

In case device registration fails during module initialisation, the platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).

Fixes 938835aa903a ("platform/x86: intel_pmc_core: do not create a static struct device")
---
 drivers/platform/x86/intel/pmc/pltdrv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/pmc/pltdrv.c +1 -1
index 73797680b895..15ca8afdd973 100644
@@ -65,7 +65,7 @@ static int __init pmc_core_platform_init(void)
 
 	retval = platform_device_register(pmc_core_device);
 	if (retval)
-		kfree(pmc_core_device);
+		platform_device_put(pmc_core_device);
 
 	return retval;
 }
Signature · 1 line
2.25.1