staging: greybus: auto_manager: use default_groups in kobj_type
Subsystems (3)
Greg Kroah-Hartman
maintainerPATCH 1/1 staging: greybus: auto_manager: use default_groups in kobj_type
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the greybus audio code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.
--- drivers/staging/greybus/audio_manager_module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/greybus/audio_manager_module.c +2 -1
@@ -142,11 +142,12 @@ static struct attribute *gb_audio_module_default_attrs[] = { &gb_audio_module_op_devices_attribute.attr,NULL ,/* need to NULL terminate the list of attributes */ }; +ATTRIBUTE_GROUPS (gb_audio_module_default);static struct kobj_type gb_audio_module_type = { .sysfs_ops = &gb_audio_module_sysfs_ops, .release = gb_audio_module_release, - .default_attrs = gb_audio_module_default_attrs, + .default_groups = gb_audio_module_default_groups, };static void send_add_uevent (struct gb_audio_manager_module *module)
Signature · 1 line
2.34.1
Quoted 7 lines · Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through thedefault_attrsfield, and thedefault_groupsfield. Move the greybus audio code to usedefault_groupsfield which has been the preferred way sinceaa30f47cf666("kobject: Add support for default attribute groups tokobj_type") so that we can soon get rid of the obsoletedefault_attrsfield.
Quoted 7 lines
Cc Vaibhav Agarwal <[email protected]>Cc Mark Greer <[email protected]>Cc Johan Hovold <[email protected]>Cc Alex Elder <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Nice and simple to convert this (as it should be). Looks good to me.
Quoted 23 lines
--- drivers/staging/greybus/audio_manager_module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/greybus/audio_manager_module.c +2
-1@@ -142,11 +142,12 @@ static struct attribute *gb_audio_module_default_attrs[] = { &gb_audio_module_op_devices_attribute.attr,NULL ,/* need to NULL terminate the list of attributes */ }; +ATTRIBUTE_GROUPS (gb_audio_module_default);static struct kobj_type gb_audio_module_type = { .sysfs_ops = &gb_audio_module_sysfs_ops, .release = gb_audio_module_release, - .default_attrs = gb_audio_module_default_attrs, + .default_groups = gb_audio_module_default_groups, };static void send_add_uevent (struct gb_audio_manager_module *module)
Quoted 38 lines · Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through thedefault_attrsfield, and thedefault_groupsfield. Move the greybus audio code to usedefault_groupsfield which has been the preferred way sinceaa30f47cf666("kobject: Add support for default attribute groups tokobj_type") so that we can soon get rid of the obsoletedefault_attrsfield.Cc Vaibhav Agarwal <[email protected]>Cc Mark Greer <[email protected]>Cc Johan Hovold <[email protected]>Cc Alex Elder <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/staging/greybus/audio_manager_module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/greybus/audio_manager_module.c +2
-1@@ -142,11 +142,12 @@ static struct attribute *gb_audio_module_default_attrs[] = { &gb_audio_module_op_devices_attribute.attr,NULL ,/* need to NULL terminate the list of attributes */ }; +ATTRIBUTE_GROUPS (gb_audio_module_default);static struct kobj_type gb_audio_module_type = { .sysfs_ops = &gb_audio_module_sysfs_ops, .release = gb_audio_module_release, - .default_attrs = gb_audio_module_default_attrs, + .default_groups = gb_audio_module_default_groups, };static void send_add_uevent (struct gb_audio_manager_module *module)Signature · 1 line
2.34.1
Nice!