Skip to contentSkip to conversation

riscv: canaan: remove useless select of non-existing config SYSCON

PATCH In review Lukas Bulwahn 3 participants 3 messages Dec 29, 2021 – Jan 20, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: canaan: remove useless select of non-existing config SYSCON

The config SYSCON never existed in the kernel repository; so, the select of that config in ./drivers/soc/canaan/Kconfig has no effect.

Presumably, this was just some mistake, assuming some symmetry in handling and naming of configs that simply does not exist.

Remove this useless select of a non-existing config.

---
 drivers/soc/canaan/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/soc/canaan/Kconfig +0 -1
index 853096b7e84c..2527cf5757ec 100644
@@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
 	depends on RISCV && SOC_CANAAN && OF
 	default SOC_CANAAN
         select PM
-        select SYSCON
         select MFD_SYSCON
 	help
 	  Canaan Kendryte K210 SoC system controller driver.
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Lukas Bulwahn

The config SYSCON never existed in the kernel repository; so, the select of that config in ./drivers/soc/canaan/Kconfig has no effect.

Presumably, this was just some mistake, assuming some symmetry in handling and naming of configs that simply does not exist.

Remove this useless select of a non-existing config.

---
 drivers/soc/canaan/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/soc/canaan/Kconfig +0 -0
index 853096b7e84c..2527cf5757ec 100644

drivers/soc/canaan/Kconfig config SOC_K210_SYSCTL · line 10

Quoted 7 lines
drivers/soc/canaan/Kconfig +0 -1
@@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
 	depends on RISCV && SOC_CANAAN && OF
 	default SOC_CANAAN
         select PM
-        select SYSCON
         select MFD_SYSCON
 	help
 	  Canaan Kendryte K210 SoC system controller driver.

My bad :)

Signature · 2 lines
Damien Le Moal
Western Digital Research
maintainer
#2 lore raw
In reply to Lukas Bulwahn
Quoted 18 lines · On Wed, 29 Dec 2021 11:24:58 PST (-0800), [email protected] wrote:

The config SYSCON never existed in the kernel repository; so, the select of that config in ./drivers/soc/canaan/Kconfig has no effect.

Presumably, this was just some mistake, assuming some symmetry in handling and naming of configs that simply does not exist.

Remove this useless select of a non-existing config.

---
 drivers/soc/canaan/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/soc/canaan/Kconfig +0 -0
index 853096b7e84c..2527cf5757ec 100644

drivers/soc/canaan/Kconfig config SOC_K210_SYSCTL · line 10

Quoted 7 lines
drivers/soc/canaan/Kconfig +0 -1
@@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
 	depends on RISCV && SOC_CANAAN && OF
 	default SOC_CANAAN
         select PM
-        select SYSCON
         select MFD_SYSCON
 	help
 	  Canaan Kendryte K210 SoC system controller driver.

Thanks, this is on for-next.