Skip to contentSkip to conversation

lib: remove redundant assignment to variable ret

PATCH Applied Colin Ian King 2 participants 2 messages Dec 30, 2021 – Jan 6, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: remove redundant assignment to variable ret

Variable ret is being assigned a value that is never read. If the for-loop is entered then ret is immediately re-assigned a new value. If the for-loop is not executed ret is never read. The assignment is redundant and can be removed.

---
 lib/asn1_encoder.c | 2 --
 1 file changed, 2 deletions(-)
lib/asn1_encoder.c +0 -2
index 27bbe891714f..0fd3c454a468 100644
@@ -164,8 +164,6 @@ asn1_encode_oid(unsigned char *data, const unsigned char *end_data,
 
 	data_len -= 3;
 
-	ret = 0;
-
 	for (i = 2; i < oid_len; i++) {
 		ret = asn1_encode_oid_digit(&d, &data_len, oid[i]);
 		if (ret < 0)
Signature · 1 line
2.33.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Colin Ian King

Variable ret is being assigned a value that is never read. If the for-loop is entered then ret is immediately re-assigned a new value. If the for-loop is not executed ret is never read. The assignment is redundant and can be removed.

BR,
Jarkko

Quoted 20 lines
---
 lib/asn1_encoder.c | 2 --
 1 file changed, 2 deletions(-)
lib/asn1_encoder.c +0 -2
index 27bbe891714f..0fd3c454a468 100644
@@ -164,8 +164,6 @@ asn1_encode_oid(unsigned char *data, const unsigned char *end_data,
 
 	data_len -= 3;
 
-	ret = 0;
-
 	for (i = 2; i < oid_len; i++) {
 		ret = asn1_encode_oid_digit(&d, &data_len, oid[i]);
 		if (ret < 0)
Signature · 1 line
2.33.1