ARM: mediatek: add smp bringup code for MT6582
Subsystems (4)
PATCH 1/2 ARM: mediatek: add smp bringup code for MT6582
This patch adds support SMP on MediaTek MT6582 Cortex-A7 quad core SoC.
--- arch/arm/mach-mediatek/mediatek.c | 4 +++- arch/arm/mach-mediatek/platsmp.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)
arch/arm/mach-mediatek/mediatek.c +3 -1
@@ -20,7 +20,8 @@ static void __init mediatek_timer_init(void) {void __iomem *gpt_base; -if (of_machine_is_compatible ("mediatek,mt6589" ) || +if (of_machine_is_compatible ("mediatek,mt6582" ) || +of_machine_is_compatible ("mediatek,mt6589" ) ||of_machine_is_compatible ("mediatek,mt7623" ) ||of_machine_is_compatible ("mediatek,mt8135" ) ||of_machine_is_compatible ("mediatek,mt8127" )) {
@@ -38,6 +39,7 @@ static void __init mediatek_timer_init(void)static const char *const mediatek_board_dt_compat[] = {"mediatek,mt2701" , +"mediatek,mt6582" ,"mediatek,mt6589" ,"mediatek,mt6592" ,"mediatek,mt7623" ,
arch/arm/mach-mediatek/platsmp.c +1 -0
@@ -49,6 +49,7 @@ static const struct of_device_id mtk_tz_smp_boot_infos[] __initconst = { };static const struct of_device_id mtk_smp_boot_infos[]__initconst = { + { .compatible ="mediatek,mt6582" , .data = &mtk_mt7623_boot }, { .compatible ="mediatek,mt6589" , .data = &mtk_mt6589_boot }, { .compatible ="mediatek,mt7623" , .data = &mtk_mt7623_boot }, { .compatible ="mediatek,mt7629" , .data = &mtk_mt7623_boot },
Signature · 1 line
2.34.1
PATCH 2/2 ARM: mediatek: dts: activate SMP for mt6582
This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
--- arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-)
arch/arm/boot/dts/mt6582.dtsi +30 -5
@@ -15,29 +15,43 @@ / { cpus { #address-cells = <1>; #size-cells = <0>; + enable-method = "mediatek,mt6589-smp"; - cpu@0 { + cpu0: cpu@0 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x0>; + clock-frequency = <1300000000>; }; - cpu@1 { + cpu1: cpu@1 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x1>; + clock-frequency = <1300000000>; }; - cpu@2 { + cpu2: cpu@2 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x2>; + clock-frequency = <1300000000>; }; - cpu@3 { + cpu3: cpu@3 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x3>; + clock-frequency = <1300000000>; }; }; + pmu { + compatible = "arm,cortex-a7-pmu"; + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; + }; + system_clk: dummy13m { compatible = "fixed-clock"; clock-frequency = <13000000>;
@@ -56,7 +70,18 @@ uart_clk: dummy26m { #clock-cells = <0>; }; - timer: timer@11008000 { + timer { + compatible = "arm,armv7-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; + clock-frequency = <13000000>; + arm,cpu-registers-not-fw-configured; + }; + + timer: timer@10008000 { compatible = "mediatek,mt6577-timer"; reg = <0x10008000 0x80>; interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.34.1
Matthias Brugger
maintainerRe: [PATCH 2/2] ARM: mediatek: dts: activate SMP for mt6582
Quoted 13 lines · Maxim Kutnij
This patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
Signed-off-by Maxim Kutnij <[email protected]>--- arch/arm/boot/dts/mt6582.dtsi | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-)arch/arm/boot/dts/mt6582.dtsi +0
-0@@ -15,29 +15,43 @@ / { cpus {
arch/arm/boot/dts/mt6582.dtsi / { · line 24
Quoted 10 lines
arch/arm/boot/dts/mt6582.dtsi +3
-1#address-cells = <1>; #size-cells = <0>; + enable-method = "mediatek,mt6589-smp"; - cpu@0 { + cpu0: cpu@0 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x0>; + clock-frequency = <1300000000>;
What do we need the clock-frequency for? I wasn't able to figure that out right now.
Other then that patches look good.
Regards,
Matthias
Quoted 56 lines
arch/arm/boot/dts/mt6582.dtsi +27
-4}; - cpu@1 { + cpu1: cpu@1 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x1>; + clock-frequency = <1300000000>; }; - cpu@2 { + cpu2: cpu@2 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x2>; + clock-frequency = <1300000000>; }; - cpu@3 { + cpu3: cpu@3 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x3>; + clock-frequency = <1300000000>; }; }; + pmu { + compatible = "arm,cortex-a7-pmu"; + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; + }; + system_clk: dummy13m { compatible = "fixed-clock"; clock-frequency = <13000000>;@@ -56,7 +70,18 @@ uart_clk: dummy26m { #clock-cells = <0>; }; - timer: timer@11008000 { + timer { + compatible = "arm,armv7-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; + clock-frequency = <13000000>; + arm,cpu-registers-not-fw-configured; + }; + + timer: timer@10008000 { compatible = "mediatek,mt6577-timer"; reg = <0x10008000 0x80>; interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
Quoted 7 lines · Matthias Brugger
What do we need the clock-frequency for? I wasn't able to figure that out right now.
Other then that patches look good.
Regards,
Matthias
I thought it might be useful in the future. But if not, then I will remove it in the next patch.
Maxim
PATCH v2 1/2 ARM: mediatek: add smp bringup code for MT6582
In reply to Matthias BruggerThis patch adds SMP support on the MediaTek MT6582 quad-core Cortex-A7 SoC. And also enable GPT6.
--- arch/arm/mach-mediatek/mediatek.c | 4 +++- arch/arm/mach-mediatek/platsmp.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)
arch/arm/mach-mediatek/mediatek.c +3 -1
@@ -20,7 +20,8 @@ static void __init mediatek_timer_init(void) {void __iomem *gpt_base; -if (of_machine_is_compatible ("mediatek,mt6589" ) || +if (of_machine_is_compatible ("mediatek,mt6582" ) || +of_machine_is_compatible ("mediatek,mt6589" ) ||of_machine_is_compatible ("mediatek,mt7623" ) ||of_machine_is_compatible ("mediatek,mt8135" ) ||of_machine_is_compatible ("mediatek,mt8127" )) {
@@ -38,6 +39,7 @@ static void __init mediatek_timer_init(void)static const char *const mediatek_board_dt_compat[] = {"mediatek,mt2701" , +"mediatek,mt6582" ,"mediatek,mt6589" ,"mediatek,mt6592" ,"mediatek,mt7623" ,
arch/arm/mach-mediatek/platsmp.c +1 -0
@@ -49,6 +49,7 @@ static const struct of_device_id mtk_tz_smp_boot_infos[] __initconst = { };static const struct of_device_id mtk_smp_boot_infos[]__initconst = { + { .compatible ="mediatek,mt6582" , .data = &mtk_mt7623_boot }, { .compatible ="mediatek,mt6589" , .data = &mtk_mt6589_boot }, { .compatible ="mediatek,mt7623" , .data = &mtk_mt7623_boot }, { .compatible ="mediatek,mt7629" , .data = &mtk_mt7623_boot },
Signature · 1 line
2.33.1
PATCH v2 2/2 ARM: mediatek: dts: activate SMP for mt6582
In reply to Matthias BruggerThis patch adds nodes mt6589-smp, pmu and arm,armv7-timer.
--- arch/arm/boot/dts/mt6582.dtsi | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-)
arch/arm/boot/dts/mt6582.dtsi +26 -5
@@ -15,29 +15,39 @@ / { cpus { #address-cells = <1>; #size-cells = <0>; + enable-method = "mediatek,mt6589-smp"; - cpu@0 { + cpu0: cpu@0 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x0>; }; - cpu@1 { + cpu1: cpu@1 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x1>; }; - cpu@2 { + cpu2: cpu@2 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x2>; }; - cpu@3 { + cpu3: cpu@3 { device_type = "cpu"; compatible = "arm,cortex-a7"; reg = <0x3>; }; }; + pmu { + compatible = "arm,cortex-a7-pmu"; + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 5 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 6 IRQ_TYPE_LEVEL_LOW>, + <GIC_SPI 7 IRQ_TYPE_LEVEL_LOW>; + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; + }; + system_clk: dummy13m { compatible = "fixed-clock"; clock-frequency = <13000000>;
@@ -56,7 +66,18 @@ uart_clk: dummy26m { #clock-cells = <0>; }; - timer: timer@11008000 { + timer { + compatible = "arm,armv7-timer"; + interrupt-parent = <&gic>; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; + clock-frequency = <13000000>; + arm,cpu-registers-not-fw-configured; + }; + + timer: timer@10008000 { compatible = "mediatek,mt6577-timer"; reg = <0x10008000 0x80>; interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_LOW>;
Signature · 7 lines
2.33.1 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek