package/tvheadend: disable execinfo
PATCH 1/1 package/tvheadend: disable execinfo
Disable execinfo to avoid the following build failure if libexecinfo is built before tvheadend since the addition of the package in commit eea8ba446c10701a273432552108d80fb2224ef4:
/home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld: /home/peko/autobuild/instance-0/output-1/build/tvheadend-b8710206eb073c72b142bce95846b77a0ffa34a6/build.linux/src/tvhlog.o: in function `tvhlog_backtrace_printf':/home/peko/autobuild/instance-0/output-1/build/tvheadend-b8710206eb073c72b142bce95846b77a0ffa34a6/src/tvhlog.c:522: undefined reference to `backtrace'
Fixes:
- http://autobuild.buildroot.org/results/ee9ad2c999b622097fe0f1522e7e32184722e548
--- .../0002-configure-add-execinfo-option.patch | 55 +++++++++++++++++++ package/tvheadend/tvheadend.mk | 1 + 2 files changed, 56 insertions(+) create mode 100644 package/tvheadend/0002-configure-add-execinfo-option.patch
package/tvheadend/0002-configure-add-execinfo-option.patch new file +55 -0
@@ -0,0 +1,55 @@ +From 04c01e631cb1bf47dd50b1ef92a086308e380eff Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Sat, 1 Jan 2022 16:53:29 +0100 +Subject: [PATCH] configure: add execinfo option + +Add execinfo option to allow the user to disable the feature even if +execinfo.h is found on the system + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upsteam status: https://github.com/tvheadend/tvheadend/pull/1431] +--- + configure | 17 +++++++++++++++-- + 1 file changed, 15 insertions(+), 2 deletions(-) + +diff --git a/configure b/configure +index 4dad024c4..c087502bf 100755 +--- a/configure ++++ b/configure +@@ -75,6 +75,7 @@ OPTIONS=( + "ddci:yes" + "cclang_threadsan:no" + "gperftools:no" ++ "execinfo:auto" + ) + + # +@@ -150,11 +151,23 @@ if [ ${PLATFORM} = "freebsd" ]; then + # If we don't have libunwind then fallback to execinfo. + if ! enabled libunwind + then +- check_cc_header execinfo ++ if enabled_or_auto execinfo; then ++ if check_cc_header execinfo; then ++ enable execinfo ++ else ++ die "execinfo.h not found (use --disable-execinfo)" ++ fi ++ fi + fi + + else +- check_cc_header execinfo ++ if enabled_or_auto execinfo; then ++ if check_cc_header execinfo; then ++ enable execinfo ++ else ++ die "execinfo.h not found (use --disable-execinfo)" ++ fi ++ fi + fi + check_cc_option mmx + check_cc_option sse2 +-- +2.33.0 +
package/tvheadend/tvheadend.mk +1 -0
@@ -161,6 +161,7 @@ define TVHEADEND_CONFIGURE_CMDS --enable-dvbscan \ --enable-bundle \ --enable-pngquant \ + --disable-execinfo \ --disable-ffmpeg_static \ --disable-hdhomerun_static \ $(TVHEADEND_CONF_OPTS) \
Signature · 6 lines
2.33.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 6 lines · Fabrice Fontaine
Disable execinfo to avoid the following build failure if libexecinfo is built before tvheadend since the addition of the package in commit
eea8ba446c10701a273432552108d80fb2224ef4:
/home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i686-buildroot-linux-uclibc/9.3.0/../../../../i686-buildroot-linux-uclibc/bin/ld:/home/peko/autobuild/instance-0/output-1/build/tvheadend-b8710206eb073c72b142bce95846b77a0ffa34a6/build.linux/src/tvhlog.o: in function `tvhlog_backtrace_printf':/home/peko/autobuild/instance-0/output-1/build/tvheadend-b8710206eb073c72b142bce95846b77a0ffa34a6/src/tvhlog.c:522: undefined reference to `backtrace'
I was thinking, why not simply link with libexecinfo when needed? But since
the patch was anyway accepted upstream and I don't care about execinfo in tvheadend:
Applied to master, thanks.
Regards,
Arnout
Quoted 78 lines
Fixes:
- http://autobuild.buildroot.org/results/ee9ad2c999b622097fe0f1522e7e32184722e548Signed-off-by Fabrice Fontaine <[email protected]>--- .../0002-configure-add-execinfo-option.patch | 55 +++++++++++++++++++ package/tvheadend/tvheadend.mk | 1 + 2 files changed, 56 insertions(+)create mode 100644
package/tvheadend/0002-configure-add-execinfo-option.patchpackage/tvheadend/0002-configure-add-execinfo-option.patch new file +55
-0@@ -0,0 +1,55 @@ +From 04c01e631cb1bf47dd50b1ef92a086308e380eff Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Sat, 1 Jan 2022 16:53:29 +0100 +Subject: [PATCH] configure: add execinfo option + +Add execinfo option to allow the user to disable the feature even if +execinfo.h is found on the system + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upsteam status: https://github.com/tvheadend/tvheadend/pull/1431] +--- + configure | 17 +++++++++++++++-- + 1 file changed, 15 insertions(+), 2 deletions(-) + +diff --git a/configure b/configure +index 4dad024c4..c087502bf 100755 +--- a/configure ++++ b/configure +@@ -75,6 +75,7 @@ OPTIONS=( + "ddci:yes" + "cclang_threadsan:no" + "gperftools:no" ++ "execinfo:auto" + ) + + # +@@ -150,11 +151,23 @@ if [ ${PLATFORM} = "freebsd" ]; then + # If we don't have libunwind then fallback to execinfo. + if ! enabled libunwind + then +- check_cc_header execinfo ++ if enabled_or_auto execinfo; then ++ if check_cc_header execinfo; then ++ enable execinfo ++ else ++ die "execinfo.h not found (use --disable-execinfo)" ++ fi ++ fi + fi + + else +- check_cc_header execinfo ++ if enabled_or_auto execinfo; then ++ if check_cc_header execinfo; then ++ enable execinfo ++ else ++ die "execinfo.h not found (use --disable-execinfo)" ++ fi ++ fi + fi + check_cc_option mmx + check_cc_option sse2 +-- +2.33.0 +package/tvheadend/tvheadend.mk +0
-0
package/tvheadend/tvheadend.mk define TVHEADEND_CONFIGURE_CMDS · line 167
Quoted 7 lines
package/tvheadend/tvheadend.mk +1
-0@@ -161,6 +161,7 @@ define TVHEADEND_CONFIGURE_CMDS --enable-dvbscan \ --enable-bundle \ --enable-pngquant \ + --disable-execinfo \ --disable-ffmpeg_static \ --disable-hdhomerun_static \ $(TVHEADEND_CONF_OPTS) \
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot