power: supply: add dock type

PATCH In review Jack Wu 2 participants 4 messages Jan 4, 2022 – Mar 4, 2022 Power supply

Share & tools

Jack Wu

author

2022-01-04 12:25 UTC #0 lore raw

PATCH 1/1 power: supply: add dock type

Add dock power_supply_type for the drivers which supports dock can register a power supply class device with POWER_SUPPLY_TYPE_DOCK.

Signed-off-by Jack Wu <[email protected]>

---
 Documentation/ABI/testing/sysfs-class-power | 2 +-
 drivers/power/supply/power_supply_sysfs.c   | 1 +
 include/linux/power_supply.h                | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

Documentation/ABI/testing/sysfs-class-power +1 -1

index f7904efc4cfa..854299a0d36f 100644
@@ -34,7 +34,7 @@ Description:
 		Describes the main type of the supply.
 
 		Access: Read
-		Valid values: "Battery", "UPS", "Mains", "USB", "Wireless"
+		Valid values: "Battery", "UPS", "Mains", "USB", "Wireless", "Dock"
 
 **Battery and USB properties**

drivers/power/supply/power_supply_sysfs.c +1 -0

index c3d7cbcd4fad..53494b56bbb4 100644
@@ -57,6 +57,7 @@ static const char * const POWER_SUPPLY_TYPE_TEXT[] = {
 	[POWER_SUPPLY_TYPE_USB_PD_DRP]		= "USB_PD_DRP",
 	[POWER_SUPPLY_TYPE_APPLE_BRICK_ID]	= "BrickID",
 	[POWER_SUPPLY_TYPE_WIRELESS]		= "Wireless",
+	[POWER_SUPPLY_TYPE_DOCK]		= "Dock",
 };
 
 static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {

include/linux/power_supply.h +1 -0

index 9ca1f120a211..fa80eaa54242 100644
@@ -187,6 +187,7 @@ enum power_supply_type {
 	POWER_SUPPLY_TYPE_USB_PD_DRP,		/* PD Dual Role Port */
 	POWER_SUPPLY_TYPE_APPLE_BRICK_ID,	/* Apple Charging Method */
 	POWER_SUPPLY_TYPE_WIRELESS,		/* Wireless */
+	POWER_SUPPLY_TYPE_DOCK,			/* Dock Charging */
 };
 
 enum power_supply_usb_type {

Signature · 1 line

2.34.1.448.ga2b2bfdf31-goog

Jack Wu

author

2022-01-07 03:37 UTC #1 lore raw

+ Alex and Vincent

Jack Wu <[email protected]> 於 2022年1月4日週二下午8:25寫道：

Quoted 51 lines

Add dock power_supply_type for the drivers which supports dock can register a power supply class device with POWER_SUPPLY_TYPE_DOCK.

Signed-off-by Jack Wu <[email protected]>

---
 Documentation/ABI/testing/sysfs-class-power | 2 +-
 drivers/power/supply/power_supply_sysfs.c   | 1 +
 include/linux/power_supply.h                | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

Documentation/ABI/testing/sysfs-class-power +1 -1

index f7904efc4cfa..854299a0d36f 100644
@@ -34,7 +34,7 @@ Description:
                Describes the main type of the supply.
 
                Access: Read
-               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless"
+               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless", "Dock"
 
 **Battery and USB properties**

drivers/power/supply/power_supply_sysfs.c +1 -0

index c3d7cbcd4fad..53494b56bbb4 100644
@@ -57,6 +57,7 @@ static const char * const POWER_SUPPLY_TYPE_TEXT[] = {
        [POWER_SUPPLY_TYPE_USB_PD_DRP]          = "USB_PD_DRP",
        [POWER_SUPPLY_TYPE_APPLE_BRICK_ID]      = "BrickID",
        [POWER_SUPPLY_TYPE_WIRELESS]            = "Wireless",
+       [POWER_SUPPLY_TYPE_DOCK]                = "Dock",
 };
 
 static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {

include/linux/power_supply.h +1 -1

index 9ca1f120a211..fa80eaa54242 100644
@@ -187,6 +187,7 @@ enum power_supply_type {
        POWER_SUPPLY_TYPE_USB_PD_DRP,           /* PD Dual Role Port */
        POWER_SUPPLY_TYPE_APPLE_BRICK_ID,       /* Apple Charging Method */
        POWER_SUPPLY_TYPE_WIRELESS,             /* Wireless */
+       POWER_SUPPLY_TYPE_DOCK,                 /* Dock Charging */
 };
 
 enum power_supply_usb_type {
--

2.34.1.448.ga2b2bfdf31-goog

Jack Wu

author

2022-02-14 06:23 UTC #2 lore raw

+ Ken

Jack Wu <[email protected]> 於 2022年1月7日週五上午11:37寫道：

Quoted 55 lines

+ Alex and Vincent

Jack Wu <[email protected]> 於 2022年1月4日週二下午8:25寫道：

Quoted 51 lines

Add dock power_supply_type for the drivers which supports dock can register a power supply class device with POWER_SUPPLY_TYPE_DOCK.

Signed-off-by Jack Wu <[email protected]>

---
 Documentation/ABI/testing/sysfs-class-power | 2 +-
 drivers/power/supply/power_supply_sysfs.c   | 1 +
 include/linux/power_supply.h                | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

Documentation/ABI/testing/sysfs-class-power +1 -1

index f7904efc4cfa..854299a0d36f 100644
@@ -34,7 +34,7 @@ Description:
                Describes the main type of the supply.
 
                Access: Read
-               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless"
+               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless", "Dock"
 
 **Battery and USB properties**

drivers/power/supply/power_supply_sysfs.c +1 -0

index c3d7cbcd4fad..53494b56bbb4 100644
@@ -57,6 +57,7 @@ static const char * const POWER_SUPPLY_TYPE_TEXT[] = {
        [POWER_SUPPLY_TYPE_USB_PD_DRP]          = "USB_PD_DRP",
        [POWER_SUPPLY_TYPE_APPLE_BRICK_ID]      = "BrickID",
        [POWER_SUPPLY_TYPE_WIRELESS]            = "Wireless",
+       [POWER_SUPPLY_TYPE_DOCK]                = "Dock",
 };
 
 static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {

include/linux/power_supply.h +1 -1

index 9ca1f120a211..fa80eaa54242 100644
@@ -187,6 +187,7 @@ enum power_supply_type {
        POWER_SUPPLY_TYPE_USB_PD_DRP,           /* PD Dual Role Port */
        POWER_SUPPLY_TYPE_APPLE_BRICK_ID,       /* Apple Charging Method */
        POWER_SUPPLY_TYPE_WIRELESS,             /* Wireless */
+       POWER_SUPPLY_TYPE_DOCK,                 /* Dock Charging */
 };
 
 enum power_supply_usb_type {
--

2.34.1.448.ga2b2bfdf31-goog

Sebastian Reichel

2022-03-04 22:00 UTC #3 lore raw

Hi,

When you send a new patch version you should

a) increase patch version (this is v2)
b) add a changelog below the --- marker

Apart from that this submission is still missing a driver using the newly introduced POWER_SUPPLY_TYPE_DOCK. Mainline kernel ABI is only extended for mainline kernel users.

Thanks,

-- Sebastian

Quoted 58 lines · Jack Wu

+ Ken

Jack Wu <[email protected]> 於 2022年1月7日週五上午11:37寫道：

Quoted 55 lines

+ Alex and Vincent

Jack Wu <[email protected]> 於 2022年1月4日週二下午8:25寫道：

Quoted 51 lines

Add dock power_supply_type for the drivers which supports dock can register a power supply class device with POWER_SUPPLY_TYPE_DOCK.

Signed-off-by Jack Wu <[email protected]>

---
 Documentation/ABI/testing/sysfs-class-power | 2 +-
 drivers/power/supply/power_supply_sysfs.c   | 1 +
 include/linux/power_supply.h                | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

Documentation/ABI/testing/sysfs-class-power +1 -1

index f7904efc4cfa..854299a0d36f 100644
@@ -34,7 +34,7 @@ Description:
                Describes the main type of the supply.
 
                Access: Read
-               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless"
+               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless", "Dock"
 
 **Battery and USB properties**

drivers/power/supply/power_supply_sysfs.c +1 -0

index c3d7cbcd4fad..53494b56bbb4 100644
@@ -57,6 +57,7 @@ static const char * const POWER_SUPPLY_TYPE_TEXT[] = {
        [POWER_SUPPLY_TYPE_USB_PD_DRP]          = "USB_PD_DRP",
        [POWER_SUPPLY_TYPE_APPLE_BRICK_ID]      = "BrickID",
        [POWER_SUPPLY_TYPE_WIRELESS]            = "Wireless",
+       [POWER_SUPPLY_TYPE_DOCK]                = "Dock",
 };
 
 static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {

include/linux/power_supply.h +1 -1

index 9ca1f120a211..fa80eaa54242 100644
@@ -187,6 +187,7 @@ enum power_supply_type {
        POWER_SUPPLY_TYPE_USB_PD_DRP,           /* PD Dual Role Port */
        POWER_SUPPLY_TYPE_APPLE_BRICK_ID,       /* Apple Charging Method */
        POWER_SUPPLY_TYPE_WIRELESS,             /* Wireless */
+       POWER_SUPPLY_TYPE_DOCK,                 /* Dock Charging */
 };
 
 enum power_supply_usb_type {
--

2.34.1.448.ga2b2bfdf31-goog