Skip to contentSkip to conversation

MIPS: Loongson64: Add missing of_node_put() in ls2k_reset_init()

PATCH Applied Yang Yingliang 2 participants 2 messages Jan 4, 2022 – Jan 5, 2022 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: Loongson64: Add missing of_node_put() in ls2k_reset_init()

This node pointer is returned by of_find_compatible_node() with refcount incremented in ls2k_reset_init(). Calling of_node_put() to aovid the refcount leak.

Fixes 7eb7819a2e12 ("MIPS: Loongson64: Add Loongson-2K1000 reset platform driver")
---
 drivers/platform/mips/ls2k-reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/mips/ls2k-reset.c +1 -1
index b70e7b8a092c..8f42d5d16480 100644
@@ -38,6 +38,7 @@ static int ls2k_reset_init(void)
 	}
 
 	base = of_iomap(np, 0);
+	of_node_put(np);
 	if (!base) {
 		pr_info("Failed to map PM register base address\n");
 		return -ENOMEM;
@@ -46,7 +47,6 @@ static int ls2k_reset_init(void)
 	_machine_restart = ls2k_restart;
 	pm_power_off = ls2k_poweroff;
 
-	of_node_put(np);
 	return 0;
 }
 
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 33 lines · Yang Yingliang

This node pointer is returned by of_find_compatible_node() with refcount incremented in ls2k_reset_init(). Calling of_node_put() to aovid the refcount leak.

Fixes 7eb7819a2e12 ("MIPS: Loongson64: Add Loongson-2K1000 reset platform driver")
---
 drivers/platform/mips/ls2k-reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/mips/ls2k-reset.c +1 -1
index b70e7b8a092c..8f42d5d16480 100644
@@ -38,6 +38,7 @@ static int ls2k_reset_init(void)
 	}
 
 	base = of_iomap(np, 0);
+	of_node_put(np);
 	if (!base) {
 		pr_info("Failed to map PM register base address\n");
 		return -ENOMEM;
@@ -46,7 +47,6 @@ static int ls2k_reset_init(void)
 	_machine_restart = ls2k_restart;
 	pm_power_off = ls2k_poweroff;
 
-	of_node_put(np);
 	return 0;
 }
 
Signature · 1 line
2.25.1

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]