Skip to contentSkip to conversation

usb: dwc2: do not gate off the hardware if it does not support clock gating

PATCH New Dinh Nguyen 1 participant 1 message Jan 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 usb: dwc2: do not gate off the hardware if it does not support clock gating

We should not be clearing the HCD_FLAG_HW_ACCESSIBLE bit if the hardware does not support clock gating.

Fixes 50fb0c128b6e ("usb: dwc2: Add clock gating entering flow by system suspend")

---
v2: Add Acked-by, and fix "Fixes" line

---
 drivers/usb/dwc2/hcd.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/usb/dwc2/hcd.c +4 -3
index 13c779a28e94..f63a27d11fac 100644
@@ -4399,11 +4399,12 @@ static int _dwc2_hcd_suspend(struct usb_hcd *hcd)
 		 * If not hibernation nor partial power down are supported,
 		 * clock gating is used to save power.
 		 */
-		if (!hsotg->params.no_clock_gating)
+		if (!hsotg->params.no_clock_gating) {
 			dwc2_host_enter_clock_gating(hsotg);
 
-		/* After entering suspend, hardware is not accessible */
-		clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
+			/* After entering suspend, hardware is not accessible */
+			clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
+		}
 		break;
 	default:
 		goto skip_power_saving;
Signature · 1 line
2.25.1