powerpc/cacheinfo: use default_groups in kobj_type
PATCH 1/1 powerpc/cacheinfo: use default_groups in kobj_type
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the powerpc cacheinfo sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.
--- arch/powerpc/kernel/cacheinfo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
arch/powerpc/kernel/cacheinfo.c +3 -2
@@ -710,7 +710,7 @@ static struct kobj_attribute cache_shared_cpu_list_attr =__ATTR (shared_cpu_list,0444 , shared_cpu_list_show,NULL );/* Attributes which should always be created -- the kobject/sysfs core -* does this automatically via kobj_type->default_attrs. This is the +* does this automatically via kobj_type->default_groups. This is the * minimum data required to uniquely identify a cache. */ static struct attribute *cache_index_default_attrs[] = {
@@ -720,6 +720,7 @@ static struct attribute *cache_index_default_attrs[] = { &cache_shared_cpu_list_attr.attr,NULL , }; +ATTRIBUTE_GROUPS (cache_index_default);/* Attributes which should be created if the cache device node has the * right properties -- see cacheinfo_create_index_opt_attrs
@@ -738,7 +739,7 @@ static const struct sysfs_ops cache_index_ops = {static struct kobj_type cache_index_type = { .release = cache_index_release, .sysfs_ops = &cache_index_ops, - .default_attrs = cache_index_default_attrs, + .default_groups = cache_index_default_groups, };static void cacheinfo_create_index_opt_attrs (struct cache_index_dir *dir)
Signature · 1 line
2.34.1
Quoted 7 lines · Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through thedefault_attrsfield, and thedefault_groupsfield. Move the powerpc cacheinfo sysfs code to usedefault_groupsfield which has been the preferred way sinceaa30f47cf666("kobject: Add support for default attribute groups tokobj_type") so that we can soon get rid of the obsoletedefault_attrsfield.
Quoted 8 lines
Cc Michael Ellerman <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc Paul Mackerras <[email protected]>Cc "Gautham R. Shenoy" <[email protected]>Cc Parth Shah <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>---
Michael Ellerman
AppliedQuoted 8 lines · Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through thedefault_attrsfield, and thedefault_groupsfield. Move the powerpc cacheinfo sysfs code to usedefault_groupsfield which has been the preferred way sinceaa30f47cf666("kobject: Add support for default attribute groups tokobj_type") so that we can soon get rid of the obsoletedefault_attrsfield.[...]
Applied to powerpc/next.
[1/1] powerpc/cacheinfo: use default_groups in kobj_type
https://git.kernel.org/powerpc/c/2bdf3f9e9df0a4ce7709fc916b9997ca2dc30d25
cheers