Skip to contentSkip to conversation

Config.in.legacy: fix removed bootlin riscv64 toolchains

PATCH Applied Arnout Vandecappelle (Essensium/Mind) 3 participants 3 messages Jan 4, 2022 – Jan 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Config.in.legacy: fix removed bootlin riscv64 toolchains

commit b3c66481e1f1503fcbf193d0c780271e880ad500 replaced RISC-V LP64 bootlin toolchains by RISC-V LP64D. However, Config.in.legacy was added for BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE, which never existed (the stable version was only added after the switch to LP64D). Conversely, BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE, which was removed, was not mentioned in Config.in.legacy.

Correct the symbol name and its comment in Config.in.legacy.

---
 Config.in.legacy | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Config.in.legacy +2 -2
index 5994d94487..e5349e58ac 100644
@@ -153,8 +153,8 @@ config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_BLEEDING_EDGE
 	  The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
 	  in favor of RISC-V 64-bit LP64D toolchains.
 
-config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE
-	bool "Bootlin riscv64 glibc bleeding-edge toolchain removed"
+config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE
+	bool "Bootlin riscv64 musl bleeding-edge toolchain removed"
 	select BR2_LEGACY
 	help
 	  The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Arnout, All,

On 2022-01-04 18:11 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:

Quoted 8 lines

commit b3c66481e1f1503fcbf193d0c780271e880ad500 replaced RISC-V LP64 bootlin toolchains by RISC-V LP64D. However, Config.in.legacy was added for BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE, which never existed (the stable version was only added after the switch to LP64D). Conversely, BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE, which was removed, was not mentioned in Config.in.legacy.

Correct the symbol name and its comment in Config.in.legacy.

Thanks for spotting what I missed. How did you notice, so that I can add that to my check-list?

Quoted 1 line

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 Config.in.legacy | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Config.in.legacy +2 -2
index 5994d94487..e5349e58ac 100644
@@ -153,8 +153,8 @@ config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_BLEEDING_EDGE
 	  The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
 	  in favor of RISC-V 64-bit LP64D toolchains.
 
-config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE
-	bool "Bootlin riscv64 glibc bleeding-edge toolchain removed"
+config BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE
+	bool "Bootlin riscv64 musl bleeding-edge toolchain removed"
 	select BR2_LEGACY
 	help
 	  The RISC-V 64-bit LP64 Bootlin toolchains have been removed,
Signature · 6 lines
2.31.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Acked-by on v1 1/1
#2 lore raw
In reply to Arnout Vandecappelle (Essensium/Mind)

Hello Arnout,

Quoted 7 lines · On Tue, 4 Jan 2022 18:11:28 +0100 "Arnout Vandecappelle (Essensium/Mind)"…

commit b3c66481e1f1503fcbf193d0c780271e880ad500 replaced RISC-V LP64 bootlin toolchains by RISC-V LP64D. However, Config.in.legacy was added for BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_GLIBC_STABLE, which never existed (the stable version was only added after the switch to LP64D). Conversely, BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_RISCV64_MUSL_BLEEDING_EDGE, which was removed, was not mentioned in Config.in.legacy.

Quoted 6 lines

Correct the symbol name and its comment in Config.in.legacy.

---
 Config.in.legacy | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Too late, but:

Thanks for fixing this!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot