Skip to contentSkip to conversation

package/qpdf: needs atomic

PATCH In review Fabrice Fontaine 2 participants 4 messages Jan 4, 2022 – Jan 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qpdf: needs atomic

qpdf needs atomic since bump to version 10.5.0 in commit b5352c2177011ca389cbb7c68e78447549cbdaaa and
https://github.com/qpdf/qpdf/commit/c5c1a028cdd3cf345046c46963fb0fdacfb2c33c:

/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/m68k-buildroot-uclinux-uclibc/bin/ld.real: /home/buildroot/autobuild/instance-2/output-1/build/qpdf-10.5.0/libqpdf/build/.libs/libqpdf.a(QPDF.o): in function `QPDF::QPDF()':
QPDF.cc:(.text+0x48de): undefined reference to `__atomic_fetch_add_8'

Fixes:
- http://autobuild.buildroot.org/results/7e18689670dcbe491c35f0597e5c3c787936263f

---
 package/cups-filters/Config.in | 2 ++
 package/qpdf/Config.in         | 2 ++
 2 files changed, 4 insertions(+)
package/cups-filters/Config.in +2 -0
index 32381e6c1f..ded99a4774 100644
@@ -8,6 +8,7 @@ config BR2_PACKAGE_CUPS_FILTERS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_PACKAGE_CUPS
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # qpdf
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC # qpdf
 	select BR2_PACKAGE_JPEG
 	select BR2_PACKAGE_FONTCONFIG
 	select BR2_PACKAGE_FREETYPE
@@ -33,6 +34,7 @@ config BR2_PACKAGE_CUPS_FILTERS
 
 comment "cups-filters needs a toolchain w/ wchar, C++, threads and dynamic library, gcc >= 5"
 	depends on BR2_USE_MMU
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_USE_WCHAR || BR2_STATIC_LIBS || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
package/qpdf/Config.in +2 -0
index 047c4c8a75..accf2b5f34 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QPDF
 	bool "qpdf"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_JPEG
 	select BR2_PACKAGE_LIBOPENSSL_ENABLE_RC4 if BR2_PACKAGE_LIBOPENSSL
@@ -16,5 +17,6 @@ config BR2_PACKAGE_QPDF
 	  http://qpdf.sourceforge.net/
 
 comment "qpdf needs a toolchain w/ C++, gcc >= 5"
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 7 lines · On Tue, 4 Jan 2022 22:07:27 +0100 Fabrice Fontaine…

qpdf needs atomic since bump to version 10.5.0 in commit b5352c2177011ca389cbb7c68e78447549cbdaaa and
https://github.com/qpdf/qpdf/commit/c5c1a028cdd3cf345046c46963fb0fdacfb2c33c:

/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/m68k-buildroot-uclinux-uclibc/bin/ld.real: /home/buildroot/autobuild/instance-2/output-1/build/qpdf-10.5.0/libqpdf/build/.libs/libqpdf.a(QPDF.o): in function `QPDF::QPDF()':
QPDF.cc:(.text+0x48de): undefined reference to `__atomic_fetch_add_8'

Quoted 8 lines

Fixes:
- http://autobuild.buildroot.org/results/7e18689670dcbe491c35f0597e5c3c787936263f

---
 package/cups-filters/Config.in | 2 ++
 package/qpdf/Config.in         | 2 ++
 2 files changed, 4 insertions(+)

Applied to master, thanks. However, could you do a test build on sparcv8 ? Indeed normally when something needs atomic, it also needs to link with libatomic when available, as some architectures (such as sparcv8) have all atomic built-ins implemented in libatomic.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
Quoted 20 lines · Thomas Petazzoni
Quoted 7 lines · On Tue, 4 Jan 2022 22:07:27 +0100 Fabrice Fontaine…

qpdf needs atomic since bump to version 10.5.0 in commit b5352c2177011ca389cbb7c68e78447549cbdaaa and
https://github.com/qpdf/qpdf/commit/c5c1a028cdd3cf345046c46963fb0fdacfb2c33c:

/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/m68k-buildroot-uclinux-uclibc/bin/ld.real: /home/buildroot/autobuild/instance-2/output-1/build/qpdf-10.5.0/libqpdf/build/.libs/libqpdf.a(QPDF.o): in function `QPDF::QPDF()':
QPDF.cc:(.text+0x48de): undefined reference to `__atomic_fetch_add_8'

Quoted 8 lines

Fixes:
- http://autobuild.buildroot.org/results/7e18689670dcbe491c35f0597e5c3c787936263f

---
 package/cups-filters/Config.in | 2 ++
 package/qpdf/Config.in         | 2 ++
 2 files changed, 4 insertions(+)
Quoted 4 lines

Applied to master, thanks. However, could you do a test build on sparcv8 ? Indeed normally when something needs atomic, it also needs to link with libatomic when available, as some architectures (such as sparcv8) have all atomic built-ins implemented in libatomic.

qpdf handles linking with atomic since version 10.0.2 and
https://github.com/qpdf/qpdf/commit/66198f447f45a87718b6457756976baa8defb2fd

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 2 lines · On Fri, 7 Jan 2022 22:16:26 +0100 Fabrice Fontaine…

qpdf handles linking with atomic since version 10.0.2 and
https://github.com/qpdf/qpdf/commit/66198f447f45a87718b6457756976baa8defb2fd

Excellent, thanks for confirming!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot