counter: 104-quad-8: Fix use-after-free by quad8_irq_handler
Subsystems (3)
PATCH 1/1 counter: 104-quad-8: Fix use-after-free by quad8_irq_handler
On unbind an irq might be pending which results in quad8_irq_handler() calling counter_push_event() for a counter that is already unregistered. This patch fixes that situation by passing the struct counter_device dev to devm_request_irq() rather than the parent's so that the irq handler is cleaned before the counter is unregistered.
Fixes 7aa2ba0df651 ("counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8")
Reported-by Uwe Kleine-König <[email protected]>
Cc Syed Nayyar Waris <[email protected]>
Signed-off-by William Breathitt Gray <[email protected]>
--- drivers/counter/104-quad-8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/counter/104-quad-8.c +2 -2
@@ -1188,8 +1188,8 @@ static int quad8_probe(struct device *dev, unsigned int id)/* Enable all counters and enable interrupt function */ outb (QUAD8_CHAN_OP_ENABLE_INTERRUPT_FUNC , base[id] +QUAD8_REG_CHAN_OP ); - err =devm_request_irq (dev, irq[id], quad8_irq_handler,IRQF_SHARED , - counter->name, counter); + err =devm_request_irq (&counter->dev, irq[id], quad8_irq_handler, +IRQF_SHARED , counter->name, counter);if (err)return err;
base-commit: 8f2cade5da97713e77ca5be576438f194b8873d7
Signature · 1 line
2.33.1