pci: iproc: Set all 24 bits of PCI class code
Subsystems (2)
PATCH 1/1 pci: iproc: Set all 24 bits of PCI class code
Register 0x43c in its low 24 bits contains PCI class code.
Update code to set all 24 bits of PCI class code and not only upper 16 bits of PCI class code.
Use standard U-Boot macro (PCI_CLASS_BRIDGE_PCI << 8) for constructing all 24-bits of PCI class for PCI bridge Normal decode.
---
Roman helped me with this change and confirmed that class code is stored really in bits [23:0] of custom register 0x43c (normally class code is stored in bits [31:8] of pci register 0x08).
--- drivers/pci/pcie_iproc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/pci/pcie_iproc.c +4 -5
@@ -1127,15 +1127,14 @@ static int iproc_pcie_check_link(struct iproc_pcie *pcie)u32 link_status, class; pcie->link_is_active = false; -/* force class to PCI_CLASS_BRIDGE_PCI (0x0604) */ +/* force class to PCI bridge Normal decode (0x060400) */ #define PCI_BRIDGE_CTRL_REG_OFFSET 0x43c -#define PCI_CLASS_BRIDGE_MASK 0xffff00 -#define PCI_CLASS_BRIDGE_SHIFT 8 +#define PCI_BRIDGE_CTRL_REG_CLASS_MASK 0xffffffiproc_pci_raw_config_read32 (pcie,0 ,PCI_BRIDGE_CTRL_REG_OFFSET ,4 , &class); - class &= ~PCI_CLASS_BRIDGE_MASK ; - class |= (PCI_CLASS_BRIDGE_PCI <<PCI_CLASS_BRIDGE_SHIFT ); + class &= ~PCI_BRIDGE_CTRL_REG_CLASS_MASK ; + class |= (PCI_CLASS_BRIDGE_PCI <<8 );iproc_pci_raw_config_write32 (pcie,0 ,PCI_BRIDGE_CTRL_REG_OFFSET ,4 , class);
Signature · 1 line
2.20.1
Quoted 44 lines · Pali Rohár
Register
0x43cin its low 24 bits contains PCI class code.Update code to set all 24 bits of PCI class code and not only upper 16 bits of PCI class code.
Use standard U-Boot macro (
PCI_CLASS_BRIDGE_PCI<< 8) for constructing all 24-bits of PCI class for PCI bridge Normal decode.Signed-off-by Pali Rohár <[email protected]>---
Roman helped me with this change and confirmed that class code is stored really in bits [23:0] of custom register0x43c(normally class code is stored in bits [31:8] of pci register0x08).--- drivers/pci/pcie_iproc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)drivers/pci/pcie_iproc.c +4
-6@@ -1127,15 +1127,14 @@ static int iproc_pcie_check_link(struct iproc_pcie *pcie)u32 link_status, class; pcie->link_is_active = false; -/* force class to PCI_CLASS_BRIDGE_PCI (0x0604) */ +/* force class to PCI bridge Normal decode (0x060400) */ #define PCI_BRIDGE_CTRL_REG_OFFSET 0x43c -#define PCI_CLASS_BRIDGE_MASK 0xffff00 -#define PCI_CLASS_BRIDGE_SHIFT 8 +#define PCI_BRIDGE_CTRL_REG_CLASS_MASK 0xffffffiproc_pci_raw_config_read32 (pcie,0 ,PCI_BRIDGE_CTRL_REG_OFFSET ,4 , &class); - class &= ~PCI_CLASS_BRIDGE_MASK ; - class |= (PCI_CLASS_BRIDGE_PCI <<PCI_CLASS_BRIDGE_SHIFT ); + class &= ~PCI_BRIDGE_CTRL_REG_CLASS_MASK ; + class |= (PCI_CLASS_BRIDGE_PCI <<8 );iproc_pci_raw_config_write32 (pcie,0 ,PCI_BRIDGE_CTRL_REG_OFFSET ,4 , class); --
Quoted 2 lines
2.20.1
Signature · 11 lines
This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Quoted 10 lines · Pali Rohár
Register
0x43cin its low 24 bits contains PCI class code.Update code to set all 24 bits of PCI class code and not only upper 16 bits of PCI class code.
Use standard U-Boot macro (
PCI_CLASS_BRIDGE_PCI<< 8) for constructing all 24-bits of PCI class for PCI bridge Normal decode.Signed-off-by Pali Rohár <[email protected]>Acked-by Roman Bacik <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom