Skip to contentSkip to conversation

package/libsemanage: add gcc >= 5 dependency

PATCH Applied Fabrice Fontaine 2 participants 6 messages Jan 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 package/libsemanage: add gcc >= 5 dependency

Commit 56d9b887685c86fd4fbadda247cdbe733d499e81 forgot to add gcc >= 5 dependency

Fixes:
- No autobuilder failures (yet)

---
 package/libsemanage/Config.in     | 6 ++++--
 package/policycoreutils/Config.in | 8 +++++---
 2 files changed, 9 insertions(+), 5 deletions(-)
package/libsemanage/Config.in +4 -2
index 3c7050ee51..5103df3f15 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBSEMANAGE
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # libselinux -> libsepol
 	select BR2_PACKAGE_AUDIT
 	select BR2_PACKAGE_LIBSELINUX
 	select BR2_PACKAGE_BZIP2
@@ -17,6 +18,7 @@ config BR2_PACKAGE_LIBSEMANAGE
 
 	  http://selinuxproject.org/page/Main_Page
 
-comment "libsemanage needs a toolchain w/ threads, dynamic library"
+comment "libsemanage needs a toolchain w/ threads, dynamic library, gcc >= 5"
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
package/policycoreutils/Config.in +5 -3
index 81900b4e41..3201c8fede 100644
@@ -1,12 +1,14 @@
-comment "policycoreutils needs a toolchain w/ threads, dynamic library"
+comment "policycoreutils needs a toolchain w/ threads, dynamic library, gcc >= 5"
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
 
 config BR2_PACKAGE_POLICYCOREUTILS
 	bool "policycoreutils"
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS # libsemanage
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libsemanage
-	depends on !BR2_STATIC_LIBS #libsemanage
+	depends on !BR2_STATIC_LIBS # libsemanage
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # libsemanage -> libselinux -> libsepol
 	select BR2_PACKAGE_LIBSEMANAGE
 	select BR2_PACKAGE_LIBCAP_NG
 	help
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/4 package/refpolicy: add host gcc >= 5 dependency

Commit 56d9b887685c86fd4fbadda247cdbe733d499e81 forgot to add host gcc >= 5 dependency

Fixes:
- No autobuilder failures (yet)

---
 package/refpolicy/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/refpolicy/Config.in +4 -2
index 043cc40a72..0e72b895df 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_REFPOLICY
 	bool "refpolicy"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libsepol
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # libsepol
+	depends on BR2_HOST_GCC_AT_LEAST_5 # host-setools -> host-libsepol
 	# Even though libsepol is not necessary for building, we get
 	# the policy version from libsepol, so we select it, and treat
 	# it like a runtime dependency.
@@ -114,6 +115,7 @@ endif
 
 endif
 
-comment "refpolicy needs a toolchain w/ threads, gcc >= 5"
+comment "refpolicy needs a toolchain w/ threads, gcc >= 5, host gcc >= 5"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_5 || \
+		!BR2_HOST_GCC_AT_LEAST_5
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

PATCH 3/4 package/checkpolicy: add host gcc >= 5 dependency

In reply to Fabrice Fontaine

Commit 56d9b887685c86fd4fbadda247cdbe733d499e81 forgot to add host gcc >= 5 dependency

Fixes:
- http://autobuild.buildroot.org/results/fc727efc0c658aaae55c83632a91af83701f0c49

---
 package/checkpolicy/Config.in.host | 4 ++++
 1 file changed, 4 insertions(+)
package/checkpolicy/Config.in.host +4 -0
index 240a5b6dc4..38e35e2fc1 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_HOST_CHECKPOLICY
 	bool "host checkpolicy"
+	depends on BR2_HOST_GCC_AT_LEAST_5 # host-libselinux -> host-libsepol
 	help
 	  checkpolicy is the SELinux policy compiler. It uses libsepol
 	  to generate the binary policy. checkpolicy uses the static
@@ -8,3 +9,6 @@ config BR2_PACKAGE_HOST_CHECKPOLICY
 	  shared library interface.
 
 	  http://selinuxproject.org/page/Main_Page
+
+comment "host checkpolicy needs a toolchain w/ host gcc >= 5"
+	depends on !BR2_HOST_GCC_AT_LEAST_5
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

PATCH 4/4 package/android-tools: add host gcc >= 5 dependency

In reply to Fabrice Fontaine

Commit 56d9b887685c86fd4fbadda247cdbe733d499e81 forgot to add host gcc >= 5 dependency

Fixes:
- No autobuilder failures (yet)

---
 package/android-tools/Config.in.host | 8 ++++++++
 1 file changed, 8 insertions(+)
package/android-tools/Config.in.host +8 -0
index 433f4e384f..576e53e8b5 100644
@@ -10,12 +10,16 @@ config BR2_PACKAGE_HOST_ANDROID_TOOLS
 if BR2_PACKAGE_HOST_ANDROID_TOOLS
 
 config BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT
+	depends on BR2_HOST_GCC_AT_LEAST_5 # host-libselinux -> host-libsepol
 	bool "fastboot"
 	help
 	  This option will build and install the fastboot utility for
 	  the host, which can be used to reflash target devices
 	  implementing the fastboot protocol.
 
+comment "fastboot needs a toolchain w/ host gcc >= 5"
+	depends on !BR2_HOST_GCC_AT_LEAST_5
+
 config BR2_PACKAGE_HOST_ANDROID_TOOLS_ADB
 	bool "adb"
 	help
@@ -24,10 +28,14 @@ config BR2_PACKAGE_HOST_ANDROID_TOOLS_ADB
 	  implementing the ADB protocol.
 
 config BR2_PACKAGE_HOST_ANDROID_TOOLS_EXT4_UTILS
+	depends on BR2_HOST_GCC_AT_LEAST_5 # host-libselinux -> host-libsepol
 	bool "ext4 utils"
 	help
 	  This option will build and install the ext4 utils for the
 	  host, i.e. make_ext4fs, ext4fixup, ext2simg, img2simg,
 	  simg2img and simg2simg.
 
+comment "ext4 utils needs a toolchain w/ host gcc >= 5"
+	depends on !BR2_HOST_GCC_AT_LEAST_5
+
 endif
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH 4/4] package/android-tools: add host gcc >= 5 dependency

Fabrice, All,

On 2022-01-05 19:04 +0100, Fabrice Fontaine spake thusly:

Quoted 33 lines

Commit 56d9b887685c86fd4fbadda247cdbe733d499e81 forgot to add host gcc >= 5 dependency

Fixes:
- No autobuilder failures (yet)

---
 package/android-tools/Config.in.host | 8 ++++++++
 1 file changed, 8 insertions(+)
package/android-tools/Config.in.host +4 -0
index 433f4e384f..576e53e8b5 100644
@@ -10,12 +10,16 @@ config BR2_PACKAGE_HOST_ANDROID_TOOLS
 if BR2_PACKAGE_HOST_ANDROID_TOOLS
 
 config BR2_PACKAGE_HOST_ANDROID_TOOLS_FASTBOOT
+	depends on BR2_HOST_GCC_AT_LEAST_5 # host-libselinux -> host-libsepol
 	bool "fastboot"
 	help
 	  This option will build and install the fastboot utility for
 	  the host, which can be used to reflash target devices
 	  implementing the fastboot protocol.
 
+comment "fastboot needs a toolchain w/ host gcc >= 5"
+	depends on !BR2_HOST_GCC_AT_LEAST_5
+
 config BR2_PACKAGE_HOST_ANDROID_TOOLS_ADB
 	bool "adb"
 	help

package/android-tools/Config.in.host config BR2_PACKAGE_HOST_ANDROID_TOOLS_ADB · line 31

Quoted 4 lines
package/android-tools/Config.in.host +1 -0
@@ -24,10 +28,14 @@ config BR2_PACKAGE_HOST_ANDROID_TOOLS_ADB
 	  implementing the ADB protocol.
 
 config BR2_PACKAGE_HOST_ANDROID_TOOLS_EXT4_UTILS
+	depends on BR2_HOST_GCC_AT_LEAST_5 # host-libselinux -> host-libsepol
    $ make check-package
    package/android-tools/Config.in.host:14: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)
    package/android-tools/Config.in.host:32: attributes order: type, default, depends on, select, help (http://nightly.buildroot.org/#_config_files)   

Applied to master after fixing this, thanks.

Regards,
Yann E. MORIN.

Quoted 17 lines
package/android-tools/Config.in.host +3 -0
 	bool "ext4 utils"
 	help
 	  This option will build and install the ext4 utils for the
 	  host, i.e. make_ext4fs, ext4fixup, ext2simg, img2simg,
 	  simg2img and simg2simg.
 
+comment "ext4 utils needs a toolchain w/ host gcc >= 5"
+	depends on !BR2_HOST_GCC_AT_LEAST_5
+
 endif
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
In reply to Fabrice Fontaine

Fabrice, All,

On 2022-01-05 19:03 +0100, Fabrice Fontaine spake thusly:

Quoted 7 lines

Commit 56d9b887685c86fd4fbadda247cdbe733d499e81 forgot to add gcc >= 5 dependency

Fixes:
- No autobuilder failures (yet)

Series of 4 patches applied to master, thanks.

I'll further reply to patch 4...

Regards,
Yann E. MORIN.

Quoted 56 lines
---
 package/libsemanage/Config.in     | 6 ++++--
 package/policycoreutils/Config.in | 8 +++++---
 2 files changed, 9 insertions(+), 5 deletions(-)
package/libsemanage/Config.in +4 -2
index 3c7050ee51..5103df3f15 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBSEMANAGE
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # libselinux -> libsepol
 	select BR2_PACKAGE_AUDIT
 	select BR2_PACKAGE_LIBSELINUX
 	select BR2_PACKAGE_BZIP2
@@ -17,6 +18,7 @@ config BR2_PACKAGE_LIBSEMANAGE
 
 	  http://selinuxproject.org/page/Main_Page
 
-comment "libsemanage needs a toolchain w/ threads, dynamic library"
+comment "libsemanage needs a toolchain w/ threads, dynamic library, gcc >= 5"
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
package/policycoreutils/Config.in +5 -3
index 81900b4e41..3201c8fede 100644
@@ -1,12 +1,14 @@
-comment "policycoreutils needs a toolchain w/ threads, dynamic library"
+comment "policycoreutils needs a toolchain w/ threads, dynamic library, gcc >= 5"
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
 
 config BR2_PACKAGE_POLICYCOREUTILS
 	bool "policycoreutils"
 	depends on BR2_PACKAGE_AUDIT_ARCH_SUPPORTS # libsemanage
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libsemanage
-	depends on !BR2_STATIC_LIBS #libsemanage
+	depends on !BR2_STATIC_LIBS # libsemanage
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # libsemanage -> libselinux -> libsepol
 	select BR2_PACKAGE_LIBSEMANAGE
 	select BR2_PACKAGE_LIBCAP_NG
 	help
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot