KVM: x86/pt: Do not advertise Intel PT Event Trace capability
PATCH 1/1 KVM: x86/pt: Do not advertise Intel PT Event Trace capability
From: Like Xu <[email protected]>
The Inte PT Event Trace capability (Intel SDM Vol3, 32.2.4 Event Tracing) is a new CPU feature that "exposes details about the asynchronous events, when they are generated, and when their corresponding software event handler completes execution".
It is not possible for KVM to emulate all events including interrupts, VM exits, VM entries, INIT, SIPI events and etc. for guests and to emulate the simultaneous writing of Control Flow Events and Event Data packets generated by the KVM to the guest PT buffer.
For KVM, it is best not to advertise the Event Trace feature and just let it be a system-wide-only tracing capability.
---
Off topic, other new PT features such as "PSB and PMI Preservation Supported" and "TNT disable" are under investigation or awaiting host support to move on.
arch/x86/kvm/cpuid.c | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/kvm/cpuid.c +2 -0
@@ -901,6 +901,8 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)break ; } +/* Not advertise Event Trace capability due to endless emulation */ + entry->ebx &= ~BIT (7 );for (i =1 , max_idx = entry->eax; i <= max_idx; ++i) {if (!do_host_cpuid (array, function, i)) goto out;
Signature · 1 line
2.33.1
Paolo Bonzini
maintainerQuoted 12 lines · Like Xu
From: Like Xu <[email protected]>
The Inte PT Event Trace capability (Intel SDM Vol3, 32.2.4 Event Tracing) is a new CPU feature that "exposes details about the asynchronous events, when they are generated, and when their corresponding software event handler completes execution".
It is not possible for KVM to emulate all events including interrupts, VM exits, VM entries, INIT, SIPI events and etc. for guests and to emulate the simultaneous writing of Control Flow Events and Event Data packets generated by the KVM to the guest PT buffer.
Quoted 7 lines
For KVM, it is best not to advertise the Event Trace feature and just let it be a system-wide-only tracing capability.
Signed-off-by Like Xu <[email protected]>---
Off topic, other new PT features such as "PSB and PMI Preservation Supported" and "TNT disable" are under investigation or awaiting host support to move on.
Yeah, I think it's better to be safe and ignore _all_ unknown capabilities.
Paolo
Quoted 16 lines
arch/x86/kvm/cpuid.c | 2 ++ 1 file changed, 2 insertions(+)arch/x86/kvm/cpuid.c +2
-0@@ -901,6 +901,8 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)break ; } +/* Not advertise Event Trace capability due to endless emulation */ + entry->ebx &= ~BIT (7 );for (i =1 , max_idx = entry->eax; i <= max_idx; ++i) {if (!do_host_cpuid (array, function, i)) goto out;