Skip to contentSkip to conversation

xen, blkback: fix persistent grants negotiation

PATCH In review Maximilian Heyne 4 participants 6 messages Jan 6, 2022 – Jan 21, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen, blkback: fix persistent grants negotiation

Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device:

  $ xenstore-ls -f | grep 20674 | grep persistent
  /local/domain/0/backend/vbd/20674/768/feature-persistent = "0"
  /local/domain/0/backend/vbd/20674/51792/feature-persistent = "1"

Here disk 768 was attached during guest creation while 51792 was attached at runtime. If the guest would have advertised the persistent grant feature, there would be a xenstore entry like:

/local/domain/20674/device/vbd/51792/feature-persistent = "1"

Persistent grants are also used when the guest tries to access the disk which can be seen when enabling log stats:

  $ echo 1 > /sys/module/xen_blkback/parameters/log_stats
  $ dmesg
  xen-blkback: (20674.xvdf-0): oo   0  |  rd    0  |  wr    0  |  f    0 |  ds    0 | pg:    1/1056

The "pg: 1/1056" shows that one persistent grant is used.

Before commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") vbd->feature_gnt_persistent was set in connect_ring. After the commit it was intended to be initialized in xen_vbd_create and then set according to the guest feature availability in connect_ring. However, with a running guest, connect_ring might be called before xen_vbd_create and vbd->feature_gnt_persistent will be incorrectly initialized. xen_vbd_create will overwrite it with the value of feature_persistent regardless whether the guest actually supports persistent grants.

With this commit, vbd->feature_gnt_persistent is set only in connect_ring and this is the only use of the module parameter feature_persistent. This avoids races when the module parameter changes during the block attachment process.

Note that vbd->feature_gnt_persistent doesn't need to be initialized in xen_vbd_create. It's next use is in connect which can only be called once connect_ring has initialized the rings. xen_update_blkif_status is checking for this.

Fixes aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")
---
 drivers/block/xen-blkback/xenbus.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/block/xen-blkback/xenbus.c +3 -6
index 914587aabca0c..51b6ec0380ca4 100644
@@ -522,8 +522,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 	if (q && blk_queue_secure_erase(q))
 		vbd->discard_secure = true;
 
-	vbd->feature_gnt_persistent = feature_persistent;
-
 	pr_debug("Successful creation of handle=%04x (dom=%u)\n",
 		handle, blkif->domid);
 	return 0;
@@ -1090,10 +1088,9 @@ static int connect_ring(struct backend_info *be)
 		xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
 		return -ENOSYS;
 	}
-	if (blkif->vbd.feature_gnt_persistent)
-		blkif->vbd.feature_gnt_persistent =
-			xenbus_read_unsigned(dev->otherend,
-					"feature-persistent", 0);
+
+	blkif->vbd.feature_gnt_persistent = feature_persistent &&
+		xenbus_read_unsigned(dev->otherend, "feature-persistent", 0);
 
 	blkif->vbd.overflow_max_grants = 0;
 
Signature · 12 lines
2.32.0




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
Reviewed-by on v1 1/1
#1 lore raw

From: SeongJae Park <[email protected]>

Quoted 38 lines · On Thu, 6 Jan 2022 09:10:13 +0000 Maximilian Heyne <[email protected]> wrote:

Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device:

  $ xenstore-ls -f | grep 20674 | grep persistent
  /local/domain/0/backend/vbd/20674/768/feature-persistent = "0"
  /local/domain/0/backend/vbd/20674/51792/feature-persistent = "1"

Here disk 768 was attached during guest creation while 51792 was attached at runtime. If the guest would have advertised the persistent grant feature, there would be a xenstore entry like:

/local/domain/20674/device/vbd/51792/feature-persistent = "1"

Persistent grants are also used when the guest tries to access the disk which can be seen when enabling log stats:

  $ echo 1 > /sys/module/xen_blkback/parameters/log_stats
  $ dmesg
  xen-blkback: (20674.xvdf-0): oo   0  |  rd    0  |  wr    0  |  f    0 |  ds    0 | pg:    1/1056

The "pg: 1/1056" shows that one persistent grant is used.

Before commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") vbd->feature_gnt_persistent was set in connect_ring. After the commit it was intended to be initialized in xen_vbd_create and then set according to the guest feature availability in connect_ring. However, with a running guest, connect_ring might be called before xen_vbd_create and vbd->feature_gnt_persistent will be incorrectly initialized. xen_vbd_create will overwrite it with the value of feature_persistent regardless whether the guest actually supports persistent grants.

With this commit, vbd->feature_gnt_persistent is set only in connect_ring and this is the only use of the module parameter feature_persistent. This avoids races when the module parameter changes during the block attachment process.

Quoted 7 lines

Note that vbd->feature_gnt_persistent doesn't need to be initialized in xen_vbd_create. It's next use is in connect which can only be called once connect_ring has initialized the rings. xen_update_blkif_status is checking for this.

Fixes aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")

Thank you for this patch!

Also, I guess this tag is needed?

Cc <[email protected]> # 5.10.x

Thanks,
SJ

Quoted 45 lines
---
 drivers/block/xen-blkback/xenbus.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/block/xen-blkback/xenbus.c +3 -6
index 914587aabca0c..51b6ec0380ca4 100644
@@ -522,8 +522,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 	if (q && blk_queue_secure_erase(q))
 		vbd->discard_secure = true;
 
-	vbd->feature_gnt_persistent = feature_persistent;
-
 	pr_debug("Successful creation of handle=%04x (dom=%u)\n",
 		handle, blkif->domid);
 	return 0;
@@ -1090,10 +1088,9 @@ static int connect_ring(struct backend_info *be)
 		xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
 		return -ENOSYS;
 	}
-	if (blkif->vbd.feature_gnt_persistent)
-		blkif->vbd.feature_gnt_persistent =
-			xenbus_read_unsigned(dev->otherend,
-					"feature-persistent", 0);
+
+	blkif->vbd.feature_gnt_persistent = feature_persistent &&
+		xenbus_read_unsigned(dev->otherend, "feature-persistent", 0);
 
 	blkif->vbd.overflow_max_grants = 0;
 
Signature · 12 lines
2.32.0




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
#2 lore raw
In reply to Maximilian Heyne
Quoted 7 lines · Maximilian Heyne

Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device:

  $ xenstore-ls -f | grep 20674 | grep persistent
  /local/domain/0/backend/vbd/20674/768/feature-persistent = "0"
  /local/domain/0/backend/vbd/20674/51792/feature-persistent = "1"

The mechanism that we use to advertise persistent grants support is wrong. 'feature-persistent' should always be set if the backend supports persistent grant (like it's done for other features in xen_blkbk_probe). The usage of the feature depends on whether both parties support persistent grants, and the xenstore entry printed by blkback shouldn't reflect whether persistent grants are in use, but rather whether blkback supports the feature.

Quoted 56 lines

Here disk 768 was attached during guest creation while 51792 was attached at runtime. If the guest would have advertised the persistent grant feature, there would be a xenstore entry like:

/local/domain/20674/device/vbd/51792/feature-persistent = "1"

Persistent grants are also used when the guest tries to access the disk which can be seen when enabling log stats:

  $ echo 1 > /sys/module/xen_blkback/parameters/log_stats
  $ dmesg
  xen-blkback: (20674.xvdf-0): oo   0  |  rd    0  |  wr    0  |  f    0 |  ds    0 | pg:    1/1056

The "pg: 1/1056" shows that one persistent grant is used.

Before commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") vbd->feature_gnt_persistent was set in connect_ring. After the commit it was intended to be initialized in xen_vbd_create and then set according to the guest feature availability in connect_ring. However, with a running guest, connect_ring might be called before xen_vbd_create and vbd->feature_gnt_persistent will be incorrectly initialized. xen_vbd_create will overwrite it with the value of feature_persistent regardless whether the guest actually supports persistent grants.

With this commit, vbd->feature_gnt_persistent is set only in connect_ring and this is the only use of the module parameter feature_persistent. This avoids races when the module parameter changes during the block attachment process.

Note that vbd->feature_gnt_persistent doesn't need to be initialized in xen_vbd_create. It's next use is in connect which can only be called once connect_ring has initialized the rings. xen_update_blkif_status is checking for this.

Fixes aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")
---
 drivers/block/xen-blkback/xenbus.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/block/xen-blkback/xenbus.c +0 -2
index 914587aabca0c..51b6ec0380ca4 100644
@@ -522,8 +522,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
 	if (q && blk_queue_secure_erase(q))
 		vbd->discard_secure = true;
 
-	vbd->feature_gnt_persistent = feature_persistent;
-
 	pr_debug("Successful creation of handle=%04x (dom=%u)\n",
 		handle, blkif->domid);
 	return 0;

drivers/block/xen-blkback/xenbus.c static int connect_ring(struct backend_info *be) · line 1093

Quoted 10 lines
drivers/block/xen-blkback/xenbus.c +3 -4
@@ -1090,10 +1088,9 @@ static int connect_ring(struct backend_info *be)
 		xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
 		return -ENOSYS;
 	}
-	if (blkif->vbd.feature_gnt_persistent)
-		blkif->vbd.feature_gnt_persistent =
-			xenbus_read_unsigned(dev->otherend,
-					"feature-persistent", 0);
+
+	blkif->vbd.feature_gnt_persistent = feature_persistent &&
+		xenbus_read_unsigned(dev->otherend, "feature-persistent", 0);

I'm not sure it's correct to potentially read feature_persistent multiple times like it's done here.

A device can be disconnected and re-attached multiple times, and that implies multiple calls to connect_ring which could make the state of feature_gnt_persistent change across reconnections if the value of feature_persistent is changed. I think that would be unexpected.

There are also similar issues with xenblk_max_queues/xen_blkif_max_ring_order changing after xen_blkbk_probe has been executed. We likely need to stash all those parameters so what's on xenbus is consistent with the limits enforced in blkback.

Thanks, Roger.

#3 lore raw
Quoted 87 lines · Roger Pau Monné
Quoted 7 lines · Maximilian Heyne

Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device:

   $ xenstore-ls -f | grep 20674 | grep persistent
   /local/domain/0/backend/vbd/20674/768/feature-persistent = "0"
   /local/domain/0/backend/vbd/20674/51792/feature-persistent = "1"

The mechanism that we use to advertise persistent grants support is wrong. 'feature-persistent' should always be set if the backend supports persistent grant (like it's done for other features in xen_blkbk_probe). The usage of the feature depends on whether both parties support persistent grants, and the xenstore entry printed by blkback shouldn't reflect whether persistent grants are in use, but rather whether blkback supports the feature.

Quoted 56 lines

Here disk 768 was attached during guest creation while 51792 was attached at runtime. If the guest would have advertised the persistent grant feature, there would be a xenstore entry like:

   /local/domain/20674/device/vbd/51792/feature-persistent = "1"

Persistent grants are also used when the guest tries to access the disk which can be seen when enabling log stats:

   $ echo 1 > /sys/module/xen_blkback/parameters/log_stats
   $ dmesg
   xen-blkback: (20674.xvdf-0): oo   0  |  rd    0  |  wr    0  |  f    0 |  ds    0 | pg:    1/1056

The "pg: 1/1056" shows that one persistent grant is used.

Before commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") vbd->feature_gnt_persistent was set in connect_ring. After the commit it was intended to be initialized in xen_vbd_create and then set according to the guest feature availability in connect_ring. However, with a running guest, connect_ring might be called before xen_vbd_create and vbd->feature_gnt_persistent will be incorrectly initialized. xen_vbd_create will overwrite it with the value of feature_persistent regardless whether the guest actually supports persistent grants.

With this commit, vbd->feature_gnt_persistent is set only in connect_ring and this is the only use of the module parameter feature_persistent. This avoids races when the module parameter changes during the block attachment process.

Note that vbd->feature_gnt_persistent doesn't need to be initialized in xen_vbd_create. It's next use is in connect which can only be called once connect_ring has initialized the rings. xen_update_blkif_status is checking for this.

Fixes aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")
---
  drivers/block/xen-blkback/xenbus.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)
drivers/block/xen-blkback/xenbus.c +0 -2
index 914587aabca0c..51b6ec0380ca4 100644
@@ -522,8 +522,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
  	if (q && blk_queue_secure_erase(q))
  		vbd->discard_secure = true;
 
-	vbd->feature_gnt_persistent = feature_persistent;
-
  	pr_debug("Successful creation of handle=%04x (dom=%u)\n",
  		handle, blkif->domid);
  	return 0;

drivers/block/xen-blkback/xenbus.c static int connect_ring(struct backend_info *be) · line 1093

Quoted 10 lines
drivers/block/xen-blkback/xenbus.c +3 -4
@@ -1090,10 +1088,9 @@ static int connect_ring(struct backend_info *be)
  		xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
  		return -ENOSYS;
  	}
-	if (blkif->vbd.feature_gnt_persistent)
-		blkif->vbd.feature_gnt_persistent =
-			xenbus_read_unsigned(dev->otherend,
-					"feature-persistent", 0);
+
+	blkif->vbd.feature_gnt_persistent = feature_persistent &&
+		xenbus_read_unsigned(dev->otherend, "feature-persistent", 0);

I'm not sure it's correct to potentially read feature_persistent multiple times like it's done here.

Quoted 5 lines

A device can be disconnected and re-attached multiple times, and that implies multiple calls to connect_ring which could make the state of feature_gnt_persistent change across reconnections if the value of feature_persistent is changed. I think that would be unexpected.

Would that not be legitimate though? What happens if blkfront is upgraded (or downgraded)? Each connection should be 'groundhog day' for the backend IMO.

Paul

Quoted 8 lines

There are also similar issues with xenblk_max_queues/xen_blkif_max_ring_order changing after xen_blkbk_probe has been executed. We likely need to stash all those parameters so what's on xenbus is consistent with the limits enforced in blkback.

Thanks, Roger.

#4 lore raw
Quoted 93 lines · Paul
Quoted 86 lines · Roger Pau Monné
Quoted 7 lines · Maximilian Heyne

Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device:

   $ xenstore-ls -f | grep 20674 | grep persistent
   /local/domain/0/backend/vbd/20674/768/feature-persistent = "0"
   /local/domain/0/backend/vbd/20674/51792/feature-persistent = "1"

The mechanism that we use to advertise persistent grants support is wrong. 'feature-persistent' should always be set if the backend supports persistent grant (like it's done for other features in xen_blkbk_probe). The usage of the feature depends on whether both parties support persistent grants, and the xenstore entry printed by blkback shouldn't reflect whether persistent grants are in use, but rather whether blkback supports the feature.

Quoted 55 lines

Here disk 768 was attached during guest creation while 51792 was attached at runtime. If the guest would have advertised the persistent grant feature, there would be a xenstore entry like:

   /local/domain/20674/device/vbd/51792/feature-persistent = "1"

Persistent grants are also used when the guest tries to access the disk which can be seen when enabling log stats:

   $ echo 1 > /sys/module/xen_blkback/parameters/log_stats
   $ dmesg
   xen-blkback: (20674.xvdf-0): oo   0  |  rd    0  |  wr    0  |  f    0 |  ds    0 | pg:    1/1056

The "pg: 1/1056" shows that one persistent grant is used.

Before commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") vbd->feature_gnt_persistent was set in connect_ring. After the commit it was intended to be initialized in xen_vbd_create and then set according to the guest feature availability in connect_ring. However, with a running guest, connect_ring might be called before xen_vbd_create and vbd->feature_gnt_persistent will be incorrectly initialized. xen_vbd_create will overwrite it with the value of feature_persistent regardless whether the guest actually supports persistent grants.

With this commit, vbd->feature_gnt_persistent is set only in connect_ring and this is the only use of the module parameter feature_persistent. This avoids races when the module parameter changes during the block attachment process.

Note that vbd->feature_gnt_persistent doesn't need to be initialized in xen_vbd_create. It's next use is in connect which can only be called once connect_ring has initialized the rings. xen_update_blkif_status is checking for this.

Fixes aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")
---
  drivers/block/xen-blkback/xenbus.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)
drivers/block/xen-blkback/xenbus.c +0 -2
index 914587aabca0c..51b6ec0380ca4 100644
@@ -522,8 +522,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
  	if (q && blk_queue_secure_erase(q))
  		vbd->discard_secure = true;
-	vbd->feature_gnt_persistent = feature_persistent;
-
  	pr_debug("Successful creation of handle=%04x (dom=%u)\n",
  		handle, blkif->domid);
  	return 0;

drivers/block/xen-blkback/xenbus.c static int connect_ring(struct backend_info *be) · line 1093

Quoted 10 lines
drivers/block/xen-blkback/xenbus.c +3 -4
@@ -1090,10 +1088,9 @@ static int connect_ring(struct backend_info *be)
  		xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
  		return -ENOSYS;
  	}
-	if (blkif->vbd.feature_gnt_persistent)
-		blkif->vbd.feature_gnt_persistent =
-			xenbus_read_unsigned(dev->otherend,
-					"feature-persistent", 0);
+
+	blkif->vbd.feature_gnt_persistent = feature_persistent &&
+		xenbus_read_unsigned(dev->otherend, "feature-persistent", 0);

I'm not sure it's correct to potentially read feature_persistent multiple times like it's done here.

Quoted 5 lines

A device can be disconnected and re-attached multiple times, and that implies multiple calls to connect_ring which could make the state of feature_gnt_persistent change across reconnections if the value of feature_persistent is changed. I think that would be unexpected.

Quoted 3 lines

Would that not be legitimate though? What happens if blkfront is upgraded (or downgraded)? Each connection should be 'groundhog day' for the backend IMO.

Previous implementation cached the value of feature_persistent for the lifetime of the backend, and I assume this was the intended behavior.
Ie: so that an admin could create a set of backends with persistent grants not enabled and then switch it on afterwards and expect only newly created backends to use the new value.

If the intention is indeed to read the value of feature_persistent on each reconnection it should be noted in the commit message, as it's a behavior change.

Thanks, Roger.

#5 lore raw
Quoted 104 lines · On Tue, 11 Jan 2022 13:26:50 +0100 "Roger Pau Monné" <[email protected]>…
Quoted 93 lines · Paul
Quoted 86 lines · Roger Pau Monné
Quoted 7 lines · Maximilian Heyne

Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device:

   $ xenstore-ls -f | grep 20674 | grep persistent
   /local/domain/0/backend/vbd/20674/768/feature-persistent = "0"
   /local/domain/0/backend/vbd/20674/51792/feature-persistent = "1"

The mechanism that we use to advertise persistent grants support is wrong. 'feature-persistent' should always be set if the backend supports persistent grant (like it's done for other features in xen_blkbk_probe). The usage of the feature depends on whether both parties support persistent grants, and the xenstore entry printed by blkback shouldn't reflect whether persistent grants are in use, but rather whether blkback supports the feature.

Quoted 55 lines

Here disk 768 was attached during guest creation while 51792 was attached at runtime. If the guest would have advertised the persistent grant feature, there would be a xenstore entry like:

   /local/domain/20674/device/vbd/51792/feature-persistent = "1"

Persistent grants are also used when the guest tries to access the disk which can be seen when enabling log stats:

   $ echo 1 > /sys/module/xen_blkback/parameters/log_stats
   $ dmesg
   xen-blkback: (20674.xvdf-0): oo   0  |  rd    0  |  wr    0  |  f    0 |  ds    0 | pg:    1/1056

The "pg: 1/1056" shows that one persistent grant is used.

Before commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") vbd->feature_gnt_persistent was set in connect_ring. After the commit it was intended to be initialized in xen_vbd_create and then set according to the guest feature availability in connect_ring. However, with a running guest, connect_ring might be called before xen_vbd_create and vbd->feature_gnt_persistent will be incorrectly initialized. xen_vbd_create will overwrite it with the value of feature_persistent regardless whether the guest actually supports persistent grants.

With this commit, vbd->feature_gnt_persistent is set only in connect_ring and this is the only use of the module parameter feature_persistent. This avoids races when the module parameter changes during the block attachment process.

Note that vbd->feature_gnt_persistent doesn't need to be initialized in xen_vbd_create. It's next use is in connect which can only be called once connect_ring has initialized the rings. xen_update_blkif_status is checking for this.

Fixes aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")
---
  drivers/block/xen-blkback/xenbus.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)
drivers/block/xen-blkback/xenbus.c +0 -2
index 914587aabca0c..51b6ec0380ca4 100644
@@ -522,8 +522,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
  	if (q && blk_queue_secure_erase(q))
  		vbd->discard_secure = true;
-	vbd->feature_gnt_persistent = feature_persistent;
-
  	pr_debug("Successful creation of handle=%04x (dom=%u)\n",
  		handle, blkif->domid);
  	return 0;

drivers/block/xen-blkback/xenbus.c static int connect_ring(struct backend_info *be) · line 1093

Quoted 10 lines
drivers/block/xen-blkback/xenbus.c +3 -4
@@ -1090,10 +1088,9 @@ static int connect_ring(struct backend_info *be)
  		xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol);
  		return -ENOSYS;
  	}
-	if (blkif->vbd.feature_gnt_persistent)
-		blkif->vbd.feature_gnt_persistent =
-			xenbus_read_unsigned(dev->otherend,
-					"feature-persistent", 0);
+
+	blkif->vbd.feature_gnt_persistent = feature_persistent &&
+		xenbus_read_unsigned(dev->otherend, "feature-persistent", 0);

I'm not sure it's correct to potentially read feature_persistent multiple times like it's done here.

Quoted 5 lines

A device can be disconnected and re-attached multiple times, and that implies multiple calls to connect_ring which could make the state of feature_gnt_persistent change across reconnections if the value of feature_persistent is changed. I think that would be unexpected.

Quoted 3 lines

Would that not be legitimate though? What happens if blkfront is upgraded (or downgraded)? Each connection should be 'groundhog day' for the backend IMO.

Previous implementation cached the value of feature_persistent for the lifetime of the backend, and I assume this was the intended behavior.
Ie: so that an admin could create a set of backends with persistent grants not enabled and then switch it on afterwards and expect only newly created backends to use the new value.

Quoted 3 lines

If the intention is indeed to read the value of feature_persistent on each reconnection it should be noted in the commit message, as it's a behavior change.

Sorry for late reply. And yes, the intention of my previous implementation is as Roger explained. I guess simply moving the caching to xen_blkbk_probe() would keep the behavior and fix this issue?

I'm also ok with the new behavior. However, then we will need to clearly describe the change in the commit message and the document[1]. Because blkfront side also has same behavior[2], maybe keeping the behavior is better?

[1] Documentation/ABI/testing/sysfs-driver-xen-blkback
[2] 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent grants")

Thanks,
SJ

Quoted 2 lines

Thanks, Roger.