drm/amdkfd: use default_groups in kobj_type
Subsystems (3)
PATCH 1/1 drm/amdkfd: use default_groups in kobj_type
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the amdkfd sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field.
--- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +2 -1
@@ -462,6 +462,7 @@ static struct attribute *procfs_queue_attrs[] = { &attr_queue_gpuid,NULL }; +ATTRIBUTE_GROUPS (procfs_queue);static const struct sysfs_ops procfs_queue_ops = { .show = kfd_procfs_queue_show,
@@ -469,7 +470,7 @@ static const struct sysfs_ops procfs_queue_ops = {static struct kobj_type procfs_queue_type = { .sysfs_ops = &procfs_queue_ops, - .default_attrs = procfs_queue_attrs, + .default_groups = procfs_queue_groups, };static const struct sysfs_ops procfs_stats_ops = {
Signature · 1 line
2.34.1
Alex Deucher
AppliedQuoted 8 lines · Greg Kroah-Hartman
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through thedefault_attrsfield, and thedefault_groupsfield. Move the amdkfd sysfs code to usedefault_groupsfield which has been the preferred way sinceaa30f47cf666("kobject: Add support for default attribute groups tokobj_type") so that we can soon get rid of the obsoletedefault_attrsfield.
Quoted 9 lines
Cc Felix Kuehling <[email protected]>Cc Alex Deucher <[email protected]>Cc "Christian König" <[email protected]>Cc "Pan, Xinhui" <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Applied. Thanks!
Alex
Quoted 28 lines
--- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdkfd/kfd_process.c +2
-2@@ -462,6 +462,7 @@ static struct attribute *procfs_queue_attrs[] = { &attr_queue_gpuid,NULL }; +ATTRIBUTE_GROUPS (procfs_queue);static const struct sysfs_ops procfs_queue_ops = { .show = kfd_procfs_queue_show,@@ -469,7 +470,7 @@ static const struct sysfs_ops procfs_queue_ops = {static struct kobj_type procfs_queue_type = { .sysfs_ops = &procfs_queue_ops, - .default_attrs = procfs_queue_attrs, + .default_groups = procfs_queue_groups, };static const struct sysfs_ops procfs_stats_ops = { --2.34.1