Skip to contentSkip to conversation

dt-bindings: mmc: arm,pl18x: Make each example a separate entry

PATCH Applied Rob Herring 2 participants 3 messages Jan 6, 2022 – Jan 19, 2022

Subsystems (2)
Device tree bindings MMC, SD and SDIO
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mmc: arm,pl18x: Make each example a separate entry

Each independent example should be a separate entry. This and dropping 'interrupt-parent' allows for 'interrupts' to have different cell sizes.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mmc/arm,pl18x.yaml +5 -1
index 47595cb483be..2a64cffbe6ad 100644
@@ -167,6 +167,9 @@ examples:
       clock-names = "mclk", "apb_pclk";
     };
 
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
     mmc@80126000 {
       compatible = "arm,pl18x", "arm,primecell";
       reg = <0x80126000 0x1000>;

@@ -188,12 +191,12 @@ examples:
       vqmmc-supply = <&vmmci>;
     };
 
+  - |
     mmc@101f6000 {
       compatible = "arm,pl18x", "arm,primecell";
       reg = <0x101f6000 0x1000>;
       clocks = <&sdiclk>, <&pclksdi>;
       clock-names = "mclk", "apb_pclk";
-      interrupt-parent = <&vica>;
       interrupts = <22>;
       max-frequency = <400000>;
       bus-width = <4>;

@@ -208,6 +211,7 @@ examples:
       vmmc-supply = <&vmmc_regulator>;
     };
 
+  - |
     mmc@52007000 {
       compatible = "arm,pl18x", "arm,primecell";
       arm,primecell-periphid = <0x10153180>;
Signature · 1 line
2.32.0
author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

Each independent example should be a separate entry. This and dropping 'interrupt-parent' allows for 'interrupts' to have different cell sizes.

Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Applied, thanks!