bpf/selftests: Test bpf_d_path on rdonly_mem.
Subsystems (3)
PATCH v2 1/1 bpf/selftests: Test bpf_d_path on rdonly_mem.
The second parameter of bpf_d_path() can only accept writable memories. Rdonly_mem obtained from bpf_per_cpu_ptr() can not be passed into bpf_d_path for modification. This patch adds a selftest to verify this behavior.
---
Changelog since v1:
- remove duplicated vmlinux.h (Yonghong)
- use 'void *' as type of 'active' (Andrii)
- use codename instead of descriptive sentense in ASSERT_ERR_PTR's error message. (Andrii)
.../testing/selftests/bpf/prog_tests/d_path.c | 22 ++++++++++++++- .../bpf/progs/test_d_path_check_rdonly_mem.c | 28 +++++++++++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/bpf/progs/test_d_path_check_rdonly_mem.c
tools/testing/selftests/bpf/prog_tests/d_path.c +21 -1
@@ -9,6 +9,7 @@#define MAX_FILES 7#include "test_d_path.skel.h" +#include "test_d_path_check_rdonly_mem.skel.h" static int duration;
@@ -99,7 +100,7 @@ static int trigger_fstat_events(pid_t pid)return ret; } -void test_d_path (void ) +static void test_d_path_basic (void ) {struct test_d_path__bss *bss;struct test_d_path *skel;
@@ -155,3 +156,22 @@ void test_d_path(void) cleanup:test_d_path__destroy (skel); } + +static void test_d_path_check_rdonly_mem (void ) +{ +struct test_d_path_check_rdonly_mem *skel; + + skel =test_d_path_check_rdonly_mem__open_and_load (); +ASSERT_ERR_PTR (skel,"unexpected_load_overwriting_rdonly_mem\n" ); + +test_d_path_check_rdonly_mem__destroy (skel); +} + +void test_d_path (void ) +{ +if (test__start_subtest ("basic" )) +test_d_path_basic (); + +if (test__start_subtest ("check_rdonly_mem" )) +test_d_path_check_rdonly_mem (); +}
tools/testing/selftests/bpf/progs/test_d_path_check_rdonly_mem.c new file +28 -0
@@ -0,0 +1,28 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2022 Google */ + +#include "vmlinux.h" +#include <bpf/bpf_helpers.h> +#include <bpf/bpf_tracing.h> + +extern const int bpf_prog_active __ksym; + +SEC("fentry/security_inode_getattr") +int BPF_PROG (d_path_check_rdonly_mem ,struct path *path,struct kstat *stat, +__u32 request_mask,unsigned int query_flags) +{ +void *active; +__u32 cpu; + + cpu =bpf_get_smp_processor_id (); + active = (void *)bpf_per_cpu_ptr (&bpf_prog_active, cpu); +if (active) { +/* FAIL here! 'active' points to readonly memory. bpf helpers +* that update its arguments can not write into it. +*/ +bpf_d_path (path, active,sizeof (int )); + } +return 0 ; +} + +char _license[] SEC("license") = "GPL";
Signature · 1 line
2.34.1.448.ga2b2bfdf31-goog
Quoted 6 lines · Hao Luo
The second parameter of
bpf_d_path()can only accept writable memories.Rdonly_memobtained frombpf_per_cpu_ptr()can not be passed intobpf_d_pathfor modification. This patch adds a selftest to verify this behavior.Signed-off-by Hao Luo <[email protected]>
Andrii Nakryiko
AppliedQuoted 4 lines · Yonghong Song
On 1/6/22 12:55 PM, Hao Luo wrote:
Quoted 8 lines
Quoted 6 lines
The second parameter of
bpf_d_path()can only accept writable memories.Rdonly_memobtained frombpf_per_cpu_ptr()can not be passed intobpf_d_pathfor modification. This patch adds a selftest to verify this behavior.Signed-off-by Hao Luo <[email protected]>Acked-by Yonghong Song <[email protected]>
Applied to bpf-next, thanks.