Skip to contentSkip to conversation

usb: gadget: tegra-xudc: Do not program SPARAM

PATCH In review Wayne Chang 2 participants 2 messages Jan 7, 2022 – Feb 25, 2022

Subsystems (2)
USB Tegra architecture support
lore
Share & tools
lore

Wayne Chang

author
#0 lore raw

PATCH 1/1 usb: gadget: tegra-xudc: Do not program SPARAM

According to the Tegra Technical Reference Manual, SPARAM is a read-only register and should not be programmed in the driver.

The change removes the wrong SPARAM usage.

Signed-off-by Wayne Chang <[email protected]>
---
 drivers/usb/gadget/udc/tegra-xudc.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/usb/gadget/udc/tegra-xudc.c +0 -8
index 43f1b0d461c1..716d9ab2d2ff 100644
@@ -32,9 +32,6 @@
 #include <linux/workqueue.h>
 
 /* XUSB_DEV registers */
-#define SPARAM 0x000
-#define  SPARAM_ERSTMAX_MASK GENMASK(20, 16)
-#define  SPARAM_ERSTMAX(x) (((x) << 16) & SPARAM_ERSTMAX_MASK)
 #define DB 0x004
 #define  DB_TARGET_MASK GENMASK(15, 8)
 #define  DB_TARGET(x) (((x) << 8) & DB_TARGET_MASK)

@@ -3295,11 +3292,6 @@ static void tegra_xudc_init_event_ring(struct tegra_xudc *xudc)
 	unsigned int i;
 	u32 val;
 
-	val = xudc_readl(xudc, SPARAM);
-	val &= ~(SPARAM_ERSTMAX_MASK);
-	val |= SPARAM_ERSTMAX(XUDC_NR_EVENT_RINGS);
-	xudc_writel(xudc, val, SPARAM);
-
 	for (i = 0; i < ARRAY_SIZE(xudc->event_ring); i++) {
 		memset(xudc->event_ring[i], 0, XUDC_EVENT_RING_SIZE *
 		       sizeof(*xudc->event_ring[i]));
Signature · 1 line
2.25.1
#1 lore raw
Quoted 10 lines · Wayne Chang

According to the Tegra Technical Reference Manual, SPARAM is a read-only register and should not be programmed in the driver.

The change removes the wrong SPARAM usage.

Signed-off-by Wayne Chang <[email protected]>
---
 drivers/usb/gadget/udc/tegra-xudc.c | 8 --------
 1 file changed, 8 deletions(-)

What's the impact on this? Does it fix a bug? Or is it more of a cosmetic change?

Thierry