Fix undefined behavior, acessing dead object
cover Fix undefined behavior, acessing dead object
This series fixes undefined behavior caused by accessing local variables that have been out of their scope.
FWIW, compile the following code with gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0:
```
#include <stdio.h>
int main(void)
{
int *pa, *pb;
{
int a;
pa = &a;
}
{
int b;
pb = &b;
}
*pa = 100;
*pb = 200;
printf("(pa == pb) = %d\n", pa == pb);
printf("*pa == %d; *pb == %d\n", *pa, *pb);
return 0;
}
```produces the following output:
``` ammarfaizi2@integral2:/tmp$ gcc q.c -o q ammarfaizi2@integral2:/tmp$ ./q (pa == pb) = 1 *pa == 200; *pb == 200 ammarfaizi2@integral2:/tmp$ ammarfaizi2@integral2:/tmp$ gcc -O3 q.c -o q ammarfaizi2@integral2:/tmp$ ./q (pa == pb) = 0 *pa == 100; *pb == 200 ammarfaizi2@integral2:/tmp$ ```
Note that the int a and int b lifetime have ended, but we still hold the references to them dereference them.
Also the result differs for the different optimization levels. That's to say, there is no guarantee due to UB. Compiler is free to reuse "out of scope variable"'s storage.
The same happens with test/socket-rw{,-eagain,-offset}.c.
---
Ammar Faizi (3):
test/socket-rw-eagain: Fix UB, accessing dead object test/socket-rw: Fix UB, accessing dead object test/socket-rw-offset: Fix UB, accessing dead object
test/socket-rw-eagain.c | 17 +++++++---------- test/socket-rw-offset.c | 17 +++++++---------- test/socket-rw.c | 17 +++++++---------- 3 files changed, 21 insertions(+), 30 deletions(-)
base-commit: 918d8061ffdfdf253806a1e8e141c71644e678bd
Signature · 1 line
2.32.0
PATCH 1/3 test/socket-rw-eagain: Fix UB, accessing dead object
Dereference to a local variable that has been out of its scope is undefined behavior, it may contain garbage or the compiler may reuse it for other local variables.
Fix this by moving the struct iov variable declarations so their lifetime is extended.
--- test/socket-rw-eagain.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)
test/socket-rw-eagain.c +7 -10
@@ -25,6 +25,7 @@ int main(int argc, char *argv[])int32_t recv_s0;int32_t val =1 ;struct sockaddr_in addr; +struct iovec iov_r[1 ], iov_w[1 ];if (argc >1 )return 0 ;
@@ -105,28 +106,24 @@ int main(int argc, char *argv[])char send_buff[128 ]; { -struct iovec iov[1 ]; - - iov[0 ].iov_base = recv_buff; - iov[0 ].iov_len =sizeof (recv_buff); + iov_r[0 ].iov_base = recv_buff; + iov_r[0 ].iov_len =sizeof (recv_buff);struct io_uring_sqe * sqe =io_uring_get_sqe (&m_io_uring);assert (sqe !=NULL ); -io_uring_prep_readv (sqe, p_fd[0 ], iov,1 ,0 ); +io_uring_prep_readv (sqe, p_fd[0 ], iov_r,1 ,0 ); sqe->user_data =1 ; } { -struct iovec iov[1 ]; - - iov[0 ].iov_base = send_buff; - iov[0 ].iov_len =sizeof (send_buff); + iov_w[0 ].iov_base = send_buff; + iov_w[0 ].iov_len =sizeof (send_buff);struct io_uring_sqe * sqe =io_uring_get_sqe (&m_io_uring);assert (sqe !=NULL ); -io_uring_prep_writev (sqe, p_fd[1 ], iov,1 ,0 ); +io_uring_prep_writev (sqe, p_fd[1 ], iov_w,1 ,0 ); sqe->user_data =2 ; }
Signature · 1 line
2.32.0
PATCH 2/3 test/socket-rw: Fix UB, accessing dead object
In reply to Ammar FaiziDereference to a local variable that has been out of its scope is undefined behavior, it may contain garbage or the compiler may reuse it for other local variables.
Fix this by moving the struct iov variable declarations so their lifetime is extended.
--- test/socket-rw.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)
test/socket-rw.c +7 -10
@@ -27,6 +27,7 @@ int main(int argc, char *argv[])int32_t recv_s0;int32_t val =1 ;struct sockaddr_in addr; +struct iovec iov_r[1 ], iov_w[1 ];if (argc >1 )return 0 ;
@@ -103,27 +104,23 @@ int main(int argc, char *argv[])char send_buff[128 ]; { -struct iovec iov[1 ]; - - iov[0 ].iov_base = recv_buff; - iov[0 ].iov_len =sizeof (recv_buff); + iov_r[0 ].iov_base = recv_buff; + iov_r[0 ].iov_len =sizeof (recv_buff);struct io_uring_sqe * sqe =io_uring_get_sqe (&m_io_uring);assert (sqe !=NULL ); -io_uring_prep_readv (sqe, p_fd[0 ], iov,1 ,0 ); +io_uring_prep_readv (sqe, p_fd[0 ], iov_r,1 ,0 ); } { -struct iovec iov[1 ]; - - iov[0 ].iov_base = send_buff; - iov[0 ].iov_len =sizeof (send_buff); + iov_w[0 ].iov_base = send_buff; + iov_w[0 ].iov_len =sizeof (send_buff);struct io_uring_sqe * sqe =io_uring_get_sqe (&m_io_uring);assert (sqe !=NULL ); -io_uring_prep_writev (sqe, p_fd[1 ], iov,1 ,0 ); +io_uring_prep_writev (sqe, p_fd[1 ], iov_w,1 ,0 ); } ret =io_uring_submit_and_wait (&m_io_uring,2 );
Signature · 1 line
2.32.0
PATCH 3/3 test/socket-rw-offset: Fix UB, accessing dead object
In reply to Ammar FaiziDereference to a local variable that has been out of its scope is undefined behavior, it may contain garbage or the compiler may reuse it for other local variables.
Fix this by moving the struct iov variable declarations so their lifetime is extended.
--- test/socket-rw-offset.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)
test/socket-rw-offset.c +7 -10
@@ -27,6 +27,7 @@ int main(int argc, char *argv[])int32_t recv_s0;int32_t val =1 ;struct sockaddr_in addr; +struct iovec iov_r[1 ], iov_w[1 ];if (argc >1 )return 0 ;
@@ -108,27 +109,23 @@ int main(int argc, char *argv[])char send_buff[128 ]; { -struct iovec iov[1 ]; - - iov[0 ].iov_base = recv_buff; - iov[0 ].iov_len =sizeof (recv_buff); + iov_r[0 ].iov_base = recv_buff; + iov_r[0 ].iov_len =sizeof (recv_buff);struct io_uring_sqe * sqe =io_uring_get_sqe (&m_io_uring);assert (sqe !=NULL ); -io_uring_prep_readv (sqe, p_fd[0 ], iov,1 ,-1 ); +io_uring_prep_readv (sqe, p_fd[0 ], iov_r,1 ,-1 ); } { -struct iovec iov[1 ]; - - iov[0 ].iov_base = send_buff; - iov[0 ].iov_len =sizeof (send_buff); + iov_w[0 ].iov_base = send_buff; + iov_w[0 ].iov_len =sizeof (send_buff);struct io_uring_sqe * sqe =io_uring_get_sqe (&m_io_uring);assert (sqe !=NULL ); -io_uring_prep_writev (sqe, p_fd[1 ], iov,1 ,0 ); +io_uring_prep_writev (sqe, p_fd[1 ], iov_w,1 ,0 ); } ret =io_uring_submit_and_wait (&m_io_uring,2 );
Signature · 1 line
2.32.0
Quoted 8 lines · Ammar Faizi
This series fixes undefined behavior caused by accessing local variables that have been out of their scope.
FWIW, compile the following code with gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0:
```
#include <stdio.h>[...]
Applied, thanks!
[1/3] test/socket-rw-eagain: Fix UB, accessing dead object
commit: 5ee4feeac88d42c8c4cadee1f242279ff5fc0277
[2/3] test/socket-rw: Fix UB, accessing dead object
commit: e5bb9f3e65f0e18132b27ba0322e2419d87f4f92
[3/3] test/socket-rw-offset: Fix UB, accessing dead object
commit: 3f10277e6412d56cb52424d07f685128112498faBest regards,
Signature · 1 line
Jens Axboe