x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
PATCH v3 1/3 x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk ass applied by itself.
So replace the uses of QFLAG_APPLY_ONCE with static local variables in the few quirks that use this logic and remove all the flags logic.
---
v3: Keep in this patch only the mechanical change to move from QFLAG_APPLY_ONCE to static locals. Differently than v2, we don't try to set quirk_applied in nvidia_bugs() and via_bugs() only when the global resource is set - this patch is a mechanical move only and shouldn't change any behavior. For intel_graphics_quirks(), we will move it to the right place in a subsequent patch.
arch/x86/kernel/early-quirks.c | 55 +++++++++++++++++++++------------- 1 file changed, 34 insertions(+), 21 deletions(-)
arch/x86/kernel/early-quirks.c +34 -21
@@ -57,6 +57,13 @@ static void __init fix_hypertransport_config(int num, int slot, int func)static void __init via_bugs (int num,int slot,int func) {#ifdef CONFIG_GART_IOMMU +static bool quirk_applied__initdata ; + +if (quirk_applied) +return ; + + quirk_applied = true; +if ((max_pfn >MAX_DMA32_PFN || force_iommu) && !gart_iommu_aperture_allowed) { printk(KERN_INFO
@@ -81,6 +88,13 @@ static void __init nvidia_bugs(int num, int slot, int func) {#ifdef CONFIG_ACPI #ifdef CONFIG_X86_IO_APIC +static bool quirk_applied__initdata ; + +if (quirk_applied) +return ; + + quirk_applied = true; +/* * Only applies to Nvidia root ports (bus 0) and not to * Nvidia graphics cards with PCI ports on secondary buses.
@@ -587,10 +601,16 @@ intel_graphics_stolen(int num, int slot, int func,static void __init intel_graphics_quirks (int num,int slot,int func) { +static bool quirk_applied__initdata ;const struct intel_early_ops *early_ops;u16 device;int i; +if (quirk_applied) +return ; + + quirk_applied = true; + device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {
@@ -673,37 +693,33 @@ static void __init apple_airport_reset(int bus, int slot, int func)early_iounmap (mmio,BCM4331_MMIO_SIZE ); } -#define QFLAG_APPLY_ONCE 0x1 -#define QFLAG_APPLIED 0x2 -#define QFLAG_DONE (QFLAG_APPLY_ONCE|QFLAG_APPLIED)struct chipset {u32 vendor;u32 device;u32 class;u32 class_mask; -u32 flags;void (*f)(int num,int slot,int func); };static struct chipset early_qrk[]__initdata = { {PCI_VENDOR_ID_NVIDIA ,PCI_ANY_ID , -PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID ,QFLAG_APPLY_ONCE , nvidia_bugs }, +PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID , nvidia_bugs }, {PCI_VENDOR_ID_VIA ,PCI_ANY_ID , -PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID ,QFLAG_APPLY_ONCE , via_bugs }, +PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID , via_bugs }, {PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_K8_NB , -PCI_CLASS_BRIDGE_HOST ,PCI_ANY_ID ,0 , fix_hypertransport_config }, +PCI_CLASS_BRIDGE_HOST ,PCI_ANY_ID , fix_hypertransport_config }, {PCI_VENDOR_ID_ATI ,PCI_DEVICE_ID_ATI_IXP400_SMBUS , -PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID ,0 , ati_bugs }, +PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID , ati_bugs }, {PCI_VENDOR_ID_ATI ,PCI_DEVICE_ID_ATI_SBX00_SMBUS , -PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID ,0 , ati_bugs_contd }, +PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID , ati_bugs_contd }, {PCI_VENDOR_ID_INTEL ,0x3403 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,0x3405 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,0x3406 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,PCI_ANY_ID ,PCI_CLASS_DISPLAY_VGA ,PCI_ANY_ID , -QFLAG_APPLY_ONCE , intel_graphics_quirks }, + intel_graphics_quirks },/* * HPET on the current version of the Baytrail platform has accuracy * problems: it will halt in deep idle state - so we disable it.
@@ -713,9 +729,9 @@ static struct chipset early_qrk[] __initdata = {* http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/atom-z8000-datasheet-vol-1.pdf */ {PCI_VENDOR_ID_INTEL ,0x0f00 , - PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet}, + PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, force_disable_hpet}, { PCI_VENDOR_ID_BROADCOM, 0x4331, - PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, 0, apple_airport_reset}, + PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, apple_airport_reset}, {} };
@@ -756,12 +772,9 @@ static int __init check_dev_quirk(int num, int slot, int func) ((early_qrk[i].device ==PCI_ANY_ID ) || (early_qrk[i].device == device)) && (!((early_qrk[i].class ^ class) & - early_qrk[i].class_mask))) { - if ((early_qrk[i].flags & -QFLAG_DONE ) !=QFLAG_DONE ) - early_qrk[i].f(num, slot, func); - early_qrk[i].flags |=QFLAG_APPLIED ; - } + early_qrk[i].class_mask))) + early_qrk[i].f(num, slot, func); + } type = read_pci_config_byte(num, slot, func,
Signature · 1 line
2.34.1
PATCH v3 2/3 x86/quirks: Improve line wrap on quirk conditions
Remove extra parenthesis and wrap lines so it's easier to read what are the conditions being checked. The call to the hook also had an extra
indentation: remove here to conform to coding style.
--- arch/x86/kernel/early-quirks.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
arch/x86/kernel/early-quirks.c +6 -8
@@ -767,14 +767,12 @@ static int __init check_dev_quirk(int num, int slot, int func) device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; early_qrk[i].f !=NULL ; i++) { -if (((early_qrk[i].vendor ==PCI_ANY_ID ) || - (early_qrk[i].vendor == vendor)) && - ((early_qrk[i].device ==PCI_ANY_ID ) || - (early_qrk[i].device == device)) && - (!((early_qrk[i].class ^ class) & - early_qrk[i].class_mask))) - early_qrk[i].f (num, slot, func); - +if ((early_qrk[i].vendor ==PCI_ANY_ID || + early_qrk[i].vendor == vendor) && + (early_qrk[i].device ==PCI_ANY_ID || + early_qrk[i].device == device) && + !((early_qrk[i].class ^ class) & early_qrk[i].class_mask)) + early_qrk[i].f (num, slot, func); } type = read_pci_config_byte(num, slot, func,
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v3 2/3] x86/quirks: Improve line wrap on quirk conditions
Quoted 5 lines · Lucas De Marchi
Remove extra parenthesis and wrap lines so it's easier to read what are the conditions being checked. The call to the hook also had an extra
indentation: remove here to conform to coding style.Signed-off-by Lucas De Marchi <[email protected]>
Quoted 32 lines
--- arch/x86/kernel/early-quirks.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)arch/x86/kernel/early-quirks.c +6
-8@@ -767,14 +767,12 @@ static int __init check_dev_quirk(int num, int slot, int func) device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; early_qrk[i].f !=NULL ; i++) { -if (((early_qrk[i].vendor ==PCI_ANY_ID ) || - (early_qrk[i].vendor == vendor)) && - ((early_qrk[i].device ==PCI_ANY_ID ) || - (early_qrk[i].device == device)) && - (!((early_qrk[i].class ^ class) & - early_qrk[i].class_mask))) - early_qrk[i].f (num, slot, func); - +if ((early_qrk[i].vendor ==PCI_ANY_ID || + early_qrk[i].vendor == vendor) && + (early_qrk[i].device ==PCI_ANY_ID || + early_qrk[i].device == device) && + !((early_qrk[i].class ^ class) & early_qrk[i].class_mask)) + early_qrk[i].f (num, slot, func); } type = read_pci_config_byte(num, slot, func,Signature · 1 line
2.34.1
PATCH v3 3/3 x86/quirks: Fix stolen detection with integrated + discrete GPU
In reply to Lucas De Marchiearly_pci_scan_bus() does a depth-first traversal, possibly calling the quirk functions for each device based on vendor, device and class from early_qrk table. intel_graphics_quirks() however uses PCI_ANY_ID and does additional filtering in the quirk.
If there is an Intel integrated + discrete GPU the quirk may be called first for the discrete GPU based on the PCI topology. Then we will fail to reserve the system stolen memory for the integrated GPU, because we will already have marked the quirk as "applied".
This was reproduced in a setup with Alderlake-P (integrated) + DG2 (discrete), with the following PCI topology:
- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Integrated GPU
Move the setting of quirk_applied in intel_graphics_quirks() so it's mark as applied only when we find the integrated GPU based on the intel_early_ids table.
---
v3: now that we do the refactor before the fix, we can do a single line change to fix intel_graphics_quirks(). Also, we don't change intel_graphics_stolen() anymore as we did in v2: we don't have to check other devices anymore if there was a previous match causing intel_graphics_stolen() to be called (there can only be one integrated GPU reserving the stolen memory).
arch/x86/kernel/early-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/early-quirks.c +2 -2
@@ -609,8 +609,6 @@ static void __init intel_graphics_quirks(int num, int slot, int func)if (quirk_applied)return ; - quirk_applied = true; - device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {
@@ -623,6 +621,8 @@ static void __init intel_graphics_quirks(int num, int slot, int func)intel_graphics_stolen (num, slot, func, early_ops); + quirk_applied = true; +return ; } }
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU
Quoted 17 lines · Lucas De Marchi
early_pci_scan_bus()does a depth-first traversal, possibly calling the quirk functions for each device based on vendor, device and class fromearly_qrktable.intel_graphics_quirks()however usesPCI_ANY_IDand does additional filtering in the quirk.If there is an Intel integrated + discrete GPU the quirk may be called first for the discrete GPU based on the PCI topology. Then we will fail to reserve the system stolen memory for the integrated GPU, because we will already have marked the quirk as "applied".
This was reproduced in a setup with Alderlake-P (integrated) + DG2 (discrete), with the following PCI topology:
- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Integrated GPU
Quoted 5 lines
Move the setting of
quirk_appliedinintel_graphics_quirks()so it's mark as applied only when we find the integrated GPU based on theintel_early_idstable.Signed-off-by Lucas De Marchi <[email protected]>
I don't know the details of stolen memory, but the implementation of this quirk looks good to me. Very nice that it's now very clear exactly what the change is.
Quoted 37 lines
---
v3: now that we do the refactor before the fix, we can do a single line change to fix
intel_graphics_quirks(). Also, we don't changeintel_graphics_stolen()anymore as we did in v2: we don't have to check other devices anymore if there was a previous match causingintel_graphics_stolen()to be called (there can only be one integrated GPU reserving the stolen memory).arch/x86/kernel/early-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/x86/kernel/early-quirks.c +2
-2@@ -609,8 +609,6 @@ static void __init intel_graphics_quirks(int num, int slot, int func)if (quirk_applied)return ; - quirk_applied = true; - device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {@@ -623,6 +621,8 @@ static void __init intel_graphics_quirks(int num, int slot, int func)intel_graphics_stolen (num, slot, func, early_ops); + quirk_applied = true; +return ; } }Signature · 1 line
2.34.1
Rodrigo Vivi
Reviewed-byRe: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU
Quoted 22 lines · Bjorn Helgaas
Quoted 21 lines · Lucas De Marchi
early_pci_scan_bus()does a depth-first traversal, possibly calling the quirk functions for each device based on vendor, device and class fromearly_qrktable.intel_graphics_quirks()however usesPCI_ANY_IDand does additional filtering in the quirk.If there is an Intel integrated + discrete GPU the quirk may be called first for the discrete GPU based on the PCI topology. Then we will fail to reserve the system stolen memory for the integrated GPU, because we will already have marked the quirk as "applied".
This was reproduced in a setup with Alderlake-P (integrated) + DG2 (discrete), with the following PCI topology:
- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Integrated GPUMove the setting of
quirk_appliedinintel_graphics_quirks()so it's mark as applied only when we find the integrated GPU based on theintel_early_idstable.
Quoted 5 lines
Quoted 1 line
Signed-off-by Lucas De Marchi <[email protected]>I don't know the details of stolen memory, but the implementation of this quirk looks good to me. Very nice that it's now very clear exactly what the change is.
Bjorn, ack to merge through drm-intel?
Quoted 38 lines
Quoted 38 lines
---
v3: now that we do the refactor before the fix, we can do a single line change to fix
intel_graphics_quirks(). Also, we don't changeintel_graphics_stolen()anymore as we did in v2: we don't have to check other devices anymore if there was a previous match causingintel_graphics_stolen()to be called (there can only be one integrated GPU reserving the stolen memory).arch/x86/kernel/early-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/x86/kernel/early-quirks.c +2
-2@@ -609,8 +609,6 @@ static void __init intel_graphics_quirks(int num, int slot, int func)if (quirk_applied)return ; - quirk_applied = true; - device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {@@ -623,6 +621,8 @@ static void __init intel_graphics_quirks(int num, int slot, int func)intel_graphics_stolen (num, slot, func, early_ops); + quirk_applied = true; +return ; } }Signature · 1 line
2.34.1
Bjorn Helgaas
Acked-byRe: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU
Quoted 25 lines · Rodrigo Vivi
Quoted 24 lines · Bjorn Helgaas
Quoted 22 lines · Lucas De Marchi
early_pci_scan_bus()does a depth-first traversal, possibly calling the quirk functions for each device based on vendor, device and class fromearly_qrktable.intel_graphics_quirks()however usesPCI_ANY_IDand does additional filtering in the quirk.If there is an Intel integrated + discrete GPU the quirk may be called first for the discrete GPU based on the PCI topology. Then we will fail to reserve the system stolen memory for the integrated GPU, because we will already have marked the quirk as "applied".
This was reproduced in a setup with Alderlake-P (integrated) + DG2 (discrete), with the following PCI topology:
- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Integrated GPUMove the setting of
quirk_appliedinintel_graphics_quirks()so it's mark as applied only when we find the integrated GPU based on theintel_early_idstable.Signed-off-by Lucas De Marchi <[email protected]>
Quoted 8 lines
Quoted 3 lines
I don't know the details of stolen memory, but the implementation of this quirk looks good to me. Very nice that it's now very clear exactly what the change is.
Reviewed-by Rodrigo Vivi <[email protected]>Bjorn, ack to merge through drm-intel?
This is a bit of a shared area between the x86 folks and me, but certainly no objection from me.
Quoted 37 lines
Quoted 37 lines
Quoted 37 lines
---
v3: now that we do the refactor before the fix, we can do a single line change to fix
intel_graphics_quirks(). Also, we don't changeintel_graphics_stolen()anymore as we did in v2: we don't have to check other devices anymore if there was a previous match causingintel_graphics_stolen()to be called (there can only be one integrated GPU reserving the stolen memory).arch/x86/kernel/early-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/x86/kernel/early-quirks.c +2
-2@@ -609,8 +609,6 @@ static void __init intel_graphics_quirks(int num, int slot, int func)if (quirk_applied)return ; - quirk_applied = true; - device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {@@ -623,6 +621,8 @@ static void __init intel_graphics_quirks(int num, int slot, int func)intel_graphics_stolen (num, slot, func, early_ops); + quirk_applied = true; +return ; } }Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU
Quoted 31 lines · Bjorn Helgaas
Quoted 30 lines · Rodrigo Vivi
Quoted 27 lines · Bjorn Helgaas
Quoted 17 lines · Lucas De Marchi
early_pci_scan_bus()does a depth-first traversal, possibly calling the quirk functions for each device based on vendor, device and class fromearly_qrktable.intel_graphics_quirks()however usesPCI_ANY_IDand does additional filtering in the quirk.If there is an Intel integrated + discrete GPU the quirk may be called first for the discrete GPU based on the PCI topology. Then we will fail to reserve the system stolen memory for the integrated GPU, because we will already have marked the quirk as "applied".
This was reproduced in a setup with Alderlake-P (integrated) + DG2 (discrete), with the following PCI topology:
- 00:01.0 Bridge
`- 03:00.0 DG2
- 00:02.0 Integrated GPUQuoted 5 lines
Move the setting of
quirk_appliedinintel_graphics_quirks()so it's mark as applied only when we find the integrated GPU based on theintel_early_idstable.Signed-off-by Lucas De Marchi <[email protected]>I don't know the details of stolen memory, but the implementation of this quirk looks good to me. Very nice that it's now very clear exactly what the change is.
Quoted 6 lines
Quoted 3 lines
Reviewed-by Rodrigo Vivi <[email protected]>Bjorn, ack to merge through drm-intel?
This is a bit of a shared area between the x86 folks and me, but certainly no objection from me.
Lucas brought a good point about patch 1 touching more stuff than i915 one, so to minimize conflicts maybe the x86 tree would be better... also works for us if you prefer.
Quoted 40 lines
Acked-by Bjorn Helgaas <[email protected]>Quoted 37 lines
Quoted 37 lines
Quoted 37 lines
---
v3: now that we do the refactor before the fix, we can do a single line change to fix
intel_graphics_quirks(). Also, we don't changeintel_graphics_stolen()anymore as we did in v2: we don't have to check other devices anymore if there was a previous match causingintel_graphics_stolen()to be called (there can only be one integrated GPU reserving the stolen memory).arch/x86/kernel/early-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/x86/kernel/early-quirks.c +2
-2@@ -609,8 +609,6 @@ static void __init intel_graphics_quirks(int num, int slot, int func)if (quirk_applied)return ; - quirk_applied = true; - device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {@@ -623,6 +621,8 @@ static void __init intel_graphics_quirks(int num, int slot, int func)intel_graphics_stolen (num, slot, func, early_ops); + quirk_applied = true; +return ; } }Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
In reply to Lucas De Marchi== Series Details ==
== Series Details ==
Series: series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
URL : https://patchwork.freedesktop.org/series/98622/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11054 -> Patchwork_21943
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/index.html
Participating hosts (45 -> 37)
------------------------------
Additional (1): fi-kbl-soraka
Missing (9): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-rpls-1 fi-bdw-samus bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_21943 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-kbl-soraka/igt@gem_exec_fence@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [PASS][2] -> [INCOMPLETE][3] ([i915#146])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [PASS][4] -> [INCOMPLETE][5] ([i915#4547])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/fi-skl-6600u/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-skl-6600u/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-kbl-soraka/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-soraka: NOTRUN -> [DMESG-WARN][8] ([i915#1982] / [i915#4391])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886] / [i915#2291])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-kbl-soraka/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-kbl-soraka/igt@[email protected]
#### Warnings ####
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][12] ([i915#4312]) -> [FAIL][13] ([i915#2722] / [i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/fi-skl-6600u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/fi-skl-6600u/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11054 -> Patchwork_21943
CI-20190529: 20190529
CI_DRM_11054: fa1b08e2ffac9e40a4e0ce8dc17ff11a1163f560 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6325: ac29e097d4ff0f2e269a955ca86c5eb23908467a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21943: abbeb771ca07f5ae5f0687d253367dc1ffad561b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
abbeb771ca07 x86/quirks: Fix stolen detection with integrated + discrete GPU b7d1a15ff26b x86/quirks: Improve line wrap on quirk conditions 8cc99bf8bda8 x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
In reply to Lucas De Marchi== Series Details ==
== Series Details ==
Series: series starting with [v3,1/3] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
URL : https://patchwork.freedesktop.org/series/98622/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11054_full -> Patchwork_21943_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21943_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_create@madvise@smem:
- {shard-rkl}: ([DMESG-WARN][1], [PASS][2]) -> [INCOMPLETE][3]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-5/igt@gem_exec_create@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@gem_exec_create@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-5/igt@gem_exec_create@[email protected]
* igt@gem_exec_whisper@basic-queues-forked:
- {shard-rkl}: [PASS][4] -> [INCOMPLETE][5] +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-6/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-5/igt@[email protected]
* igt@gem_exec_whisper@basic-queues-priority-all:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-5/igt@[email protected]
* igt@prime_self_import@reimport-vs-gem_close-race:
- {shard-rkl}: [PASS][7] -> ([PASS][8], [DMESG-WARN][9])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-2/igt@prime_self_import@reimport-vs-gem_close-race.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-4/igt@prime_self_import@reimport-vs-gem_close-race.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-5/igt@prime_self_import@reimport-vs-gem_close-race.html
* igt@runner@aborted:
- {shard-rkl}: ([FAIL][10], [FAIL][11], [FAIL][12]) ([i915#2029] / [i915#3002] / [i915#3810] / [i915#4312]) -> ([FAIL][13], [FAIL][14]) ([i915#3002] / [i915#4312])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-5/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_21943_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-apl8/igt@gem_ctx_isolation@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][17] -> [SKIP][18] ([i915#4525]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-iclb2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb8/igt@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-kbl3/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-apl7/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl2/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-kbl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl7/igt@[email protected]
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4613])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl6/igt@[email protected]
* igt@gem_lmem_swapping@random:
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl3/igt@[email protected]
* igt@gem_pxp@create-regular-context-2:
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#4270])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb8/igt@[email protected]
* igt@gen9_exec_parse@unaligned-access:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#2856])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb6/igt@[email protected]
* igt@i915_query@query-topology-known-pci-ids:
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#109303])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-glk: [PASS][30] -> [DMESG-WARN][31] ([i915#118])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-glk3/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-glk5/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][32] ([i915#3743]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl3/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3777]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl7/igt@[email protected]
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3886]) +6 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271]) +132 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl7/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-audio-edid:
- shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +8 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl3/igt@[email protected]
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +5 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@[email protected]
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +8 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl6/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-green-to-red:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb3/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-kbl: NOTRUN -> [TIMEOUT][42] ([i915#1319])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl6/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109274] / [fdo#109278])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb6/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109274] / [fdo#111825])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb8/igt@[email protected]
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#533]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl7/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][46] -> [FAIL][47] ([i915#2122])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-glk6/igt@kms_flip@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][48] -> [FAIL][49] ([i915#79])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-skl10/igt@kms_flip@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][50] -> [DMESG-WARN][51] ([i915#180]) +5 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-kbl7/igt@kms_flip@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][52] -> [INCOMPLETE][53] ([i915#180])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-apl7/igt@kms_flip@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@kms_flip@[email protected]
- shard-kbl: [PASS][54] -> [INCOMPLETE][55] ([i915#180] / [i915#3614])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-kbl6/igt@kms_flip@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1:
- shard-skl: [PASS][56] -> [FAIL][57] ([i915#2122]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-skl3/igt@kms_flip@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][58] -> [SKIP][59] ([i915#3701])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109280] / [fdo#111825]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb8/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271]) +114 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl7/igt@[email protected]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#533]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl7/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#533])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][64] -> [INCOMPLETE][65] ([i915#2828])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-skl3/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][66] -> [FAIL][67] ([fdo#108145] / [i915#265]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-skl4/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][68] ([fdo#108145] / [i915#265])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][69] ([i915#265])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][70] ([fdo#108145] / [i915#265]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl3/igt@[email protected]
* igt@kms_plane_cursor@pipe-c-overlay-size-256:
- shard-glk: [PASS][71] -> [FAIL][72] ([i915#1888] / [i915#4729])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-glk3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-glk5/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#3536])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb3/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl6/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl6/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109441])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][78] -> [SKIP][79] ([fdo#109441]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb7/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-d-wait-forked:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271]) +53 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@[email protected]
* igt@prime_nv_pcopy@test3_2:
- shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109291])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb3/igt@prime_nv_pcopy@test3_2.html
* igt@sysfs_clients@fair-3:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2994])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@[email protected]
* igt@sysfs_clients@recycle-many:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2994]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl9/igt@[email protected]
* igt@sysfs_clients@sema-25:
- shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl7/igt@[email protected]
#### Possible fixes ####
* igt@drm_import_export@prime:
- {shard-rkl}: [INCOMPLETE][85] -> [PASS][86] +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][87] ([i915#658]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-iclb5/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb2/igt@[email protected]
* igt@gem_ctx_isolation@preservation-s3@vcs1:
- shard-tglb: [DMESG-WARN][89] ([i915#2411] / [i915#2867]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-tglb2/igt@gem_ctx_isolation@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb1/igt@gem_ctx_isolation@[email protected]
* igt@gem_eio@in-flight-1us:
- shard-tglb: [TIMEOUT][91] ([i915#3063]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-tglb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb1/igt@[email protected]
* igt@gem_eio@in-flight-contexts-10ms:
- {shard-rkl}: [TIMEOUT][93] ([i915#3063]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][95] ([i915#2481] / [i915#3070]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-iclb2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb7/igt@[email protected]
* igt@gem_exec_balancer@bonded-pair:
- {shard-tglu}: [FAIL][97] ([i915#1888]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-tglu-3/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglu-2/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][99] ([i915#4525]) -> [PASS][100] +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-iclb7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb1/igt@[email protected]
* igt@gem_exec_capture@pi@bcs0:
- shard-skl: [INCOMPLETE][101] ([i915#4547]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-skl1/igt@gem_exec_capture@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl1/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][103] ([i915#2842]) -> [PASS][104] +4 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-kbl6/igt@gem_exec_fair@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][105] ([i915#2190]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-tglb6/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb2/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][107] ([i915#1436] / [i915#716]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-apl8/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl3/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][109] ([i915#454]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-iclb3/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-iclb5/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- {shard-rkl}: [SKIP][111] ([fdo#109308]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@drm-resources-equal:
- {shard-rkl}: ([PASS][113], [SKIP][114]) ([fdo#109308]) -> [PASS][115]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-6/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- {shard-dg1}: [SKIP][116] ([i915#1397]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-dg1-15/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-dg1-18/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- {shard-tglu}: [DMESG-FAIL][118] ([i915#3987]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-tglu-3/igt@i915_selftest@live@gt_pm.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglu-1/igt@i915_selftest@live@gt_pm.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- {shard-tglu}: [DMESG-WARN][120] ([i915#402]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-tglu-5/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglu-6/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][122] ([i915#118]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-glk9/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-glk8/igt@[email protected]
* igt@kms_color@pipe-a-ctm-blue-to-red:
- {shard-rkl}: [SKIP][124] ([i915#1149] / [i915#4098]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@kms_color@pipe-a-ctm-negative:
- {shard-rkl}: [SKIP][126] ([i915#1149] / [i915#1849]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-5/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][128] ([i915#180]) -> [PASS][129] +2 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-kbl4/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-kbl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding:
- {shard-rkl}: ([SKIP][130], [PASS][131]) ([fdo#112022]) -> [PASS][132] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-6/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
- {shard-rkl}: [SKIP][133] ([fdo#112022]) -> [PASS][134] +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-5/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][135] ([i915#180]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-apl2/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-apl6/igt@[email protected]
* igt@kms_cursor_legacy@pipe-c-forked-move:
- {shard-rkl}: [SKIP][137] ([i915#4070]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-6/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-5/igt@[email protected]
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size:
- {shard-rkl}: ([PASS][139], [SKIP][140]) ([fdo#111825]) -> [PASS][141]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
- {shard-rkl}: ([SKIP][142], [SKIP][143]) ([fdo#111314] / [i915#4098]) -> [PASS][144]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-5/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-rkl-4/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][145] ([i915#79]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-skl10/igt@kms_flip@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-tglb: [FAIL][147] ([i915#79]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11054/shard-tglb5/igt@kms_flip@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/shard-tglb2/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21943/index.html
Quoted 3 lines · Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk ass applied by itself.
s/ass applied/as applied/
Quoted 4 lines
So replace the uses of
QFLAG_APPLY_ONCEwith static local variables in the few quirks that use this logic and remove all the flags logic.Signed-off-by Lucas De Marchi <[email protected]>
Quoted 139 lines
---
v3: Keep in this patch only the mechanical change to move from
QFLAG_APPLY_ONCEto static locals. Differently than v2, we don't try to setquirk_appliedinnvidia_bugs()andvia_bugs()only when the global resource is set - this patch is a mechanical move only and shouldn't change any behavior. Forintel_graphics_quirks(), we will move it to the right place in a subsequent patch.arch/x86/kernel/early-quirks.c | 55 +++++++++++++++++++++------------- 1 file changed, 34 insertions(+), 21 deletions(-)arch/x86/kernel/early-quirks.c +34
-21@@ -57,6 +57,13 @@ static void __init fix_hypertransport_config(int num, int slot, int func)static void __init via_bugs (int num,int slot,int func) {#ifdef CONFIG_GART_IOMMU +static bool quirk_applied__initdata ; + +if (quirk_applied) +return ; + + quirk_applied = true; +if ((max_pfn >MAX_DMA32_PFN || force_iommu) && !gart_iommu_aperture_allowed) { printk(KERN_INFO@@ -81,6 +88,13 @@ static void __init nvidia_bugs(int num, int slot, int func) {#ifdef CONFIG_ACPI #ifdef CONFIG_X86_IO_APIC +static bool quirk_applied__initdata ; + +if (quirk_applied) +return ; + + quirk_applied = true; +/* * Only applies to Nvidia root ports (bus 0) and not to * Nvidia graphics cards with PCI ports on secondary buses. @@ -587,10 +601,16 @@ intel_graphics_stolen(int num, int slot, int func,static void __init intel_graphics_quirks (int num,int slot,int func) { +static bool quirk_applied__initdata ;const struct intel_early_ops *early_ops;u16 device;int i; +if (quirk_applied) +return ; + + quirk_applied = true; + device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {@@ -673,37 +693,33 @@ static void __init apple_airport_reset(int bus, int slot, int func)early_iounmap (mmio,BCM4331_MMIO_SIZE ); } -#define QFLAG_APPLY_ONCE 0x1 -#define QFLAG_APPLIED 0x2 -#define QFLAG_DONE (QFLAG_APPLY_ONCE|QFLAG_APPLIED)struct chipset {u32 vendor;u32 device;u32 class;u32 class_mask; -u32 flags;void (*f)(int num,int slot,int func); };static struct chipset early_qrk[]__initdata = { {PCI_VENDOR_ID_NVIDIA ,PCI_ANY_ID , -PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID ,QFLAG_APPLY_ONCE , nvidia_bugs }, +PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID , nvidia_bugs }, {PCI_VENDOR_ID_VIA ,PCI_ANY_ID , -PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID ,QFLAG_APPLY_ONCE , via_bugs }, +PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID , via_bugs }, {PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_K8_NB , -PCI_CLASS_BRIDGE_HOST ,PCI_ANY_ID ,0 , fix_hypertransport_config }, +PCI_CLASS_BRIDGE_HOST ,PCI_ANY_ID , fix_hypertransport_config }, {PCI_VENDOR_ID_ATI ,PCI_DEVICE_ID_ATI_IXP400_SMBUS , -PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID ,0 , ati_bugs }, +PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID , ati_bugs }, {PCI_VENDOR_ID_ATI ,PCI_DEVICE_ID_ATI_SBX00_SMBUS , -PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID ,0 , ati_bugs_contd }, +PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID , ati_bugs_contd }, {PCI_VENDOR_ID_INTEL ,0x3403 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,0x3405 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,0x3406 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,PCI_ANY_ID ,PCI_CLASS_DISPLAY_VGA ,PCI_ANY_ID , -QFLAG_APPLY_ONCE , intel_graphics_quirks }, + intel_graphics_quirks },/* * HPET on the current version of the Baytrail platform has accuracy * problems: it will halt in deep idle state - so we disable it. @@ -713,9 +729,9 @@ static struct chipset early_qrk[] __initdata = {* http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/atom-z8000-datasheet-vol-1.pdf */ {PCI_VENDOR_ID_INTEL ,0x0f00 , - PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet}, + PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, force_disable_hpet}, { PCI_VENDOR_ID_BROADCOM, 0x4331, - PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, 0, apple_airport_reset}, + PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, apple_airport_reset}, {} };@@ -756,12 +772,9 @@ static int __init check_dev_quirk(int num, int slot, int func) ((early_qrk[i].device ==PCI_ANY_ID ) || (early_qrk[i].device == device)) && (!((early_qrk[i].class ^ class) & - early_qrk[i].class_mask))) { - if ((early_qrk[i].flags & -QFLAG_DONE ) !=QFLAG_DONE ) - early_qrk[i].f(num, slot, func); - early_qrk[i].flags |=QFLAG_APPLIED ; - } + early_qrk[i].class_mask))) + early_qrk[i].f(num, slot, func); + } type = read_pci_config_byte(num, slot, func,Signature · 1 line
2.34.1
PATCH v4 1/1 x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk as applied by itself.
So replace the uses of QFLAG_APPLY_ONCE with static local variables in the few quirks that use this logic and remove all the flags logic.
---
v4: Fix typo in commit message
arch/x86/kernel/early-quirks.c | 55 +++++++++++++++++++++------------- 1 file changed, 34 insertions(+), 21 deletions(-)
arch/x86/kernel/early-quirks.c +34 -21
@@ -57,6 +57,13 @@ static void __init fix_hypertransport_config(int num, int slot, int func)static void __init via_bugs (int num,int slot,int func) {#ifdef CONFIG_GART_IOMMU +static bool quirk_applied__initdata ; + +if (quirk_applied) +return ; + + quirk_applied = true; +if ((max_pfn >MAX_DMA32_PFN || force_iommu) && !gart_iommu_aperture_allowed) { printk(KERN_INFO
@@ -81,6 +88,13 @@ static void __init nvidia_bugs(int num, int slot, int func) {#ifdef CONFIG_ACPI #ifdef CONFIG_X86_IO_APIC +static bool quirk_applied__initdata ; + +if (quirk_applied) +return ; + + quirk_applied = true; +/* * Only applies to Nvidia root ports (bus 0) and not to * Nvidia graphics cards with PCI ports on secondary buses.
@@ -589,10 +603,16 @@ intel_graphics_stolen(int num, int slot, int func,static void __init intel_graphics_quirks (int num,int slot,int func) { +static bool quirk_applied__initdata ;const struct intel_early_ops *early_ops;u16 device;int i; +if (quirk_applied) +return ; + + quirk_applied = true; + device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {
@@ -675,37 +695,33 @@ static void __init apple_airport_reset(int bus, int slot, int func)early_iounmap (mmio,BCM4331_MMIO_SIZE ); } -#define QFLAG_APPLY_ONCE 0x1 -#define QFLAG_APPLIED 0x2 -#define QFLAG_DONE (QFLAG_APPLY_ONCE|QFLAG_APPLIED)struct chipset {u32 vendor;u32 device;u32 class;u32 class_mask; -u32 flags;void (*f)(int num,int slot,int func); };static struct chipset early_qrk[]__initdata = { {PCI_VENDOR_ID_NVIDIA ,PCI_ANY_ID , -PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID ,QFLAG_APPLY_ONCE , nvidia_bugs }, +PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID , nvidia_bugs }, {PCI_VENDOR_ID_VIA ,PCI_ANY_ID , -PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID ,QFLAG_APPLY_ONCE , via_bugs }, +PCI_CLASS_BRIDGE_PCI ,PCI_ANY_ID , via_bugs }, {PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_K8_NB , -PCI_CLASS_BRIDGE_HOST ,PCI_ANY_ID ,0 , fix_hypertransport_config }, +PCI_CLASS_BRIDGE_HOST ,PCI_ANY_ID , fix_hypertransport_config }, {PCI_VENDOR_ID_ATI ,PCI_DEVICE_ID_ATI_IXP400_SMBUS , -PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID ,0 , ati_bugs }, +PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID , ati_bugs }, {PCI_VENDOR_ID_ATI ,PCI_DEVICE_ID_ATI_SBX00_SMBUS , -PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID ,0 , ati_bugs_contd }, +PCI_CLASS_SERIAL_SMBUS ,PCI_ANY_ID , ati_bugs_contd }, {PCI_VENDOR_ID_INTEL ,0x3403 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,0x3405 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,0x3406 ,PCI_CLASS_BRIDGE_HOST , -PCI_BASE_CLASS_BRIDGE ,0 , intel_remapping_check }, +PCI_BASE_CLASS_BRIDGE , intel_remapping_check }, {PCI_VENDOR_ID_INTEL ,PCI_ANY_ID ,PCI_CLASS_DISPLAY_VGA ,PCI_ANY_ID , -QFLAG_APPLY_ONCE , intel_graphics_quirks }, + intel_graphics_quirks },/* * HPET on the current version of the Baytrail platform has accuracy * problems: it will halt in deep idle state - so we disable it.
@@ -715,9 +731,9 @@ static struct chipset early_qrk[] __initdata = {* http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/atom-z8000-datasheet-vol-1.pdf */ {PCI_VENDOR_ID_INTEL ,0x0f00 , - PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet}, + PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, force_disable_hpet}, { PCI_VENDOR_ID_BROADCOM, 0x4331, - PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, 0, apple_airport_reset}, + PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, apple_airport_reset}, {} };
@@ -758,12 +774,9 @@ static int __init check_dev_quirk(int num, int slot, int func) ((early_qrk[i].device ==PCI_ANY_ID ) || (early_qrk[i].device == device)) && (!((early_qrk[i].class ^ class) & - early_qrk[i].class_mask))) { - if ((early_qrk[i].flags & -QFLAG_DONE ) !=QFLAG_DONE ) - early_qrk[i].f(num, slot, func); - early_qrk[i].flags |=QFLAG_APPLIED ; - } + early_qrk[i].class_mask))) + early_qrk[i].f(num, slot, func); + } type = read_pci_config_byte(num, slot, func,
Signature · 1 line
2.34.1
Quoted 9 lines · Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk as applied by itself.
So replace the uses of
QFLAG_APPLY_ONCEwith static local variables in the few quirks that use this logic and remove all the flags logic.Signed-off-by Lucas De Marchi <[email protected]>Reviewed-by Bjorn Helgaas <[email protected]>
Only occurred to me now, but another, less intrusive approach would be to just remove QFLAG_APPLY_ONCE from intel_graphics_quirks() and do its bookkeeping internally, e.g.,
arch/x86/kernel/early-quirks.c +6 -1
@@ -587,10 +587,14 @@ intel_graphics_stolen(int num, int slot, int func,static void __init intel_graphics_quirks (int num,int slot,int func) { +static bool stolen__initdata = false;const struct intel_early_ops *early_ops;u16 device;int i; +if (stolen) +return ; + device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {
@@ -602,6 +606,7 @@ static void __init intel_graphics_quirks(int num, int slot, int func) early_ops = (typeof (early_ops ))driver_data;intel_graphics_stolen (num, slot, func, early_ops); + stolen = true;return ; }
@@ -703,7 +708,7 @@ static struct chipset early_qrk[] __initdata = { {PCI_VENDOR_ID_INTEL ,0x3406 ,PCI_CLASS_BRIDGE_HOST , PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check }, { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA, PCI_ANY_ID, - QFLAG_APPLY_ONCE, intel_graphics_quirks }, + 0, intel_graphics_quirks },/* * HPET on the current version of the Baytrail platform has accuracy * problems: it will halt in deep idle state - so we disable it.
Quoted 8 lines · Bjorn Helgaas
Quoted 7 lines · Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk as applied by itself.
So replace the uses of
QFLAG_APPLY_ONCEwith static local variables in the few quirks that use this logic and remove all the flags logic.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Lucas De Marchi <[email protected]>Reviewed-by Bjorn Helgaas <[email protected]>Only occurred to me now, but another, less intrusive approach would be to just remove
QFLAG_APPLY_ONCEfromintel_graphics_quirks()and do its bookkeeping internally, e.g.,
that is actually what I suggested after your comment in v2: this would be the first patch with "minimal fix". But then to keep it consistent with the other calls to follow up with additional patches on top converting them as well. Maybe what I wrote wasn't clear in the direction? Copying it here:
1) add the static local only to intel graphics quirk and remove the flag from this item
2 and 3) add the static local to other functions and remove the flag from those items
4) remove the flag from the table, the defines and its usage.
5) fix the coding style (to be clear, it's already wrong, not something wrong introduced here... maybe could be squashed in (4)?)
Lucas De Marchi
Quoted 37 lines
arch/x86/kernel/early-quirks.c +6
-1@@ -587,10 +587,14 @@ intel_graphics_stolen(int num, int slot, int func,static void __init intel_graphics_quirks (int num,int slot,int func) { +static bool stolen__initdata = false;const struct intel_early_ops *early_ops;u16 device;int i; +if (stolen) +return ; + device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {@@ -602,6 +606,7 @@ static void __init intel_graphics_quirks(int num, int slot, int func) early_ops = (typeof (early_ops ))driver_data;intel_graphics_stolen (num, slot, func, early_ops); + stolen = true;return ; }@@ -703,7 +708,7 @@ static struct chipset early_qrk[] __initdata = { {PCI_VENDOR_ID_INTEL ,0x3406 ,PCI_CLASS_BRIDGE_HOST , PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check }, { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA, PCI_ANY_ID, - QFLAG_APPLY_ONCE, intel_graphics_quirks }, + 0, intel_graphics_quirks },/* * HPET on the current version of the Baytrail platform has accuracy * problems: it will halt in deep idle state - so we disable it.
Quoted 22 lines · Lucas De Marchi
Quoted 8 lines · Bjorn Helgaas
Quoted 7 lines · Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk as applied by itself.
So replace the uses of
QFLAG_APPLY_ONCEwith static local variables in the few quirks that use this logic and remove all the flags logic.Quoted 6 lines
Quoted 2 lines
Signed-off-by Lucas De Marchi <[email protected]>Reviewed-by Bjorn Helgaas <[email protected]>Only occurred to me now, but another, less intrusive approach would be to just remove
QFLAG_APPLY_ONCEfromintel_graphics_quirks()and do its bookkeeping internally, e.g.,that is actually what I suggested after your comment in v2: this would be the first patch with "minimal fix". But then to keep it consistent with the other calls to follow up with additional patches on top converting them as well. Maybe what I wrote wasn't clear in the direction? Copying it here:
Quoted 7 lines
1) add the static local only to intel graphics quirk and remove the flag from this item
2 and 3) add the static local to other functions and remove the flag from those items
4) remove the flag from the table, the defines and its usage.
5) fix the coding style (to be clear, it's already wrong, not something wrong introduced here... maybe could be squashed in (4)?)
Oh, sorry, I guess I just skimmed over that without really comprehending it.
Although the patch below is basically just 1 from above and doesn't require any changes to the other functions or the flags themselves (2-4 above).
Quoted 36 lines
Quoted 36 lines
arch/x86/kernel/early-quirks.c +6
-1@@ -587,10 +587,14 @@ intel_graphics_stolen(int num, int slot, int func,static void __init intel_graphics_quirks (int num,int slot,int func) { +static bool stolen__initdata = false;const struct intel_early_ops *early_ops;u16 device;int i; +if (stolen) +return ; + device =read_pci_config_16 (num, slot, func,PCI_DEVICE_ID );for (i =0 ; i <ARRAY_SIZE (intel_early_ids); i++) {@@ -602,6 +606,7 @@ static void __init intel_graphics_quirks(int num, int slot, int func) early_ops = (typeof (early_ops ))driver_data;intel_graphics_stolen (num, slot, func, early_ops); + stolen = true;return ; }@@ -703,7 +708,7 @@ static struct chipset early_qrk[] __initdata = { {PCI_VENDOR_ID_INTEL ,0x3406 ,PCI_CLASS_BRIDGE_HOST , PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check }, { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA, PCI_ANY_ID, - QFLAG_APPLY_ONCE, intel_graphics_quirks }, + 0, intel_graphics_quirks },/* * HPET on the current version of the Baytrail platform has accuracy * problems: it will halt in deep idle state - so we disable it.
Quoted 31 lines · Bjorn Helgaas
Quoted 22 lines · Lucas De Marchi
Quoted 8 lines · Bjorn Helgaas
Quoted 7 lines · Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk as applied by itself.
So replace the uses of
QFLAG_APPLY_ONCEwith static local variables in the few quirks that use this logic and remove all the flags logic.Quoted 6 lines
Quoted 2 lines
Signed-off-by Lucas De Marchi <[email protected]>Reviewed-by Bjorn Helgaas <[email protected]>Only occurred to me now, but another, less intrusive approach would be to just remove
QFLAG_APPLY_ONCEfromintel_graphics_quirks()and do its bookkeeping internally, e.g.,that is actually what I suggested after your comment in v2: this would be the first patch with "minimal fix". But then to keep it consistent with the other calls to follow up with additional patches on top converting them as well. Maybe what I wrote wasn't clear in the direction? Copying it here:
Quoted 7 lines
1) add the static local only to intel graphics quirk and remove the flag from this item
2 and 3) add the static local to other functions and remove the flag from those items
4) remove the flag from the table, the defines and its usage.
5) fix the coding style (to be clear, it's already wrong, not something wrong introduced here... maybe could be squashed in (4)?)
Quoted 6 lines
Oh, sorry, I guess I just skimmed over that without really comprehending it.
Although the patch below is basically just 1 from above and doesn't require any changes to the other functions or the flags themselves (2-4 above).
Yes, but I would do the rest of the conversion anyway. It would be odd to be inconsistent with just a few functions. So in the end I think we would achieve the same goal.
I would really prefer this approach, having the bug fix first, if I was concerned about having to backport this to linux-stable beyond 5.10.y (we have a trivial conflict on 5.10).
However given this situation is new (Intel GPU + Intel Discrete GPU) rare (it also needs a PCI topology in a certain way to reproduce it), I'm not too concerned. Not even sure if it's worth submitting to linux-stable.
I'll wait others to chime in on one way vs the other.
thanks
Lucas De Marchi
Quoted 43 lines · Lucas De Marchi
Quoted 31 lines · Bjorn Helgaas
Quoted 22 lines · Lucas De Marchi
Quoted 8 lines · Bjorn Helgaas
Quoted 7 lines · Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk as applied by itself.
So replace the uses of
QFLAG_APPLY_ONCEwith static local variables in the few quirks that use this logic and remove all the flags logic.Quoted 6 lines
Quoted 2 lines
Signed-off-by Lucas De Marchi <[email protected]>Reviewed-by Bjorn Helgaas <[email protected]>Only occurred to me now, but another, less intrusive approach would be to just remove
QFLAG_APPLY_ONCEfromintel_graphics_quirks()and do its bookkeeping internally, e.g.,that is actually what I suggested after your comment in v2: this would be the first patch with "minimal fix". But then to keep it consistent with the other calls to follow up with additional patches on top converting them as well. Maybe what I wrote wasn't clear in the direction? Copying it here:
Quoted 7 lines
1) add the static local only to intel graphics quirk and remove the flag from this item
2 and 3) add the static local to other functions and remove the flag from those items
4) remove the flag from the table, the defines and its usage.
5) fix the coding style (to be clear, it's already wrong, not something wrong introduced here... maybe could be squashed in (4)?)Quoted 6 lines
Oh, sorry, I guess I just skimmed over that without really comprehending it.
Although the patch below is basically just 1 from above and doesn't require any changes to the other functions or the flags themselves (2-4 above).
Yes, but I would do the rest of the conversion anyway. It would be odd to be inconsistent with just a few functions. So in the end I think we would achieve the same goal.
Quoted 8 lines
I would really prefer this approach, having the bug fix first, if I was concerned about having to backport this to linux-stable beyond 5.10.y (we have a trivial conflict on 5.10).
However given this situation is new (Intel GPU + Intel Discrete GPU) rare (it also needs a PCI topology in a certain way to reproduce it), I'm not too concerned. Not even sure if it's worth submitting to linux-stable.
+1 on the minimal fix approach first and send that to stable 5.10+. We will hit this case for sure.
also +1 on the discussed ideas as a follow up.
Quoted 5 lines
I'll wait others to chime in on one way vs the other.
thanks
Lucas De Marchi
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals (rev3)
In reply to Lucas De Marchi== Series Details ==
== Series Details ==
Series: series starting with [v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals (rev3)
URL : https://patchwork.freedesktop.org/series/98622/
State : failure
== Summary ==
Applying: x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
Applying: x86/quirks: Improve line wrap on quirk conditions
error: sha1 information is lacking or useless (arch/x86/kernel/early-quirks.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0002 x86/quirks: Improve line wrap on quirk conditions When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals (rev2)
In reply to Lucas De Marchi== Series Details ==
== Series Details ==
Series: series starting with [v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals (rev2)
URL : https://patchwork.freedesktop.org/series/98622/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11075 -> Patchwork_21987
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/index.html
Participating hosts (44 -> 43)
------------------------------
Additional (1): fi-kbl-soraka
Missing (2): fi-bsw-cyan fi-pnv-d510
Known issues
------------
Here are the changes found in Patchwork_21987 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +31 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-bdw-5557u/igt@amdgpu/[email protected]
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-snb-2600/igt@amdgpu/[email protected]
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-kbl-soraka/igt@gem_exec_fence@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-cfl-guc: [PASS][6] -> [DMESG-FAIL][7] ([i915#541])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/fi-cfl-guc/igt@i915_selftest@live@gt_heartbeat.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-cfl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886] / [i915#2291])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: NOTRUN -> [DMESG-FAIL][9] ([i915#4494])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/bat-dg1-5/igt@i915_selftest@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-kbl-soraka/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-bdw-5557u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][12] -> [DMESG-WARN][13] ([i915#4269])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/fi-cml-u2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-cml-u2/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-kbl-soraka/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [PASS][15] -> [INCOMPLETE][16] ([i915#4838])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
#### Possible fixes ####
* igt@core_auth@basic-auth:
- {bat-jsl-2}: [DMESG-WARN][17] ([i915#4562]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/bat-jsl-2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/bat-jsl-2/igt@[email protected]
* igt@gem_exec_suspend@basic-s0@smem:
- fi-tgl-1115g4: [FAIL][19] ([i915#1888]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-tgl-1115g4/igt@gem_exec_suspend@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [INCOMPLETE][21] ([i915#146]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-bdw-5557u/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [INCOMPLETE][23] ([i915#4418]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@hangcheck:
- {fi-ehl-2}: [DMESG-FAIL][25] -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/fi-ehl-2/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-ehl-2/igt@i915_selftest@[email protected]
- fi-snb-2600: [INCOMPLETE][27] ([i915#3921]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/fi-snb-2600/igt@i915_selftest@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/fi-snb-2600/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@hugepages:
- {bat-adlp-6}: [DMESG-WARN][29] ([i915#1888]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11075/bat-adlp-6/igt@i915_selftest@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/bat-adlp-6/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4562]: https://gitlab.freedesktop.org/drm/intel/issues/4562
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4838]: https://gitlab.freedesktop.org/drm/intel/issues/4838
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Build changes
-------------
* Linux: CI_DRM_11075 -> Patchwork_21987
CI-20190529: 20190529
CI_DRM_11075: 9b371f79eeb9a3867d2483e4038f22f89a854886 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6326: ec75f64fcbcf4aac58fbf1bf629e8f59b19db4ce @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21987: 34812ca8c6367de08c2c10f18ab8559270d78277 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
34812ca8c636 x86/quirks: Fix stolen detection with integrated + discrete GPU 3affb65cf0a1 x86/quirks: Improve line wrap on quirk conditions 629c14c16b4a x86/quirks: Replace QFLAG_APPLY_ONCE with static locals
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21987/index.html