Skip to contentSkip to conversation

drm/imx: Fix memory leak in imx_pd_connector_get_modes

PATCH Applied José Expósito 2 participants 2 messages Jan 8, 2022 – Mar 29, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/imx: Fix memory leak in imx_pd_connector_get_modes

Avoid leaking the display mode variable if of_get_drm_display_mode fails.

Fixes 76ecd9c9fb24 ("drm/imx: parallel-display: check return code from of_get_drm_display_mode()")

Addresses-Coverity-ID: 1443943 ("Resource leak")

---

v2: Improve commit message

---
 drivers/gpu/drm/imx/parallel-display.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/imx/parallel-display.c +3 -1
index a8aba0141ce7..3bf8e0a4803a 100644
@@ -75,8 +75,10 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
 		ret = of_get_drm_display_mode(np, &imxpd->mode,
 					      &imxpd->bus_flags,
 					      OF_USE_NATIVE_MODE);
-		if (ret)
+		if (ret) {
+			drm_mode_destroy(connector->dev, mode);
 			return ret;
+		}
 
 		drm_mode_copy(mode, &imxpd->mode);
 		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 30 lines · José Expósito

Avoid leaking the display mode variable if of_get_drm_display_mode fails.

Fixes 76ecd9c9fb24 ("drm/imx: parallel-display: check return code

from of_get_drm_display_mode()")
Addresses-Coverity-ID: 1443943 ("Resource leak")

---

v2: Improve commit message
---
 drivers/gpu/drm/imx/parallel-display.c | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/imx/parallel-display.c +3 -1
index a8aba0141ce7..3bf8e0a4803a 100644
@@ -75,8 +75,10 @@ static int imx_pd_connector_get_modes(struct
 drm_connector *connector)
                 ret = of_get_drm_display_mode(np, &imxpd->mode,
                                               &imxpd->bus_flags,
                                               OF_USE_NATIVE_MODE);
-               if (ret)
+               if (ret) {
+                       drm_mode_destroy(connector->dev, mode);
                         return ret;
+               }
Quoted 4 lines


                drm_mode_copy(mode, &imxpd->mode); mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;

Thank you, applied to imx-drm/fixes.

regards
Philipp