tcp: tcp_send_challenge_ack delete useless param `skb`
Subsystems (3)
PATCH 1/1 tcp: tcp_send_challenge_ack delete useless param `skb`
After this parameter is passed in, there is no usage, and deleting it will
not bring any impact.
Signed-off-by Benjamin Yim <[email protected]>
--- net/ipv4/tcp_input.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
net/ipv4/tcp_input.c +5 -5
@@ -3601,7 +3601,7 @@ bool tcp_oow_rate_limited(struct net *net, const struct sk_buff *skb, }/* RFC 5961 7 [ACK Throttling] */ -static void tcp_send_challenge_ack (struct sock *sk,const struct sk_buff *skb) +static void tcp_send_challenge_ack (struct sock *sk) {/* unprotected vars, we dont care of overwrites */ static u32 challenge_timestamp;
@@ -3763,7 +3763,7 @@ static int tcp_ack(struct sock *sk, const struct sk_buff *skb, int flag)/* RFC 5961 5.2 [Blind Data Injection Attack].[Mitigation] */ if (before (ack, prior_snd_una - tp->max_window)) {if (!(flag &FLAG_NO_CHALLENGE_ACK )) -tcp_send_challenge_ack (sk, skb); +tcp_send_challenge_ack (sk);return -1 ; } goto old_ack;
@@ -5726,7 +5726,7 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb,if (tp->syn_fastopen && !tp->data_segs_in && sk->sk_state ==TCP_ESTABLISHED )tcp_fastopen_active_disable (sk); -tcp_send_challenge_ack (sk, skb); +tcp_send_challenge_ack (sk); } goto discard; }
@@ -5741,7 +5741,7 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb,if (syn_inerr)TCP_INC_STATS (sock_net (sk),TCP_MIB_INERRS );NET_INC_STATS (sock_net (sk),LINUX_MIB_TCPSYNCHALLENGE ); -tcp_send_challenge_ack (sk, skb); +tcp_send_challenge_ack (sk); goto discard; }
@@ -6456,7 +6456,7 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb)if (!acceptable) {if (sk->sk_state ==TCP_SYN_RECV )return 1 ;/* send one RST */ -tcp_send_challenge_ack (sk, skb); +tcp_send_challenge_ack (sk); goto discard; }switch (sk->sk_state) {
Signature · 1 line
2.33.1
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 7 lines · On Sun, 9 Jan 2022 21:08:24 +0800 you wrote:
After this parameter is passed in, there is no usage, and deleting it will
not bring any impact.Signed-off-by Benjamin Yim <[email protected]>--- net/ipv4/tcp_input.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Here is the summary with links:
- tcp: tcp_send_challenge_ack delete useless param skb
https://git.kernel.org/netdev/net-next/c/208dd45d8d05
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html