Skip to contentSkip to conversation

package/pkg-cargo: convert to uppercase RUSTC_TARGET_NAME

PATCH Applied Giulio Benetti 2 participants 2 messages Jan 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/pkg-cargo: convert to uppercase RUSTC_TARGET_NAME

RUSTC_TARGET_NAME's dashes are substituted with underscores, but this is not enough to fix building, we also need to make it UPPERCASE. So let make it like that by using UPPERCASE macro.

Fixes:
http://autobuild.buildroot.net/results/498/498b96224c8bcff91542ca3731dfd66891f4ec23/

---
 package/pkg-cargo.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-cargo.mk +1 -1
index 067c45a920..71f4dc4c91 100644
@@ -44,7 +44,7 @@ PKG_CARGO_ENV = \
 	CARGO_UNSTABLE_TARGET_APPLIES_TO_HOST="true" \
 	CARGO_TARGET_APPLIES_TO_HOST="false" \
 	CARGO_BUILD_TARGET="$(RUSTC_TARGET_NAME)" \
-	CARGO_TARGET_$(subst -,_,$(RUSTC_TARGET_NAME))_LINKER=$(notdir $(TARGET_CROSS))gcc
+	CARGO_TARGET_$(call UPPERCASE,$(subst -,_,$(RUSTC_TARGET_NAME)))_LINKER=$(notdir $(TARGET_CROSS))gcc
 
 HOST_PKG_CARGO_ENV = \
 	$(PKG_COMMON_CARGO_ENV)
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 17 lines · Giulio Benetti

RUSTC_TARGET_NAME's dashes are substituted with underscores, but this is not enough to fix building, we also need to make it UPPERCASE. So let make it like that by using UPPERCASE macro.

Fixes:
http://autobuild.buildroot.net/results/498/498b96224c8bcff91542ca3731dfd66891f4ec23/

---
  package/pkg-cargo.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-cargo.mk +0 -0
index 067c45a920..71f4dc4c91 100644

package/pkg-cargo.mk PKG_CARGO_ENV = \ · line 47

Quoted 5 lines
package/pkg-cargo.mk +1 -1
@@ -44,7 +44,7 @@ PKG_CARGO_ENV = \
  	CARGO_UNSTABLE_TARGET_APPLIES_TO_HOST="true" \
  	CARGO_TARGET_APPLIES_TO_HOST="false" \
  	CARGO_BUILD_TARGET="$(RUSTC_TARGET_NAME)" \
-	CARGO_TARGET_$(subst -,_,$(RUSTC_TARGET_NAME))_LINKER=$(notdir $(TARGET_CROSS))gcc
+	CARGO_TARGET_$(call UPPERCASE,$(subst -,_,$(RUSTC_TARGET_NAME)))_LINKER=$(notdir $(TARGET_CROSS))gcc

UPPERCASE already does the subst, so that's redundant.

Applied to master with that fixed, thanks.

With the two of us working together, the autobuilder failure should finally be
fixed!

Regards,
Arnout

package/pkg-cargo.mk PKG_CARGO_ENV = \

Quoted 4 lines
package/pkg-cargo.mk +0 -0
  HOST_PKG_CARGO_ENV = \
  	$(PKG_COMMON_CARGO_ENV)
 

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot