drm/amd/display: invalid parameter check in dmub_hpd_callback
Subsystems (3)
PATCH 1/1 drm/amd/display: invalid parameter check in dmub_hpd_callback
The function performs a check on the "adev" input parameter, however, it is used before the check.
Initialize the "dev" variable after the sanity check to avoid a possible NULL pointer dereference.
Addresses-Coverity-ID: 1493909 ("Null pointer dereference")
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -1
@@ -656,7 +656,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *notstruct drm_connector_list_iter iter;struct dc_link *link;uint8_t link_index =0 ; -struct drm_device *dev = adev->dm.ddev; +struct drm_device *dev;if (adev ==NULL )return ;
@@ -673,6 +673,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *not link_index = notify->link_index; link = adev->dm.dc->links[link_index]; + dev = adev->dm.ddev;drm_connector_list_iter_begin (dev, &iter);drm_for_each_connector_iter (connector, &iter) {
Signature · 1 line
2.25.1
Quoted 9 lines · José Expósito
The function performs a check on the "adev" input parameter, however, it is used before the check.
Initialize the "dev" variable after the sanity check to avoid a possible NULL pointer dereference.
Fixes e27c41d5b0681 ("drm/amd/display: Support for DMUB HPD interrupt handling")Addresses-Coverity-ID: 1493909 ("Null pointer dereference")
Signed-off-by José Expósito <[email protected]>
Harry
Quoted 25 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-1@@ -656,7 +656,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *notstruct drm_connector_list_iter iter;struct dc_link *link;uint8_t link_index =0 ; -struct drm_device *dev = adev->dm.ddev; +struct drm_device *dev;if (adev ==NULL )return ;@@ -673,6 +673,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *not link_index = notify->link_index; link = adev->dm.dc->links[link_index]; + dev = adev->dm.ddev;drm_connector_list_iter_begin (dev, &iter);drm_for_each_connector_iter (connector, &iter) {
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 42 lines · Harry Wentland
Quoted 9 lines · José Expósito
The function performs a check on the "adev" input parameter, however, it is used before the check.
Initialize the "dev" variable after the sanity check to avoid a possible NULL pointer dereference.
Fixes e27c41d5b0681 ("drm/amd/display: Support for DMUB HPD interrupt handling")Addresses-Coverity-ID: 1493909 ("Null pointer dereference")
Signed-off-by José Expósito <[email protected]>Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 25 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-1@@ -656,7 +656,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *notstruct drm_connector_list_iter iter;struct dc_link *link;uint8_t link_index =0 ; -struct drm_device *dev = adev->dm.ddev; +struct drm_device *dev;if (adev ==NULL )return ;@@ -673,6 +673,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *not link_index = notify->link_index; link = adev->dm.dc->links[link_index]; + dev = adev->dm.ddev;drm_connector_list_iter_begin (dev, &iter);drm_for_each_connector_iter (connector, &iter) {