package/mesa3d: Gallium VC4 driver depends on NEON
PATCH 1/1 package/mesa3d: Gallium VC4 driver depends on NEON
Since version 21.3.0 of mesa3d, the generic broadcom infrastructure (which is called v3d but is used also for VC4) started using NEON instructions. This leads to assembler failures when VC4 is built for 32-bit ARM without NEON:
FAILED: src/broadcom/libv3d_neon.a.p/common_v3d_tiling.c.o /home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc [...] -c ../src/broadcom/common/v3d_tiling.c /tmp/ccAvufNv.s: Assembler messages:/tmp/ccAvufNv.s:602: Error: selected processor does not support `vldm r7,{q0,q1,q2,q3}' in ARM mode [...]/tmp/ccAvufNv.s:686: Error: selected processor does not support `vstm r7,{q0,q1,q2,q3}' in ARM mode
Let the VC4 driver depend on NEON for 32-bit ARM. Aarch64 always has NEON, so no condition is needed there.
Fixes:
http://autobuild.buildroot.net/results/2b5/2b531f7aa4506ee31a7252c87a2e401fffab9dfb/
http://autobuild.buildroot.net/results/6f9/6f9e7c864808dc0fafbca7c8984651fe92edbaf2/
--- package/mesa3d/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/mesa3d/Config.in +1 -1
@@ -274,7 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 bool "Gallium vc4 driver" - depends on BR2_arm || BR2_aarch64 + depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64 depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # libxshmfence select BR2_PACKAGE_MESA3D_DRI3 if BR2_PACKAGE_XORG7 select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
Signature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Arnout,
Le 09/01/2022 à 18:15, Arnout Vandecappelle (Essensium/Mind) a écrit :
Quoted 12 lines
Since version 21.3.0 of mesa3d, the generic broadcom infrastructure (which is called v3d but is used also for VC4) started using NEON instructions. This leads to assembler failures when VC4 is built for 32-bit ARM without NEON:
FAILED:
src/broadcom/libv3d_neon.a.p/common_v3d_tiling.c.o/home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc[...] -c../src/broadcom/common/v3d_tiling.c/tmp/ccAvufNv.s: Assembler messages:/tmp/ccAvufNv.s:602: Error: selected processor does not support `vldm r7,{q0,q1,q2,q3}' in ARM mode [...]/tmp/ccAvufNv.s:686: Error: selected processor does not support `vstm r7,{q0,q1,q2,q3}' in ARM mode
Quoted 2 lines
Let the VC4 driver depend on NEON for 32-bit ARM. Aarch64 always has NEON, so no condition is needed there.
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D selecting BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 already requires NEON.
Best regards,
Romain
Quoted 16 lines
Fixes:
http://autobuild.buildroot.net/results/2b5/2b531f7aa4506ee31a7252c87a2e401fffab9dfb/
http://autobuild.buildroot.net/results/6f9/6f9e7c864808dc0fafbca7c8984651fe92edbaf2/--- package/mesa3d/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/mesa3d/Config.in +0
-0
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D · line 280
Quoted 8 lines
package/mesa3d/Config.in +1
-1@@ -274,7 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 bool "Gallium vc4 driver" - depends on BR2_arm || BR2_aarch64 + depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64 depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # libxshmfence select BR2_PACKAGE_MESA3D_DRI3 if BR2_PACKAGE_XORG7 select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 15 lines · Romain Naour
Hello Arnout,
Le 09/01/2022 à 18:15, Arnout Vandecappelle (Essensium/Mind) a écrit :
Quoted 12 lines
Since version 21.3.0 of mesa3d, the generic broadcom infrastructure (which is called v3d but is used also for VC4) started using NEON instructions. This leads to assembler failures when VC4 is built for 32-bit ARM without NEON:
FAILED:
src/broadcom/libv3d_neon.a.p/common_v3d_tiling.c.o/home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc[...] -c../src/broadcom/common/v3d_tiling.c/tmp/ccAvufNv.s: Assembler messages:/tmp/ccAvufNv.s:602: Error: selected processor does not support `vldm r7,{q0,q1,q2,q3}' in ARM mode [...]/tmp/ccAvufNv.s:686: Error: selected processor does not support `vstm r7,{q0,q1,q2,q3}' in ARM mode
Quoted 5 lines
Quoted 2 lines
Let the VC4 driver depend on NEON for 32-bit ARM. Aarch64 always has NEON, so no condition is needed there.
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3DselectingBR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4already requires NEON.
Yeah, but VC4 doesn't select V3D so that doesn't mean anything.
Regards,
Arnout
Quoted 23 lines
Reviewed-by Romain Naour <[email protected]>Best regards,
RomainQuoted 16 lines
Fixes:
http://autobuild.buildroot.net/results/2b5/2b531f7aa4506ee31a7252c87a2e401fffab9dfb/
http://autobuild.buildroot.net/results/6f9/6f9e7c864808dc0fafbca7c8984651fe92edbaf2/--- package/mesa3d/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/mesa3d/Config.in +0
-0@@ -274,7 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D
Quoted 9 lines
package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D · line 280
Quoted 8 lines
package/mesa3d/Config.in +1
-1config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 bool "Gallium vc4 driver" - depends on BR2_arm || BR2_aarch64 + depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64 depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # libxshmfence select BR2_PACKAGE_MESA3D_DRI3 if BR2_PACKAGE_XORG7 select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Yann E. MORIN
AppliedArnout, All,
On 2022-01-09 18:15 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:
Quoted 12 lines
Since version 21.3.0 of mesa3d, the generic broadcom infrastructure (which is called v3d but is used also for VC4) started using NEON instructions. This leads to assembler failures when VC4 is built for 32-bit ARM without NEON:
FAILED:
src/broadcom/libv3d_neon.a.p/common_v3d_tiling.c.o/home/buildroot/autobuild/instance-2/output-1/host/bin/arm-linux-gcc[...] -c../src/broadcom/common/v3d_tiling.c/tmp/ccAvufNv.s: Assembler messages:/tmp/ccAvufNv.s:602: Error: selected processor does not support `vldm r7,{q0,q1,q2,q3}' in ARM mode [...]/tmp/ccAvufNv.s:686: Error: selected processor does not support `vstm r7,{q0,q1,q2,q3}' in ARM mode
Quoted 8 lines
Let the VC4 driver depend on NEON for 32-bit ARM. Aarch64 always has NEON, so no condition is needed there.
Fixes:
http://autobuild.buildroot.net/results/2b5/2b531f7aa4506ee31a7252c87a2e401fffab9dfb/
http://autobuild.buildroot.net/results/6f9/6f9e7c864808dc0fafbca7c8984651fe92edbaf2/
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 24 lines
--- package/mesa3d/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/mesa3d/Config.in +1
-1@@ -274,7 +274,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4 bool "Gallium vc4 driver" - depends on BR2_arm || BR2_aarch64 + depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64 depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # libxshmfence select BR2_PACKAGE_MESA3D_DRI3 if BR2_PACKAGE_XORG7 select BR2_PACKAGE_MESA3D_GALLIUM_DRIVERSignature · 6 lines
2.31.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot