Skip to contentSkip to conversation

package/libvirt: libvirtd needs C++

PATCH Applied Fabrice Fontaine 2 participants 3 messages Jan 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libvirt: libvirtd needs C++

Fix the following build failure raised since commit fbf25acfbfd5a73b3560918bea081768abbe5723:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_NMAP
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] Selected by [y]:
- BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_PACKAGE_LIBVIRT [=y] && !BR2_PACKAGE_NETCAT_OPENBSD [=n]

Fixes:
- No autobuilder failures (yet)

---
 package/libvirt/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/libvirt/Config.in +4 -0
index a35295bc97..d7ca5f8db5 100644
@@ -37,6 +37,7 @@ if BR2_PACKAGE_LIBVIRT
 config BR2_PACKAGE_LIBVIRT_DAEMON
 	bool "libvirtd"
 	default y
+	depends on BR2_INSTALL_LIBSTDCPP # nmap
 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_DNSMASQ
 	select BR2_PACKAGE_EBTABLES
@@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
 	  Build the libvirt daemon (libvirtd) otherwise build only the
 	  utility programs.
 
+comment "libvirtd needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
+
 # Stateful drivers are useful only when building the daemon.
 if BR2_PACKAGE_LIBVIRT_DAEMON
 
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Fabrice, All,

You little joker, sending a fix right when I was applying your bump... ;-)

On 2022-01-09 21:20 +0100, Fabrice Fontaine spake thusly:

Quoted 21 lines

Fix the following build failure raised since commit fbf25acfbfd5a73b3560918bea081768abbe5723:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_NMAP
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] Selected by [y]:
- BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_PACKAGE_LIBVIRT [=y] && !BR2_PACKAGE_NETCAT_OPENBSD [=n]

Fixes:
- No autobuilder failures (yet)

---
 package/libvirt/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/libvirt/Config.in +0 -0
index a35295bc97..d7ca5f8db5 100644

package/libvirt/Config.in if BR2_PACKAGE_LIBVIRT · line 40

Quoted 4 lines
package/libvirt/Config.in +1 -0
@@ -37,6 +37,7 @@ if BR2_PACKAGE_LIBVIRT
 config BR2_PACKAGE_LIBVIRT_DAEMON
 	bool "libvirtd"
 	default y
+	depends on BR2_INSTALL_LIBSTDCPP # nmap

In fact, the requirement on C++ is due to nmap-ncat, which is enabled only if netcat-openbsd is not available, so I relaxed the requirement accordingly.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 20 lines
package/libvirt/Config.in +3 -0
 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_DNSMASQ
 	select BR2_PACKAGE_EBTABLES
@@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
 	  Build the libvirt daemon (libvirtd) otherwise build only the
 	  utility programs.
 
+comment "libvirtd needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
+
 # Stateful drivers are useful only when building the daemon.
 if BR2_PACKAGE_LIBVIRT_DAEMON
 
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Fabrice, All,

On 2022-01-09 21:48 +0100, Yann E. MORIN spake thusly:

Quoted 17 lines

On 2022-01-09 21:20 +0100, Fabrice Fontaine spake thusly:

Quoted 16 lines

Fix the following build failure raised since commit fbf25acfbfd5a73b3560918bea081768abbe5723:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_NMAP
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] Selected by [y]:
- BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_PACKAGE_LIBVIRT [=y] && !BR2_PACKAGE_NETCAT_OPENBSD [=n]

Fixes:
- No autobuilder failures (yet)

---
 package/libvirt/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 13 lines

package/libvirt/Config.in if BR2_PACKAGE_LIBVIRT · line 40

Quoted 9 lines
package/libvirt/Config.in +1 -0
index a35295bc97..d7ca5f8db5 100644
@@ -37,6 +37,7 @@ if BR2_PACKAGE_LIBVIRT
 config BR2_PACKAGE_LIBVIRT_DAEMON
 	bool "libvirtd"
 	default y
+	depends on BR2_INSTALL_LIBSTDCPP # nmap

In fact, the requirement on C++ is due to nmap-ncat, which is enabled only if netcat-openbsd is not available, so I relaxed the requirement accordingly.

This introduced a messy circular dependency, so I pushed another patch that;
- remove the C++ dependency
- switches the nmap-ncat and netcat-openbsd conditional dependnecies

Regards,
Yann E. MORIN.

Quoted 37 lines

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 20 lines
package/libvirt/Config.in +3 -0
 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_DNSMASQ
 	select BR2_PACKAGE_EBTABLES
@@ -50,6 +51,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON
 	  Build the libvirt daemon (libvirtd) otherwise build only the
 	  utility programs.
 
+comment "libvirtd needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
+
 # Stateful drivers are useful only when building the daemon.
 if BR2_PACKAGE_LIBVIRT_DAEMON
 
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot