Skip to contentSkip to conversation

package/squid: needs threads

PATCH Applied Fabrice Fontaine 2 participants 2 messages Jan 9, 2022 – Jan 10, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/squid: needs threads

squid needs threads and
https://github.com/squid-cache/squid/commit/7dba4ac446341548a0b101489785f2cef9a33caa
to avoid the following build failure raised since
bump to version 5.3 in commit efc07b7a1818787229ddb335ca26ff2cf03820ae:

ntlm_fake_auth.cc: In function 'int main(int, char**)':
ntlm_fake_auth.cc:187:18: error: 'std::this_thread' has not been declared

  187 |             std::this_thread::sleep_for(std::chrono::milliseconds(response_delay));
      |                  ^~~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/2aabc8375d41ad4d047d20ff8ee4fe1c978e7ee1

---
 package/squid/Config.in | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/squid/Config.in +5 -2
index 0df2aedef6..6272140768 100644
@@ -1,13 +1,16 @@
-comment "squid needs a toolchain w/ C++, gcc >= 4.8 not affected by bug 64735"
+comment "squid needs a toolchain w/ C++, threads, gcc >= 4.8 not affected by bug 64735"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735 || \
-		!BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+		!BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 
 config BR2_PACKAGE_SQUID
 	bool "squid"
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::current_exception
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
 	# needs fork()
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 7 lines · Fabrice Fontaine

squid needs threads and
https://github.com/squid-cache/squid/commit/7dba4ac446341548a0b101489785f2cef9a33caa
to avoid the following build failure raised since
bump to version 5.3 in commit efc07b7a1818787229ddb335ca26ff2cf03820ae:

ntlm_fake_auth.cc: In function 'int main(int, char**)':
ntlm_fake_auth.cc:187:18: error: 'std::this_thread' has not been declared

Quoted 7 lines
   187 |             std::this_thread::sleep_for(std::chrono::milliseconds(response_delay));
       |                  ^~~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/2aabc8375d41ad4d047d20ff8ee4fe1c978e7ee1

Applied to master, thanks.

Regards,
Arnout

Quoted 18 lines
---
  package/squid/Config.in | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)
package/squid/Config.in +3 -2
index 0df2aedef6..6272140768 100644
@@ -1,13 +1,16 @@
-comment "squid needs a toolchain w/ C++, gcc >= 4.8 not affected by bug 64735"
+comment "squid needs a toolchain w/ C++, threads, gcc >= 4.8 not affected by bug 64735"
  	depends on BR2_USE_MMU
  	depends on BR2_TOOLCHAIN_HAS_ATOMIC
  	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735 || \
-		!BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+		!BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_HAS_THREADS || \

package/squid/Config.in line 16

Quoted 10 lines
package/squid/Config.in +2 -0
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 
  config BR2_PACKAGE_SQUID
  	bool "squid"
  	depends on BR2_TOOLCHAIN_HAS_ATOMIC
  	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::current_exception
  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
  	# needs fork()

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot