fbdev: aty128fb: make some arrays static const
PATCH 1/1 fbdev: aty128fb: make some arrays static const
Don't populate some read-only arrays on the stack but instead make them static const. Also makes the object code a little smaller. Re-format one of the declarations. Add spaces between commas and make PostDivSet unsigned int to fixup checkpatch warnings.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/video/fbdev/aty/aty128fb.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/video/fbdev/aty/aty128fb.c +6 -4
@@ -952,7 +952,7 @@ static void aty128_timings(struct aty128fb_par *par)u32 x_mpll_ref_fb_div;u32 xclk_cntl;u32 Nx,M ; -unsigned PostDivSet[] = {0 ,1 ,2 ,4 ,8 ,3 ,6 ,12 }; +static const unsigned int PostDivSet[] = {0 ,1 ,2 ,4 ,8 ,3 ,6 ,12 };#endif if (!par->constants.ref_clk)
@@ -1321,8 +1321,10 @@ static void aty128_set_pll(struct aty128_pll *pll, {u32 div3; -unsigned char post_conv[] =/* register values for post dividers */ - {2 ,0 ,1 ,4 ,2 ,2 ,6 ,2 ,3 ,2 ,2 ,2 ,7 }; +/* register values for post dividers */ +static const unsigned char post_conv[] = { +2 ,0 ,1 ,4 ,2 ,2 ,6 ,2 ,3 ,2 ,2 ,2 ,7 + };/* select PPLL_DIV_3 */ aty_st_le32 (CLOCK_CNTL_INDEX ,aty_ld_le32 (CLOCK_CNTL_INDEX ) | (3 <<8 ));
@@ -1360,7 +1362,7 @@ static int aty128_var_to_pll(u32 period_in_ps, struct aty128_pll *pll, const struct aty128fb_par *par) {const struct aty128_constants c = par->constants; -unsigned char post_dividers[] = {1 ,2 ,4 ,8 ,3 ,6 ,12 }; +static const unsigned char post_dividers[] = {1 ,2 ,4 ,8 ,3 ,6 ,12 };u32 output_freq;u32 vclk;/* in .01 MHz */ int i =0 ;
Signature · 1 line
2.32.0