HID: Ignore battery for Elan touchscreen on HP Envy X360 15t-dr100
Subsystems (2)
PATCH 1/1 HID: Ignore battery for Elan touchscreen on HP Envy X360 15t-dr100
Battery status on Elan tablet driver is reported for the HP ENVY x360 15t-dr100. There is no separate battery for the Elan controller resulting in a battery level report of 0% or 1% depending on whether a stylus has interacted with the screen. These low battery level reports causes a variety of bad behavior in desktop environments. This patch adds the appropriate quirk to indicate that the batery status is unused for this target.
--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+)
drivers/hid/hid-ids.h +1 -0
@@ -398,6 +398,7 @@#define USB_DEVICE_ID_HP_X2 0x074d#define USB_DEVICE_ID_HP_X2_10_COVER 0x0755#define I2C_DEVICE_ID_HP_ENVY_X360_15 0x2d05 +#define I2C_DEVICE_ID_HP_ENVY_X360_15T_DR100 0x29CF#define I2C_DEVICE_ID_HP_SPECTRE_X360_15 0x2817#define USB_DEVICE_ID_ASUS_UX550VE_TOUCHSCREEN 0x2544#define USB_DEVICE_ID_ASUS_UX550_TOUCHSCREEN 0x2706
drivers/hid/hid-input.c +2 -0
@@ -329,6 +329,8 @@ static const struct hid_device_id hid_battery_quirks[] = { HID_BATTERY_QUIRK_IGNORE }, {HID_I2C_DEVICE (USB_VENDOR_ID_ELAN ,I2C_DEVICE_ID_HP_ENVY_X360_15 ), HID_BATTERY_QUIRK_IGNORE }, + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_HP_ENVY_X360_15T_DR100), + HID_BATTERY_QUIRK_IGNORE }, { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_HP_SPECTRE_X360_15), HID_BATTERY_QUIRK_IGNORE }, { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_SURFACE_GO_TOUCHSCREEN),
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 8 lines · Karl Kurbjun
Battery status on Elan tablet driver is reported for the HP ENVY x360 15t-dr100. There is no separate battery for the Elan controller resulting in a battery level report of 0% or 1% depending on whether a stylus has interacted with the screen. These low battery level reports causes a variety of bad behavior in desktop environments. This patch adds the appropriate quirk to indicate that the batery status is unused for this target.
Quoted 5 lines
Signed-off-by Karl Kurbjun <[email protected]>--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
Quoted 16 lines · Greg KH
Quoted 8 lines · Karl Kurbjun
Battery status on Elan tablet driver is reported for the HP ENVY x360 15t-dr100. There is no separate battery for the Elan controller resulting in a battery level report of 0% or 1% depending on whether a stylus has interacted with the screen. These low battery level reports causes a variety of bad behavior in desktop environments. This patch adds the appropriate quirk to indicate that the batery status is unused for this target.
Quoted 5 lines
Signed-off-by Karl Kurbjun <[email protected]>--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+)
Quoted 8 lines
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.</formletter>
Thanks Greg,
Sorry for the mix-up on my side. I read that page before I submitted the patch but I went back and reread it. I was trying to follow "option 1" but I am guessing what I messed up was the cc in the signed-off area rather than the cc through email?
I was looking for an example of that - I found these threads:
https://lore.kernel.org/lkml/[email protected]/
and this one was what I was originally modeling my submission off of:
https://lore.kernel.org/lkml/[email protected]/
Is there an example of how I should add the cc to the sign-off area. As I read those threads the stable list was added to the email cc? Should I resubmit it to the linux-input with the appropriate change or follow a different flow now that the first email went out?
If I were going to resubmit I think I would need to to like so:
...
Quoted 2 lines
target.
drivers/hid/hid-ids.h
Quoted 8 lines
Signed-off-by Karl Kurbjun <[email protected]>--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+)drivers/hid/hid-ids.h +0
-0
...
Is that correct?
Karl
Greg KH
maintainerQuoted 24 lines · Karl Kurbjun
Quoted 23 lines · Greg KH
Quoted 8 lines · Karl Kurbjun
Battery status on Elan tablet driver is reported for the HP ENVY x360 15t-dr100. There is no separate battery for the Elan controller resulting in a battery level report of 0% or 1% depending on whether a stylus has interacted with the screen. These low battery level reports causes a variety of bad behavior in desktop environments. This patch adds the appropriate quirk to indicate that the batery status is unused for this target.
Quoted 5 lines
Signed-off-by Karl Kurbjun <[email protected]>--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+)<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
Quoted 8 lines
Quoted 1 line
</formletter>
Thanks Greg,
Sorry for the mix-up on my side. I read that page before I submitted the patch but I went back and reread it. I was trying to follow "option 1" but I am guessing what I messed up was the cc in the signed-off area rather than the cc through email?
Yes, please just put it in the signed-off-by area.
Quoted 22 lines
I was looking for an example of that - I found these threads:
https://lore.kernel.org/lkml/[email protected]/
and this one was what I was originally modeling my submission off of:
https://lore.kernel.org/lkml/[email protected]/Is there an example of how I should add the cc to the sign-off area. As I read those threads the stable list was added to the email cc? Should I resubmit it to the linux-input with the appropriate change or follow a different flow now that the first email went out?
If I were going to resubmit I think I would need to to like so:
...
Quoted 2 lines
target.
Quoted 6 lines
Signed-off-by Karl Kurbjun <[email protected]>--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+)
Quoted 5 lines
drivers/hid/hid-ids.h
Quoted 2 lines
drivers/hid/hid-ids.h +0
-0...
Is that correct?
Yes, that is correct.
thanks,
greg k-h
Jiri Kosina
maintainerQuoted 9 lines · Karl Kurbjun
Battery status on Elan tablet driver is reported for the HP ENVY x360 15t-dr100. There is no separate battery for the Elan controller resulting in a battery level report of 0% or 1% depending on whether a stylus has interacted with the screen. These low battery level reports causes a variety of bad behavior in desktop environments. This patch adds the appropriate quirk to indicate that the batery status is unused for this target.
Signed-off-by Karl Kurbjun <[email protected]>
I've added Cc: stable and applied to hid.git#for-5.17/upstream-fixes
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs