Skip to contentSkip to conversation

DEVELOPERS: add entry for avrdude to Yegor Yefremov

PATCH Applied yegorslists--- via buildroot 3 participants 6 messages Jan 10, 2022 – Jan 27, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 DEVELOPERS: add entry for avrdude to Yegor Yefremov

From: Yegor Yefremov <[email protected]>

---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)
DEVELOPERS +1 -0
index cd0b54b041..7a9f0f7370 100644
@@ -2968,6 +2968,7 @@ F:	configs/beaglebone_defconfig
 F:	configs/beaglebone_qt5_defconfig
 F:	package/acl/
 F:	package/attr/
+F:	package/avrdude/
 F:	package/boost/
 F:	package/bootstrap/
 F:	package/cannelloni/
Signature · 6 lines
2.17.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/avrdude: add support for Linux sysfs GPIO interface

From: Yegor Yefremov <[email protected]>

---
 package/avrdude/Config.in  | 3 +++
 package/avrdude/avrdude.mk | 6 ++++++
 2 files changed, 9 insertions(+)
package/avrdude/Config.in +3 -0
index 89558a5ff5..57a8df66ea 100644
@@ -17,6 +17,9 @@ config BR2_PACKAGE_AVRDUDE
 
 if BR2_PACKAGE_AVRDUDE
 
+config BR2_PACKAGE_AVRDUDE_LINUXGPIO
+	bool "Linux sysfs GPIO interface support"
+
 config BR2_PACKAGE_AVRDUDE_SPI
 	bool "SPI support"
 	default y # Backward compatibility
package/avrdude/avrdude.mk +6 -0
index accd92c1d5..3ccba80d8e 100644
@@ -16,6 +16,12 @@ AVRDUDE_CONF_OPTS = --enable-linuxgpio
 AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
 	host-flex host-bison
 
+ifeq ($(BR2_PACKAGE_AVRDUDE_LINUXGPIO),y)
+AVRDUDE_CONF_OPTS += --enable-linuxgpio
+else
+AVRDUDE_CONF_OPTS += --disable-linuxgpio
+endif
+
 ifeq ($(BR2_PACKAGE_AVRDUDE_SPI),y)
 AVRDUDE_CONF_OPTS += --enable-linuxspi
 else
Signature · 6 lines
2.17.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface

Yegor, All,

On 2022-01-10 09:58 +0100, yegorslists--- via buildroot spake thusly:

Quoted 27 lines

From: Yegor Yefremov <[email protected]>

---
 package/avrdude/Config.in  | 3 +++
 package/avrdude/avrdude.mk | 6 ++++++
 2 files changed, 9 insertions(+)
package/avrdude/Config.in +3 -0
index 89558a5ff5..57a8df66ea 100644
@@ -17,6 +17,9 @@ config BR2_PACKAGE_AVRDUDE
 
 if BR2_PACKAGE_AVRDUDE
 
+config BR2_PACKAGE_AVRDUDE_LINUXGPIO
+	bool "Linux sysfs GPIO interface support"
+
 config BR2_PACKAGE_AVRDUDE_SPI
 	bool "SPI support"
 	default y # Backward compatibility
package/avrdude/avrdude.mk +0 -0
index accd92c1d5..3ccba80d8e 100644

package/avrdude/avrdude.mk AVRDUDE_CONF_OPTS = --enable-linuxgpio · line 23

Quoted 8 lines
package/avrdude/avrdude.mk +5 -0
@@ -16,6 +16,12 @@ AVRDUDE_CONF_OPTS = --enable-linuxgpio
 AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
 	host-flex host-bison
 
+ifeq ($(BR2_PACKAGE_AVRDUDE_LINUXGPIO),y)
+AVRDUDE_CONF_OPTS += --enable-linuxgpio
+else
+AVRDUDE_CONF_OPTS += --disable-linuxgpio
+endif

We already have an unconditional activation of those:

https://github.com/buildroot/buildroot/blob/master/package/avrdude/avrdude.mk#L15

(which you can btw. incidentally also notice as part the hunk header).

So, if the intention was to be able to enable linux-gpio, then this is a noop as they are already enabled. If the intention was to be able to disable them, then the unconditional enable should be dropped.

But then, does it make sense to be able to disable linux GPIO?

And what if both SPI and GPIO are disabled?

Regards,
Yann E. MORIN.

Quoted 10 lines
package/avrdude/avrdude.mk +0 -0
 ifeq ($(BR2_PACKAGE_AVRDUDE_SPI),y)
 AVRDUDE_CONF_OPTS += --enable-linuxspi
 else
Signature · 6 lines
2.17.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH 2/2] package/avrdude: add support for Linux sysfs GPIO interface

Hi Yann, all,

Quoted 42 lines · Yann E. MORIN

Yegor, All,

On 2022-01-10 09:58 +0100, yegorslists--- via buildroot spake thusly:

Quoted 27 lines

From: Yegor Yefremov <[email protected]>

---
 package/avrdude/Config.in  | 3 +++
 package/avrdude/avrdude.mk | 6 ++++++
 2 files changed, 9 insertions(+)
package/avrdude/Config.in +3 -0
index 89558a5ff5..57a8df66ea 100644
@@ -17,6 +17,9 @@ config BR2_PACKAGE_AVRDUDE
 
 if BR2_PACKAGE_AVRDUDE
 
+config BR2_PACKAGE_AVRDUDE_LINUXGPIO
+     bool "Linux sysfs GPIO interface support"
+
 config BR2_PACKAGE_AVRDUDE_SPI
      bool "SPI support"
      default y # Backward compatibility
package/avrdude/avrdude.mk +0 -0
index accd92c1d5..3ccba80d8e 100644

package/avrdude/avrdude.mk AVRDUDE_CONF_OPTS = --enable-linuxgpio · line 23

Quoted 8 lines
package/avrdude/avrdude.mk +5 -0
@@ -16,6 +16,12 @@ AVRDUDE_CONF_OPTS = --enable-linuxgpio
 AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
      host-flex host-bison
 
+ifeq ($(BR2_PACKAGE_AVRDUDE_LINUXGPIO),y)
+AVRDUDE_CONF_OPTS += --enable-linuxgpio
+else
+AVRDUDE_CONF_OPTS += --disable-linuxgpio
+endif

We already have an unconditional activation of those:

Quoted 3 lines

https://github.com/buildroot/buildroot/blob/master/package/avrdude/avrdude.mk#L15

(which you can btw. incidentally also notice as part the hunk header).

My bad. I have just overlooked this setting. You can drop the patch.

Regards,
Yegor

Quoted 22 lines

So, if the intention was to be able to enable linux-gpio, then this is a noop as they are already enabled. If the intention was to be able to disable them, then the unconditional enable should be dropped.

But then, does it make sense to be able to disable linux GPIO?

And what if both SPI and GPIO are disabled?

Regards,
Yann E. MORIN.

Quoted 10 lines
package/avrdude/avrdude.mk +0 -1
 ifeq ($(BR2_PACKAGE_AVRDUDE_SPI),y)
 AVRDUDE_CONF_OPTS += --enable-linuxspi
 else
--

2.17.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Quoted 7 lines

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
In reply to yegorslists--- via buildroot

Yegor, All,

On 2022-01-10 09:58 +0100, yegorslists--- via buildroot spake thusly:

Quoted 3 lines

From: Yegor Yefremov <[email protected]>

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)
DEVELOPERS +1 -0
index cd0b54b041..7a9f0f7370 100644
@@ -2968,6 +2968,7 @@ F:	configs/beaglebone_defconfig
 F:	configs/beaglebone_qt5_defconfig
 F:	package/acl/
 F:	package/attr/
+F:	package/avrdude/
 F:	package/boost/
 F:	package/bootstrap/
 F:	package/cannelloni/
Signature · 6 lines
2.17.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
In reply to yegorslists--- via buildroot
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"yegorslists---" == yegorslists--- via buildroot <[email protected]> writes:

From: Yegor Yefremov <[email protected]>

Committed to 2021.02.x and 2021.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot