Skip to contentSkip to conversation

arm64: dts: exynos: Link DSI panel at port@1 for TM2 board

PATCH In review Jagan Teki 2 participants 4 messages Jan 10, 2022 – Jan 11, 2022

Subsystems (2)
lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/2 arm64: dts: exynos: Link DSI panel at port@1 for TM2 board

TM2 board DSI pipeline has input from MIC and output to s6e3ha2 panel.

The existing pipeline has child nodes of ports, panel and MIC is remote-endpoint reference of port@0 of ports.

Adding panel as another child node to DSI is unconventional as pipeline has ports child. However it can be true if MIC is added inside port node like this.

dsi {
	compatible = "samsung,exynos5433-mipi-dsi";
	#address-cells = <1>;
	#size-cells = <0>;

	port {
		dsi_to_mic: endpoint {
			remote-endpoint = <&mic_to_dsi>;
		};
	};

	panel@0 {
		compatible = "samsung,s6e3hf2";
                reg = <0>;
                vdd3-supply = <&ldo27_reg>;
                vci-supply = <&ldo28_reg>;
                reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
                enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
	};
};

The above pipeline is proper but it requires the DSI input MIC pipeline to update.

This patch is trying to add panel at port@1 so-that the entire pipeline before to panel output is untouched.

---
 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +16 -0
index aca01709fd29..e13210c8d7e0 100644
@@ -53,6 +53,16 @@ &cmu_disp {
 };
 
 &dsi {
+	ports {
+		port@1 {
+			reg = <1>;
+
+			dsi_out_panel: endpoint {
+				remote-endpoint = <&dsi_in_panel>;
+			};
+		};
+	};
+
 	panel@0 {
 		compatible = "samsung,s6e3ha2";
 		reg = <0>;
@@ -60,6 +70,12 @@ panel@0 {
 		vci-supply = <&ldo28_reg>;
 		reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
 		enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+
+		port {
+			dsi_in_panel: endpoint {
+				remote-endpoint = <&dsi_out_panel>;
+			};
+		};
 	};
 };
 
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 2/2 arm64: dts: exynos: Link DSI panel at port@1 for TM2E board

TM2E board DSI pipeline has input from MIC and output to s6e3ha2 panel.

The existing pipeline has child nodes of ports, panel and MIC is remote-endpoint reference of port@0 of ports.

Adding panel as another child node to DSI is unconventional as pipeline has ports child. However it can be true if MIC is added inside port node like this.

dsi {
	compatible = "samsung,exynos5433-mipi-dsi";
	#address-cells = <1>;
	#size-cells = <0>;

	port {
		dsi_to_mic: endpoint {
			remote-endpoint = <&mic_to_dsi>;
		};
	};

	panel@0 {
		compatible = "samsung,s6e3hf2";
                reg = <0>;
                vdd3-supply = <&ldo27_reg>;
                vci-supply = <&ldo28_reg>;
                reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
                enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
	};
};

The above pipeline is proper but it requires the DSI input MIC pipeline to update.

This patch is trying to add panel at port@1 so-that the entire pipeline before to panel output is untouched.

---
 arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts +16 -0
index 22d26460f3dd..09418fe30353 100644
@@ -51,6 +51,16 @@ &cmu_disp {
 };
 
 &dsi {
+	ports {
+		port@1 {
+			reg = <1>;
+
+			dsi_out_panel: endpoint {
+				remote-endpoint = <&dsi_in_panel>;
+			};
+		};
+	};
+
 	panel@0 {
 		compatible = "samsung,s6e3hf2";
 		reg = <0>;
@@ -58,6 +68,12 @@ panel@0 {
 		vci-supply = <&ldo28_reg>;
 		reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
 		enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+
+		port {
+			dsi_in_panel: endpoint {
+				remote-endpoint = <&dsi_out_panel>;
+			};
+		};
 	};
 };
 
Signature · 1 line
2.25.1
#2 lore raw
In reply to Jagan Teki

+CC: dri-devel

Quoted 65 lines · Jagan Teki

TM2 board DSI pipeline has input from MIC and output to s6e3ha2 panel.

The existing pipeline has child nodes of ports, panel and MIC is remote-endpoint reference of port@0 of ports.

Adding panel as another child node to DSI is unconventional as pipeline has ports child. However it can be true if MIC is added inside port node like this.

dsi {
	compatible = "samsung,exynos5433-mipi-dsi";
	#address-cells = <1>;
	#size-cells = <0>;

	port {
		dsi_to_mic: endpoint {
			remote-endpoint = <&mic_to_dsi>;
		};
	};

	panel@0 {
		compatible = "samsung,s6e3hf2";
                 reg = <0>;
                 vdd3-supply = <&ldo27_reg>;
                 vci-supply = <&ldo28_reg>;
                 reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
                 enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
	};
};

The above pipeline is proper but it requires the DSI input MIC pipeline to update.

This patch is trying to add panel at port@1 so-that the entire pipeline before to panel output is untouched.

---
  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +10 -0
index aca01709fd29..e13210c8d7e0 100644
@@ -53,6 +53,16 @@ &cmu_disp {
  };
 
  &dsi {
+	ports {
+		port@1 {
+			reg = <1>;
+
+			dsi_out_panel: endpoint {
+				remote-endpoint = <&dsi_in_panel>;
+			};
+		};
+	};
+
  	panel@0 {
  		compatible = "samsung,s6e3ha2";
  		reg = <0>;

arch/arm64/boot/dts/exynos/exynos5433-tm2.dts panel@0 { · line 78

Quoted 9 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +6 -0
@@ -60,6 +70,12 @@ panel@0 {
  		vci-supply = <&ldo28_reg>;
  		reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
  		enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+
+		port {
+			dsi_in_panel: endpoint {
+				remote-endpoint = <&dsi_out_panel>;
+			};
+		};

As I already wrote in Exynos thread, DSI host has already parent-child relation with the panel - DSI host knows well who is connected to it. Adding another links between them is redundant and has no value added.

I have already answered in Exynos thread[1] how could you deal with the issue, you have.

[1]: https://lore.kernel.org/dri-devel/[email protected]/

Regards

Andrzej

Quoted 3 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +0 -0
  	};
  };
 
author
#3 lore raw

Hi Andrzej,

Quoted 84 lines · Andrzej Hajda

+CC: dri-devel

Quoted 65 lines · Jagan Teki

TM2 board DSI pipeline has input from MIC and output to s6e3ha2 panel.

The existing pipeline has child nodes of ports, panel and MIC is remote-endpoint reference of port@0 of ports.

Adding panel as another child node to DSI is unconventional as pipeline has ports child. However it can be true if MIC is added inside port node like this.

dsi {
      compatible = "samsung,exynos5433-mipi-dsi";
      #address-cells = <1>;
      #size-cells = <0>;

      port {
              dsi_to_mic: endpoint {
                      remote-endpoint = <&mic_to_dsi>;
              };
      };

      panel@0 {
              compatible = "samsung,s6e3hf2";
                 reg = <0>;
                 vdd3-supply = <&ldo27_reg>;
                 vci-supply = <&ldo28_reg>;
                 reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
                 enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
      };
};

The above pipeline is proper but it requires the DSI input MIC pipeline to update.

This patch is trying to add panel at port@1 so-that the entire pipeline before to panel output is untouched.

---
  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +10 -0
index aca01709fd29..e13210c8d7e0 100644
@@ -53,6 +53,16 @@ &cmu_disp {
  };
 
  &dsi {
+     ports {
+             port@1 {
+                     reg = <1>;
+
+                     dsi_out_panel: endpoint {
+                             remote-endpoint = <&dsi_in_panel>;
+                     };
+             };
+     };
+
      panel@0 {
              compatible = "samsung,s6e3ha2";
              reg = <0>;

arch/arm64/boot/dts/exynos/exynos5433-tm2.dts panel@0 { · line 78

Quoted 9 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +6 -0
@@ -60,6 +70,12 @@ panel@0 {
              vci-supply = <&ldo28_reg>;
              reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
              enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+
+             port {
+                     dsi_in_panel: endpoint {
+                             remote-endpoint = <&dsi_out_panel>;
+                     };
+             };

As I already wrote in Exynos thread, DSI host has already parent-child relation with the panel - DSI host knows well who is connected to it. Adding another links between them is redundant and has no value added.

Quoted 5 lines

I have already answered in Exynos thread[1] how could you deal with the issue, you have.

[1]:
https://lore.kernel.org/dri-devel/[email protected]/

I have commented on this thread for better understanding. Please have a look and respond.

Thanks,
Jagan.