Skip to contentSkip to conversation

xfs: new code for 5.17

GIT PULL Merged Darrick J. Wong 2 participants 5 messages Jan 10, 2022 – Jan 15, 2022 VFS

lore
Share & tools
lore
#0 lore raw

Hi Linus,

Please pull this new code for Linux 5.17. The big new feature here is that the mount code now only bothers to try to free stale COW staging extents if the fs unmounted uncleanly. This should reduce mount times, particularly on filesystems supporting reflink and containing a large number of allocation groups.

Everything else this cycle are bugfixes, as the iomap folios conversion should be plenty enough excitement for anyone. That and I ran out of brain bandwidth after Thanksgiving last year.

The branch merges cleanly against upstream as of a few minutes ago. Please let me know if anything else strange happens during the merge process. There will definitely be a second pull request coming with at least one more bug fix and most probably a full withdrawal of the recently troublesome ALLOCSP ioctl family.

--D

The following changes since commit 2585cf9dfaaddf00b069673f27bb3f8530e2039c:

Linux 5.16-rc5 (2021-12-12 14:53:01 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.17-merge-2

for you to fetch changes up to 7e937bb3cbe1f6b9840a43f879aa6e3f1a5e6537:

xfs: warn about inodes with project id of -1 (2022-01-06 10:43:30 -0800)

----------------------------------------------------------------
New code for 5.17:
- Fix log recovery with da btree buffers when metauuid is in use.
- Fix type coercion problems in xattr buffer size validation.
- Fix a bug in online scrub dir leaf bestcount checking.
- Only run COW recovery when recovering the log.
- Fix symlink target buffer UAF problems and symlink locking problems by not exposing xfs innards to the VFS.
- Fix incorrect quotaoff lock usage.
- Don't let transactions cancel cleanly if they have deferred work items attached.
- Fix a UAF when we're deciding if we need to relog an intent item.
- Reduce kvmalloc overhead for log shadow buffers.
- Clean up sysfs attr group usage.
- Fix a bug where scrub's bmap/rmap checking could race with a quota file block allocation due to insufficient locking.
- Teach scrub to complain about invalid project ids.

----------------------------------------------------------------
Dan Carpenter (1):
xfs: prevent a WARN_ONCE() in xfs_ioc_attr_list()

Darrick J. Wong (8):
xfs: shut down filesystem if we xfs_trans_cancel with deferred work items
xfs: fix quotaoff mutex usage now that we don't support disabling it
xfs: don't expose internal symlink metadata buffers to the vfs
xfs: only run COW extent recovery when there are no live extents
xfs: fix a bug in the online fsck directory leaf1 bestcount check
xfs: prevent UAF in xfs_log_item_in_current_chkpt
xfs: hold quota inode ILOCK_EXCL until the end of dqalloc
xfs: warn about inodes with project id of -1

Dave Chinner (2):
xfs: check sb_meta_uuid for dabuf buffer recovery
xfs: reduce kvmalloc overhead for CIL shadow buffers

Greg Kroah-Hartman (1):
xfs: sysfs: use default_groups in kobj_type

Jiapeng Chong (1):
xfs: Remove redundant assignment of mp

Yang Xu (1):
xfs: Fix comments mentioning xfs_ialloc

 fs/xfs/scrub/dir.c            | 15 +++++---
 fs/xfs/scrub/inode.c          | 14 ++++++++
 fs/xfs/scrub/quota.c          |  4 +--
 fs/xfs/scrub/repair.c         |  3 ++
 fs/xfs/scrub/scrub.c          |  4 ---
 fs/xfs/scrub/scrub.h          |  1 -
 fs/xfs/xfs_buf_item_recover.c |  2 +-
 fs/xfs/xfs_dquot.c            | 79 +++++++++++++++----------------------------
 fs/xfs/xfs_error.c            |  3 +-
 fs/xfs/xfs_icache.c           |  3 +-
 fs/xfs/xfs_ioctl.c            |  2 +-
 fs/xfs/xfs_ioctl.h            |  5 +--
 fs/xfs/xfs_iops.c             | 40 +++-------------------
 fs/xfs/xfs_log_cil.c          | 52 ++++++++++++++++++++--------
 fs/xfs/xfs_log_recover.c      | 26 ++++++++++++--
 fs/xfs/xfs_mount.c            | 10 ------
 fs/xfs/xfs_qm_syscalls.c      | 11 +-----
 fs/xfs/xfs_reflink.c          |  5 ++-
 fs/xfs/xfs_super.c            |  9 -----
 fs/xfs/xfs_symlink.c          | 27 ++++++++++-----
 fs/xfs/xfs_sysfs.c            | 16 +++++----
 fs/xfs/xfs_trans.c            | 11 +++++-
 22 files changed, 175 insertions(+), 167 deletions(-)
#2 lore raw
In reply to Darrick J. Wong

Hi Linus,

Please pull these bug fixes for Linux 5.17. These are the last few obvious fixes that I found while stress testing online fsck for XFS prior to initiating a design review of the whole giant machinery.

The branch merges cleanly against upstream as of a few minutes ago. Please let me know if anything else strange happens during the merge process. There will definitely be a third pull request coming with a removal of the recently troublesome ALLOCSP/FREESP ioctl family and the long dead SGI XFS HSM ioctls.

--D

The following changes since commit 7e937bb3cbe1f6b9840a43f879aa6e3f1a5e6537:

xfs: warn about inodes with project id of -1 (2022-01-06 10:43:30 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.17-merge-3

for you to fetch changes up to 4a9bca86806fa6fc4fbccf050c1bd36a4778948a:

xfs: fix online fsck handling of v5 feature bits on secondary supers (2022-01-12 09:45:21 -0800)

----------------------------------------------------------------
New code for 5.17:

- Fix a minor locking inconsistency in readdir
- Fix incorrect fs feature bit validation for secondary superblocks

----------------------------------------------------------------
Darrick J. Wong (2):
xfs: take the ILOCK when readdir inspects directory mapping data
xfs: fix online fsck handling of v5 feature bits on secondary supers

 fs/xfs/scrub/agheader.c        | 53 ++++++++++++++++++++--------------------
 fs/xfs/scrub/agheader_repair.c | 12 +++++++++
 fs/xfs/xfs_dir2_readdir.c      | 55 +++++++++++++++++++++++++++---------------
 3 files changed, 73 insertions(+), 47 deletions(-)
#3 lore raw
Quoted 1 line · Darrick J. Wong

Hi Linus,

Oops, sent this as a reply by accident. I'll resend this as a new thread; sorry for the noise.

--D

Quoted 40 lines

Please pull these bug fixes for Linux 5.17. These are the last few obvious fixes that I found while stress testing online fsck for XFS prior to initiating a design review of the whole giant machinery.

The branch merges cleanly against upstream as of a few minutes ago. Please let me know if anything else strange happens during the merge process. There will definitely be a third pull request coming with a removal of the recently troublesome ALLOCSP/FREESP ioctl family and the long dead SGI XFS HSM ioctls.

--D

The following changes since commit 7e937bb3cbe1f6b9840a43f879aa6e3f1a5e6537:

xfs: warn about inodes with project id of -1 (2022-01-06 10:43:30 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.17-merge-3

for you to fetch changes up to 4a9bca86806fa6fc4fbccf050c1bd36a4778948a:

xfs: fix online fsck handling of v5 feature bits on secondary supers (2022-01-12 09:45:21 -0800)

----------------------------------------------------------------
New code for 5.17:

- Fix a minor locking inconsistency in readdir
- Fix incorrect fs feature bit validation for secondary superblocks

----------------------------------------------------------------
Darrick J. Wong (2):
xfs: take the ILOCK when readdir inspects directory mapping data
xfs: fix online fsck handling of v5 feature bits on secondary supers

 fs/xfs/scrub/agheader.c        | 53 ++++++++++++++++++++--------------------
 fs/xfs/scrub/agheader_repair.c | 12 +++++++++
 fs/xfs/xfs_dir2_readdir.c      | 55 +++++++++++++++++++++++++++---------------
 3 files changed, 73 insertions(+), 47 deletions(-)
merge bot Merged
#4 lore raw
In reply to Darrick J. Wong
The pull request you sent on Fri, 14 Jan 2022 20:17:12 -0800:

The pull request you sent on Fri, 14 Jan 2022 20:17:12 -0800:

Quoted 1 line

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-5.17-merge-3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a33f5c380c4bd3fa5278d690421b72052456d9fe

Thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html